185356 2018-05-05 14:50:26 -0700 Draw a drop-shadow behind the system preview badge 2018-05-06 17:06:40 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino darin webkit-bug-importer wenson_hsieh oldest_to_newest 1421072 0 dino 2018-05-05 14:50:26 -0700 Draw a drop-shadow behind the system preview badge 1421073 1 webkit-bug-importer 2018-05-05 14:51:47 -0700 <rdar://problem/40004936> 1421074 2 339656 dino 2018-05-05 15:02:00 -0700 Created attachment 339656 Patch 1421077 3 339656 wenson_hsieh 2018-05-05 15:19:34 -0700 Comment on attachment 339656 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339656&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:1853 > + RetainPtr<CGPathRef> circle = adoptCF(CGPathCreateWithRoundedRect(absoluteBadgeRect, badgeDimension / 2, badgeDimension / 2, nullptr)); Nit - I think we generally auto these. 1421080 4 dino 2018-05-05 15:43:16 -0700 Committed r231397: <https://trac.webkit.org/changeset/231397> 1421177 5 339656 darin 2018-05-06 17:06:40 -0700 Comment on attachment 339656 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339656&action=review >> Source/WebCore/rendering/RenderThemeIOS.mm:1853 >> + RetainPtr<CGPathRef> circle = adoptCF(CGPathCreateWithRoundedRect(absoluteBadgeRect, badgeDimension / 2, badgeDimension / 2, nullptr)); > > Nit - I think we generally auto these. I often work with both of you on WebKit and I endorse this message. 339656 2018-05-05 15:02:00 -0700 2018-05-05 15:19:34 -0700 Patch bug-185356-20180505150159.patch text/plain 6747 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmFlODQxMDJjOGI2ZjVk ODllNWQ2N2RmMGVhNWYwZmVkYzM3MjcwYy4uNDFkYmJjMmEwNDgwMGRhNTMwYjZkYzJmYzQ2OGNi M2ZjMDBhN2UyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA1LTA1ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBEcmF3IGEgZHJvcC1zaGFkb3cg YmVoaW5kIHRoZSBzeXN0ZW0gcHJldmlldyBiYWRnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1MzU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80 MDAwNDkzNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBEcmF3IGEgdmVyeSBzdWJ0bGUgZHJvcC1zaGFkb3cgdW5kZXIgdGhlIHN5c3RlbQorICAgICAg ICBwcmV2aWV3IGJhZGdlIHNvIHRoYXQgaXQgaXMgbW9yZSB2aXNpYmxlIG9uIGEgcHVyZQorICAg ICAgICB3aGl0ZSBiYWNrZ3JvdW5kLgorCisgICAgICAgIEkgYWxzbyBtb3ZlZCBzb21lIGNvZGUg YXJvdW5kIHRvIG1ha2UgaXQgbW9yZSBjbGVhcgorICAgICAgICBhbmQgaW1wcm92ZWQgY29tbWVu dHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW06CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJUaGVtZUlPUzo6cGFpbnRTeXN0ZW1QcmV2aWV3QmFkZ2UpOgorCiAyMDE4 LTA1LTAyICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgSU9T dXJmYWNlcyBmb3IgQ29yZUltYWdlIG9wZXJhdGlvbnMgd2hlcmUgcG9zc2libGUKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbSBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbQppbmRleCA5N2EzODhkM2NlZWIyMmRh ZjRiZGY2NDZjOTBhN2M5ZjNlYWM4YmI1Li42MDNlMTk4N2I3Mjg0ODU0Zjc3NDdhZmU2ZmYxNzUx ZWJmZDk1YTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhl bWVJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1t CkBAIC0xODQzLDE4ICsxODQzLDQ1IEBAIHZvaWQgUmVuZGVyVGhlbWVJT1M6OnBhaW50U3lzdGVt UHJldmlld0JhZGdlKEltYWdlJiBpbWFnZSwgY29uc3QgUGFpbnRJbmZvJiBwYWluCiAgICAgaWYg KHJlY3Qud2lkdGgoKSA8IG1pbmltdW1EaW1lbnNpb24gfHwgcmVjdC5oZWlnaHQoKSA8IG1pbmlt dW1EaW1lbnNpb24pCiAgICAgICAgIHJldHVybjsKIAorICAgIENHUmVjdCBhYnNvbHV0ZUJhZGdl UmVjdCA9IENHUmVjdE1ha2UocmVjdC54KCkgKyByZWN0LndpZHRoKCkgLSBiYWRnZURpbWVuc2lv biAtIGJhZGdlT2Zmc2V0LCByZWN0LnkoKSArIGJhZGdlT2Zmc2V0LCBiYWRnZURpbWVuc2lvbiwg YmFkZ2VEaW1lbnNpb24pOworICAgIENHUmVjdCBpbnNldEJhZGdlUmVjdCA9IENHUmVjdE1ha2Uo cmVjdC53aWR0aCgpIC0gYmFkZ2VEaW1lbnNpb24gLSBiYWRnZU9mZnNldCwgYmFkZ2VPZmZzZXQs IGJhZGdlRGltZW5zaW9uLCBiYWRnZURpbWVuc2lvbik7CisgICAgQ0dSZWN0IGJhZGdlUmVjdCA9 IENHUmVjdE1ha2UoMCwgMCwgYmFkZ2VEaW1lbnNpb24sIGJhZGdlRGltZW5zaW9uKTsKKwogICAg IENJSW1hZ2UgKmlucHV0SW1hZ2UgPSBbQ0lJbWFnZSBpbWFnZVdpdGhDR0ltYWdlOmltYWdlLm5h dGl2ZUltYWdlKCkuZ2V0KCldOwogCi0gICAgLy8gU2NhbGUgZnJvbSBpbnRyaW5zaWMgc2l6ZSB0 byByZW5kZXIgc2l6ZS4KKyAgICAvLyBDcmVhdGUgYSBjaXJjbGUgdG8gYmUgdXNlZCBmb3IgdGhl IGNsaXBwaW5nIHBhdGggaW4gdGhlIGJhZGdlLCBhcyB3ZWxsIGFzIHRoZSBkcm9wIHNoYWRvdy4K KyAgICBSZXRhaW5QdHI8Q0dQYXRoUmVmPiBjaXJjbGUgPSBhZG9wdENGKENHUGF0aENyZWF0ZVdp dGhSb3VuZGVkUmVjdChhYnNvbHV0ZUJhZGdlUmVjdCwgYmFkZ2VEaW1lbnNpb24gLyAyLCBiYWRn ZURpbWVuc2lvbiAvIDIsIG51bGxwdHIpKTsKKworICAgIENHQ29udGV4dFJlZiBjdHggPSBwYWlu dEluZm8uY29udGV4dCgpLnBsYXRmb3JtQ29udGV4dCgpOworCisgICAgQ0dDb250ZXh0U2F2ZUdT dGF0ZShjdHgpOworCisgICAgLy8gRHJhdyBhIGRyb3Agc2hhZG93IGFyb3VuZCB0aGUgY2lyY2xl LgorICAgIENHRmxvYXQgc2hhZG93Q29sb3JDb21wb25lbnRzWzRdID0geyAwLCAwLCAwLCAwLjEg fTsKKyAgICBSZXRhaW5QdHI8Q0dDb2xvclJlZj4gc2hhZG93Q29sb3IgPSBhZG9wdENGKENHQ29s b3JDcmVhdGUoc1JHQkNvbG9yU3BhY2VSZWYoKSwgc2hhZG93Q29sb3JDb21wb25lbnRzKSk7Cisg ICAgLy8gVGhlIGNpcmNsZSBtdXN0IGhhdmUgYW4gYWxwaGEgY2hhbm5lbCB2YWx1ZSBvZiAxIGZv ciB0aGUgc2hhZG93IGNvbG9yIHRvIGFwcGVhci4KKyAgICBDR0Zsb2F0IGNpcmNsZUNvbG9yQ29t cG9uZW50c1s0XSA9IHsgMCwgMCwgMCwgMSB9OworICAgIFJldGFpblB0cjxDR0NvbG9yUmVmPiBj aXJjbGVDb2xvciA9IGFkb3B0Q0YoQ0dDb2xvckNyZWF0ZShzUkdCQ29sb3JTcGFjZVJlZigpLCBj aXJjbGVDb2xvckNvbXBvbmVudHMpKTsKKyAgICBDR0NvbnRleHRTZXRGaWxsQ29sb3JXaXRoQ29s b3IoY3R4LCBjaXJjbGVDb2xvci5nZXQoKSk7CisgICAgQ0dDb250ZXh0U2V0U2hhZG93V2l0aENv bG9yKGN0eCwgQ0dTaXplWmVybywgMTYsIHNoYWRvd0NvbG9yLmdldCgpKTsKKworICAgIC8vIERy YXcgYSBzbGlnaHRseSBzbWFsbGVyIGNpcmNsZSB3aXRoIGEgc2hhZG93LCBvdGhlcndpc2Ugd2Un bGwgc2VlIGEgZnJpbmdlIG9mIHRoZSBzb2xpZAorICAgIC8vIGJsYWNrIGNpcmNsZSBhcm91bmQg dGhlIGVkZ2VzIG9mIHRoZSBjbGlwZWQgcGF0aCBiZWxvdy4KKyAgICBDR0NvbnRleHRCZWdpblBh dGgoY3R4KTsKKyAgICBDR1JlY3Qgc2xpZ2h0bHlTbWFsbGVyQWJzb2x1dGVCYWRnZVJlY3QgPSBD R1JlY3RNYWtlKGFic29sdXRlQmFkZ2VSZWN0Lm9yaWdpbi54ICsgMC41LCBhYnNvbHV0ZUJhZGdl UmVjdC5vcmlnaW4ueSArIDAuNSwgYmFkZ2VEaW1lbnNpb24gLSAxLCBiYWRnZURpbWVuc2lvbiAt IDEpOworICAgIFJldGFpblB0cjxDR1BhdGhSZWY+IHNsaWdodGx5U21hbGxlckNpcmNsZSA9IGFk b3B0Q0YoQ0dQYXRoQ3JlYXRlV2l0aFJvdW5kZWRSZWN0KHNsaWdodGx5U21hbGxlckFic29sdXRl QmFkZ2VSZWN0LCBzbGlnaHRseVNtYWxsZXJBYnNvbHV0ZUJhZGdlUmVjdC5zaXplLndpZHRoIC8g Miwgc2xpZ2h0bHlTbWFsbGVyQWJzb2x1dGVCYWRnZVJlY3Quc2l6ZS5oZWlnaHQgLyAyLCBudWxs cHRyKSk7CisgICAgQ0dDb250ZXh0QWRkUGF0aChjdHgsIHNsaWdodGx5U21hbGxlckNpcmNsZS5n ZXQoKSk7CisgICAgQ0dDb250ZXh0Q2xvc2VQYXRoKGN0eCk7CisgICAgQ0dDb250ZXh0RmlsbFBh dGgoY3R4KTsKKworICAgIENHQ29udGV4dFJlc3RvcmVHU3RhdGUoY3R4KTsKKworICAgIC8vIERy YXcgdGhlIGJsdXJyZWQgYmFja2Ryb3AuIFNjYWxlIGZyb20gaW50cmluc2ljIHNpemUgdG8gcmVu ZGVyIHNpemUuCiAgICAgQ0dBZmZpbmVUcmFuc2Zvcm0gdHJhbnNmb3JtID0gQ0dBZmZpbmVUcmFu c2Zvcm1JZGVudGl0eTsKICAgICB0cmFuc2Zvcm0gPSBDR0FmZmluZVRyYW5zZm9ybVNjYWxlKHRy YW5zZm9ybSwgcmVjdC53aWR0aCgpIC8gaW1hZ2Uud2lkdGgoKSwgcmVjdC5oZWlnaHQoKSAvIGlt YWdlLmhlaWdodCgpKTsKICAgICBDSUltYWdlICpzY2FsZWRJbWFnZSA9IFtpbnB1dEltYWdlIGlt YWdlQnlBcHBseWluZ1RyYW5zZm9ybTp0cmFuc2Zvcm1dOwogCi0gICAgQ0dSZWN0IGFic29sdXRl QmFkZ2VSZWN0ID0gQ0dSZWN0TWFrZShyZWN0LngoKSArIHJlY3Qud2lkdGgoKSAtIGJhZGdlRGlt ZW5zaW9uIC0gYmFkZ2VPZmZzZXQsIHJlY3QueSgpICsgYmFkZ2VPZmZzZXQsIGJhZGdlRGltZW5z aW9uLCBiYWRnZURpbWVuc2lvbik7Ci0gICAgQ0dSZWN0IGluc2V0QmFkZ2VSZWN0ID0gQ0dSZWN0 TWFrZShyZWN0LndpZHRoKCkgLSBiYWRnZURpbWVuc2lvbiAtIGJhZGdlT2Zmc2V0LCBiYWRnZU9m ZnNldCwgYmFkZ2VEaW1lbnNpb24sIGJhZGdlRGltZW5zaW9uKTsKLSAgICBDR1JlY3QgYmFkZ2VS ZWN0ID0gQ0dSZWN0TWFrZSgwLCAwLCBiYWRnZURpbWVuc2lvbiwgYmFkZ2VEaW1lbnNpb24pOwot Ci0gICAgLy8gQ0kgY29vcmRpbmF0ZXMgYXJlIHktdXAsIHNvIHdlIG5lZWQgdG8gZmxpcCB0aGUg YmFkZ2UgcmVjdGFuZ2xlIHdpdGhpbiB0aGUgaW1hZ2UgZnJhbWUuCisgICAgLy8gQ29yZUltYWdl IGNvb3JkaW5hdGVzIGFyZSB5LXVwLCBzbyB3ZSBuZWVkIHRvIGZsaXAgdGhlIGJhZGdlIHJlY3Rh bmdsZSB3aXRoaW4gdGhlIGltYWdlIGZyYW1lLgogICAgIENHUmVjdCBmbGlwcGVkSW5zZXRCYWRn ZVJlY3QgPSBDR1JlY3RNYWtlKGluc2V0QmFkZ2VSZWN0Lm9yaWdpbi54LCByZWN0LmhlaWdodCgp IC0gaW5zZXRCYWRnZVJlY3Qub3JpZ2luLnkgLSBpbnNldEJhZGdlUmVjdC5zaXplLmhlaWdodCwg YmFkZ2VEaW1lbnNpb24sIGJhZGdlRGltZW5zaW9uKTsKIAogICAgIC8vIENyZWF0ZSBhIGNyb3Bw ZWQgcmVnaW9uIHdpdGggcGl4ZWwgdmFsdWVzIGV4dGVuZGluZyBvdXR3YXJkcy4KQEAgLTE4Nzgs MTYgKzE5MDUsNiBAQCB2b2lkIFJlbmRlclRoZW1lSU9TOjpwYWludFN5c3RlbVByZXZpZXdCYWRn ZShJbWFnZSYgaW1hZ2UsIGNvbnN0IFBhaW50SW5mbyYgcGFpbgogICAgIFtzb3VyY2VPdmVyRmls dGVyIHNldFZhbHVlOnRpbnRGaWx0ZXIxLm91dHB1dEltYWdlIGZvcktleTprQ0lJbnB1dEltYWdl S2V5XTsKICAgICBbc291cmNlT3ZlckZpbHRlciBzZXRWYWx1ZTpzYXR1cmF0aW9uRmlsdGVyLm91 dHB1dEltYWdlIGZvcktleTprQ0lJbnB1dEJhY2tncm91bmRJbWFnZUtleV07CiAKLSAgICAvLyBC ZWZvcmUgd2UgcmVuZGVyIHRoZSByZXN1bHQsIHdlIHNob3VsZCBjbGlwIHRvIGEgY2lyY2xlIGFy b3VuZCB0aGUgYmFkZ2UgcmVjdGFuZ2xlLgotICAgIENHQ29udGV4dFJlZiBjdHggPSBwYWludElu Zm8uY29udGV4dCgpLnBsYXRmb3JtQ29udGV4dCgpOwotICAgIENHQ29udGV4dFNhdmVHU3RhdGUo Y3R4KTsKLSAgICBDR0NvbnRleHRCZWdpblBhdGgoY3R4KTsKLSAgICBDR1BhdGhSZWYgY2lyY2xl ID0gQ0dQYXRoQ3JlYXRlV2l0aFJvdW5kZWRSZWN0KGFic29sdXRlQmFkZ2VSZWN0LCBiYWRnZURp bWVuc2lvbiAvIDIsIGJhZGdlRGltZW5zaW9uIC8gMiwgbmlsKTsKLSAgICBDR0NvbnRleHRBZGRQ YXRoKGN0eCwgY2lyY2xlKTsKLSAgICBDR0NvbnRleHRDbG9zZVBhdGgoY3R4KTsKLSAgICBDR0Nv bnRleHRDbGlwKGN0eCk7Ci0gICAgQ0dQYXRoUmVsZWFzZShjaXJjbGUpOwotCiAgICAgaWYgKCFt X2NpQ29udGV4dCkKICAgICAgICAgbV9jaUNvbnRleHQgPSBbQ0lDb250ZXh0IGNvbnRleHRdOwog CkBAIC0xOTEyLDE3ICsxOTI5LDIwIEBAIHZvaWQgUmVuZGVyVGhlbWVJT1M6OnBhaW50U3lzdGVt UHJldmlld0JhZGdlKEltYWdlJiBpbWFnZSwgY29uc3QgUGFpbnRJbmZvJiBwYWluCiAgICAgY2dJ bWFnZSA9IGFkb3B0Q0YoW21fY2lDb250ZXh0LmdldCgpIGNyZWF0ZUNHSW1hZ2U6c291cmNlT3Zl ckZpbHRlci5vdXRwdXRJbWFnZSBmcm9tUmVjdDpmbGlwcGVkSW5zZXRCYWRnZVJlY3RdKTsKICNl bmRpZgogCisgICAgLy8gQmVmb3JlIHdlIHJlbmRlciB0aGUgcmVzdWx0LCB3ZSBzaG91bGQgY2xp cCB0byBhIGNpcmNsZSBhcm91bmQgdGhlIGJhZGdlIHJlY3RhbmdsZS4KICAgICBDR0NvbnRleHRT YXZlR1N0YXRlKGN0eCk7CisgICAgQ0dDb250ZXh0QmVnaW5QYXRoKGN0eCk7CisgICAgQ0dDb250 ZXh0QWRkUGF0aChjdHgsIGNpcmNsZS5nZXQoKSk7CisgICAgQ0dDb250ZXh0Q2xvc2VQYXRoKGN0 eCk7CisgICAgQ0dDb250ZXh0Q2xpcChjdHgpOworCiAgICAgQ0dDb250ZXh0VHJhbnNsYXRlQ1RN KGN0eCwgYWJzb2x1dGVCYWRnZVJlY3Qub3JpZ2luLngsIGFic29sdXRlQmFkZ2VSZWN0Lm9yaWdp bi55KTsKICAgICBDR0NvbnRleHRUcmFuc2xhdGVDVE0oY3R4LCAwLCBiYWRnZURpbWVuc2lvbik7 CiAgICAgQ0dDb250ZXh0U2NhbGVDVE0oY3R4LCAxLCAtMSk7CiAgICAgQ0dDb250ZXh0RHJhd0lt YWdlKGN0eCwgYmFkZ2VSZWN0LCBjZ0ltYWdlLmdldCgpKTsKLSAgICBDR0NvbnRleHRSZXN0b3Jl R1N0YXRlKGN0eCk7CiAKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogICAgIGlmIChhdXRv IGxvZ28gPSBzeXN0ZW1QcmV2aWV3TG9nbygpKSB7Ci0gICAgICAgIC8vIEZJWE1FOiBEbyB3ZSBu ZWVkIHRvIGZsaXAgaGVyZSB0b28/Ci0gICAgICAgIENHQ29udGV4dFRyYW5zbGF0ZUNUTShjdHgs IGFic29sdXRlQmFkZ2VSZWN0Lm9yaWdpbi54LCBhYnNvbHV0ZUJhZGdlUmVjdC5vcmlnaW4ueSk7 CiAgICAgICAgIENHU2l6ZSBwZGZTaXplID0gQ0dQREZQYWdlR2V0Qm94UmVjdChsb2dvLCBrQ0dQ REZNZWRpYUJveCkuc2l6ZTsKICAgICAgICAgQ0dGbG9hdCBzY2FsZVggPSBiYWRnZURpbWVuc2lv biAvIHBkZlNpemUud2lkdGg7CiAgICAgICAgIENHRmxvYXQgc2NhbGVZID0gYmFkZ2VEaW1lbnNp b24gLyBwZGZTaXplLmhlaWdodDsK