185316 2018-05-04 12:07:45 -0700 Fix Tools/Scripts/webkitdirs.pm for retrocompatibility 2018-05-07 15:02:07 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 leo webkit-unassigned ap dbates ews-watchlist lforschler oldest_to_newest 1420804 0 leo 2018-05-04 12:07:45 -0700 Fix Tools/Scripts/webkitdirs.pm for retrocompatibility 1420805 1 339579 leo 2018-05-04 12:08:22 -0700 Created attachment 339579 Patch 1420808 2 leo 2018-05-04 12:11:17 -0700 the `use version` is not really necessary for this script and it's not present before Perl 5.10. This script is indirectly called by the Test262 Runner where Perl 5.8.8 is required. 1420838 3 ap 2018-05-04 13:28:40 -0700 Could you please explain the situation in more detail? We use webkitdirs.pm everywhere, so it is very surprising that there is an environment where we need to use test262 runner, but haven’t been using webkitdirs fringe forever already. 1420841 4 ap 2018-05-04 13:30:16 -0700 *since forever 1421326 5 leo 2018-05-07 10:42:26 -0700 Hi Alexey, After discussing this feedback internally, we believe it's best to not require any other shared script so the 5.8.8 limitation goes isolated for the t262 runner only. I can talk more about using the environments test262 runner - mostly through the CI processes, but I'm afraid this could sidetrack the patch here. You can ping me on my email leo at bocoup.com and I'd be happy to give more details. 1421458 6 339579 ap 2018-05-07 15:02:07 -0700 Comment on attachment 339579 Patch Marking r-, as the issue is now NTBF. 339579 2018-05-04 12:08:22 -0700 2018-05-07 15:02:07 -0700 Patch bug-185316-20180504160821.patch text/plain 2064 leo U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODM2YzlkNjE2Zjk1YmI3ZGFiZTVjYmE2N2E4ZjNkNDQ4 MDg2MmY0Ny4uZjdlYjg0M2U1YjA4Y2Y0N2FkODQyNjQyMjdlMDRkNmYzZjBkYjdiZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA1LTA0ICBMZW8gQmFsdGVyICA8bGVvbmFyZG8uYmFsdGVyQGdtYWlsLmNvbT4K KworICAgICAgICBGaXggVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGZvciByZXRyb2NvbXBh dGliaWxpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NTMxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoYnVpbGRWaXN1YWxTdHVkaW9Qcm9q ZWN0KToKKwogMjAxOC0wNS0wNCAgV2Vuc29uIEhzaWVoICA8d2hzaWVoQGJlcmtlbGV5LmVkdT4K IAogICAgICAgICBSRUdSRVNTSU9OOiBbaW9zLXNpbXVsYXRvcl0gMyBXS1dlYlZpZXdBdXRvZmls bFRlc3RzIEFQSSB0ZXN0IGZhaWx1cmVzIHNlZW4gd2l0aCAxMS4zIFNESwpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt CmluZGV4IDhmNDg4MTFmMGZiN2Q4Njg2ZWVlZGI2OTFjZWY3ZGE3ZmJiNTdmODUuLjJhNjlhMDRk MjFjZGI2NmQ1YmQ4ZTJmM2I0OTY0MjI0OTI5OTk1MzIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTMw LDcgKzMwLDYgQEAKICMgTW9kdWxlIHRvIHNoYXJlIGNvZGUgdG8gZ2V0IHRvIFdlYktpdCBkaXJl Y3Rvcmllcy4KIAogdXNlIHN0cmljdDsKLXVzZSB2ZXJzaW9uOwogdXNlIHdhcm5pbmdzOwogdXNl IENvbmZpZzsKIHVzZSBDd2QgcXcocmVhbHBhdGgpOwpAQCAtMzgsNyArMzcsNyBAQCB1c2UgRGln ZXN0OjpNRDUgcXcobWQ1X2hleCk7CiB1c2UgRmluZEJpbjsKIHVzZSBGaWxlOjpCYXNlbmFtZTsK IHVzZSBGaWxlOjpGaW5kOwotdXNlIEZpbGU6OlBhdGggcXcobWFrZV9wYXRoIG1rcGF0aCBybXRy ZWUpOwordXNlIEZpbGU6OlBhdGggcXcobWtwYXRoIHJtdHJlZSk7CiB1c2UgRmlsZTo6U3BlYzsK IHVzZSBGaWxlOjpUZW1wIHF3KHRlbXBkaXIpOwogdXNlIEZpbGU6OnN0YXQ7CkBAIC00OSw4ICs0 OCw3IEBAIHVzZSBWQ1NVdGlsczsKIAogQkVHSU4gewogICAgdXNlIEV4cG9ydGVyICAgKCk7Ci0g ICBvdXIgKCRWRVJTSU9OLCBASVNBLCBARVhQT1JULCBARVhQT1JUX09LLCAlRVhQT1JUX1RBR1Mp OwotICAgJFZFUlNJT04gICAgID0gMS4wMDsKKyAgIG91ciAoQElTQSwgQEVYUE9SVCwgQEVYUE9S VF9PSywgJUVYUE9SVF9UQUdTKTsKICAgIEBJU0EgICAgICAgICA9IHF3KEV4cG9ydGVyKTsKICAg IEBFWFBPUlQgICAgICA9IHF3KAogICAgICAgICZYY29kZUNvdmVyYWdlU3VwcG9ydE9wdGlvbnMK QEAgLTE5MjQsNyArMTkyMiw3IEBAIHN1YiBidWlsZFZpc3VhbFN0dWRpb1Byb2plY3QKIAogICAg IG15ICRwbGF0Zm9ybSA9ICIvcDpQbGF0Zm9ybT0iIC4gKGlzV2luNjQoKSA/ICJ4NjQiIDogIldp bjMyIik7CiAgICAgbXkgJGxvZ1BhdGggPSBGaWxlOjpTcGVjLT5jYXRkaXIoJGJhc2VQcm9kdWN0 RGlyLCAkY29uZmlndXJhdGlvbik7Ci0gICAgbWFrZV9wYXRoKCRsb2dQYXRoKSB1bmxlc3MgLWQg JGxvZ1BhdGggb3IgJGxvZ1BhdGggZXEgIi4iOworICAgIG1rcGF0aCgkbG9nUGF0aCkgdW5sZXNz IC1kICRsb2dQYXRoIG9yICRsb2dQYXRoIGVxICIuIjsKIAogICAgIG15ICRlcnJvckxvZ0ZpbGUg PSBGaWxlOjpTcGVjLT5jYXRmaWxlKCRsb2dQYXRoLCAid2Via2l0X2Vycm9ycy5sb2ciKTsKICAg ICBjaG9tcCgkZXJyb3JMb2dGaWxlID0gYGN5Z3BhdGggLXcgIiRlcnJvckxvZ0ZpbGUiYCkgaWYg aXNDeWd3aW4oKTsK