185305 2018-05-04 10:11:53 -0700 Use more references in updateTracksOfType 2018-05-04 11:38:19 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1420725 0 youennf 2018-05-04 10:11:53 -0700 Use more references in updateTracksOfType 1420726 1 339559 youennf 2018-05-04 10:13:02 -0700 Created attachment 339559 Patch 1420784 2 339559 commit-queue 2018-05-04 11:37:25 -0700 Comment on attachment 339559 Patch Clearing flags on attachment: 339559 Committed r231366: <https://trac.webkit.org/changeset/231366> 1420785 3 commit-queue 2018-05-04 11:37:26 -0700 All reviewed patches have been landed. Closing bug. 1420786 4 webkit-bug-importer 2018-05-04 11:38:19 -0700 <rdar://problem/39983847> 339559 2018-05-04 10:13:02 -0700 2018-05-04 11:37:25 -0700 Patch bug-185305-20180504101301.patch text/plain 6170 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ1OWFkOTI4NzZhMWZk Y2QwMzg5OWQ3MTVkYWI3ODJjYzc2YmRlZi4uMDVkMzhjNjllNDRiMzQxMDA5NzVhZTZlYjExNzY4 YzA5NTkxOTI4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA1LTA0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgbW9yZSByZWZlcmVu Y2VzIGluIHVwZGF0ZVRyYWNrc09mVHlwZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg1MzA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gY2hhbmdlIG9mIGJlaGF2aW9yLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFT dHJlYW1BVkZPYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6dXBkYXRlVHJhY2tzT2ZUeXBlKToK KyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQzo6 dXBkYXRlVHJhY2tzKToKKwogMjAxOC0wNS0wNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBs ZS5jb20+CiAKICAgICAgICAgTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9jaGFuZ2UtdHJh Y2tzLW1lZGlhLXN0cmVhbS1iZWluZy1wbGF5ZWQuaHRtbCBpcyBjcmFzaGluZyBhZnRlciByMjMx MzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakMubW0gYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXll clByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakMubW0KaW5kZXggMDBlZTdjZDlmYzJiY2JhNTk1NzI5 Nzg3M2ZlOWExNjlmMTViN2M5YS4uOWQxMmNlNjA2YmIwZmJhNTMyZWViY2RkNGIxMTEwMzc3Njg4 YzNlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3Vu ZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDLm1tCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlh UGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQy5tbQpAQCAtOTE1LDcgKzkxNSw3IEBAIHR5 cGVkZWYgZW51bSB7CiB9IFRyYWNrU3RhdGU7CiAKIHRlbXBsYXRlIDx0eXBlbmFtZSBSZWZUPgot dm9pZCB1cGRhdGVUcmFja3NPZlR5cGUoSGFzaE1hcDxTdHJpbmcsIFJlZlQ+JiB0cmFja01hcCwg UmVhbHRpbWVNZWRpYVNvdXJjZTo6VHlwZSB0cmFja1R5cGUsIE1lZGlhU3RyZWFtVHJhY2tQcml2 YXRlVmVjdG9yJiBjdXJyZW50VHJhY2tzLCBSZWZUICgqaXRlbUZhY3RvcnkpKE1lZGlhU3RyZWFt VHJhY2tQcml2YXRlJiksIGNvbnN0IEZ1bmN0aW9uPHZvaWQoUmVmVCwgaW50LCBUcmFja1N0YXRl KT4mIGNvbmZpZ3VyZVRyYWNrKQordm9pZCB1cGRhdGVUcmFja3NPZlR5cGUoSGFzaE1hcDxTdHJp bmcsIFJlZlQ+JiB0cmFja01hcCwgUmVhbHRpbWVNZWRpYVNvdXJjZTo6VHlwZSB0cmFja1R5cGUs IE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlVmVjdG9yJiBjdXJyZW50VHJhY2tzLCBSZWZUICgqaXRl bUZhY3RvcnkpKE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlJiksIGNvbnN0IEZ1bmN0aW9uPHZvaWQo dHlwZW5hbWUgUmVmVDo6VmFsdWVUeXBlJiwgaW50LCBUcmFja1N0YXRlKT4mIGNvbmZpZ3VyZVRy YWNrKQogewogICAgIFZlY3RvcjxSZWZUPiByZW1vdmVkVHJhY2tzOwogICAgIFZlY3RvcjxSZWZU PiBhZGRlZFRyYWNrczsKQEAgLTk0NywxNSArOTQ3LDE1IEBAIHZvaWQgdXBkYXRlVHJhY2tzT2ZU eXBlKEhhc2hNYXA8U3RyaW5nLCBSZWZUPiYgdHJhY2tNYXAsIFJlYWx0aW1lTWVkaWFTb3VyY2U6 OlR5CiAKICAgICBpbnQgaW5kZXggPSAwOwogICAgIGZvciAoYXV0byYgdHJhY2sgOiByZW1vdmVk VHJhY2tzKQotICAgICAgICBjb25maWd1cmVUcmFjayh0cmFjaywgaW5kZXgrKywgVHJhY2tTdGF0 ZTo6UmVtb3ZlKTsKKyAgICAgICAgY29uZmlndXJlVHJhY2soKnRyYWNrLCBpbmRleCsrLCBUcmFj a1N0YXRlOjpSZW1vdmUpOwogCiAgICAgaW5kZXggPSAwOwogICAgIGZvciAoYXV0byYgdHJhY2sg OiBhZGRlZFRyYWNrcykKLSAgICAgICAgY29uZmlndXJlVHJhY2sodHJhY2ssIGluZGV4KyssIFRy YWNrU3RhdGU6OkFkZCk7CisgICAgICAgIGNvbmZpZ3VyZVRyYWNrKCp0cmFjaywgaW5kZXgrKywg VHJhY2tTdGF0ZTo6QWRkKTsKIAogICAgIGluZGV4ID0gMDsKICAgICBmb3IgKGNvbnN0IGF1dG8m IHRyYWNrIDogdHJhY2tNYXAudmFsdWVzKCkpCi0gICAgICAgIGNvbmZpZ3VyZVRyYWNrKHRyYWNr LCBpbmRleCsrLCBUcmFja1N0YXRlOjpDb25maWd1cmUpOworICAgICAgICBjb25maWd1cmVUcmFj aygqdHJhY2ssIGluZGV4KyssIFRyYWNrU3RhdGU6OkNvbmZpZ3VyZSk7CiB9CiAKIHZvaWQgTWVk aWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDOjpjaGVja1NlbGVjdGVkVmlkZW9UcmFj aygpCkBAIC05OTIsNDcgKzk5Miw0NyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3Ry ZWFtQVZGT2JqQzo6dXBkYXRlVHJhY2tzKCkKIHsKICAgICBNZWRpYVN0cmVhbVRyYWNrUHJpdmF0 ZVZlY3RvciBjdXJyZW50VHJhY2tzID0gbV9tZWRpYVN0cmVhbVByaXZhdGUtPnRyYWNrcygpOwog Ci0gICAgRnVuY3Rpb248dm9pZChSZWZQdHI8QXVkaW9UcmFja1ByaXZhdGVNZWRpYVN0cmVhbUNv Y29hPiwgaW50LCBUcmFja1N0YXRlKT4gIHNldEF1ZGlvVHJhY2tTdGF0ZSA9IFt0aGlzXShhdXRv IHRyYWNrLCBpbnQgaW5kZXgsIFRyYWNrU3RhdGUgc3RhdGUpCisgICAgYXV0byBzZXRBdWRpb1Ry YWNrU3RhdGUgPSBbdGhpc10oQXVkaW9UcmFja1ByaXZhdGVNZWRpYVN0cmVhbUNvY29hJiB0cmFj aywgaW50IGluZGV4LCBUcmFja1N0YXRlIHN0YXRlKQogICAgIHsKICAgICAgICAgc3dpdGNoIChz dGF0ZSkgewogICAgICAgICBjYXNlIFRyYWNrU3RhdGU6OlJlbW92ZToKLSAgICAgICAgICAgIHRy YWNrLT5zdHJlYW1UcmFjaygpLnJlbW92ZU9ic2VydmVyKCp0aGlzKTsKLSAgICAgICAgICAgIG1f cGxheWVyLT5yZW1vdmVBdWRpb1RyYWNrKCp0cmFjayk7CisgICAgICAgICAgICB0cmFjay5zdHJl YW1UcmFjaygpLnJlbW92ZU9ic2VydmVyKCp0aGlzKTsKKyAgICAgICAgICAgIG1fcGxheWVyLT5y ZW1vdmVBdWRpb1RyYWNrKHRyYWNrKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNl IFRyYWNrU3RhdGU6OkFkZDoKLSAgICAgICAgICAgIHRyYWNrLT5zdHJlYW1UcmFjaygpLmFkZE9i c2VydmVyKCp0aGlzKTsKLSAgICAgICAgICAgIG1fcGxheWVyLT5hZGRBdWRpb1RyYWNrKCp0cmFj ayk7CisgICAgICAgICAgICB0cmFjay5zdHJlYW1UcmFjaygpLmFkZE9ic2VydmVyKCp0aGlzKTsK KyAgICAgICAgICAgIG1fcGxheWVyLT5hZGRBdWRpb1RyYWNrKHRyYWNrKTsKICAgICAgICAgICAg IGJyZWFrOwogICAgICAgICBjYXNlIFRyYWNrU3RhdGU6OkNvbmZpZ3VyZToKLSAgICAgICAgICAg IHRyYWNrLT5zZXRUcmFja0luZGV4KGluZGV4KTsKLSAgICAgICAgICAgIGJvb2wgZW5hYmxlZCA9 IHRyYWNrLT5zdHJlYW1UcmFjaygpLmVuYWJsZWQoKSAmJiAhdHJhY2stPnN0cmVhbVRyYWNrKCku bXV0ZWQoKTsKLSAgICAgICAgICAgIHRyYWNrLT5zZXRFbmFibGVkKGVuYWJsZWQpOworICAgICAg ICAgICAgdHJhY2suc2V0VHJhY2tJbmRleChpbmRleCk7CisgICAgICAgICAgICBib29sIGVuYWJs ZWQgPSB0cmFjay5zdHJlYW1UcmFjaygpLmVuYWJsZWQoKSAmJiAhdHJhY2suc3RyZWFtVHJhY2so KS5tdXRlZCgpOworICAgICAgICAgICAgdHJhY2suc2V0RW5hYmxlZChlbmFibGVkKTsKICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfTsKLSAgICB1cGRhdGVUcmFja3NPZlR5cGUo bV9hdWRpb1RyYWNrTWFwLCBSZWFsdGltZU1lZGlhU291cmNlOjpUeXBlOjpBdWRpbywgY3VycmVu dFRyYWNrcywgJkF1ZGlvVHJhY2tQcml2YXRlTWVkaWFTdHJlYW1Db2NvYTo6Y3JlYXRlLCBzZXRB dWRpb1RyYWNrU3RhdGUpOworICAgIHVwZGF0ZVRyYWNrc09mVHlwZShtX2F1ZGlvVHJhY2tNYXAs IFJlYWx0aW1lTWVkaWFTb3VyY2U6OlR5cGU6OkF1ZGlvLCBjdXJyZW50VHJhY2tzLCAmQXVkaW9U cmFja1ByaXZhdGVNZWRpYVN0cmVhbUNvY29hOjpjcmVhdGUsIFdURk1vdmUoc2V0QXVkaW9UcmFj a1N0YXRlKSk7CiAKLSAgICBGdW5jdGlvbjx2b2lkKFJlZlB0cjxWaWRlb1RyYWNrUHJpdmF0ZU1l ZGlhU3RyZWFtPiwgaW50LCBUcmFja1N0YXRlKT4gc2V0VmlkZW9UcmFja1N0YXRlID0gWyZdKGF1 dG8gdHJhY2ssIGludCBpbmRleCwgVHJhY2tTdGF0ZSBzdGF0ZSkKKyAgICBhdXRvIHNldFZpZGVv VHJhY2tTdGF0ZSA9IFt0aGlzXShWaWRlb1RyYWNrUHJpdmF0ZU1lZGlhU3RyZWFtJiB0cmFjaywg aW50IGluZGV4LCBUcmFja1N0YXRlIHN0YXRlKQogICAgIHsKICAgICAgICAgc3dpdGNoIChzdGF0 ZSkgewogICAgICAgICBjYXNlIFRyYWNrU3RhdGU6OlJlbW92ZToKLSAgICAgICAgICAgIHRyYWNr LT5zdHJlYW1UcmFjaygpLnJlbW92ZU9ic2VydmVyKCp0aGlzKTsKLSAgICAgICAgICAgIG1fcGxh eWVyLT5yZW1vdmVWaWRlb1RyYWNrKCp0cmFjayk7CisgICAgICAgICAgICB0cmFjay5zdHJlYW1U cmFjaygpLnJlbW92ZU9ic2VydmVyKCp0aGlzKTsKKyAgICAgICAgICAgIG1fcGxheWVyLT5yZW1v dmVWaWRlb1RyYWNrKHRyYWNrKTsKICAgICAgICAgICAgIGNoZWNrU2VsZWN0ZWRWaWRlb1RyYWNr KCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBUcmFja1N0YXRlOjpBZGQ6Ci0g ICAgICAgICAgICB0cmFjay0+c3RyZWFtVHJhY2soKS5hZGRPYnNlcnZlcigqdGhpcyk7Ci0gICAg ICAgICAgICBtX3BsYXllci0+YWRkVmlkZW9UcmFjaygqdHJhY2spOworICAgICAgICAgICAgdHJh Y2suc3RyZWFtVHJhY2soKS5hZGRPYnNlcnZlcigqdGhpcyk7CisgICAgICAgICAgICBtX3BsYXll ci0+YWRkVmlkZW9UcmFjayh0cmFjayk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2Fz ZSBUcmFja1N0YXRlOjpDb25maWd1cmU6Ci0gICAgICAgICAgICB0cmFjay0+c2V0VHJhY2tJbmRl eChpbmRleCk7Ci0gICAgICAgICAgICBib29sIHNlbGVjdGVkID0gJnRyYWNrLT5zdHJlYW1UcmFj aygpID09IG1fbWVkaWFTdHJlYW1Qcml2YXRlLT5hY3RpdmVWaWRlb1RyYWNrKCk7Ci0gICAgICAg ICAgICB0cmFjay0+c2V0U2VsZWN0ZWQoc2VsZWN0ZWQpOworICAgICAgICAgICAgdHJhY2suc2V0 VHJhY2tJbmRleChpbmRleCk7CisgICAgICAgICAgICBib29sIHNlbGVjdGVkID0gJnRyYWNrLnN0 cmVhbVRyYWNrKCkgPT0gbV9tZWRpYVN0cmVhbVByaXZhdGUtPmFjdGl2ZVZpZGVvVHJhY2soKTsK KyAgICAgICAgICAgIHRyYWNrLnNldFNlbGVjdGVkKHNlbGVjdGVkKTsKICAgICAgICAgICAgIGNo ZWNrU2VsZWN0ZWRWaWRlb1RyYWNrKCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQog ICAgIH07Ci0gICAgdXBkYXRlVHJhY2tzT2ZUeXBlKG1fdmlkZW9UcmFja01hcCwgUmVhbHRpbWVN ZWRpYVNvdXJjZTo6VHlwZTo6VmlkZW8sIGN1cnJlbnRUcmFja3MsICZWaWRlb1RyYWNrUHJpdmF0 ZU1lZGlhU3RyZWFtOjpjcmVhdGUsIHNldFZpZGVvVHJhY2tTdGF0ZSk7CisgICAgdXBkYXRlVHJh Y2tzT2ZUeXBlKG1fdmlkZW9UcmFja01hcCwgUmVhbHRpbWVNZWRpYVNvdXJjZTo6VHlwZTo6Vmlk ZW8sIGN1cnJlbnRUcmFja3MsICZWaWRlb1RyYWNrUHJpdmF0ZU1lZGlhU3RyZWFtOjpjcmVhdGUs IFdURk1vdmUoc2V0VmlkZW9UcmFja1N0YXRlKSk7CiB9CiAKIHN0ZDo6dW5pcXVlX3B0cjxQbGF0 Zm9ybVRpbWVSYW5nZXM+IE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQzo6c2Vl a2FibGUoKSBjb25zdAo=