185298 2018-05-04 06:40:37 -0700 OptionsSet initializer list constructor should be constexpr 2018-05-04 08:36:18 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned andersca benjamin cdumez cmarcelo commit-queue dbates ews-watchlist sam webkit-bug-importer oldest_to_newest 1420638 0 koivisto 2018-05-04 06:40:37 -0700 It should. 1420641 1 339539 koivisto 2018-05-04 06:52:43 -0700 Created attachment 339539 patch 1420665 2 339539 commit-queue 2018-05-04 08:05:40 -0700 Comment on attachment 339539 patch Rejecting attachment 339539 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 339539, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/7564449 1420676 3 koivisto 2018-05-04 08:35:54 -0700 https://trac.webkit.org/r231353 1420677 4 webkit-bug-importer 2018-05-04 08:36:18 -0700 <rdar://problem/39976940> 339539 2018-05-04 06:52:43 -0700 2018-05-04 08:36:04 -0700 patch optionset-constexpr.patch text/plain 1660 koivisto SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzEzNTEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDE4LTA1LTA0ICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KKworICAgICAgICBPcHRpb25zU2V0IGluaXRpYWxpemVyIGxpc3QgY29u c3RydWN0b3Igc2hvdWxkIGJlIGNvbnN0ZXhwcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1Mjk4CisKKyAgICAgICAgKiB3dGYvT3B0aW9uU2V0Lmg6 CisgICAgICAgIChXVEY6Ok9wdGlvblNldDo6T3B0aW9uU2V0KToKKwogMjAxOC0wNS0wMyAgWXVz dWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBVc2UgZGVmYXVs dCBzdGQ6Om9wdGlvbmFsIGlmIGl0IGlzIHByb3ZpZGVkCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9P cHRpb25TZXQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9PcHRpb25TZXQuaAkocmV2 aXNpb24gMjMxMzUxKQorKysgU291cmNlL1dURi93dGYvT3B0aW9uU2V0LmgJKHdvcmtpbmcgY29w eSkKQEAgLTc4LDE2ICs3OCwxOSBAQCBwdWJsaWM6CiAgICAgICAgIDogbV9zdG9yYWdlKHN0YXRp Y19jYXN0PFN0b3JhZ2VUeXBlPih0KSkKICAgICB7CiAgICAgfQorCisgICAgY29uc3RleHByIE9w dGlvblNldChzdGQ6OmluaXRpYWxpemVyX2xpc3Q8VD4gaW5pdGlhbGl6ZXJMaXN0KQorICAgIHsK KyAgICAgICAgZm9yIChhdXRvJiBvcHRpb24gOiBpbml0aWFsaXplckxpc3QpCisgICAgICAgICAg ICBtX3N0b3JhZ2UgfD0gc3RhdGljX2Nhc3Q8U3RvcmFnZVR5cGU+KG9wdGlvbik7CisgICAgfQog I2Vsc2UKICAgICBPcHRpb25TZXQoVCB0KQogICAgICAgICA6IG1fc3RvcmFnZShzdGF0aWNfY2Fz dDxTdG9yYWdlVHlwZT4odCkpCiAgICAgewogICAgICAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKGhh c09uZUJpdFNldChzdGF0aWNfY2FzdDxTdG9yYWdlVHlwZT4odCkpLCAiRW51bWVyYXRvciBpcyBu b3QgYSBwb3NpdGl2ZSBwb3dlciBvZiB0d28uIik7CiAgICAgfQotI2VuZGlmCiAKLSAgICAvLyBG SVhNRTogTWFrZSB0aGlzIGNvbnN0ZXhwciBvbmNlIHdlIGFkb3B0IEMrKzE0IGFzIEMrKzExIGRv ZXMgbm90IHN1cHBvcnQgZm9yLWxvb3BzCi0gICAgLy8gaW4gYSBjb25zdGV4cHIgZnVuY3Rpb24u CiAgICAgT3B0aW9uU2V0KHN0ZDo6aW5pdGlhbGl6ZXJfbGlzdDxUPiBpbml0aWFsaXplckxpc3Qp CiAgICAgewogICAgICAgICBmb3IgKGF1dG8mIG9wdGlvbiA6IGluaXRpYWxpemVyTGlzdCkgewpA QCAtOTUsNiArOTgsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICBtX3N0b3JhZ2UgfD0gc3RhdGlj X2Nhc3Q8U3RvcmFnZVR5cGU+KG9wdGlvbik7CiAgICAgICAgIH0KICAgICB9CisjZW5kaWYKIAog ICAgIGNvbnN0ZXhwciBTdG9yYWdlVHlwZSB0b1JhdygpIGNvbnN0IHsgcmV0dXJuIG1fc3RvcmFn ZTsgfQogCg==