185292 2018-05-03 21:46:25 -0700 Remove std::random_shuffle 2018-05-03 22:33:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 185293 1 ysuzuki ysuzuki achristensen darin ews-watchlist fpizlo keith_miller mark.lam msaboff rniwa saam sam webkit-bug-importer oldest_to_newest 1420558 0 ysuzuki 2018-05-03 21:46:25 -0700 Remove std::random_shuffle 1420559 1 339520 ysuzuki 2018-05-03 21:47:10 -0700 Created attachment 339520 Patch 1420562 2 339520 fpizlo 2018-05-03 22:19:21 -0700 Comment on attachment 339520 Patch Can we instead have a WeakRandon rwference passed to BinarySwitch? Maybe users of BinarySwitch can keep a WeakRandom around longer. 1420563 3 darin 2018-05-03 22:22:58 -0700 (In reply to Filip Pizlo from comment #2) > Can we instead have a WeakRandon rwference passed to BinarySwitch? Maybe > users of BinarySwitch can keep a WeakRandom around longer. Seems OK, but this is not changing here, so seems orthogonal. 1420569 4 ysuzuki 2018-05-03 22:31:13 -0700 (In reply to Filip Pizlo from comment #2) > Comment on attachment 339520 [details] > Patch > > Can we instead have a WeakRandon rwference passed to BinarySwitch? Maybe > users of BinarySwitch can keep a WeakRandom around longer. OK, I'll do this that in a separate patch. This patch removes std::random_shuffle, this is required b/c C++17 removes this function, and actually MSVC w/ C++17 flag does not have this function :) 1420570 5 ysuzuki 2018-05-03 22:32:46 -0700 Committed r231347: <https://trac.webkit.org/changeset/231347> 1420571 6 webkit-bug-importer 2018-05-03 22:33:27 -0700 <rdar://problem/39967119> 339520 2018-05-03 21:47:10 -0700 2018-05-03 22:21:05 -0700 Patch bug-185292-20180504134709.patch text/plain 2838 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NWVlYTY2MGEzZjJkYTNiOWJlZTU4ZTIwMDY0MWQwZWFlYmY4YjUxLi40ZWQ2Nzg5Mjk1YmRlZGQ5 YjIzYzM0MzE2NDVjMGY3Yzg5YTViNzMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOC0wNS0wMyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBSZW1vdmUgc3RkOjpyYW5kb21fc2h1ZmZsZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1MjkyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc3RkOjpyYW5kb21fc2h1ZmZsZSBp cyBkZXByZWNhdGVkIGluIEMrKzE0IGFuZCByZW1vdmVkIGluIEMrKzE3LAorICAgICAgICBzaW5j ZSBzdGQ6OnJhbmRvbV9zaHVmZmxlIHJlbGllcyBvbiByYW5kIGFuZCBzcmFuZC4KKyAgICAgICAg VXNlIHN0ZDo6c2h1ZmZsZSBpbnN0ZWFkLgorCisgICAgICAgICogaml0L0JpbmFyeVN3aXRjaC5j cHA6CisgICAgICAgIChKU0M6OlJhbmRvbU51bWJlckdlbmVyYXRvcjo6UmFuZG9tTnVtYmVyR2Vu ZXJhdG9yKToKKyAgICAgICAgKEpTQzo6UmFuZG9tTnVtYmVyR2VuZXJhdG9yOjpvcGVyYXRvcigp KToKKyAgICAgICAgKEpTQzo6UmFuZG9tTnVtYmVyR2VuZXJhdG9yOjptaW4pOgorICAgICAgICAo SlNDOjpSYW5kb21OdW1iZXJHZW5lcmF0b3I6Om1heCk6CisgICAgICAgIChKU0M6OkJpbmFyeVN3 aXRjaDo6YnVpbGQpOgorCiAyMDE4LTA1LTAzICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgogCiAgICAgICAgIERvbid0IHByZXZlbnQgQ3JlYXRlVGhpcyBiZWluZyBmb2xkZWQgdG8g TmV3T2JqZWN0IHdoZW4gdGhlIHN0cnVjdHVyZSBpcyBwb2x5IHByb3RvCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0JpbmFyeVN3aXRjaC5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0JpbmFyeVN3aXRjaC5jcHAKaW5kZXggMGVhYjU2NTE5MjUzMjllMTdiM2Y1 Y2EyNWRiMTM0YWI0ZGQ5YTY3Mi4uZThlNjU3ZTQ0NGI1Y2MyOTk4MjA1OTQzZDE2YWQ0OTg2MmEz NjI3NSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9CaW5hcnlTd2l0Y2gu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQmluYXJ5U3dpdGNoLmNwcApAQCAt MTM3LDYgKzEzNywyNyBAQCBib29sIEJpbmFyeVN3aXRjaDo6YWR2YW5jZShNYWNyb0Fzc2VtYmxl ciYgaml0KQogICAgIH0KIH0KIAorY2xhc3MgUmFuZG9tTnVtYmVyR2VuZXJhdG9yIHsKK3B1Ymxp YzoKKyAgICB1c2luZyByZXN1bHRfdHlwZSA9IHVpbnQzMl90OworCisgICAgUmFuZG9tTnVtYmVy R2VuZXJhdG9yKFdlYWtSYW5kb20mIHdlYWtSYW5kb20pCisgICAgICAgIDogbV93ZWFrUmFuZG9t KHdlYWtSYW5kb20pCisgICAgeworICAgIH0KKworICAgIHVpbnQzMl90IG9wZXJhdG9yKCkoKQor ICAgIHsKKyAgICAgICAgcmV0dXJuIG1fd2Vha1JhbmRvbS5nZXRVaW50MzIoKTsKKyAgICB9CisK KyAgICBzdGF0aWMgY29uc3RleHByIHVpbnQzMl90IG1pbigpIHsgcmV0dXJuIHN0ZDo6bnVtZXJp Y19saW1pdHM8dWludDMyX3Q+OjptaW4oKTsgfQorICAgIHN0YXRpYyBjb25zdGV4cHIgdWludDMy X3QgbWF4KCkgeyByZXR1cm4gc3RkOjpudW1lcmljX2xpbWl0czx1aW50MzJfdD46Om1heCgpOyB9 CisKK3ByaXZhdGU6CisgICAgV2Vha1JhbmRvbSYgbV93ZWFrUmFuZG9tOworfTsKKwogdm9pZCBC aW5hcnlTd2l0Y2g6OmJ1aWxkKHVuc2lnbmVkIHN0YXJ0LCBib29sIGhhcmRTdGFydCwgdW5zaWdu ZWQgZW5kKQogewogICAgIGlmIChCaW5hcnlTd2l0Y2hJbnRlcm5hbDo6dmVyYm9zZSkKQEAgLTE5 NSwxMyArMjE2LDkgQEAgdm9pZCBCaW5hcnlTd2l0Y2g6OmJ1aWxkKHVuc2lnbmVkIHN0YXJ0LCBi b29sIGhhcmRTdGFydCwgdW5zaWduZWQgZW5kKQogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAw OyBpIDwgc2l6ZTsgKytpKQogICAgICAgICAgICAgbG9jYWxDYXNlSW5kaWNlcy5hcHBlbmQoc3Rh cnQgKyBpKTsKICAgICAgICAgCi0gICAgICAgIHN0ZDo6cmFuZG9tX3NodWZmbGUoCisgICAgICAg IHN0ZDo6c2h1ZmZsZSgKICAgICAgICAgICAgIGxvY2FsQ2FzZUluZGljZXMuYmVnaW4oKSwgbG9j YWxDYXNlSW5kaWNlcy5lbmQoKSwKLSAgICAgICAgICAgIFt0aGlzXSAodW5zaWduZWQgbikgewot ICAgICAgICAgICAgICAgIC8vIFdlIHVzZSBtb2R1bG8gdG8gZ2V0IGEgcmFuZG9tIG51bWJlciBp biB0aGUgcmFuZ2Ugd2Ugd2FudCBmdWxseSBrbm93aW5nIHRoYXQKLSAgICAgICAgICAgICAgICAv LyB0aGlzIGludHJvZHVjZXMgYSB0aW55IGFtb3VudCBvZiBiaWFzLCBidXQgd2UncmUgZmluZSB3 aXRoIHN1Y2ggdGlueSBiaWFzLgotICAgICAgICAgICAgICAgIHJldHVybiBtX3dlYWtSYW5kb20u Z2V0VWludDMyKCkgJSBuOwotICAgICAgICAgICAgfSk7CisgICAgICAgICAgICBSYW5kb21OdW1i ZXJHZW5lcmF0b3IobV93ZWFrUmFuZG9tKSk7CiAgICAgICAgIAogICAgICAgICBmb3IgKHVuc2ln bmVkIGkgPSAwOyBpIDwgc2l6ZSAtIDE7ICsraSkgewogICAgICAgICAgICAgYXBwZW5kKEJyYW5j aENvZGUoTm90RXF1YWxUb1B1c2gsIGxvY2FsQ2FzZUluZGljZXNbaV0pKTsK