185291 2018-05-03 21:37:11 -0700 Use subprocess.call instead of os.system to handle path with spaces 2018-05-03 22:29:33 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki achristensen cdumez darin fpizlo rniwa saam sam webkit-bug-importer oldest_to_newest 1420555 0 ysuzuki 2018-05-03 21:37:11 -0700 Use subprocess.call instead of os.system to handle path with spaces 1420556 1 339518 ysuzuki 2018-05-03 21:37:53 -0700 Created attachment 339518 Patch 1420566 2 ysuzuki 2018-05-03 22:28:17 -0700 Committed r231346: <https://trac.webkit.org/changeset/231346> 1420567 3 ysuzuki 2018-05-03 22:28:42 -0700 Thanks for your review! 1420568 4 webkit-bug-importer 2018-05-03 22:29:33 -0700 <rdar://problem/39967056> 339518 2018-05-03 21:37:53 -0700 2018-05-03 22:23:54 -0700 Patch bug-185291-20180504133752.patch text/plain 4176 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDIzMWNmZTU2YmJiYWEx MTExODA3Y2NkMmY2NDk3OGNhMWUxYjA0MC4uODhlMGIxMzBmY2YwOWJlOWE2OTZlNTVmOTM1MjQ0 MjFmM2MzZmQzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA1LTAzICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIFVzZSBzdWJwcm9j ZXNzLmNhbGwgaW5zdGVhZCBvZiBvcy5zeXN0ZW0gdG8gaGFuZGxlIHBhdGggd2l0aCBzcGFjZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTI5MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIGdwZXJm IHBhdGggaW5jbHVkZXMgc3BhY2VzLCB0aGVzZSBweXRob24gc2NyaXB0cyBmYWlsIHRvIGV4ZWN1 dGUgZ3BlcmYuCisgICAgICAgIFdlIHVzZSBzdWJwcm9jZXNzIG1vZHVsZSBpbnN0ZWFkIG9mIG9z LnN5c3RlbSB0byBpbnZva2UgZ3BlcmYuCisKKyAgICAgICAgKiBjc3MvbWFrZVNlbGVjdG9yUHNl dWRvQ2xhc3NBbmRDb21wYXRpYmlsaXR5RWxlbWVudE1hcC5weToKKyAgICAgICAgKiBjc3MvbWFr ZVNlbGVjdG9yUHNldWRvRWxlbWVudHNNYXAucHk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29y ay9jcmVhdGUtaHR0cC1oZWFkZXItbmFtZS10YWJsZToKKwogMjAxOC0wNS0wMyAgWXVzdWtlIFN1 enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhdHRl bXB0IHRvIGZpeCBXaW5DYWlybyBidWlsZCBmYWlsdXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvbWFrZVNlbGVjdG9yUHNldWRvQ2xhc3NBbmRDb21wYXRpYmlsaXR5RWxlbWVudE1h cC5weSBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlU2VsZWN0b3JQc2V1ZG9DbGFzc0FuZENvbXBh dGliaWxpdHlFbGVtZW50TWFwLnB5CmluZGV4IDc4MzMyMjcxYWM2MTU2OTU3NDNkM2NkYWE3Zjk3 YzlhMTc4NzY3YjEuLjBjMzAwODc2ZGE3NWVjOTNjYzUxOTI0NWQzMTU2Yzg1MTgxMjJmNTMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlU2VsZWN0b3JQc2V1ZG9DbGFzc0FuZENv bXBhdGliaWxpdHlFbGVtZW50TWFwLnB5CisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlU2Vs ZWN0b3JQc2V1ZG9DbGFzc0FuZENvbXBhdGliaWxpdHlFbGVtZW50TWFwLnB5CkBAIC0yNSw2ICsy NSw3IEBACiAKIGltcG9ydCBvcwogaW1wb3J0IHN5cworaW1wb3J0IHN1YnByb2Nlc3MKIAogCiBk ZWYgZW51bWVyYWJsZVBzZXVkb1R5cGUoc3RyaW5nUHNldWRvVHlwZSk6CkBAIC0yMTEsNyArMjEy LDYgQEAgZGVmIGV4cGFuZF9pZmRlZl9jb25kaXRpb24oY29uZGl0aW9uKToKIGlmICdHUEVSRicg aW4gb3MuZW52aXJvbjoKICAgICBncGVyZl9jb21tYW5kID0gb3MuZW52aXJvblsnR1BFUkYnXQog Ci1ncGVyZl9yZXR1cm4gPSBvcy5zeXN0ZW0oIiVzIC0ta2V5LXBvc2l0aW9ucz1cIipcIiAtbSAx MCAtcyAyIFNlbGVjdG9yUHNldWRvQ2xhc3NBbmRDb21wYXRpYmlsaXR5RWxlbWVudE1hcC5ncGVy ZiAtLW91dHB1dC1maWxlPVNlbGVjdG9yUHNldWRvQ2xhc3NBbmRDb21wYXRpYmlsaXR5RWxlbWVu dE1hcC5jcHAiICUgZ3BlcmZfY29tbWFuZCkKLWlmIGdwZXJmX3JldHVybiAhPSAwOgoraWYgc3Vi cHJvY2Vzcy5jYWxsKFtncGVyZl9jb21tYW5kLCAnLS1rZXktcG9zaXRpb25zPSonLCAnLW0nLCAn MTAnLCAnLXMnLCAnMicsICdTZWxlY3RvclBzZXVkb0NsYXNzQW5kQ29tcGF0aWJpbGl0eUVsZW1l bnRNYXAuZ3BlcmYnLCAnLS1vdXRwdXQtZmlsZT1TZWxlY3RvclBzZXVkb0NsYXNzQW5kQ29tcGF0 aWJpbGl0eUVsZW1lbnRNYXAuY3BwJ10pICE9IDA6CiAgICAgcHJpbnQoIkVycm9yIHdoZW4gZ2Vu ZXJhdGluZyBTZWxlY3RvclBzZXVkb0NsYXNzQW5kQ29tcGF0aWJpbGl0eUVsZW1lbnRNYXAuY3Bw IGZyb20gU2VsZWN0b3JQc2V1ZG9DbGFzc0FuZENvbXBhdGliaWxpdHlFbGVtZW50TWFwLmdwZXJm IDooIikKICAgICBzeXMuZXhpdChncGVyZl9yZXR1cm4pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvbWFrZVNlbGVjdG9yUHNldWRvRWxlbWVudHNNYXAucHkgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvbWFrZVNlbGVjdG9yUHNldWRvRWxlbWVudHNNYXAucHkKaW5kZXggODNiMjM4ZTJmNDZk NDNiNDg0MDQwMTJjMDVkZDc2MDkxNjBhYWY3Mi4uMmM5Mjc2Yzk4MWUxMDlkODk1NjM2N2Y3ZjRi Yjg5MWQyZThmZTkxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL21ha2VTZWxlY3Rv clBzZXVkb0VsZW1lbnRzTWFwLnB5CisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlU2VsZWN0 b3JQc2V1ZG9FbGVtZW50c01hcC5weQpAQCAtMjUsNiArMjUsNyBAQAogCiBpbXBvcnQgb3MKIGlt cG9ydCBzeXMKK2ltcG9ydCBzdWJwcm9jZXNzCiAKIAogZGVmIGVudW1lcmFibGVQc2V1ZG9UeXBl KHN0cmluZ1BzZXVkb1R5cGUpOgpAQCAtMjA2LDcgKzIwNyw2IEBAIGRlZiBleHBhbmRfaWZkZWZf Y29uZGl0aW9uKGNvbmRpdGlvbik6CiBpZiAnR1BFUkYnIGluIG9zLmVudmlyb246CiAgICAgZ3Bl cmZfY29tbWFuZCA9IG9zLmVudmlyb25bJ0dQRVJGJ10KIAotZ3BlcmZfcmV0dXJuID0gb3Muc3lz dGVtKCIlcyAtLWtleS1wb3NpdGlvbnM9XCIqXCIgLW0gMTAgLXMgMiBTZWxlY3RvclBzZXVkb0Vs ZW1lbnRUeXBlTWFwLmdwZXJmIC0tb3V0cHV0LWZpbGU9U2VsZWN0b3JQc2V1ZG9FbGVtZW50VHlw ZU1hcC5jcHAiICUgZ3BlcmZfY29tbWFuZCkKLWlmIGdwZXJmX3JldHVybiAhPSAwOgoraWYgc3Vi cHJvY2Vzcy5jYWxsKFtncGVyZl9jb21tYW5kLCAnLS1rZXktcG9zaXRpb25zPSonLCAnLW0nLCAn MTAnLCAnLXMnLCAnMicsICdTZWxlY3RvclBzZXVkb0VsZW1lbnRUeXBlTWFwLmdwZXJmJywgJy0t b3V0cHV0LWZpbGU9U2VsZWN0b3JQc2V1ZG9FbGVtZW50VHlwZU1hcC5jcHAnXSkgIT0gMDoKICAg ICBwcmludCgiRXJyb3Igd2hlbiBnZW5lcmF0aW5nIFNlbGVjdG9yUHNldWRvRWxlbWVudFR5cGVN YXAuY3BwIGZyb20gU2VsZWN0b3JQc2V1ZG9FbGVtZW50VHlwZU1hcC5ncGVyZiA6KCIpCiAgICAg c3lzLmV4aXQoZ3BlcmZfcmV0dXJuKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jcmVhdGUtaHR0cC1oZWFkZXItbmFtZS10YWJsZSBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3JlYXRlLWh0dHAtaGVhZGVyLW5hbWUtdGFibGUKaW5kZXggNzU1 ZDIyZTk0Njg3YTkyZmYzMjdkOTgxM2ViZDJlNzkwYThkMTgyNy4uMWQ0ZWJjYWViZDczM2NkODY0 NDQzMjVmMWU4NzEwYWU5ZGJhZWE0MyAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jcmVhdGUtaHR0cC1oZWFkZXItbmFtZS10YWJsZQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NyZWF0ZS1odHRwLWhlYWRlci1uYW1lLXRhYmxlCkBAIC0y OSw2ICsyOSw3IEBACiAKIGltcG9ydCBvcwogaW1wb3J0IHN5cworaW1wb3J0IHN1YnByb2Nlc3MK IAogcHJvZ3JhbV9uYW1lID0gb3MucGF0aC5iYXNlbmFtZShfX2ZpbGVfXykKIGlmIGxlbihzeXMu YXJndikgPCAyOgpAQCAtMjQwLDYgKzI0MSw2IEBAIGhlYWRlcl9maWxlLmNsb3NlKCkKIAogZ3Bl cmYgPSBvcy5nZXRlbnYoJ0dQRVJGJykgb3Igc3lzLmFyZ3ZbMl0KIAotaWYgb3Muc3lzdGVtKCcl cyAtLWtleS1wb3NpdGlvbnM9IioiIC1EIC1uIC1zIDIgSFRUUEhlYWRlck5hbWVzLmdwZXJmIC0t b3V0cHV0LWZpbGU9SFRUUEhlYWRlck5hbWVzLmNwcCcgJSBncGVyZik6CitpZiBzdWJwcm9jZXNz LmNhbGwoW2dwZXJmLCAnLS1rZXktcG9zaXRpb25zPSonLCAnLUQnLCAnLW4nLCAnLXMnLCAnMics ICdIVFRQSGVhZGVyTmFtZXMuZ3BlcmYnLCAnLS1vdXRwdXQtZmlsZT1IVFRQSGVhZGVyTmFtZXMu Y3BwJ10pICE9IDA6CiAgICAgc3lzLnN0ZGVyci53cml0ZSgnRmFpbGVkIHRvIHJ1biBncGVyZi4n KQogICAgIGV4aXQoMSkK