185289 2018-05-03 20:12:53 -0700 [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart 2018-05-04 21:48:11 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue darin mitz thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1420535 0 wenson_hsieh 2018-05-03 20:12:53 -0700 <rdar://problem/35756912> 1420538 1 339512 wenson_hsieh 2018-05-03 20:23:23 -0700 Created attachment 339512 Patch 1420575 2 339512 thorton 2018-05-03 23:11:42 -0700 Comment on attachment 339512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339512&action=review > Source/WebCore/ChangeLog:18 > + Additionally remove some extraneous header imports from this implementation file. Craaaazy. How sure are you that they are extraneous and you’re not just getting lucky because of unified sources? 1420576 3 339512 darin 2018-05-03 23:30:55 -0700 Comment on attachment 339512 Patch r=me as is, but I have some concerns I also don’t know how I feel about the idea of pasting multiple links as if they were text separated by newlines. I guess someone asked for that behavior. Is there a similar case in the iOS or macOS UI that we are aligning with? It’s particularly strange that it can break a word or sentence into multiple lines. I am not confident about the choice of a <br> element as a separator between multiple links to achieve having each on a separate line. I think the analogy might be to pasting text with newlines, and that does something different, does not always turn the newlines into <br> elements. See the createFragmentFromText function for details. It uses paragraph elements in some common cases. Inserting a line break by typing does a different thing. See the InsertLineBreakCommand::doApply function and note that it will use a newline character rather than a <br> in cases like inside a <pre> element. Hitting the Return will do a third different thing. See the InsertParagraphSeparator::doApply function. This code doesn’t seem to do the right thing when putting multiple links into a non-richly-editable location. Seems like it will put the URLs all next to each other without even spaces separating them? Not new to this patch: I don’t understand why the macOS and iOS versions of WebContentReader::readURL are so different from each other. They do not seem to be limited to platform specifics. It’s a sort of “bad code smell" that the additional sophistication in the iOS file seems like it comprises all improvements that would apply equally well to macOS and even other platforms. We should factor this code better. I guess I’d like to see most of this logic be entirely platform independent. It’s not good to have the platforms be diverging like this. Not new to this patch: It seems not so great to have the readURL function do the "append" logic as well as the logic for creating an element for a single link. Perhaps I don’t understand the factoring well enough here, but it seems that we should separate code that knows the platform-specific rules for how to create an anchor for a link from the code that knows how to insert the multiple anchors with appropriate separators. 1420656 4 339512 wenson_hsieh 2018-05-04 07:20:05 -0700 Comment on attachment 339512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339512&action=review >> Source/WebCore/ChangeLog:18 >> + Additionally remove some extraneous header imports from this implementation file. > > Craaaazy. How sure are you that they are extraneous and you’re not just getting lucky because of unified sources? Good point! I'm sure at least a few of these are not needed. I'll double check to make sure. 1420681 5 wenson_hsieh 2018-05-04 08:45:02 -0700 Thanks for the feedback! Replies inline. (In reply to Darin Adler from comment #3) > Comment on attachment 339512 [details] > Patch > > r=me as is, but I have some concerns > > I also don’t know how I feel about the idea of pasting multiple links as if > they were text separated by newlines. I guess someone asked for that > behavior. Is there a similar case in the iOS or macOS UI that we are > aligning with? It’s particularly strange that it can break a word or > sentence into multiple lines. > Yeah, the motivation for this comes from Lena in QA, who felt that dropping multiple links in a single line was a bug. The closest platform analogy I can find to this behavior is dropping multiple links into Messages, which puts each link on a different line. I was primarily focused on addressing her feedback than matching the platform since this is already a very different experience in Notes, where we would drop as multiple rich links on different lines. I think the Notes app is also the closest (perhaps the only?) analogy to Mail in terms of editing behaviors on iPad. Note that the change here does not take effect when one is dropping a selection that contains multiple links, but rather when links are written to the pasteboard as separate items. An example of this is starting a drag on something in News, and then tapping links to add them to the drag session (in a drag flock). Given this, I don't think there's a case where this change would cause us to end up breaking a word or sentence into multiple lines when dropping. > I am not confident about the choice of a <br> element as a separator between > multiple links to achieve having each on a separate line. I think the > analogy might be to pasting text with newlines, and that does something > different, does not always turn the newlines into <br> elements. See the > createFragmentFromText function for details. It uses paragraph elements in > some common cases. Inserting a line break by typing does a different thing. > See the InsertLineBreakCommand::doApply function and note that it will use > a newline character rather than a <br> in cases like inside a <pre> element. > Hitting the Return will do a third different thing. See the > InsertParagraphSeparator::doApply function. > Good catch — it looks like createFragmentFromText is really what I should've used here... > This code doesn’t seem to do the right thing when putting multiple links > into a non-richly-editable location. Seems like it will put the URLs all > next to each other without even spaces separating them? > Indeed! I didn't fix this in this patch because it didn't impact the bug reported here, but I think it's relevant enough that I could address this here anyways. I'll do this, and add a new API test where we drop multiple URLs into a plain text area. > Not new to this patch: I don’t understand why the macOS and iOS versions of > WebContentReader::readURL are so different from each other. They do not seem > to be limited to platform specifics. It’s a sort of “bad code smell" that > the additional sophistication in the iOS file seems like it comprises all > improvements that would apply equally well to macOS and even other > platforms. We should factor this code better. I guess I’d like to see most > of this logic be entirely platform independent. It’s not good to have the > platforms be diverging like this. > Totally agree — these implementations of readURL (in WebContentReaderMac and WebContentReaderIOS) are so similar, we should just unify them. There's some special handling to bail when transforming file URLs into web content on iOS, but that's about it. I'll add a FIXME for this. > Not new to this patch: It seems not so great to have the readURL function do > the "append" logic as well as the logic for creating an element for a single > link. Perhaps I don’t understand the factoring well enough here, but it > seems that we should separate code that knows the platform-specific rules > for how to create an anchor for a link from the code that knows how to > insert the multiple anchors with appropriate separators. That's a good point. The responsibility of WebContentReader is to transform all the items on the pasteboard into a single combined fragment to be inserted into the document via editing. As you noted, readURL is a strange place for logic that is concerned with emitting separators between items on the pasteboard. One way to improve this would be to add something like WebContentReader::insertSeparatorBetweenItems(PasteboardItemType firstItemType, PasteboardItemType secondItemType) where PasteboardItemType indicates what kind of content it is (e.g. link, selection, image, etc.). In PasteboardIOS and PasteboardMac, we'd then invoke this before calling WebContentReader::read*. I think the refactoring above would be a good followup to this, but I'd prefer to keep this patch targeted to address the case posed in <rdar://problem/35756912>. 1420990 6 darin 2018-05-04 19:05:14 -0700 (In reply to Wenson Hsieh from comment #5) > > r=me as is, but I have some concerns > > I think the refactoring above would be a good followup to this, but I'd > prefer to keep this patch targeted to address the case posed in > <rdar://problem/35756912>. Sounds fine. That’s part of what I meant when I said “r=me as is”. 1421000 7 wenson_hsieh 2018-05-04 20:06:23 -0700 (In reply to Darin Adler from comment #6) > (In reply to Wenson Hsieh from comment #5) > > > r=me as is, but I have some concerns > > > > I think the refactoring above would be a good followup to this, but I'd > > prefer to keep this patch targeted to address the case posed in > > <rdar://problem/35756912>. > > Sounds fine. That’s part of what I meant when I said “r=me as is”. Ok! On a related note, I worked towards getting plain text drops to insert links on separate lines, but discovered that there's quite a bit of refactoring involved in getting that to work. In fact, our current behavior when dropping multiple URLs in a plain text area is to only insert the *first* URL, because Pasteboard::read(PasteboardPlainText&) just reads from item index 0, and then DragData::asPlainText() just calls Pasteboard::read to figure out what text to insert. To prevent this fix from snowballing, I filed https://bugs.webkit.org/show_bug.cgi?id=185338, and I'll be following up there. 1421006 8 339626 wenson_hsieh 2018-05-04 20:30:34 -0700 Created attachment 339626 Patch for landing 1421019 9 339626 commit-queue 2018-05-04 21:39:58 -0700 Comment on attachment 339626 Patch for landing Clearing flags on attachment: 339626 Committed r231396: <https://trac.webkit.org/changeset/231396> 339512 2018-05-03 20:23:23 -0700 2018-05-03 23:11:42 -0700 Patch bug-185289-20180503202323.patch text/plain 6815 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDZmZWViNjk3ZmQ4YjQ2 Y2JmYzViMThlYjQ4ZTQwNmQyZjk5YTZjMy4uNDdhYTMzZjM1Njc1MmE1ZjA3ZWRkMWMyZTg1ZWNm NWY0MTFmMTAyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTA1LTAzICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIE11bHRp cGxlIGxpbmtzIGluIE1haWwgYXJlIGRyb3BwZWQgaW4gYSBzaW5nbGUgbGluZSwgYW5kIGFyZSBk aWZmaWN1bHQgdG8gdGVsbCBhcGFydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg1Mjg5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTc1NjkxMj4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGlu c2VydGluZyBtdWx0aXBsZSBVUkxzIGFzIGluZGl2aWR1YWwgaXRlbXMgaW4gYSBzaW5nbGUgZHJv cCwgd2UgY3VycmVudGx5IHNlcGFyYXRlIGVhY2ggaXRlbSB3aXRoIGEgc3BhY2UKKyAgICAgICAg KHNlZSByMjE3Mjg0KS4gSG93ZXZlciwgaXQgc3RpbGwgc2VlbXMgZGlmZmljdWx0IHRvIHRlbGwg ZHJvcHBlZCBsaW5rcyBhcGFydC4gVGhpcyBwYXRjaCBtYWtlcyBzb21lIHNsaWdodAorICAgICAg ICB0d2Vha3MgdG8gV2ViQ29udGVudFJlYWRlcjo6cmVhZFVSTCBzbyB0aGF0IGl0IGluc2VydHMg bGluZSBicmVha3MgYmVmb3JlIGRyb3BwZWQgVVJMcywgaWYgdGhlIGRyb3BwZWQgVVJMIGlzbid0 CisgICAgICAgIHRoZSBmaXJzdCBpdGVtIHRvIGJlIGluc2VydGVkIGluIHRoZSByZXN1bHRpbmcg ZG9jdW1lbnQgZnJhZ21lbnQuCisKKyAgICAgICAgQXVnbWVudHMgZXhpc3RpbmcgQVBJIHRlc3Rz IGluIERhdGFJbnRlcmFjdGlvblRlc3RzLgorCisgICAgICAgICogZWRpdGluZy9pb3MvV2ViQ29u dGVudFJlYWRlcklPUy5tbToKKworICAgICAgICBBZGRpdGlvbmFsbHkgcmVtb3ZlIHNvbWUgZXh0 cmFuZW91cyBoZWFkZXIgaW1wb3J0cyBmcm9tIHRoaXMgaW1wbGVtZW50YXRpb24gZmlsZS4KKwor ICAgICAgICAoV2ViQ29yZTo6V2ViQ29udGVudFJlYWRlcjo6cmVhZFVSTCk6CisKIDIwMTgtMDUt MDEgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcmVtb3ZlIGFuIHVudXNlZCB2YXJpYWJsZSBpbiBSdW50aW1lRW5hYmxlZEZlYXR1 cmVzLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvaW9zL1dlYkNvbnRlbnRS ZWFkZXJJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2lvcy9XZWJDb250ZW50UmVhZGVy SU9TLm1tCmluZGV4IDliMzEwZDU2YzY4ZGQ5M2NlMTdlOTNlNzg2MjhkZDRlYzMyYjM4MDguLjhk ZTVjMTUwMDZjYjlhOWQ4MzNlMTg3OTVhZjBhMmU3NDcwNGNiMGMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvaW9zL1dlYkNvbnRlbnRSZWFkZXJJT1MubW0KKysrIGIvU291cmNl L1dlYkNvcmUvZWRpdGluZy9pb3MvV2ViQ29udGVudFJlYWRlcklPUy5tbQpAQCAtMjgsMjQgKzI4 LDE0IEBACiAKICNpZiBQTEFURk9STShJT1MpCiAKLSNpbXBvcnQgIkFyY2hpdmVSZXNvdXJjZS5o IgogI2ltcG9ydCAiRG9jdW1lbnQuaCIKICNpbXBvcnQgIkRvY3VtZW50RnJhZ21lbnQuaCIKLSNp bXBvcnQgIkRvY3VtZW50TG9hZGVyLmgiCiAjaW1wb3J0ICJFZGl0b3IuaCIKICNpbXBvcnQgIkVk aXRvckNsaWVudC5oIgotI2ltcG9ydCAiRnJhZ21lbnRTY3JpcHRpbmdQZXJtaXNzaW9uLmgiCi0j aW1wb3J0ICJGcmFtZUxvYWRlci5oIgotI2ltcG9ydCAiRnJhbWVMb2FkZXJDbGllbnQuaCIKICNp bXBvcnQgIkhUTUxBbmNob3JFbGVtZW50LmgiCisjaW1wb3J0ICJIVE1MQlJFbGVtZW50LmgiCiAj aW1wb3J0ICJIVE1MTmFtZXMuaCIKLSNpbXBvcnQgIkxlZ2FjeVdlYkFyY2hpdmUuaCIKLSNpbXBv cnQgIk1JTUVUeXBlUmVnaXN0cnkuaCIKICNpbXBvcnQgIlRleHQuaCIKLSNpbXBvcnQgIlVUSVV0 aWxpdGllcy5oIgotI2ltcG9ydCAibWFya3VwLmgiCi0jaW1wb3J0IDxNb2JpbGVDb3JlU2Vydmlj ZXMvTW9iaWxlQ29yZVNlcnZpY2VzLmg+Ci0jaW1wb3J0IDx3dGYvdW5pY29kZS9DaGFyYWN0ZXJO YW1lcy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTYzLDE1ICs1MywxNiBAQCBib29s IFdlYkNvbnRlbnRSZWFkZXI6OnJlYWRVUkwoY29uc3QgVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYg dGl0bGUpCiAgICAgaWYgKFsoTlNVUkwgKil1cmwgaXNGaWxlVVJMXSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCi0gICAgYXV0byBhbmNob3IgPSBIVE1MQW5jaG9yRWxlbWVudDo6Y3JlYXRlKCpm cmFtZS5kb2N1bWVudCgpKTsKKyAgICBhdXRvIGRvY3VtZW50ID0gbWFrZVJlZigqZnJhbWUuZG9j dW1lbnQoKSk7CisgICAgYXV0byBhbmNob3IgPSBIVE1MQW5jaG9yRWxlbWVudDo6Y3JlYXRlKGRv Y3VtZW50LmdldCgpKTsKICAgICBhbmNob3ItPnNldEF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6 YXRpb24oSFRNTE5hbWVzOjpocmVmQXR0ciwgdXJsLnN0cmluZygpKTsKIAogICAgIFN0cmluZyBs aW5rVGV4dCA9IHRpdGxlLmxlbmd0aCgpID8gdGl0bGUgOiBTdHJpbmcoW1soTlNVUkwgKil1cmwg YWJzb2x1dGVTdHJpbmddIHByZWNvbXBvc2VkU3RyaW5nV2l0aENhbm9uaWNhbE1hcHBpbmddKTsK LSAgICBhbmNob3ItPmFwcGVuZENoaWxkKGZyYW1lLmRvY3VtZW50KCktPmNyZWF0ZVRleHROb2Rl KGxpbmtUZXh0KSk7CisgICAgYW5jaG9yLT5hcHBlbmRDaGlsZChkb2N1bWVudC0+Y3JlYXRlVGV4 dE5vZGUobGlua1RleHQpKTsKIAotICAgIGF1dG8gbmV3RnJhZ21lbnQgPSBmcmFtZS5kb2N1bWVu dCgpLT5jcmVhdGVEb2N1bWVudEZyYWdtZW50KCk7CisgICAgYXV0byBuZXdGcmFnbWVudCA9IGRv Y3VtZW50LT5jcmVhdGVEb2N1bWVudEZyYWdtZW50KCk7CiAgICAgaWYgKGZyYWdtZW50KQotICAg ICAgICBuZXdGcmFnbWVudC0+YXBwZW5kQ2hpbGQoVGV4dDo6Y3JlYXRlKCpmcmFtZS5kb2N1bWVu dCgpLCB7ICZzcGFjZSwgMSB9KSk7CisgICAgICAgIG5ld0ZyYWdtZW50LT5hcHBlbmRDaGlsZChI VE1MQlJFbGVtZW50OjpjcmVhdGUoZG9jdW1lbnQuZ2V0KCkpKTsKICAgICBuZXdGcmFnbWVudC0+ YXBwZW5kQ2hpbGQoYW5jaG9yKTsKICAgICBhZGRGcmFnbWVudChXVEZNb3ZlKG5ld0ZyYWdtZW50 KSk7CiAgICAgcmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29s cy9DaGFuZ2VMb2cKaW5kZXggNTVlMTI3YWYxYTZjZDU0YWJiZmQwN2IxNjcwNTExMjRjOTY5NTc2 ZC4uMmMxOGExZDQ1OWFmYTY5MjU3NmI5ODBjMTVlNGQ5ZTQ3NTZjZWViMyAxMDA2NDQKLS0tIGEv VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisy MDE4LTA1LTAzICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAg ICAgIFtpT1NdIE11bHRpcGxlIGxpbmtzIGluIE1haWwgYXJlIGRyb3BwZWQgaW4gYSBzaW5nbGUg bGluZSwgYW5kIGFyZSBkaWZmaWN1bHQgdG8gdGVsbCBhcGFydAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1Mjg5CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zNTc1NjkxMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBdWdtZW50IGFuZCByZWJhc2VsaW5lIHNvbWUgaU9TIGRyYWctYW5kLWRyb3AgQVBJ IHRlc3RzIHRoYXQgaGFuZGxlIGRyb3BwaW5nIFVSTHMgYXMgYSBwYXJ0IG9mIG11bHRpLWl0ZW0g ZHJvcAorICAgICAgICBzZXNzaW9ucy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMv aW9zL0RhdGFJbnRlcmFjdGlvblRlc3RzLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVT VCk6CisKIDIwMTgtMDUtMDEgIExlbyBCYWx0ZXIgIDxsZW9uYXJkby5iYWx0ZXJAZ21haWwuY29t PgogCiAgICAgICAgIEF1dG8gc2F2ZSB0aGUgcmVzdWx0cyBmb3IgVGVzdDI2MgpkaWZmIC0tZ2l0 IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvRGF0YUludGVyYWN0aW9uVGVzdHMubW0g Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9EYXRhSW50ZXJhY3Rpb25UZXN0cy5tbQpp bmRleCA0YTM0OGMyNTA0ZTc3NjI1YzNlZmYzNDRmNmJjZGQ5N2RlMWE1OTRmLi5iZjBkOTI5NWJm Y2U4ODJkY2NjMDViNWI0OWVjMjA4MTgzMWIxNTZhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL2lvcy9EYXRhSW50ZXJhY3Rpb25UZXN0cy5tbQorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL2lvcy9EYXRhSW50ZXJhY3Rpb25UZXN0cy5tbQpAQCAtODU2LDExICs4 NTYsMTcgQEAgVEVTVChEYXRhSW50ZXJhY3Rpb25UZXN0cywgRXh0ZXJuYWxTb3VyY2VNdWx0aXBs ZVVSTHNUb0NvbnRlbnRFZGl0YWJsZSkKICAgICBbZGF0YUludGVyYWN0aW9uU2ltdWxhdG9yIHNl dEV4dGVybmFsSXRlbVByb3ZpZGVyczpAWyBmaXJzdEl0ZW0uZ2V0KCksIHNlY29uZEl0ZW0uZ2V0 KCksIHRoaXJkSXRlbS5nZXQoKSBdXTsKICAgICBbZGF0YUludGVyYWN0aW9uU2ltdWxhdG9yIHJ1 bkZyb206Q0dQb2ludE1ha2UoMzAwLCA0MDApIHRvOkNHUG9pbnRNYWtlKDEwMCwgMzAwKV07CiAK LSAgICBOU0FycmF5ICpzZXBhcmF0ZWRMaW5rcyA9IFtbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRp bmdKYXZhU2NyaXB0OkAiZWRpdG9yLnRleHRDb250ZW50Il0gY29tcG9uZW50c1NlcGFyYXRlZEJ5 Q2hhcmFjdGVyc0luU2V0OltOU0NoYXJhY3RlclNldCB3aGl0ZXNwYWNlQW5kTmV3bGluZUNoYXJh Y3RlclNldF1dOwotICAgIEVYUEVDVF9FUSgzVUwsIHNlcGFyYXRlZExpbmtzLmNvdW50KTsKLSAg ICBFWFBFQ1RfV0tfU1RSRVEoImh0dHBzOi8vd3d3LmFwcGxlLmNvbS9pcGhvbmUvIiwgc2VwYXJh dGVkTGlua3NbMF0pOwotICAgIEVYUEVDVF9XS19TVFJFUSgiaHR0cHM6Ly93d3cuYXBwbGUuY29t L21hYy8iLCBzZXBhcmF0ZWRMaW5rc1sxXSk7Ci0gICAgRVhQRUNUX1dLX1NUUkVRKCJodHRwczov L3dlYmtpdC5vcmcvIiwgc2VwYXJhdGVkTGlua3NbMl0pOworICAgIE5TQXJyYXkgKmRyb3BwZWRV UkxzID0gW3dlYlZpZXcgb2JqZWN0QnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAIkFycmF5LmZyb20o ZWRpdG9yLnF1ZXJ5U2VsZWN0b3JBbGwoJ2EnKSkubWFwKGEgPT4gYS5ocmVmKSJdOworICAgIEVY UEVDVF9FUSgzVUwsIGRyb3BwZWRVUkxzLmNvdW50KTsKKyAgICBFWFBFQ1RfV0tfU1RSRVEoImh0 dHBzOi8vd3d3LmFwcGxlLmNvbS9pcGhvbmUvIiwgZHJvcHBlZFVSTHNbMF0pOworICAgIEVYUEVD VF9XS19TVFJFUSgiaHR0cHM6Ly93d3cuYXBwbGUuY29tL21hYy8iLCBkcm9wcGVkVVJMc1sxXSk7 CisgICAgRVhQRUNUX1dLX1NUUkVRKCJodHRwczovL3dlYmtpdC5vcmcvIiwgZHJvcHBlZFVSTHNb Ml0pOworCisgICAgTlNBcnJheSAqbGlua3NTZXBhcmF0ZWRCeUxpbmUgPSBbW3dlYlZpZXcgb2Jq ZWN0QnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImVkaXRvci5pbm5lclRleHQiXSBjb21wb25lbnRz U2VwYXJhdGVkQnlDaGFyYWN0ZXJzSW5TZXQ6W05TQ2hhcmFjdGVyU2V0IG5ld2xpbmVDaGFyYWN0 ZXJTZXRdXTsKKyAgICBFWFBFQ1RfRVEoM1VMLCBsaW5rc1NlcGFyYXRlZEJ5TGluZS5jb3VudCk7 CisgICAgRVhQRUNUX1dLX1NUUkVRKCJodHRwczovL3d3dy5hcHBsZS5jb20vaXBob25lLyIsIGxp bmtzU2VwYXJhdGVkQnlMaW5lWzBdKTsKKyAgICBFWFBFQ1RfV0tfU1RSRVEoImh0dHBzOi8vd3d3 LmFwcGxlLmNvbS9tYWMvIiwgbGlua3NTZXBhcmF0ZWRCeUxpbmVbMV0pOworICAgIEVYUEVDVF9X S19TVFJFUSgiaHR0cHM6Ly93ZWJraXQub3JnLyIsIGxpbmtzU2VwYXJhdGVkQnlMaW5lWzJdKTsK IH0KIAogVEVTVChEYXRhSW50ZXJhY3Rpb25UZXN0cywgUmVzcGVjdHNFeHRlcm5hbFNvdXJjZUZp ZGVsaXR5UmFua2luZ3MpCkBAIC0xNDY2LDcgKzE0NzIsNyBAQCBURVNUKERhdGFJbnRlcmFjdGlv blRlc3RzLCBBZGRpdGlvbmFsTGlua0FuZEltYWdlSW50b0NvbnRlbnRFZGl0YWJsZSkKICAgICAg ICAgQDAuMzM6IFtOU1ZhbHVlIHZhbHVlV2l0aENHUG9pbnQ6Q0dQb2ludE1ha2UoNTAsIDE1MCld LAogICAgICAgICBAMC42NjogW05TVmFsdWUgdmFsdWVXaXRoQ0dQb2ludDpDR1BvaW50TWFrZSg1 MCwgMjUwKV0KICAgICB9XTsKLSAgICBFWFBFQ1RfV0tfU1RSRVEoIkFCQ0QgQSBsaW5rIiwgW3dl YlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImVkaXRvci50ZXh0Q29udGVudCJd KTsKKyAgICBFWFBFQ1RfV0tfU1RSRVEoIkFCQ0RBIGxpbmsiLCBbd2ViVmlldyBzdHJpbmdCeUV2 YWx1YXRpbmdKYXZhU2NyaXB0OkAiZWRpdG9yLnRleHRDb250ZW50Il0pOwogICAgIEVYUEVDVF9U UlVFKFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCIhIWVkaXRvci5xdWVy eVNlbGVjdG9yKCdpbWcnKSJdKTsKICAgICBFWFBFQ1RfV0tfU1RSRVEoImh0dHBzOi8vd3d3LmFw cGxlLmNvbS8iLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZWRpdG9y LnF1ZXJ5U2VsZWN0b3IoJ2EnKS5ocmVmIl0pOwogfQo= 339626 2018-05-04 20:30:34 -0700 2018-05-04 21:39:58 -0700 Patch for landing bug-185289-20180504203033.patch text/plain 6860 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk5OTBjNzFjMmIyMjZk NzI2MGFmZjUwZDdjOTc0YTBkMjhkODcxNi4uY2IxYWQyMzVmYjU3YWE3ZjY2OGUxOTJhNDc1ZDc2 YTFkZDRlZmU5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTA1LTA0ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIE11bHRp cGxlIGxpbmtzIGluIE1haWwgYXJlIGRyb3BwZWQgaW4gYSBzaW5nbGUgbGluZSwgYW5kIGFyZSBk aWZmaWN1bHQgdG8gdGVsbCBhcGFydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg1Mjg5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTc1NjkxMj4K KworICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uIGFuZCBEYXJpbiBBZGxlci4KKworICAg ICAgICBXaGVuIGluc2VydGluZyBtdWx0aXBsZSBVUkxzIGFzIGluZGl2aWR1YWwgaXRlbXMgaW4g YSBzaW5nbGUgZHJvcCwgd2UgY3VycmVudGx5IHNlcGFyYXRlIGVhY2ggaXRlbSB3aXRoIGEgc3Bh Y2UKKyAgICAgICAgKHNlZSByMjE3Mjg0KS4gSG93ZXZlciwgaXQgc3RpbGwgc2VlbXMgZGlmZmlj dWx0IHRvIHRlbGwgZHJvcHBlZCBsaW5rcyBhcGFydC4gVGhpcyBwYXRjaCBtYWtlcyBzb21lIHNs aWdodAorICAgICAgICB0d2Vha3MgdG8gV2ViQ29udGVudFJlYWRlcjo6cmVhZFVSTCBzbyB0aGF0 IGl0IGluc2VydHMgbGluZSBicmVha3MgYmVmb3JlIGRyb3BwZWQgVVJMcywgaWYgdGhlIGRyb3Bw ZWQgVVJMIGlzbid0CisgICAgICAgIHRoZSBmaXJzdCBpdGVtIHRvIGJlIGluc2VydGVkIGluIHRo ZSByZXN1bHRpbmcgZG9jdW1lbnQgZnJhZ21lbnQuCisKKyAgICAgICAgQXVnbWVudHMgZXhpc3Rp bmcgQVBJIHRlc3RzIGluIERhdGFJbnRlcmFjdGlvblRlc3RzLgorCisgICAgICAgICogZWRpdGlu Zy9pb3MvV2ViQ29udGVudFJlYWRlcklPUy5tbToKKworICAgICAgICBBZGRpdGlvbmFsbHkgcmVt b3ZlIHNvbWUgZXh0cmFuZW91cyBoZWFkZXIgaW1wb3J0cyBmcm9tIHRoaXMgaW1wbGVtZW50YXRp b24gZmlsZS4KKworICAgICAgICAoV2ViQ29yZTo6V2ViQ29udGVudFJlYWRlcjo6cmVhZFVSTCk6 CisKIDIwMTgtMDUtMDQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBbU2ltcGxlIGxpbmUgbGF5b3V0XSBBZGQgc3VwcG9ydCBmb3IgbGluZSBsYXlvdXQgYm94IGdl bmVyYXRpb24gd2l0aCBtdWx0aXBsZSB0ZXh0IHJlbmRlcmVycy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvaW9zL1dlYkNvbnRlbnRSZWFkZXJJT1MubW0gYi9Tb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL2lvcy9XZWJDb250ZW50UmVhZGVySU9TLm1tCmluZGV4IDliMzEwZDU2YzY4 ZGQ5M2NlMTdlOTNlNzg2MjhkZDRlYzMyYjM4MDguLjhkZTVjMTUwMDZjYjlhOWQ4MzNlMTg3OTVh ZjBhMmU3NDcwNGNiMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvaW9zL1dl YkNvbnRlbnRSZWFkZXJJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9pb3MvV2Vi Q29udGVudFJlYWRlcklPUy5tbQpAQCAtMjgsMjQgKzI4LDE0IEBACiAKICNpZiBQTEFURk9STShJ T1MpCiAKLSNpbXBvcnQgIkFyY2hpdmVSZXNvdXJjZS5oIgogI2ltcG9ydCAiRG9jdW1lbnQuaCIK ICNpbXBvcnQgIkRvY3VtZW50RnJhZ21lbnQuaCIKLSNpbXBvcnQgIkRvY3VtZW50TG9hZGVyLmgi CiAjaW1wb3J0ICJFZGl0b3IuaCIKICNpbXBvcnQgIkVkaXRvckNsaWVudC5oIgotI2ltcG9ydCAi RnJhZ21lbnRTY3JpcHRpbmdQZXJtaXNzaW9uLmgiCi0jaW1wb3J0ICJGcmFtZUxvYWRlci5oIgot I2ltcG9ydCAiRnJhbWVMb2FkZXJDbGllbnQuaCIKICNpbXBvcnQgIkhUTUxBbmNob3JFbGVtZW50 LmgiCisjaW1wb3J0ICJIVE1MQlJFbGVtZW50LmgiCiAjaW1wb3J0ICJIVE1MTmFtZXMuaCIKLSNp bXBvcnQgIkxlZ2FjeVdlYkFyY2hpdmUuaCIKLSNpbXBvcnQgIk1JTUVUeXBlUmVnaXN0cnkuaCIK ICNpbXBvcnQgIlRleHQuaCIKLSNpbXBvcnQgIlVUSVV0aWxpdGllcy5oIgotI2ltcG9ydCAibWFy a3VwLmgiCi0jaW1wb3J0IDxNb2JpbGVDb3JlU2VydmljZXMvTW9iaWxlQ29yZVNlcnZpY2VzLmg+ Ci0jaW1wb3J0IDx3dGYvdW5pY29kZS9DaGFyYWN0ZXJOYW1lcy5oPgogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKQEAgLTYzLDE1ICs1MywxNiBAQCBib29sIFdlYkNvbnRlbnRSZWFkZXI6OnJlYWRV UkwoY29uc3QgVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgdGl0bGUpCiAgICAgaWYgKFsoTlNVUkwg Kil1cmwgaXNGaWxlVVJMXSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgYXV0byBhbmNo b3IgPSBIVE1MQW5jaG9yRWxlbWVudDo6Y3JlYXRlKCpmcmFtZS5kb2N1bWVudCgpKTsKKyAgICBh dXRvIGRvY3VtZW50ID0gbWFrZVJlZigqZnJhbWUuZG9jdW1lbnQoKSk7CisgICAgYXV0byBhbmNo b3IgPSBIVE1MQW5jaG9yRWxlbWVudDo6Y3JlYXRlKGRvY3VtZW50LmdldCgpKTsKICAgICBhbmNo b3ItPnNldEF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oSFRNTE5hbWVzOjpocmVmQXR0 ciwgdXJsLnN0cmluZygpKTsKIAogICAgIFN0cmluZyBsaW5rVGV4dCA9IHRpdGxlLmxlbmd0aCgp ID8gdGl0bGUgOiBTdHJpbmcoW1soTlNVUkwgKil1cmwgYWJzb2x1dGVTdHJpbmddIHByZWNvbXBv c2VkU3RyaW5nV2l0aENhbm9uaWNhbE1hcHBpbmddKTsKLSAgICBhbmNob3ItPmFwcGVuZENoaWxk KGZyYW1lLmRvY3VtZW50KCktPmNyZWF0ZVRleHROb2RlKGxpbmtUZXh0KSk7CisgICAgYW5jaG9y LT5hcHBlbmRDaGlsZChkb2N1bWVudC0+Y3JlYXRlVGV4dE5vZGUobGlua1RleHQpKTsKIAotICAg IGF1dG8gbmV3RnJhZ21lbnQgPSBmcmFtZS5kb2N1bWVudCgpLT5jcmVhdGVEb2N1bWVudEZyYWdt ZW50KCk7CisgICAgYXV0byBuZXdGcmFnbWVudCA9IGRvY3VtZW50LT5jcmVhdGVEb2N1bWVudEZy YWdtZW50KCk7CiAgICAgaWYgKGZyYWdtZW50KQotICAgICAgICBuZXdGcmFnbWVudC0+YXBwZW5k Q2hpbGQoVGV4dDo6Y3JlYXRlKCpmcmFtZS5kb2N1bWVudCgpLCB7ICZzcGFjZSwgMSB9KSk7Cisg ICAgICAgIG5ld0ZyYWdtZW50LT5hcHBlbmRDaGlsZChIVE1MQlJFbGVtZW50OjpjcmVhdGUoZG9j dW1lbnQuZ2V0KCkpKTsKICAgICBuZXdGcmFnbWVudC0+YXBwZW5kQ2hpbGQoYW5jaG9yKTsKICAg ICBhZGRGcmFnbWVudChXVEZNb3ZlKG5ld0ZyYWdtZW50KSk7CiAgICAgcmV0dXJuIHRydWU7CmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTMxNmY2 NDY1YzZhOWQyMjZhNDhhMWI0ZmI1M2ExZGU3MjUzMTAwYy4uNWEyZTI3NjY4Y2I1MWYxZDUwZjk4 ODkyYWVlNDhmYzljODYyYzU2ZiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA1LTA0ICBXZW5zb24gSHNpZWgg IDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIE11bHRpcGxlIGxpbmtz IGluIE1haWwgYXJlIGRyb3BwZWQgaW4gYSBzaW5nbGUgbGluZSwgYW5kIGFyZSBkaWZmaWN1bHQg dG8gdGVsbCBhcGFydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg1Mjg5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTc1NjkxMj4KKworICAgICAg ICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uIGFuZCBEYXJpbiBBZGxlci4KKworICAgICAgICBBdWdt ZW50IGFuZCByZWJhc2VsaW5lIHNvbWUgaU9TIGRyYWctYW5kLWRyb3AgQVBJIHRlc3RzIHRoYXQg aGFuZGxlIGRyb3BwaW5nIFVSTHMgYXMgYSBwYXJ0IG9mIG11bHRpLWl0ZW0gZHJvcAorICAgICAg ICBzZXNzaW9ucy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0RhdGFJbnRl cmFjdGlvblRlc3RzLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMTgt MDUtMDQgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIERl cHJlY2F0ZSBsZWdhY3kgV2ViVmlldyBhbmQgZnJpZW5kcwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9pb3MvRGF0YUludGVyYWN0aW9uVGVzdHMubW0gYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL2lvcy9EYXRhSW50ZXJhY3Rpb25UZXN0cy5tbQppbmRleCA0YTM0OGMy NTA0ZTc3NjI1YzNlZmYzNDRmNmJjZGQ5N2RlMWE1OTRmLi5iZjBkOTI5NWJmY2U4ODJkY2NjMDVi NWI0OWVjMjA4MTgzMWIxNTZhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L2lvcy9EYXRhSW50ZXJhY3Rpb25UZXN0cy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL2lvcy9EYXRhSW50ZXJhY3Rpb25UZXN0cy5tbQpAQCAtODU2LDExICs4NTYsMTcgQEAgVEVT VChEYXRhSW50ZXJhY3Rpb25UZXN0cywgRXh0ZXJuYWxTb3VyY2VNdWx0aXBsZVVSTHNUb0NvbnRl bnRFZGl0YWJsZSkKICAgICBbZGF0YUludGVyYWN0aW9uU2ltdWxhdG9yIHNldEV4dGVybmFsSXRl bVByb3ZpZGVyczpAWyBmaXJzdEl0ZW0uZ2V0KCksIHNlY29uZEl0ZW0uZ2V0KCksIHRoaXJkSXRl bS5nZXQoKSBdXTsKICAgICBbZGF0YUludGVyYWN0aW9uU2ltdWxhdG9yIHJ1bkZyb206Q0dQb2lu dE1ha2UoMzAwLCA0MDApIHRvOkNHUG9pbnRNYWtlKDEwMCwgMzAwKV07CiAKLSAgICBOU0FycmF5 ICpzZXBhcmF0ZWRMaW5rcyA9IFtbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0 OkAiZWRpdG9yLnRleHRDb250ZW50Il0gY29tcG9uZW50c1NlcGFyYXRlZEJ5Q2hhcmFjdGVyc0lu U2V0OltOU0NoYXJhY3RlclNldCB3aGl0ZXNwYWNlQW5kTmV3bGluZUNoYXJhY3RlclNldF1dOwot ICAgIEVYUEVDVF9FUSgzVUwsIHNlcGFyYXRlZExpbmtzLmNvdW50KTsKLSAgICBFWFBFQ1RfV0tf U1RSRVEoImh0dHBzOi8vd3d3LmFwcGxlLmNvbS9pcGhvbmUvIiwgc2VwYXJhdGVkTGlua3NbMF0p OwotICAgIEVYUEVDVF9XS19TVFJFUSgiaHR0cHM6Ly93d3cuYXBwbGUuY29tL21hYy8iLCBzZXBh cmF0ZWRMaW5rc1sxXSk7Ci0gICAgRVhQRUNUX1dLX1NUUkVRKCJodHRwczovL3dlYmtpdC5vcmcv Iiwgc2VwYXJhdGVkTGlua3NbMl0pOworICAgIE5TQXJyYXkgKmRyb3BwZWRVUkxzID0gW3dlYlZp ZXcgb2JqZWN0QnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAIkFycmF5LmZyb20oZWRpdG9yLnF1ZXJ5 U2VsZWN0b3JBbGwoJ2EnKSkubWFwKGEgPT4gYS5ocmVmKSJdOworICAgIEVYUEVDVF9FUSgzVUws IGRyb3BwZWRVUkxzLmNvdW50KTsKKyAgICBFWFBFQ1RfV0tfU1RSRVEoImh0dHBzOi8vd3d3LmFw cGxlLmNvbS9pcGhvbmUvIiwgZHJvcHBlZFVSTHNbMF0pOworICAgIEVYUEVDVF9XS19TVFJFUSgi aHR0cHM6Ly93d3cuYXBwbGUuY29tL21hYy8iLCBkcm9wcGVkVVJMc1sxXSk7CisgICAgRVhQRUNU X1dLX1NUUkVRKCJodHRwczovL3dlYmtpdC5vcmcvIiwgZHJvcHBlZFVSTHNbMl0pOworCisgICAg TlNBcnJheSAqbGlua3NTZXBhcmF0ZWRCeUxpbmUgPSBbW3dlYlZpZXcgb2JqZWN0QnlFdmFsdWF0 aW5nSmF2YVNjcmlwdDpAImVkaXRvci5pbm5lclRleHQiXSBjb21wb25lbnRzU2VwYXJhdGVkQnlD aGFyYWN0ZXJzSW5TZXQ6W05TQ2hhcmFjdGVyU2V0IG5ld2xpbmVDaGFyYWN0ZXJTZXRdXTsKKyAg ICBFWFBFQ1RfRVEoM1VMLCBsaW5rc1NlcGFyYXRlZEJ5TGluZS5jb3VudCk7CisgICAgRVhQRUNU X1dLX1NUUkVRKCJodHRwczovL3d3dy5hcHBsZS5jb20vaXBob25lLyIsIGxpbmtzU2VwYXJhdGVk QnlMaW5lWzBdKTsKKyAgICBFWFBFQ1RfV0tfU1RSRVEoImh0dHBzOi8vd3d3LmFwcGxlLmNvbS9t YWMvIiwgbGlua3NTZXBhcmF0ZWRCeUxpbmVbMV0pOworICAgIEVYUEVDVF9XS19TVFJFUSgiaHR0 cHM6Ly93ZWJraXQub3JnLyIsIGxpbmtzU2VwYXJhdGVkQnlMaW5lWzJdKTsKIH0KIAogVEVTVChE YXRhSW50ZXJhY3Rpb25UZXN0cywgUmVzcGVjdHNFeHRlcm5hbFNvdXJjZUZpZGVsaXR5UmFua2lu Z3MpCkBAIC0xNDY2LDcgKzE0NzIsNyBAQCBURVNUKERhdGFJbnRlcmFjdGlvblRlc3RzLCBBZGRp dGlvbmFsTGlua0FuZEltYWdlSW50b0NvbnRlbnRFZGl0YWJsZSkKICAgICAgICAgQDAuMzM6IFtO U1ZhbHVlIHZhbHVlV2l0aENHUG9pbnQ6Q0dQb2ludE1ha2UoNTAsIDE1MCldLAogICAgICAgICBA MC42NjogW05TVmFsdWUgdmFsdWVXaXRoQ0dQb2ludDpDR1BvaW50TWFrZSg1MCwgMjUwKV0KICAg ICB9XTsKLSAgICBFWFBFQ1RfV0tfU1RSRVEoIkFCQ0QgQSBsaW5rIiwgW3dlYlZpZXcgc3RyaW5n QnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImVkaXRvci50ZXh0Q29udGVudCJdKTsKKyAgICBFWFBF Q1RfV0tfU1RSRVEoIkFCQ0RBIGxpbmsiLCBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZh U2NyaXB0OkAiZWRpdG9yLnRleHRDb250ZW50Il0pOwogICAgIEVYUEVDVF9UUlVFKFt3ZWJWaWV3 IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCIhIWVkaXRvci5xdWVyeVNlbGVjdG9yKCdp bWcnKSJdKTsKICAgICBFWFBFQ1RfV0tfU1RSRVEoImh0dHBzOi8vd3d3LmFwcGxlLmNvbS8iLCBb d2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZWRpdG9yLnF1ZXJ5U2VsZWN0 b3IoJ2EnKS5ocmVmIl0pOwogfQo=