185282 2018-05-03 17:32:06 -0700 Allow Web Touch events to timeout 2024-09-10 10:57:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner bdakin commit-queue dino owengm3001 simon.fraser thorton wenson_hsieh oldest_to_newest 1420472 0 megan_gardner 2018-05-03 17:32:06 -0700 Allow Web Touch events to timeout 1420475 1 339495 megan_gardner 2018-05-03 17:35:21 -0700 Created attachment 339495 Patch 1420477 2 megan_gardner 2018-05-03 17:36:23 -0700 <rdar://problem/38728319> 1420788 4 thorton 2018-05-04 11:41:27 -0700 I think you should consider writing a test for this. Might need to add a mechanism to speed up timeouts (like the one we have to make them go to ∞). 1420789 5 thorton 2018-05-04 11:42:57 -0700 ignoreSynchronousMessagingTimeoutsForTesting 1420811 6 339495 commit-queue 2018-05-04 12:16:46 -0700 Comment on attachment 339495 Patch Clearing flags on attachment: 339495 Committed r231370: <https://trac.webkit.org/changeset/231370> 1420812 7 commit-queue 2018-05-04 12:16:47 -0700 All reviewed patches have been landed. Closing bug. 1421174 8 339495 wenson_hsieh 2018-05-06 16:51:32 -0700 Comment on attachment 339495 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339495&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:2303 > + handled = true; I don't think this is quite right, since it would mean any touchstart that is dispatched to the page would behave as though the page called preventDefault(). This would prevent clicks when tapping on elements that have touch event handlers, but do not preventDefault() (e.g. links on Google search result pages). 1421184 9 339495 thorton 2018-05-06 18:48:17 -0700 Comment on attachment 339495 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339495&action=review >> Source/WebKit/UIProcess/WebPageProxy.cpp:2303 >> + handled = true; > > I don't think this is quite right, since it would mean any touchstart that is dispatched to the page would behave as though the page called preventDefault(). This would prevent clicks when tapping on elements that have touch event handlers, but do not preventDefault() (e.g. links on Google search result pages). Only if it times out, though? We thought that mostly made sense. I’ll add you to a thread about it. 1421203 10 339495 wenson_hsieh 2018-05-06 20:27:04 -0700 Comment on attachment 339495 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339495&action=review >>> Source/WebKit/UIProcess/WebPageProxy.cpp:2303 >>> + handled = true; >> >> I don't think this is quite right, since it would mean any touchstart that is dispatched to the page would behave as though the page called preventDefault(). This would prevent clicks when tapping on elements that have touch event handlers, but do not preventDefault() (e.g. links on Google search result pages). > > Only if it times out, though? We thought that mostly made sense. I’ll add you to a thread about it. Yeah, I think the plan makes sense (treat IPC time out as if default was prevented). Perhaps I'm missing something, but this change seems to make it so that as long as `replyReceived` is true (e.g. the IPC message didn't time out), then we set handled to true (i.e. treat it as if the page called preventDefault()). 1421205 11 thorton 2018-05-06 20:37:04 -0700 Haha, I see, yes, it’s backwards :/ 1421206 12 thorton 2018-05-06 20:37:26 -0700 How in the world did that not cause a single test failure?!? 1421207 13 wenson_hsieh 2018-05-06 20:39:55 -0700 (In reply to Tim Horton from comment #12) > How in the world did that not cause a single test failure?!? Touch-event-related tests cannot run on the open source bots :/ That said, our internal test runners are looking quite red... 1421348 14 megan_gardner 2018-05-07 11:16:53 -0700 https://trac.webkit.org/changeset/231447/webkit 339495 2018-05-03 17:35:21 -0700 2018-05-04 12:16:46 -0700 Patch bug-185282-20180503173520.patch text/plain 1938 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzEzMzYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA1LTAzICBNZWdhbiBHYXJk bmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQWxsb3cgV2ViIFRvdWNo IGV2ZW50cyB0byB0aW1lb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODUyODIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4NzI4MzE5PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgV2Vi IFRvdWNoIGV2ZW50cyBjdXJyZW50bHkgbmV2ZXIgdGltZSBvdXQsIHdoaWNoIGJsb2NrcyB0aGUg dXNlciBmcm9tIGludGVyYWN0aW5nIHdpdGggdGhlIFVJIFByb2Nlc3MgYXQgYWxsLgorICAgICAg ICBXZSBzaG91bGQgYWxsb3cgdGhlc2UgZXZlbnRzIHRvIHRpbWUgb3V0IHNvIHRoYXQgdGhlIHVz ZXIgY2FuIGludGVyYWN0IHdpdGggdGhlIHJlc3Qgb2YgdGhlIFVJLgorCisgICAgICAgICogVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6 aGFuZGxlVG91Y2hFdmVudFN5bmNocm9ub3VzbHkpOgorCiAyMDE4LTA1LTAzICBKdXN0aW4gRmFu ICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkdMXSBBZGQgcnVudGltZSBm bGFnIGZvciBlbmFibGluZyBBU1RDIHN1cHBvcnQgaW4gV2ViR0wKSW5kZXg6IFNvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gMjMxMjUxKQorKysgU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI5 Nyw3ICsyMjk3LDEwIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpoYW5kbGVUb3VjaEV2ZW50U3luY2gK IAogICAgIG1fcHJvY2Vzcy0+cmVzcG9uc2l2ZW5lc3NUaW1lcigpLnN0YXJ0KCk7CiAgICAgYm9v bCBoYW5kbGVkID0gZmFsc2U7Ci0gICAgbV9wcm9jZXNzLT5zZW5kU3luYyhNZXNzYWdlczo6V2Vi UGFnZTo6VG91Y2hFdmVudFN5bmMoZXZlbnQpLCBNZXNzYWdlczo6V2ViUGFnZTo6VG91Y2hFdmVu dFN5bmM6OlJlcGx5KGhhbmRsZWQpLCBtX3BhZ2VJRCk7CisgICAgYm9vbCByZXBseVJlY2VpdmVk ID0gbV9wcm9jZXNzLT5zZW5kU3luYyhNZXNzYWdlczo6V2ViUGFnZTo6VG91Y2hFdmVudFN5bmMo ZXZlbnQpLCBNZXNzYWdlczo6V2ViUGFnZTo6VG91Y2hFdmVudFN5bmM6OlJlcGx5KGhhbmRsZWQp LCBtX3BhZ2VJRCwgMV9zKTsKKyAgICAvLyBJZiB0aGUgc3luYyByZXF1ZXN0IGhhcyB0aW1lZCBv dXQsIHdlIHNob3VsZCBjb25zaWRlciB0aGUgZXZlbnQgaGFuZGxlZC4gVGhlIFdlYiBQcm9jZXNz IGlzIHRvbyBidXN5IHRvIGFuc3dlciBhbnkgcXVlc3Rpb25zLCBzbyB0aGUgZGVmYXVsdCBhY3Rp b24gaXMgYWxzbyBsaWtlbHkgdG8gaGF2ZSBpc3N1ZXMuCisgICAgaWYgKHJlcGx5UmVjZWl2ZWQp CisgICAgICAgIGhhbmRsZWQgPSB0cnVlOwogICAgIGRpZFJlY2VpdmVFdmVudChldmVudC50eXBl KCksIGhhbmRsZWQpOwogICAgIG1fcGFnZUNsaWVudC5kb25lV2l0aFRvdWNoRXZlbnQoZXZlbnQs IGhhbmRsZWQpOwogICAgIG1fcHJvY2Vzcy0+cmVzcG9uc2l2ZW5lc3NUaW1lcigpLnN0b3AoKTsK