185268 2018-05-03 14:35:24 -0700 [iOS] Internal text and audio tracks not in fullscreen menu 2018-05-03 15:11:03 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue jer.noble webkit-bug-importer oldest_to_newest 1420345 0 eric.carlson 2018-05-03 14:35:24 -0700 Internal text and audio tracks not in fullscreen menu 1420347 1 eric.carlson 2018-05-03 14:35:46 -0700 <rdar://problem/38673440> 1420350 2 339468 eric.carlson 2018-05-03 14:40:44 -0700 Created attachment 339468 Patch 1420368 3 339468 commit-queue 2018-05-03 15:11:01 -0700 Comment on attachment 339468 Patch Clearing flags on attachment: 339468 Committed r231330: <https://trac.webkit.org/changeset/231330> 1420369 4 commit-queue 2018-05-03 15:11:03 -0700 All reviewed patches have been landed. Closing bug. 339468 2018-05-03 14:40:44 -0700 2018-05-03 15:11:01 -0700 Patch bug-185268-20180503144043.patch text/plain 3977 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEzYjE4NWVjZmRkNjk4 N2RkN2JmZDNiZDQzZDExMGQwZmQ2YWM3Yy4uZDM3M2Q3YjQyMjAxZDFjMjFmZGNkMjNhNGNhYWIy MDBkZDFiNjg2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA1LTAzICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEludGVy bmFsIHRleHQgYW5kIGF1ZGlvIHRyYWNrcyBub3QgaW4gZnVsbHNjcmVlbiBtZW51CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODUyNjgKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzM4NjczNDQwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9uTW9kZWxN ZWRpYUVsZW1lbnQubW06CisgICAgICAgIChXZWJDb3JlOjpQbGF5YmFja1Nlc3Npb25Nb2RlbE1l ZGlhRWxlbWVudDo6c2V0TWVkaWFFbGVtZW50KTogJ2FkZHRyYWNrJyBhbmQgJ3JlbW92ZXRyYWNr JworICAgICAgICBldmVudHMgYXJlIGZpcmVkIGF0IHRoZSB0cmFjayBsaXN0cywgbm90IHRoZSBt ZWRpYSBlbGVtZW50LgorCiAyMDE4LTA1LTAyICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVs ZEBhcHBsZS5jb20+CiAKICAgICAgICAgQ29sbGVjdGlvbiBmcmFnbWVudCBpZGVudGlmaWVycyBk b24ndCB1c2UgUG9zdFNjcmlwdCBuYW1lcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQubW0gYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9QbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudC5t bQppbmRleCA3OWEwMzBjYWJjYzM3NjA1MDdkZjZlNDJjOGU0Mzg2ZTM4NDI4NTA3Li44N2I1MTA5 YTUwM2ViNDVhNWYzY2VhNmU4YmQ3OTUwNzE2ODRmYzU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jb2NvYS9QbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudC5tbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9QbGF5YmFja1Nlc3Npb25Nb2RlbE1l ZGlhRWxlbWVudC5tbQpAQCAtNjEsMTEgKzYxLDIwIEBAIHZvaWQgUGxheWJhY2tTZXNzaW9uTW9k ZWxNZWRpYUVsZW1lbnQ6OnNldE1lZGlhRWxlbWVudChIVE1MTWVkaWFFbGVtZW50KiBtZWRpYUVs CiAgICAgaWYgKG1fbWVkaWFFbGVtZW50ID09IG1lZGlhRWxlbWVudCkKICAgICAgICAgcmV0dXJu OwogCisgICAgYXV0byYgZXZlbnRzID0gZXZlbnROYW1lcygpOworCiAgICAgaWYgKG1fbWVkaWFF bGVtZW50ICYmIG1faXNMaXN0ZW5pbmcpIHsKICAgICAgICAgZm9yIChhdXRvJiBldmVudE5hbWUg OiBvYnNlcnZlZEV2ZW50TmFtZXMoKSkKICAgICAgICAgICAgIG1fbWVkaWFFbGVtZW50LT5yZW1v dmVFdmVudExpc3RlbmVyKGV2ZW50TmFtZSwgKnRoaXMsIGZhbHNlKTsKLSAgICAgICAgbV9tZWRp YUVsZW1lbnQtPmF1ZGlvVHJhY2tzKCkucmVtb3ZlRXZlbnRMaXN0ZW5lcihldmVudE5hbWVzKCku Y2hhbmdlRXZlbnQsICp0aGlzLCBmYWxzZSk7Ci0gICAgICAgIG1fbWVkaWFFbGVtZW50LT50ZXh0 VHJhY2tzKCkucmVtb3ZlRXZlbnRMaXN0ZW5lcihldmVudE5hbWVzKCkuY2hhbmdlRXZlbnQsICp0 aGlzLCBmYWxzZSk7CisgICAgICAgIGF1dG8mIGF1ZGlvVHJhY2tzID0gbV9tZWRpYUVsZW1lbnQt PmF1ZGlvVHJhY2tzKCk7CisgICAgICAgIGF1ZGlvVHJhY2tzLnJlbW92ZUV2ZW50TGlzdGVuZXIo ZXZlbnRzLmFkZHRyYWNrRXZlbnQsICp0aGlzLCBmYWxzZSk7CisgICAgICAgIGF1ZGlvVHJhY2tz LnJlbW92ZUV2ZW50TGlzdGVuZXIoZXZlbnRzLmNoYW5nZUV2ZW50LCAqdGhpcywgZmFsc2UpOwor ICAgICAgICBhdWRpb1RyYWNrcy5yZW1vdmVFdmVudExpc3RlbmVyKGV2ZW50cy5yZW1vdmV0cmFj a0V2ZW50LCAqdGhpcywgZmFsc2UpOworCisgICAgICAgIGF1dG8mIHRleHRUcmFja3MgPSBtX21l ZGlhRWxlbWVudC0+YXVkaW9UcmFja3MoKTsKKyAgICAgICAgdGV4dFRyYWNrcy5yZW1vdmVFdmVu dExpc3RlbmVyKGV2ZW50cy5hZGR0cmFja0V2ZW50LCAqdGhpcywgZmFsc2UpOworICAgICAgICB0 ZXh0VHJhY2tzLnJlbW92ZUV2ZW50TGlzdGVuZXIoZXZlbnRzLmNoYW5nZUV2ZW50LCAqdGhpcywg ZmFsc2UpOworICAgICAgICB0ZXh0VHJhY2tzLnJlbW92ZUV2ZW50TGlzdGVuZXIoZXZlbnRzLnJl bW92ZXRyYWNrRXZlbnQsICp0aGlzLCBmYWxzZSk7CiAgICAgfQogICAgIG1faXNMaXN0ZW5pbmcg PSBmYWxzZTsKIApAQCAtNzcsOSArODYsMTYgQEAgdm9pZCBQbGF5YmFja1Nlc3Npb25Nb2RlbE1l ZGlhRWxlbWVudDo6c2V0TWVkaWFFbGVtZW50KEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWwKICAg ICBpZiAobV9tZWRpYUVsZW1lbnQpIHsKICAgICAgICAgZm9yIChhdXRvJiBldmVudE5hbWUgOiBv YnNlcnZlZEV2ZW50TmFtZXMoKSkKICAgICAgICAgICAgIG1fbWVkaWFFbGVtZW50LT5hZGRFdmVu dExpc3RlbmVyKGV2ZW50TmFtZSwgKnRoaXMsIGZhbHNlKTsKLSAgICAgICAgbV9tZWRpYUVsZW1l bnQtPmF1ZGlvVHJhY2tzKCkuYWRkRXZlbnRMaXN0ZW5lcihldmVudE5hbWVzKCkuY2hhbmdlRXZl bnQsICp0aGlzLCBmYWxzZSk7Ci0gICAgICAgIG1fbWVkaWFFbGVtZW50LT50ZXh0VHJhY2tzKCku YWRkRXZlbnRMaXN0ZW5lcihldmVudE5hbWVzKCkuY2hhbmdlRXZlbnQsICp0aGlzLCBmYWxzZSk7 Ci0gICAgICAgIG1faXNMaXN0ZW5pbmcgPSB0cnVlOworCisgICAgICAgIGF1dG8mIGF1ZGlvVHJh Y2tzID0gbV9tZWRpYUVsZW1lbnQtPmF1ZGlvVHJhY2tzKCk7CisgICAgICAgIGF1ZGlvVHJhY2tz LmFkZEV2ZW50TGlzdGVuZXIoZXZlbnRzLmFkZHRyYWNrRXZlbnQsICp0aGlzLCBmYWxzZSk7Cisg ICAgICAgIGF1ZGlvVHJhY2tzLmFkZEV2ZW50TGlzdGVuZXIoZXZlbnRzLmNoYW5nZUV2ZW50LCAq dGhpcywgZmFsc2UpOworICAgICAgICBhdWRpb1RyYWNrcy5hZGRFdmVudExpc3RlbmVyKGV2ZW50 cy5yZW1vdmV0cmFja0V2ZW50LCAqdGhpcywgZmFsc2UpOworCisgICAgICAgIGF1dG8mIHRleHRU cmFja3MgPSBtX21lZGlhRWxlbWVudC0+YXVkaW9UcmFja3MoKTsKKyAgICAgICAgdGV4dFRyYWNr cy5hZGRFdmVudExpc3RlbmVyKGV2ZW50cy5hZGR0cmFja0V2ZW50LCAqdGhpcywgZmFsc2UpOwor ICAgICAgICB0ZXh0VHJhY2tzLmFkZEV2ZW50TGlzdGVuZXIoZXZlbnRzLmNoYW5nZUV2ZW50LCAq dGhpcywgZmFsc2UpOworICAgICAgICB0ZXh0VHJhY2tzLmFkZEV2ZW50TGlzdGVuZXIoZXZlbnRz LnJlbW92ZXRyYWNrRXZlbnQsICp0aGlzLCBmYWxzZSk7CiAgICAgfQogCiAgICAgdXBkYXRlRm9y RXZlbnROYW1lKGV2ZW50TmFtZUFsbCgpKTsKQEAgLTM2OCw4ICszODQsNiBAQCBjb25zdCBWZWN0 b3I8QXRvbWljU3RyaW5nPiYgUGxheWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQ6Om9ic2Vy dmVkRXZlbnROYW1lcwogICAgICAgICBldmVudE5hbWVzKCkucmF0ZWNoYW5nZUV2ZW50LAogICAg ICAgICBldmVudE5hbWVzKCkudGltZXVwZGF0ZUV2ZW50LAogICAgICAgICBldmVudE5hbWVzKCku cHJvZ3Jlc3NFdmVudCwKLSAgICAgICAgZXZlbnROYW1lcygpLmFkZHRyYWNrRXZlbnQsCi0gICAg ICAgIGV2ZW50TmFtZXMoKS5yZW1vdmV0cmFja0V2ZW50LAogICAgICAgICBldmVudE5hbWVzKCku dm9sdW1lY2hhbmdlRXZlbnQsCiAgICAgICAgIGV2ZW50TmFtZXMoKS53ZWJraXRjdXJyZW50cGxh eWJhY2t0YXJnZXRpc3dpcmVsZXNzY2hhbmdlZEV2ZW50LAogICAgIH0pOwo=