185262 2018-05-03 12:08:09 -0700 Assertion failure in NetworkStorageSession::setCookie: privilege of UI process is not set 2018-05-07 17:34:34 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu cdumez commit-queue ggaren sihui_liu webkit-bug-importer oldest_to_newest 1420250 0 sihui_liu 2018-05-03 12:08:09 -0700 If setting cookie using defaultDataStore before creating a WebView, the app would run into this assertion failure, because the privilege of UI process to access cookie API is not granted yet. 1420323 1 339463 sihui_liu 2018-05-03 14:05:04 -0700 Created attachment 339463 Patch 1420330 2 339463 cdumez 2018-05-03 14:12:01 -0700 Comment on attachment 339463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339463&action=review > Source/WebKit/ChangeLog:3 > + Assertion failure in NetworkStorageSession::setCookie: privilege of UI process is not set What assertion? Could you please provide the crash trace on the bug? > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:50 > + WTF::setProcessPrivileges(allPrivileges()); This should probably inside WebKit::WebSiteDataStore constructor so it works for C API clients as well, and other APIs that defaultDataStore. 1420427 3 sihui_liu 2018-05-03 16:44:51 -0700 (In reply to Chris Dumez from comment #2) > Comment on attachment 339463 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339463&action=review > > > Source/WebKit/ChangeLog:3 > > + Assertion failure in NetworkStorageSession::setCookie: privilege of UI process is not set > > What assertion? Could you please provide the crash trace on the bug? > Crash trace: default 16:36:00.400052 -0700 WKCookieMonster ASSERTION FAILED: hasProcessPrivilege(ProcessPrivilege::CanAccessRawCookies) default 16:36:00.400101 -0700 WKCookieMonster platform/network/cocoa/NetworkStorageSessionCocoa.mm(40) : void WebCore::NetworkStorageSession::setCookie(const WebCore::Cookie &) default 16:36:00.406075 -0700 WKCookieMonster 1 0x115ffc259 WTFCrash default 16:36:00.423040 -0700 WKCookieMonster 2 0x106fcaa9e WebCore::NetworkStorageSession::setCookie(WebCore::Cookie const&) default 16:36:00.428838 -0700 WKCookieMonster 3 0x100399f55 API::HTTPCookieStore::setCookie(WebCore::Cookie const&, WTF::Function<void ()>&&) default 16:36:00.430665 -0700 WKCookieMonster 4 0x10135ea23 -[WKHTTPCookieStore setCookie:completionHandler:] default 16:36:00.430741 -0700 WKCookieMonster 5 0x100008260 _T015WKCookieMonster14ViewControllerC04loadC0yyF default 16:36:00.430766 -0700 WKCookieMonster 6 0x100009144 _T015WKCookieMonster14ViewControllerC04loadC0yyFTo default 16:36:00.430979 -0700 WKCookieMonster 7 0x7fff514ecb96 -[NSViewController _loadViewIfRequired] default 16:36:00.431139 -0700 WKCookieMonster 8 0x7fff514ecb01 -[NSViewController view] default 16:36:00.431268 -0700 WKCookieMonster 9 0x7fff5166b43d -[NSWindow _contentViewControllerChanged] default 16:36:00.431346 -0700 WKCookieMonster 10 0x7fff56025e8e -[NSObject(NSKeyValueCoding) setValue:forKey:] default 16:36:00.431473 -0700 WKCookieMonster 11 0x7fff516ae189 -[NSWindow setValue:forKey:] default 16:36:00.431601 -0700 WKCookieMonster 12 0x7fff516ae0ed -[NSIBUserDefinedRuntimeAttributesConnector establishConnection] default 16:36:00.431722 -0700 WKCookieMonster 13 0x7fff5147a7e5 -[NSIBObjectData nibInstantiateWithOwner:options:topLevelObjects:] default 16:36:00.431846 -0700 WKCookieMonster 14 0x7fff51575e0e -[NSNib _instantiateNibWithExternalNameTable:options:] default 16:36:00.431970 -0700 WKCookieMonster 15 0x7fff51575a6a -[NSNib _instantiateWithOwner:options:topLevelObjects:] default 16:36:00.432128 -0700 WKCookieMonster 16 0x7fff51ccc4e8 -[NSStoryboard instantiateControllerWithIdentifier:] default 16:36:00.432247 -0700 WKCookieMonster 17 0x7fff5146eaf3 NSApplicationMain default 16:36:00.432288 -0700 WKCookieMonster 18 0x10000e41d main default 16:36:00.432314 -0700 WKCookieMonster 19 0x7fff7c39f015 start --------------- In loadView(): let cookieStore = WKWebsiteDataStore.default().httpCookieStore cookieStore.setCookie(cookie) {...} 1420457 4 339490 sihui_liu 2018-05-03 17:11:23 -0700 Created attachment 339490 Patch 1420509 5 339490 cdumez 2018-05-03 18:27:24 -0700 Comment on attachment 339490 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339490&action=review > Source/WebKit/UIProcess/API/APIWebsiteDataStore.cpp:70 > + WTF::setProcessPrivileges(allPrivileges()); I said WebKit::WebsiteDataStore not the API one :) the existing call in in ProcessPool, not its API object. 1420537 6 339511 sihui_liu 2018-05-03 20:21:07 -0700 Created attachment 339511 Patch 1420715 7 339511 commit-queue 2018-05-04 09:51:21 -0700 Comment on attachment 339511 Patch Clearing flags on attachment: 339511 Committed r231356: <https://trac.webkit.org/changeset/231356> 1420716 8 commit-queue 2018-05-04 09:51:23 -0700 All reviewed patches have been landed. Closing bug. 1420717 9 webkit-bug-importer 2018-05-04 09:52:18 -0700 <rdar://problem/39979381> 1420888 10 ggaren 2018-05-04 14:39:45 -0700 It should be possible to test this with an API test that sets a cookie before creating a WebView. Subtle cases like this are extra valuable to test. 1421557 11 sihui_liu 2018-05-07 17:34:34 -0700 (In reply to Geoffrey Garen from comment #10) > It should be possible to test this with an API test that sets a cookie > before creating a WebView. Subtle cases like this are extra valuable to test. Yes, a reason we bypassed this case with API test is that process privileges were granted to TestController in initialization. I added an API test for this case: https://bugs.webkit.org/show_bug.cgi?id=185406. 339463 2018-05-03 14:05:04 -0700 2018-05-03 17:11:22 -0700 Patch bug-185262-20180503140503.patch text/plain 1601 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZlZTQ4MTQxMjZhNWEwODIy ZDU4N2M3MDU0NmZlN2QwZTdhZjRhYmMuLjI2NjM4Y2JiYTYzMmIyOGMzMDVjMzdjYTA0NWNhODVh ODhlZWM3YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDUtMDMgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWx1cmUgaW4g TmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpzZXRDb29raWU6IHByaXZpbGVnZSBvZiBVSSBwcm9jZXNz IGlzIG5vdCBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NTI2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeCBhbiBhc3NlcnRpb24gZmFpbHVyZSBieSBzZXR0aW5nIFVJIHByb2Nlc3MgcHJpdmls ZWdlcyBpbiBXS1dlYnNpdGVEYXRhU3RvcmUubW06IFVJIAorICAgICAgICBwcm9jZXNzIG1heSB1 c2UgdGhlIGNvb2tpZSBBUEkgYmVmb3JlIGNyZWF0aW5nIGEgV2ViVmlldy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJzaXRlRGF0YVN0b3JlLm1tOgorCiAyMDE4LTA1LTAy ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIE9wZW4gYXVkaW8v dmlkZW8gc2FuZGJveCBzZXJ2aWNlcyBmb3IgbWluaW1hbCBzaW11bGF0b3IKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYnNpdGVEYXRhU3RvcmUubW0g Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJzaXRlRGF0YVN0b3JlLm1t CmluZGV4IDVjNmYxM2Q4N2NjMDhhNDc0M2E1NTk0MTkyNjM1M2M0ZDg0MjBlM2UuLjE0YTM4ZmJi NzFlZGU5N2Q5NzUyOWY5MzZiODRlOTkwNWVjYzZmMjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYnNpdGVEYXRhU3RvcmUubW0KKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFTdG9yZS5tbQpAQCAtMzks NiArMzksNyBAQAogI2ltcG9ydCA8V2ViQ29yZS9VUkwuaD4KICNpbXBvcnQgPFdlYktpdC9TZXJ2 aWNlV29ya2VyUHJvY2Vzc1Byb3h5Lmg+CiAjaW1wb3J0IDx3dGYvQmxvY2tQdHIuaD4KKyNpbXBv cnQgPHd0Zi9Qcm9jZXNzUHJpdmlsZWdlLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwog CkBAIC00Niw2ICs0Nyw3IEBAIEBpbXBsZW1lbnRhdGlvbiBXS1dlYnNpdGVEYXRhU3RvcmUKIAog KyAoV0tXZWJzaXRlRGF0YVN0b3JlICopZGVmYXVsdERhdGFTdG9yZQogeworICAgIFdURjo6c2V0 UHJvY2Vzc1ByaXZpbGVnZXMoYWxsUHJpdmlsZWdlcygpKTsKICAgICByZXR1cm4gV2ViS2l0Ojp3 cmFwcGVyKEFQSTo6V2Vic2l0ZURhdGFTdG9yZTo6ZGVmYXVsdERhdGFTdG9yZSgpLmdldCgpKTsK IH0KIAo= 339490 2018-05-03 17:11:23 -0700 2018-05-03 20:21:05 -0700 Patch bug-185262-20180503171122.patch text/plain 1676 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZlZTQ4MTQxMjZhNWEwODIy ZDU4N2M3MDU0NmZlN2QwZTdhZjRhYmMuLjI2NjM4Y2JiYTYzMmIyOGMzMDVjMzdjYTA0NWNhODVh ODhlZWM3YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDUtMDMgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWx1cmUgaW4g TmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpzZXRDb29raWU6IHByaXZpbGVnZSBvZiBVSSBwcm9jZXNz IGlzIG5vdCBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NTI2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeCBhbiBhc3NlcnRpb24gZmFpbHVyZSBieSBzZXR0aW5nIFVJIHByb2Nlc3MgcHJpdmls ZWdlcyBpbiBXS1dlYnNpdGVEYXRhU3RvcmUubW06IFVJIAorICAgICAgICBwcm9jZXNzIG1heSB1 c2UgdGhlIGNvb2tpZSBBUEkgYmVmb3JlIGNyZWF0aW5nIGEgV2ViVmlldy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJzaXRlRGF0YVN0b3JlLm1tOgorCiAyMDE4LTA1LTAy ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIE9wZW4gYXVkaW8v dmlkZW8gc2FuZGJveCBzZXJ2aWNlcyBmb3IgbWluaW1hbCBzaW11bGF0b3IKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElXZWJzaXRlRGF0YVN0b3JlLmNwcCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElXZWJzaXRlRGF0YVN0b3JlLmNwcAppbmRleCBk MDQ3MmM4YTcxZDZjODEyMTkwYWJkYTc3ODNmMjlmNDI2ZGMzZjVjLi5lNjYzODBhYjUwMjZkZWU3 YjBjYjVhYWU5ZDE3MWRhZTBiYWJjMzY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQVBJV2Vic2l0ZURhdGFTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL0FQSVdlYnNpdGVEYXRhU3RvcmUuY3BwCkBAIC0yOCw2ICsyOCw3IEBACiAKICNp bmNsdWRlICJXZWJLaXQySW5pdGlhbGl6ZS5oIgogI2luY2x1ZGUgIldlYnNpdGVEYXRhU3RvcmUu aCIKKyNpbmNsdWRlIDx3dGYvUHJvY2Vzc1ByaXZpbGVnZS5oPgogCiBuYW1lc3BhY2UgQVBJIHsK IApAQCAtNjYsNiArNjcsNyBAQCBXZWJzaXRlRGF0YVN0b3JlOjpXZWJzaXRlRGF0YVN0b3JlKCkK IFdlYnNpdGVEYXRhU3RvcmU6OldlYnNpdGVEYXRhU3RvcmUoV2ViS2l0OjpXZWJzaXRlRGF0YVN0 b3JlOjpDb25maWd1cmF0aW9uIGNvbmZpZ3VyYXRpb24sIFBBTDo6U2Vzc2lvbklEIHNlc3Npb25J RCkKICAgICA6IG1fd2Vic2l0ZURhdGFTdG9yZShXZWJLaXQ6OldlYnNpdGVEYXRhU3RvcmU6OmNy ZWF0ZShXVEZNb3ZlKGNvbmZpZ3VyYXRpb24pLCBzZXNzaW9uSUQpKQogeworICAgIFdURjo6c2V0 UHJvY2Vzc1ByaXZpbGVnZXMoYWxsUHJpdmlsZWdlcygpKTsKIH0KIAogV2Vic2l0ZURhdGFTdG9y ZTo6fldlYnNpdGVEYXRhU3RvcmUoKQo= 339511 2018-05-03 20:21:07 -0700 2018-05-04 09:51:21 -0700 Patch bug-185262-20180503202106.patch text/plain 1870 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZlZTQ4MTQxMjZhNWEwODIy ZDU4N2M3MDU0NmZlN2QwZTdhZjRhYmMuLmNiNWNiN2FmYzRmZDAwMGE1NzA3ZTMxZWQ1YTdlMTA3 ZTQwY2Y2NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDUtMDMgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWx1cmUgaW4g TmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpzZXRDb29raWU6IHByaXZpbGVnZSBvZiBVSSBwcm9jZXNz IGlzIG5vdCBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NTI2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeCBhbiBhc3NlcnRpb24gZmFpbHVyZSBieSBzZXR0aW5nIFVJIHByb2Nlc3MgcHJpdmls ZWdlcyBpbiBjb25zdHJ1Y3RvciBvZiBXZWJzaXRlRGF0YVN0b3JlCisgICAgICAgIGJlY2F1c2Ug VUkgcHJvY2VzcyBtYXkgdXNlIHRoZSBjb29raWUgQVBJIGJlZm9yZSBjcmVhdGluZyBhIFdlYlZp ZXcuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYnNpdGVEYXRhU3RvcmU6OldlYnNpdGVEYXRhU3RvcmUp OgorCiAyMDE4LTA1LTAyICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIE9wZW4gYXVkaW8vdmlkZW8gc2FuZGJveCBzZXJ2aWNlcyBmb3IgbWluaW1hbCBzaW11bGF0 b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNp dGVEYXRhU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vi c2l0ZURhdGFTdG9yZS5jcHAKaW5kZXggMmFhNDY2MTA1YjhmNzVjNThmM2QxNzVjZjZlZGViYzQ0 NTUyODJiZC4uYjc1NDUyMTlmYjkwYWEzZWMwOWUxNDYyNmRiMzhiNmRlYjA1ZWQ5NCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9y ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURh dGFTdG9yZS5jcHAKQEAgLTQ4LDYgKzQ4LDcgQEAKICNpbmNsdWRlIDxXZWJDb3JlL1NlY3VyaXR5 T3JpZ2luRGF0YS5oPgogI2luY2x1ZGUgPHd0Zi9Db21wbGV0aW9uSGFuZGxlci5oPgogI2luY2x1 ZGUgPHd0Zi9Dcm9zc1RocmVhZENvcGllci5oPgorI2luY2x1ZGUgPHd0Zi9Qcm9jZXNzUHJpdmls ZWdlLmg+CiAjaW5jbHVkZSA8d3RmL1J1bkxvb3AuaD4KIAogI2lmIEVOQUJMRShORVRTQ0FQRV9Q TFVHSU5fQVBJKQpAQCAtOTAsNiArOTEsNyBAQCBXZWJzaXRlRGF0YVN0b3JlOjpXZWJzaXRlRGF0 YVN0b3JlKENvbmZpZ3VyYXRpb24gY29uZmlndXJhdGlvbiwgUEFMOjpTZXNzaW9uSUQgcwogICAg ICwgbV9zdG9yYWdlTWFuYWdlcihTdG9yYWdlTWFuYWdlcjo6Y3JlYXRlKG1fY29uZmlndXJhdGlv bi5sb2NhbFN0b3JhZ2VEaXJlY3RvcnkpKQogICAgICwgbV9xdWV1ZShXb3JrUXVldWU6OmNyZWF0 ZSgiY29tLmFwcGxlLldlYktpdC5XZWJzaXRlRGF0YVN0b3JlIikpCiB7CisgICAgV1RGOjpzZXRQ cm9jZXNzUHJpdmlsZWdlcyhhbGxQcml2aWxlZ2VzKCkpOwogICAgIG1heWJlUmVnaXN0ZXJXaXRo U2Vzc2lvbklETWFwKCk7CiAgICAgcGxhdGZvcm1Jbml0aWFsaXplKCk7CiB9Cg==