185259 2018-05-03 10:19:27 -0700 REGRESSION: Layout Test http/tests/security/location-cross-origin.html is a flaky failure 2018-05-03 11:14:29 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=184801 InRadar P2 Normal --- 1 ryanhaddad cdumez cdumez commit-queue webkit-bug-importer oldest_to_newest 1420199 0 ryanhaddad 2018-05-03 10:19:27 -0700 The following layout test is flaky on debug bots. http/tests/security/location-cross-origin.html Probable cause: Unknown. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Flocation-cross-origin.html --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/security/location-cross-origin-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/tests/security/location-cross-origin-actual.txt @@ -49,7 +49,7 @@ PASS Object.getOwnPropertyDescriptor(window.location, 'hash').set.call(frames[0].location, 1) threw exception SecurityError: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a cross-origin frame. Protocols, domains, and ports must match.. PASS Object.defineProperty(frames[0].location, 'foo', { value: 1 }) threw exception SecurityError: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a cross-origin frame. Protocols, domains, and ports must match.. PASS frames[0].location.href = 'about:blank' did not throw exception. -PASS frames[0].location.href is "about:blank" +FAIL frames[0].location.href should be about:blank. Threw exception SecurityError: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a cross-origin frame. Protocols, domains, and ports must match. PASS successfullyParsed is true TEST COMPLETE 1420202 1 ryanhaddad 2018-05-03 10:21:26 -0700 Flakiness dashboard suggests that this regressed with https://trac.webkit.org/changeset/230926, but I have not yet attempted to reproduce the failure locally. 1420206 2 cdumez 2018-05-03 10:24:08 -0700 (In reply to Ryan Haddad from comment #1) > Flakiness dashboard suggests that this regressed with > https://trac.webkit.org/changeset/230926, but I have not yet attempted to > reproduce the failure locally. Will look now. 1420207 3 cdumez 2018-05-03 10:25:44 -0700 (In reply to Chris Dumez from comment #2) > (In reply to Ryan Haddad from comment #1) > > Flakiness dashboard suggests that this regressed with > > https://trac.webkit.org/changeset/230926, but I have not yet attempted to > > reproduce the failure locally. > > Will look now. shouldNotThrow("frames[0].location.href = 'about:blank'"); setTimeout(function() { shouldBeEqualToString("frames[0].location.href", "about:blank"); finishJSTest(); }, 100); setTimeout 100, great. 1420210 4 339425 cdumez 2018-05-03 10:35:49 -0700 Created attachment 339425 Patch 1420229 5 339425 commit-queue 2018-05-03 11:13:59 -0700 Comment on attachment 339425 Patch Clearing flags on attachment: 339425 Committed r231315: <https://trac.webkit.org/changeset/231315> 1420230 6 commit-queue 2018-05-03 11:14:00 -0700 All reviewed patches have been landed. Closing bug. 1420232 7 webkit-bug-importer 2018-05-03 11:14:29 -0700 <rdar://problem/39947471> 339425 2018-05-03 10:35:49 -0700 2018-05-03 11:13:59 -0700 Patch bug-185259-20180503103549.patch text/plain 1880 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMjMwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzJmNjRkMjk1NWNhNDViNGYzMWRk ZDczZmU5ZDhjYzMxZDM5NDk4MS4uNTYwNGFkMGExNDgxMjRjYjM5MjI5ODdmY2UwODljMDY4OWQ5 MmI1ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTA1LTAzICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogTGF5b3V0IFRlc3QgaHR0cC90 ZXN0cy9zZWN1cml0eS9sb2NhdGlvbi1jcm9zcy1vcmlnaW4uaHRtbCBpcyBhIGZsYWt5IGZhaWx1 cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTI1 OQorCisgICAgICAgIFVucmV2aWV3ZWQsIHN0b3AgcmVseWluZyBvbiBhIHNldEltZW91dCgxMDAp IGFuZCBlcGVjdCB0aGUgZnJhbWUgbmF2aWdhdGlvbiB0byBoYXZlIGNvbXBsZXRlZC4gSW5zdGVh ZCwKKyAgICAgICAgdXNlIGEgc2V0SW50ZXJ2YWwoKSB0byBwb2xsIHVudGlsIHRoZSBjcm9zcy1v cmlnaW4gZnJhbWUgaGFzIG5hdmlnYXRlZC4KKworICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJp dHkvbG9jYXRpb24tY3Jvc3Mtb3JpZ2luLmh0bWw6CisKIDIwMTgtMDUtMDIgIE1zMmdlciAgPE1z MmdlckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVwZGF0ZSBkb2N1bWVudC1jcmVhdGUtdG91Y2gu aHRtbCBleHBlY3RhdGlvbnMgZm9yIHIyMzExMTQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvc2VjdXJpdHkvbG9jYXRpb24tY3Jvc3Mtb3JpZ2luLmh0bWwgYi9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2xvY2F0aW9uLWNyb3NzLW9yaWdpbi5odG1sCmluZGV4IDI1 NDAxMGY3Y2UxNWVlMWIyOThiMjg3ZjVhZDYwNGUxOWM0NTgzZDkuLjQ1NWMxNTc0MzU3ZTRkNGZm M2FmMmUzMGM5NzE5Mjk4MzJlNDkxMDYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvc2VjdXJpdHkvbG9jYXRpb24tY3Jvc3Mtb3JpZ2luLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9zZWN1cml0eS9sb2NhdGlvbi1jcm9zcy1vcmlnaW4uaHRtbApAQCAtNjAsMTAg KzYwLDE1IEBAIG9ubG9hZCA9IGZ1bmN0aW9uKCkgewogCiAgICAgLy8gU2V0dGluZyAnaHJlZicg Y3Jvc3Mgb3JpZ2luIHNob3VsZCBiZSBhbGxvd2VkLgogICAgIHNob3VsZE5vdFRocm93KCJmcmFt ZXNbMF0ubG9jYXRpb24uaHJlZiA9ICdhYm91dDpibGFuayciKTsKLSAgICBzZXRUaW1lb3V0KGZ1 bmN0aW9uKCkgewotICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImZyYW1lc1swXS5sb2Nh dGlvbi5ocmVmIiwgImFib3V0OmJsYW5rIik7Ci0gICAgICAgIGZpbmlzaEpTVGVzdCgpOwotICAg IH0sIDEwMCk7CisgICAgaGFuZGxlID0gc2V0SW50ZXJ2YWwoZnVuY3Rpb24oKSB7CisgICAgICAg IHRyeSB7CisgICAgICAgICAgICBmcmFtZXNbMF0ubG9jYXRpb24uaHJlZjsgLy8gU2hvdWxkIHRo cm93IGlmIHN0aWxsIGNyb3NzLW9yaWdpbi4KKworICAgICAgICAgICAgc2hvdWxkQmVFcXVhbFRv U3RyaW5nKCJmcmFtZXNbMF0ubG9jYXRpb24uaHJlZiIsICJhYm91dDpibGFuayIpOworICAgICAg ICAgICAgY2xlYXJJbnRlcnZhbChoYW5kbGUpOworICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7 CisgICAgICAgIH0gY2F0Y2ggKGUpIHsgfQorICAgIH0sIDUpOwogfTsKIDwvc2NyaXB0PgogPHNj cmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0Pgo=