185244 2018-05-03 02:29:10 -0700 [EME][GStreamer] Crash when the mediaKeys are created before loading the media in debug conf 2018-05-09 00:39:18 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 185277 1 bandou.yacine webkit-unassigned calvaris commit-queue olivier.blin pnormand webkit-bug-importer zan oldest_to_newest 1420065 0 bandou.yacine 2018-05-03 02:29:10 -0700 The function "MediaPlayerPrivateGStreamerBase::cdmInstanceAttached" is expected to be called once, so there is an ASSERT(!m_cdmInstance). But when the MediaKeys created before loading the media, the cdminstance is created and attached to the MediaPlayerPrivate via "MediaPlayerPrivateGStreamerBase::cdmInstanceAttached" before laoding the media. Then when the media is loading, the function "MediaPlayerPrivateGStreamerBase::cdmInstanceAttached" will be called several times via the function "mediaEngineWasUpdated" wich is called for each change in the state of the MediaElement, thus the WebProcess crashes in the ASSERT(!m_cdmInstance). To Avoid the crash we replace the Assert with a simple check. 1420069 1 pnormand 2018-05-03 02:39:04 -0700 Same issue as https://bugs.webkit.org/show_bug.cgi?id=185005 it seems. 1420073 2 calvaris 2018-05-03 03:06:53 -0700 We need to plainly remove that ASSERT. 1420425 3 339483 bandou.yacine 2018-05-03 16:43:18 -0700 Created attachment 339483 Patch 1420428 4 bandou.yacine 2018-05-03 16:47:13 -0700 (In reply to Philippe Normand from comment #1) > Same issue as https://bugs.webkit.org/show_bug.cgi?id=185005 it seems. Not exactly, but this issue is a part of this one 185005 I'll update the WPE TestExpectations when all patches are landed 1420512 5 339501 bandou.yacine 2018-05-03 18:42:50 -0700 Created attachment 339501 Patch 1421031 6 339501 zan 2018-05-05 00:50:07 -0700 Comment on attachment 339501 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339501&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1222 > + if (m_cdmInstance.get() == &instance) { .get() required here? 1421227 7 339501 calvaris 2018-05-07 01:24:51 -0700 Comment on attachment 339501 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339501&action=review > Source/WebCore/ChangeLog:11 > + to the MediaPlayerPrivate via "MediaPlayerPrivateGStreamerBase::cdmInstanceAttached" before laoding loading >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1222 >> + if (m_cdmInstance.get() == &instance) { > > .get() required here? It looks like it is not. Besides, I don't think this chunk of code is necessary as detach is not called multiple times as attach is. Unless you think I am wrong, please remove this chunk and leave the code as it was. 1421230 8 bandou.yacine 2018-05-07 01:39:01 -0700 (In reply to Zan Dobersek from comment #6) > Comment on attachment 339501 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339501&action=review > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1222 > > + if (m_cdmInstance.get() == &instance) { > > .get() required here? No, is just an oversight. 1421235 9 bandou.yacine 2018-05-07 01:45:39 -0700 (In reply to Xabier Rodríguez Calvar from comment #7) > Comment on attachment 339501 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339501&action=review > > > Source/WebCore/ChangeLog:11 > > + to the MediaPlayerPrivate via "MediaPlayerPrivateGStreamerBase::cdmInstanceAttached" before laoding > > loading > > >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1222 > >> + if (m_cdmInstance.get() == &instance) { > > > > .get() required here? > > It looks like it is not. Besides, I don't think this chunk of code is > necessary as detach is not called multiple times as attach is. Unless you > think I am wrong, please remove this chunk and leave the code as it was. I added it because I had a crash in some test. Otherwise, If we remove the assert from attach, I don't see the inconvenience of removing it from dettach. 1421237 10 calvaris 2018-05-07 01:58:32 -0700 (In reply to Yacine Bandou from comment #9) > I added it because I had a crash in some test. > Otherwise, If we remove the assert from attach, I don't see the > inconvenience of removing it from dettach. It had the same idea but different consequences. In the case of attach, we do get it called multiple times and nothing happens if it is the same CDM instance. Actually, we might want to add an assert to check if we are assigned a different instance. In the case of detach, we should still assert because we are getting a request to detach an instance we don't know. 1421240 11 bandou.yacine 2018-05-07 02:42:07 -0700 (In reply to Xabier Rodríguez Calvar from comment #10) > (In reply to Yacine Bandou from comment #9) > > I added it because I had a crash in some test. > > Otherwise, If we remove the assert from attach, I don't see the > > inconvenience of removing it from dettach. > > It had the same idea but different consequences. In the case of attach, we > do get it called multiple times and nothing happens if it is the same CDM > instance. Actually, we might want to add an assert to check if we are > assigned a different instance. > > In the case of detach, we should still assert because we are getting a > request to detach an instance we don't know. With the assert in the cdmInstanceDetached function the following test "imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-different-mediakeys.https.html" crashes. Without the assert the test passes. We have two solutions, we remove the Assert or we leave it but we will note that the test will be crashed in TestExpectations. What do you suggest? 1421256 12 339714 bandou.yacine 2018-05-07 06:02:21 -0700 Created attachment 339714 Patch 1421665 13 calvaris 2018-05-08 00:09:16 -0700 (In reply to Yacine Bandou from comment #11) > With the assert in the cdmInstanceDetached function the following test > "imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys- > multiple-times-with-different-mediakeys.https.html" crashes. > > Without the assert the test passes. > > We have two solutions, we remove the Assert or we leave it but we will note > that the test will be crashed in TestExpectations. > > What do you suggest? I suggest we remove the ASSERT. If there is something that triggers it it is better to fix it. So you were right. 1421695 14 339809 bandou.yacine 2018-05-08 05:31:34 -0700 Created attachment 339809 Patch 1422177 15 339809 commit-queue 2018-05-09 00:38:50 -0700 Comment on attachment 339809 Patch Clearing flags on attachment: 339809 Committed r231551: <https://trac.webkit.org/changeset/231551> 1422178 16 commit-queue 2018-05-09 00:38:52 -0700 All reviewed patches have been landed. Closing bug. 1422179 17 webkit-bug-importer 2018-05-09 00:39:18 -0700 <rdar://problem/40085390> 339483 2018-05-03 16:43:18 -0700 2018-05-03 18:42:45 -0700 Patch bug-185244-20180504014317.patch text/plain 2732 bandou.yacine U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmYyNzlmYWZjMmU2YTA1 YjFjZDVjYzU2ZGEyNzI2OGRhZTdmYjgwYi4uMGI2ZjMxOGYwNWMzM2NhMTc2NjM4OGIzN2I3MjE3 N2ZiZTE2YTg5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTA1LTAzICBZYWNp bmUgQmFuZG91ICA8eWFjaW5lLmJhbmRvdV9leHRAc29mdGF0aG9tZS5jb20+CisKKyAgICAgICAg W0VNRV1bR1N0cmVhbWVyXSBDcmFzaCB3aGVuIHRoZSBtZWRpYUtleXMgY3JlYXRlZCBiZWZvcmUg bG9hZGluZyB0aGUgbWVkaWEgaW4gZGVidWcgY29uZgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1MjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZ1bmN0aW9uICJNZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXJCYXNlOjpjZG1JbnN0YW5jZUF0dGFjaGVkIiBpcyBleHBlY3RlZCB0byBiZSBjYWxs ZWQgb25jZSwKKyAgICAgICAgc28gdGhlcmUgaXMgYW4gQVNTRVJUKCFtX2NkbUluc3RhbmNlKS4K KyAgICAgICAgQnV0IHdoZW4gdGhlIE1lZGlhS2V5cyBjcmVhdGVkIGJlZm9yZSBsb2FkaW5nIHRo ZSBtZWRpYSwgdGhlIGNkbWluc3RhbmNlIGlzIGNyZWF0ZWQgYW5kIGF0dGFjaGVkCisgICAgICAg IHRvIHRoZSBNZWRpYVBsYXllclByaXZhdGUgdmlhICJNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlOjpjZG1JbnN0YW5jZUF0dGFjaGVkIiBiZWZvcmUgbGFvZGluZworICAgICAgICB0aGUg bWVkaWEsIHRoZW4gd2hlbiB0aGUgbWVkaWEgaXMgbG9hZGluZywgdGhlIGZ1bmN0aW9uICJNZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjZG1JbnN0YW5jZUF0dGFjaGVkIgorICAgICAg ICB3aWxsIGJlIGNhbGxlZCBzZXZlcmFsIHRpbWVzIHZpYSB0aGUgZnVuY3Rpb24gIm1lZGlhRW5n aW5lV2FzVXBkYXRlZCIgd2ljaCBpcyBjYWxsZWQgZm9yIGVhY2ggY2hhbmdlCisgICAgICAgIGlu IHRoZSBNZWRpYUVsZW1lbnQgc3RhdGUsIHRodXMgdGhlIFdlYlByb2Nlc3MgY3Jhc2hlcyBpbiB0 aGUgQVNTRVJUKCFtX2NkbUluc3RhbmNlKS4KKworICAgICAgICBUaGlzIGNvbW1pdCBhdm9pZCB0 aGUgY3Jhc2ggYnkgcmVwbGFjaW5nIHRoZSBhc3NlcnQgd2l0aCBhIHNpbXBsZSBjaGVjay4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXJCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lckJhc2U6OmNkbUluc3RhbmNlQXR0YWNoZWQpOgorCiAyMDE4LTA1LTAzICBZYWNpbmUg QmFuZG91ICA8eWFjaW5lLmJhbmRvdV9leHRAc29mdGF0aG9tZS5jb20+CiAKICAgICAgICAgW01T RV1bR1N0cmVhbWVyXSBEZWxldGUgcHJvcGVybHkgdGhlIHN0cmVhbSBmcm9tIHRoZSBXZWJLaXRN ZWRpYVNvdXJjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lckJhc2UuY3BwCmluZGV4IDE1NTc0NzVlOTVmYjY4MzIxMDViYThkNzkzOGNhMjQ4NmE5MGE0 ZmQuLmE1YjM4MTBlODliZDljMWE4NGJkZWQ1MzQ2MzI4M2ZmYjkzOGU0YWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKQEAgLTEy MDcsMTAgKzEyMDcsMTEgQEAgdW5zaWduZWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFz ZTo6dmlkZW9EZWNvZGVkQnl0ZUNvdW50KCkgY29uc3QKICNpZiBFTkFCTEUoRU5DUllQVEVEX01F RElBKQogdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjZG1JbnN0YW5jZUF0 dGFjaGVkKENETUluc3RhbmNlJiBpbnN0YW5jZSkKIHsKLSAgICBBU1NFUlQoIW1fY2RtSW5zdGFu Y2UpOwotICAgIG1fY2RtSW5zdGFuY2UgPSAmaW5zdGFuY2U7Ci0gICAgR1NUX0RFQlVHX09CSkVD VChwaXBlbGluZSgpLCAiQ0RNIGluc3RhbmNlICVwIHNldCIsIG1fY2RtSW5zdGFuY2UuZ2V0KCkp OwotICAgIG1fcHJvdGVjdGlvbkNvbmRpdGlvbi5ub3RpZnlBbGwoKTsKKyAgICBpZiAobV9jZG1J bnN0YW5jZSAhPSAmaW5zdGFuY2UpIHsKKyAgICAgICAgbV9jZG1JbnN0YW5jZSA9ICZpbnN0YW5j ZTsKKyAgICAgICAgR1NUX0RFQlVHX09CSkVDVChwaXBlbGluZSgpLCAiQ0RNIGluc3RhbmNlICVw IHNldCIsIG1fY2RtSW5zdGFuY2UuZ2V0KCkpOworICAgICAgICBtX3Byb3RlY3Rpb25Db25kaXRp b24ubm90aWZ5QWxsKCk7CisgICAgfQogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lckJhc2U6OmNkbUluc3RhbmNlRGV0YWNoZWQoQ0RNSW5zdGFuY2UmIGluc3RhbmNlKQo= 339501 2018-05-03 18:42:50 -0700 2018-05-07 06:02:16 -0700 Patch bug-185244-20180504034249.patch text/plain 3536 bandou.yacine U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmYyNzlmYWZjMmU2YTA1 YjFjZDVjYzU2ZGEyNzI2OGRhZTdmYjgwYi4uYTYyYWIyNjZhNWU1M2MzZGU0OGE4YjhmMzNjNGY0 NDg5YjM2ODAyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE4LTA1LTAzICBZYWNp bmUgQmFuZG91ICA8eWFjaW5lLmJhbmRvdV9leHRAc29mdGF0aG9tZS5jb20+CiAKKyAgICAgICAg W0VNRV1bR1N0cmVhbWVyXSBDcmFzaCB3aGVuIHRoZSBtZWRpYUtleXMgY3JlYXRlZCBiZWZvcmUg bG9hZGluZyB0aGUgbWVkaWEgaW4gZGVidWcgY29uZgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1MjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZ1bmN0aW9uICJNZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXJCYXNlOjpjZG1JbnN0YW5jZUF0dGFjaGVkIiBpcyBleHBlY3RlZCB0byBiZSBjYWxs ZWQgb25jZSwKKyAgICAgICAgc28gdGhlcmUgaXMgYW4gQVNTRVJUKCFtX2NkbUluc3RhbmNlKS4K KyAgICAgICAgQnV0IHdoZW4gdGhlIE1lZGlhS2V5cyBjcmVhdGVkIGJlZm9yZSBsb2FkaW5nIHRo ZSBtZWRpYSwgdGhlIGNkbWluc3RhbmNlIGlzIGNyZWF0ZWQgYW5kIGF0dGFjaGVkCisgICAgICAg IHRvIHRoZSBNZWRpYVBsYXllclByaXZhdGUgdmlhICJNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlOjpjZG1JbnN0YW5jZUF0dGFjaGVkIiBiZWZvcmUgbGFvZGluZworICAgICAgICB0aGUg bWVkaWEsIHRoZW4gd2hlbiB0aGUgbWVkaWEgaXMgbG9hZGluZywgdGhlIGZ1bmN0aW9uICJNZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjZG1JbnN0YW5jZUF0dGFjaGVkIgorICAgICAg ICB3aWxsIGJlIGNhbGxlZCBzZXZlcmFsIHRpbWVzIHZpYSB0aGUgZnVuY3Rpb24gIm1lZGlhRW5n aW5lV2FzVXBkYXRlZCIgd2ljaCBpcyBjYWxsZWQgZm9yIGVhY2ggY2hhbmdlCisgICAgICAgIGlu IHRoZSBNZWRpYUVsZW1lbnQgc3RhdGUsIHRodXMgdGhlIFdlYlByb2Nlc3MgY3Jhc2hlcyBpbiB0 aGUgQVNTRVJUKCFtX2NkbUluc3RhbmNlKS4KKworICAgICAgICBUaGlzIGNvbW1pdCBhdm9pZCB0 aGUgY3Jhc2ggYnkgcmVwbGFjaW5nIHRoZSBhc3NlcnQgd2l0aCBhIHNpbXBsZSBjaGVjay4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXJCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lckJhc2U6OmNkbUluc3RhbmNlQXR0YWNoZWQpOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6Y2RtSW5zdGFuY2VEZXRhY2hlZCk6CisyMDE4 LTA1LTAzICBZYWNpbmUgQmFuZG91ICA8eWFjaW5lLmJhbmRvdV9leHRAc29mdGF0aG9tZS5jb20+ CisKICAgICAgICAgW01TRV1bR1N0cmVhbWVyXSBEZWxldGUgcHJvcGVybHkgdGhlIHN0cmVhbSBm cm9tIHRoZSBXZWJLaXRNZWRpYVNvdXJjZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg1MjQyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAppbmRleCAxNTU3NDc1ZTk1ZmI2ODMyMTA1YmE4 ZDc5MzhjYTI0ODZhOTBhNGZkLi4zNDM4OGMzNDg0OTM5M2RkZmQ2YjcyMTA3NmQ1ZGE3NzY1MTdj ZDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2UuY3BwCkBAIC0xMjA3LDEwICsxMjA3LDExIEBAIHVuc2lnbmVkIE1lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lckJhc2U6OnZpZGVvRGVjb2RlZEJ5dGVDb3VudCgpIGNvbnN0CiAjaWYgRU5B QkxFKEVOQ1JZUFRFRF9NRURJQSkKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFz ZTo6Y2RtSW5zdGFuY2VBdHRhY2hlZChDRE1JbnN0YW5jZSYgaW5zdGFuY2UpCiB7Ci0gICAgQVNT RVJUKCFtX2NkbUluc3RhbmNlKTsKLSAgICBtX2NkbUluc3RhbmNlID0gJmluc3RhbmNlOwotICAg IEdTVF9ERUJVR19PQkpFQ1QocGlwZWxpbmUoKSwgIkNETSBpbnN0YW5jZSAlcCBzZXQiLCBtX2Nk bUluc3RhbmNlLmdldCgpKTsKLSAgICBtX3Byb3RlY3Rpb25Db25kaXRpb24ubm90aWZ5QWxsKCk7 CisgICAgaWYgKG1fY2RtSW5zdGFuY2UgIT0gJmluc3RhbmNlKSB7CisgICAgICAgIG1fY2RtSW5z dGFuY2UgPSAmaW5zdGFuY2U7CisgICAgICAgIEdTVF9ERUJVR19PQkpFQ1QocGlwZWxpbmUoKSwg IkNETSBpbnN0YW5jZSAlcCBzZXQiLCBtX2NkbUluc3RhbmNlLmdldCgpKTsKKyAgICAgICAgbV9w cm90ZWN0aW9uQ29uZGl0aW9uLm5vdGlmeUFsbCgpOworICAgIH0KIH0KIAogdm9pZCBNZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjZG1JbnN0YW5jZURldGFjaGVkKENETUluc3RhbmNl JiBpbnN0YW5jZSkKQEAgLTEyMTgsMTAgKzEyMTksMTEgQEAgdm9pZCBNZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXJCYXNlOjpjZG1JbnN0YW5jZURldGFjaGVkKENETUluc3RhbmNlJiBpbnN0YW5j ZSkKICNpZmRlZiBOREVCVUcKICAgICBVTlVTRURfUEFSQU0oaW5zdGFuY2UpOwogI2VuZGlmCi0g ICAgQVNTRVJUKG1fY2RtSW5zdGFuY2UuZ2V0KCkgPT0gJmluc3RhbmNlKTsKLSAgICBHU1RfREVC VUdfT0JKRUNUKHBpcGVsaW5lKCksICJkZXRhY2hpbmcgQ0RNIGluc3RhbmNlICVwIiwgbV9jZG1J bnN0YW5jZS5nZXQoKSk7Ci0gICAgbV9jZG1JbnN0YW5jZSA9IG51bGxwdHI7Ci0gICAgbV9wcm90 ZWN0aW9uQ29uZGl0aW9uLm5vdGlmeUFsbCgpOworICAgIGlmIChtX2NkbUluc3RhbmNlLmdldCgp ID09ICZpbnN0YW5jZSkgeworICAgICAgICBHU1RfREVCVUdfT0JKRUNUKHBpcGVsaW5lKCksICJk ZXRhY2hpbmcgQ0RNIGluc3RhbmNlICVwIiwgbV9jZG1JbnN0YW5jZS5nZXQoKSk7CisgICAgICAg IG1fY2RtSW5zdGFuY2UgPSBudWxscHRyOworICAgICAgICBtX3Byb3RlY3Rpb25Db25kaXRpb24u bm90aWZ5QWxsKCk7CisgICAgfQogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2U6OmF0dGVtcHRUb0RlY3J5cHRXaXRoSW5zdGFuY2UoQ0RNSW5zdGFuY2UmIGluc3RhbmNl KQo= 339714 2018-05-07 06:02:21 -0700 2018-05-08 05:31:29 -0700 Patch bug-185244-20180507150221.patch text/plain 2740 bandou.yacine U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzcxYmE0NmM1MmZiZjYz NTM0N2VjMTFhMzgzYjIwNTE0M2M0MTU4My4uYjQ5YTliZWI1MGM3MDYyZmE2Yjc5Mzg0MDJhZjJl OTBjMjU4NzE1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTA1LTAzICBZYWNp bmUgQmFuZG91ICA8eWFjaW5lLmJhbmRvdV9leHRAc29mdGF0aG9tZS5jb20+CisKKyAgICAgICAg W0VNRV1bR1N0cmVhbWVyXSBDcmFzaCB3aGVuIHRoZSBtZWRpYUtleXMgYXJlIGNyZWF0ZWQgYmVm b3JlIGxvYWRpbmcgdGhlIG1lZGlhIGluIGRlYnVnIGNvbmYKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTI0NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBmdW5jdGlvbiAiTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyQmFzZTo6Y2RtSW5zdGFuY2VBdHRhY2hlZCIgaXMgZXhwZWN0ZWQgdG8gYmUg Y2FsbGVkIG9uY2UsCisgICAgICAgIHNvIHRoZXJlIGlzIGFuIEFTU0VSVCghbV9jZG1JbnN0YW5j ZSkuCisgICAgICAgIEJ1dCB3aGVuIHRoZSBNZWRpYUtleXMgYXJlIGNyZWF0ZWQgYmVmb3JlIGxv YWRpbmcgdGhlIG1lZGlhLCB0aGUgY2RtaW5zdGFuY2UgaXMgY3JlYXRlZCBhbmQgYXR0YWNoZWQK KyAgICAgICAgdG8gdGhlIE1lZGlhUGxheWVyUHJpdmF0ZSB2aWEgIk1lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lckJhc2U6OmNkbUluc3RhbmNlQXR0YWNoZWQiIGJlZm9yZSBsb2FkaW5nCisgICAg ICAgIHRoZSBtZWRpYSwgdGhlbiB3aGVuIHRoZSBtZWRpYSBpcyBsb2FkaW5nLCB0aGUgZnVuY3Rp b24gIk1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmNkbUluc3RhbmNlQXR0YWNoZWQi CisgICAgICAgIHdpbGwgYmUgY2FsbGVkIHNldmVyYWwgdGltZXMgdmlhIHRoZSBmdW5jdGlvbiAi bWVkaWFFbmdpbmVXYXNVcGRhdGVkIiB3aWNoIGlzIGNhbGxlZCBmb3IgZWFjaCBjaGFuZ2UKKyAg ICAgICAgaW4gdGhlIE1lZGlhRWxlbWVudCBzdGF0ZSwgdGh1cyB0aGUgV2ViUHJvY2VzcyBjcmFz aGVzIGluIHRoZSBBU1NFUlQoIW1fY2RtSW5zdGFuY2UpLgorCisgICAgICAgIFRoaXMgY29tbWl0 IGF2b2lkIHRoZSBjcmFzaCBieSByZXBsYWNpbmcgdGhlIGFzc2VydCB3aXRoIGEgc2ltcGxlIGNo ZWNrLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyQmFzZTo6Y2RtSW5zdGFuY2VBdHRhY2hlZCk6CisKIDIwMTgtMDUtMDMg IFlhY2luZSBCYW5kb3UgIDx5YWNpbmUuYmFuZG91X2V4dEBzb2Z0YXRob21lLmNvbT4KIAogICAg ICAgICBbTVNFXVtHU3RyZWFtZXJdIERlbGV0ZSBwcm9wZXJseSB0aGUgc3RyZWFtIGZyb20gdGhl IFdlYktpdE1lZGlhU291cmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyQmFzZS5jcHAKaW5kZXggMTU1NzQ3NWU5NWZiNjgzMjEwNWJhOGQ3OTM4Y2Ey NDg2YTkwYTRmZC4uYTViMzgxMGU4OWJkOWMxYTg0YmRlZDUzNDYzMjgzZmZiOTM4ZTRhYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNw cApAQCAtMTIwNywxMCArMTIwNywxMSBAQCB1bnNpZ25lZCBNZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXJCYXNlOjp2aWRlb0RlY29kZWRCeXRlQ291bnQoKSBjb25zdAogI2lmIEVOQUJMRShFTkNS WVBURURfTUVESUEpCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmNkbUlu c3RhbmNlQXR0YWNoZWQoQ0RNSW5zdGFuY2UmIGluc3RhbmNlKQogewotICAgIEFTU0VSVCghbV9j ZG1JbnN0YW5jZSk7Ci0gICAgbV9jZG1JbnN0YW5jZSA9ICZpbnN0YW5jZTsKLSAgICBHU1RfREVC VUdfT0JKRUNUKHBpcGVsaW5lKCksICJDRE0gaW5zdGFuY2UgJXAgc2V0IiwgbV9jZG1JbnN0YW5j ZS5nZXQoKSk7Ci0gICAgbV9wcm90ZWN0aW9uQ29uZGl0aW9uLm5vdGlmeUFsbCgpOworICAgIGlm IChtX2NkbUluc3RhbmNlICE9ICZpbnN0YW5jZSkgeworICAgICAgICBtX2NkbUluc3RhbmNlID0g Jmluc3RhbmNlOworICAgICAgICBHU1RfREVCVUdfT0JKRUNUKHBpcGVsaW5lKCksICJDRE0gaW5z dGFuY2UgJXAgc2V0IiwgbV9jZG1JbnN0YW5jZS5nZXQoKSk7CisgICAgICAgIG1fcHJvdGVjdGlv bkNvbmRpdGlvbi5ub3RpZnlBbGwoKTsKKyAgICB9CiB9CiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyQmFzZTo6Y2RtSW5zdGFuY2VEZXRhY2hlZChDRE1JbnN0YW5jZSYgaW5zdGFu Y2UpCg== 339809 2018-05-08 05:31:34 -0700 2018-05-09 00:38:50 -0700 Patch bug-185244-20180508143136.patch text/plain 3482 bandou.yacine U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzcxYmE0NmM1MmZiZjYz NTM0N2VjMTFhMzgzYjIwNTE0M2M0MTU4My4uZGQwZWQxYzAzN2E4OTdkYzJmNmQxYmU4OGMxN2Vh NzkwNjI5MjJkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTA1LTAzICBZYWNp bmUgQmFuZG91ICA8eWFjaW5lLmJhbmRvdV9leHRAc29mdGF0aG9tZS5jb20+CisKKyAgICAgICAg W0VNRV1bR1N0cmVhbWVyXSBDcmFzaCB3aGVuIHRoZSBtZWRpYUtleXMgYXJlIGNyZWF0ZWQgYmVm b3JlIGxvYWRpbmcgdGhlIG1lZGlhIGluIGRlYnVnIGNvbmYKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTI0NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBmdW5jdGlvbiAiTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyQmFzZTo6Y2RtSW5zdGFuY2VBdHRhY2hlZCIgaXMgZXhwZWN0ZWQgdG8gYmUg Y2FsbGVkIG9uY2UsCisgICAgICAgIHNvIHRoZXJlIGlzIGFuIEFTU0VSVCghbV9jZG1JbnN0YW5j ZSkuCisgICAgICAgIEJ1dCB3aGVuIHRoZSBNZWRpYUtleXMgYXJlIGNyZWF0ZWQgYmVmb3JlIGxv YWRpbmcgdGhlIG1lZGlhLCB0aGUgY2RtaW5zdGFuY2UgaXMgY3JlYXRlZCBhbmQgYXR0YWNoZWQK KyAgICAgICAgdG8gdGhlIE1lZGlhUGxheWVyUHJpdmF0ZSB2aWEgIk1lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lckJhc2U6OmNkbUluc3RhbmNlQXR0YWNoZWQiIGJlZm9yZSBsb2FkaW5nCisgICAg ICAgIHRoZSBtZWRpYSwgdGhlbiB3aGVuIHRoZSBtZWRpYSBpcyBsb2FkaW5nLCB0aGUgZnVuY3Rp b24gIk1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmNkbUluc3RhbmNlQXR0YWNoZWQi CisgICAgICAgIHdpbGwgYmUgY2FsbGVkIHNldmVyYWwgdGltZXMgdmlhIHRoZSBmdW5jdGlvbiAi bWVkaWFFbmdpbmVXYXNVcGRhdGVkIiB3aWNoIGlzIGNhbGxlZCBmb3IgZWFjaCBjaGFuZ2UKKyAg ICAgICAgaW4gdGhlIE1lZGlhRWxlbWVudCBzdGF0ZSwgdGh1cyB0aGUgV2ViUHJvY2VzcyBjcmFz aGVzIGluIHRoZSBBU1NFUlQoIW1fY2RtSW5zdGFuY2UpLgorCisgICAgICAgIFRoaXMgY29tbWl0 IGF2b2lkIHRoZSBjcmFzaCBieSByZXBsYWNpbmcgdGhlIGFzc2VydCB3aXRoIGEgc2ltcGxlIGNo ZWNrLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyQmFzZTo6Y2RtSW5zdGFuY2VBdHRhY2hlZCk6CisgICAgICAgIChXZWJD b3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjZG1JbnN0YW5jZURldGFjaGVk KToKKwogMjAxOC0wNS0wMyAgWWFjaW5lIEJhbmRvdSAgPHlhY2luZS5iYW5kb3VfZXh0QHNvZnRh dGhvbWUuY29tPgogCiAgICAgICAgIFtNU0VdW0dTdHJlYW1lcl0gRGVsZXRlIHByb3Blcmx5IHRo ZSBzdHJlYW0gZnJvbSB0aGUgV2ViS2l0TWVkaWFTb3VyY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXJCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAppbmRleCAxNTU3NDc1ZTk1ZmI2 ODMyMTA1YmE4ZDc5MzhjYTI0ODZhOTBhNGZkLi4yZTg3Njc2Y2JjZDMzNzljYzdiNTlmZWZmZDAy MjJhYjlhYzRlODFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lckJhc2UuY3BwCkBAIC0xMjA3LDEwICsxMjA3LDExIEBAIHVuc2lnbmVkIE1lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OnZpZGVvRGVjb2RlZEJ5dGVDb3VudCgpIGNvbnN0 CiAjaWYgRU5BQkxFKEVOQ1JZUFRFRF9NRURJQSkKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyQmFzZTo6Y2RtSW5zdGFuY2VBdHRhY2hlZChDRE1JbnN0YW5jZSYgaW5zdGFuY2UpCiB7 Ci0gICAgQVNTRVJUKCFtX2NkbUluc3RhbmNlKTsKLSAgICBtX2NkbUluc3RhbmNlID0gJmluc3Rh bmNlOwotICAgIEdTVF9ERUJVR19PQkpFQ1QocGlwZWxpbmUoKSwgIkNETSBpbnN0YW5jZSAlcCBz ZXQiLCBtX2NkbUluc3RhbmNlLmdldCgpKTsKLSAgICBtX3Byb3RlY3Rpb25Db25kaXRpb24ubm90 aWZ5QWxsKCk7CisgICAgaWYgKG1fY2RtSW5zdGFuY2UgIT0gJmluc3RhbmNlKSB7CisgICAgICAg IG1fY2RtSW5zdGFuY2UgPSAmaW5zdGFuY2U7CisgICAgICAgIEdTVF9ERUJVR19PQkpFQ1QocGlw ZWxpbmUoKSwgIkNETSBpbnN0YW5jZSAlcCBzZXQiLCBtX2NkbUluc3RhbmNlLmdldCgpKTsKKyAg ICAgICAgbV9wcm90ZWN0aW9uQ29uZGl0aW9uLm5vdGlmeUFsbCgpOworICAgIH0KIH0KIAogdm9p ZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjZG1JbnN0YW5jZURldGFjaGVkKENE TUluc3RhbmNlJiBpbnN0YW5jZSkKQEAgLTEyMTgsMTAgKzEyMTksMTEgQEAgdm9pZCBNZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjZG1JbnN0YW5jZURldGFjaGVkKENETUluc3RhbmNl JiBpbnN0YW5jZSkKICNpZmRlZiBOREVCVUcKICAgICBVTlVTRURfUEFSQU0oaW5zdGFuY2UpOwog I2VuZGlmCi0gICAgQVNTRVJUKG1fY2RtSW5zdGFuY2UuZ2V0KCkgPT0gJmluc3RhbmNlKTsKLSAg ICBHU1RfREVCVUdfT0JKRUNUKHBpcGVsaW5lKCksICJkZXRhY2hpbmcgQ0RNIGluc3RhbmNlICVw IiwgbV9jZG1JbnN0YW5jZS5nZXQoKSk7Ci0gICAgbV9jZG1JbnN0YW5jZSA9IG51bGxwdHI7Ci0g ICAgbV9wcm90ZWN0aW9uQ29uZGl0aW9uLm5vdGlmeUFsbCgpOworICAgIGlmIChtX2NkbUluc3Rh bmNlID09ICZpbnN0YW5jZSkgeworICAgICAgICBHU1RfREVCVUdfT0JKRUNUKHBpcGVsaW5lKCks ICJkZXRhY2hpbmcgQ0RNIGluc3RhbmNlICVwIiwgbV9jZG1JbnN0YW5jZS5nZXQoKSk7CisgICAg ICAgIG1fY2RtSW5zdGFuY2UgPSBudWxscHRyOworICAgICAgICBtX3Byb3RlY3Rpb25Db25kaXRp b24ubm90aWZ5QWxsKCk7CisgICAgfQogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lckJhc2U6OmF0dGVtcHRUb0RlY3J5cHRXaXRoSW5zdGFuY2UoQ0RNSW5zdGFuY2UmIGluc3Rh bmNlKQo=