185227 2018-05-02 16:47:37 -0700 Remove superfluous check for a null attribute value check in Element::removeAttributeInternal 2018-05-02 20:41:25 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa cdumez cmarcelo dbates esprehn+autocc ews-watchlist kangil.han koivisto webkit-bug-importer zalan oldest_to_newest 1419924 0 rniwa 2018-05-02 16:47:37 -0700 Element::removeAttributeInternal has a check for valueBeingRemoved.isNull() before calling willModifyAttribute. But this is impossible because attribute value is always empty string or a string of at least length 1. 1419928 1 339365 rniwa 2018-05-02 16:59:17 -0700 Created attachment 339365 Removes the code 1420002 2 rniwa 2018-05-02 20:40:31 -0700 Committed r231294: <https://trac.webkit.org/changeset/231294> 1420003 3 webkit-bug-importer 2018-05-02 20:41:25 -0700 <rdar://problem/39930646> 339365 2018-05-02 16:59:17 -0700 2018-05-02 18:33:22 -0700 Removes the code bug-185227-20180502165917.patch text/plain 1409 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMTI4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA1LTAyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBzdXBlcmZsdW91cyBj aGVjayBmb3IgYSBudWxsIGF0dHJpYnV0ZSB2YWx1ZSBjaGVjayBpbiBFbGVtZW50OjpyZW1vdmVB dHRyaWJ1dGVJbnRlcm5hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg1MjI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVtb3ZlZCB0aGUgY2hlY2suIFRoZSBhdHRyaWJ1dGUgdmFsdWUgc3RyaW5nIGNh biBuZXZlciBiZSBudWxsLgorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RWxlbWVudDo6cmVtb3ZlQXR0cmlidXRlSW50ZXJuYWwpOgorCiAyMDE4LTA1LTAy ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAgICAgICBDYW4ndCBj b3B5IGFuZCBwYXN0ZSBVUkxzIHRoYXQgaGF2ZSBubyB0aXRsZSBpbnRvIE1haWwgKG1hY09TKQpJ bmRleDogU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gMjMxMjY2KQorKysgU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzYzLDkgKzIzNjMsOCBA QCB2b2lkIEVsZW1lbnQ6OnJlbW92ZUF0dHJpYnV0ZUludGVybmFsKHVuCiAgICAgICAgIHJldHVy bjsKICAgICB9CiAKLSAgICBpZiAoIXZhbHVlQmVpbmdSZW1vdmVkLmlzTnVsbCgpKQotICAgICAg ICB3aWxsTW9kaWZ5QXR0cmlidXRlKG5hbWUsIHZhbHVlQmVpbmdSZW1vdmVkLCBudWxsQXRvbSgp KTsKLQorICAgIEFTU0VSVCghdmFsdWVCZWluZ1JlbW92ZWQuaXNOdWxsKCkpOworICAgIHdpbGxN b2RpZnlBdHRyaWJ1dGUobmFtZSwgdmFsdWVCZWluZ1JlbW92ZWQsIG51bGxBdG9tKCkpOwogICAg IHsKICAgICAgICAgU3R5bGU6OkF0dHJpYnV0ZUNoYW5nZUludmFsaWRhdGlvbiBzdHlsZUludmFs aWRhdGlvbigqdGhpcywgbmFtZSwgdmFsdWVCZWluZ1JlbW92ZWQsIG51bGxBdG9tKCkpOwogICAg ICAgICBlbGVtZW50RGF0YS5yZW1vdmVBdHRyaWJ1dGUoaW5kZXgpOwo=