185213 2018-05-02 13:29:22 -0700 JSC should know how to cache custom getter accesses on the prototype chain 2018-05-02 17:38:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1419820 0 fpizlo 2018-05-02 13:29:22 -0700 Patch forthcoming. 1419821 1 339330 fpizlo 2018-05-02 13:31:06 -0700 Created attachment 339330 the patch 1419837 2 339334 fpizlo 2018-05-02 13:59:51 -0700 Created attachment 339334 the patch 1419847 3 339334 keith_miller 2018-05-02 14:16:10 -0700 Comment on attachment 339334 the patch r=me. 1419948 4 fpizlo 2018-05-02 17:37:49 -0700 Landed in https://trac.webkit.org/changeset/231283/webkit 1419949 5 webkit-bug-importer 2018-05-02 17:38:25 -0700 <rdar://problem/39926845> 339330 2018-05-02 13:31:06 -0700 2018-05-02 13:59:51 -0700 the patch blah.patch text/plain 3250 fpizlo SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzEyNTgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA1LTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgSlNDIHNob3VsZCBrbm93IGhvdyB0byBjYWNoZSBjdXN0b20gZ2V0dGVy IGFjY2Vzc2VzIG9uIHRoZSBwcm90b3R5cGUgY2hhaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTIxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWljcm9iZW5jaG1hcmtzL2dldC1jdXN0b20tZ2V0 dGVyLmpzOiBBZGRlZC4KKyAgICAgICAgKHRlc3QpOgorCiAyMDE4LTA1LTAyICBSb2JpbiBNb3Jp c3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CiAKICAgICAgICAgZW1pdENvZGVUb0dldEFyZ3Vt ZW50c0FycmF5TGVuZ3RoIHNob3VsZCBub3QgY3Jhc2ggb24gUGhhbnRvbU5ld0FycmF5V2l0aFNw cmVhZApJbmRleDogSlNUZXN0cy9taWNyb2JlbmNobWFya3MvZ2V0LWN1c3RvbS1nZXR0ZXIuanMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSlNUZXN0cy9taWNyb2JlbmNobWFya3MvZ2V0LWN1c3RvbS1nZXR0ZXIu anMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9taWNyb2JlbmNobWFya3MvZ2V0LWN1c3RvbS1n ZXR0ZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyMSBAQAorLy8gUmVnRXhwLmlucHV0 IGlzIGEgaGFuZHkgc2V0dGVyCisKK3ZhciBvID0gUmVnRXhwOworby5pbnB1dCA9ICJmb28iOwor CitmdW5jdGlvbiB0ZXN0KG8pIHsKKyAgICB2YXIgcmVzdWx0ID0gbnVsbDsKKyAgICBmb3IgKHZh ciBpID0gMDsgaSA8IDMwMDAwOyBpKyspCisgICAgICAgIHJlc3VsdCA9IG8uaW5wdXQ7CisKKyAg ICByZXR1cm4gcmVzdWx0OworfQorCitmb3IgKHZhciBrID0gMDsgayA8IDk7IGsrKykgeworICAg IHZhciBuZXdSZXN1bHQgPSB0ZXN0KG8pCisgICAgaWYgKG5ld1Jlc3VsdCAhPSAiZm9vIikKKyAg ICAgICAgdGhyb3cgIkZhaWxlZCBhdCAiICsgayArICIgd2l0aCAiICtuZXdSZXN1bHQ7CisgICAg cmVzdWx0ID0gbmV3UmVzdWx0OyAKKyAgICBvID0ge19fcHJvdG9fXyA6IG8gfQorfQorCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMTI1OCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAx OC0wNS0wMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgorCisgICAgICAgIEpTQyBz aG91bGQga25vdyBob3cgdG8gY2FjaGUgY3VzdG9tIGdldHRlciBhY2Nlc3NlcyBvbiB0aGUgcHJv dG90eXBlIGNoYWluCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODUyMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIHdhcyBhIHNpbXBsZSBmaXggYWZ0ZXIgdGhlIHdvcmsgSSBkaWQgZm9yIGJ1ZyAx ODUxNzQuID40eCBzcGVlZC11cCBvbiB0aGUgbmV3IGdldC1jdXN0b20tZ2V0dGVyLmpzIHRlc3Qu CisKKyAgICAgICAgKiBqaXQvUmVwYXRjaC5jcHA6CisgICAgICAgIChKU0M6OnRyeUNhY2hlR2V0 QnlJRCk6CisKIDIwMTgtMDUtMDEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAog ICAgICAgICBKU0Mgc2hvdWxkIGJlIGFibGUgdG8gY2FjaGUgY3VzdG9tIHNldHRlciBjYWxscyBv biB0aGUgcHJvdG90eXBlIGNoYWluCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1Jl cGF0Y2guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVwYXRj aC5jcHAJKHJldmlzaW9uIDIzMTI1MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVw YXRjaC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwNCwxMCArMzA0LDE0IEBAIHN0YXRpYyBJbmxp bmVDYWNoZUFjdGlvbiB0cnlDYWNoZUdldEJ5SUQKICAgICAgICAgICAgICAgICAgICAgICAgIGlm IChzbG90LmlzVW5zZXQoKSkgewogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbmRpdGlv blNldCA9IGdlbmVyYXRlQ29uZGl0aW9uc0ZvclByb3BlcnR5TWlzcygKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdm0sIGNvZGVCbG9jaywgZXhlYywgc3RydWN0dXJlLCBwcm9wZXJ0 eU5hbWUuaW1wbCgpKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAg ICAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKCFzbG90LmlzQ2FjaGVhYmxlQ3VzdG9tKCkpIHsK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25kaXRpb25TZXQgPSBnZW5lcmF0ZUNvbmRp dGlvbnNGb3JQcm90b3R5cGVQcm9wZXJ0eUhpdCgKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdm0sIGNvZGVCbG9jaywgZXhlYywgc3RydWN0dXJlLCBzbG90LnNsb3RCYXNlKCksCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHByb3BlcnR5TmFtZS5pbXBsKCkpOworICAg ICAgICAgICAgICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjb25kaXRpb25TZXQgPSBnZW5lcmF0ZUNvbmRpdGlvbnNGb3JQcm90b3R5cGVQcm9wZXJ0eUhp dEN1c3RvbSgKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdm0sIGNvZGVCbG9jaywg ZXhlYywgc3RydWN0dXJlLCBzbG90LnNsb3RCYXNlKCksCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHByb3BlcnR5TmFtZS5pbXBsKCkpOwogICAgICAgICAgICAgICAgICAgICAgICAg fQogCiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoIWNvbmRpdGlvblNldC5pc1ZhbGlkKCkp Cg== 339334 2018-05-02 13:59:51 -0700 2018-05-02 14:16:10 -0700 the patch blah.patch text/plain 3578 fpizlo SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzEyNTgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA1LTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgSlNDIHNob3VsZCBrbm93IGhvdyB0byBjYWNoZSBjdXN0b20gZ2V0dGVy IGFjY2Vzc2VzIG9uIHRoZSBwcm90b3R5cGUgY2hhaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTIxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWljcm9iZW5jaG1hcmtzL2dldC1jdXN0b20tZ2V0 dGVyLmpzOiBBZGRlZC4KKyAgICAgICAgKHRlc3QpOgorCiAyMDE4LTA1LTAyICBSb2JpbiBNb3Jp c3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CiAKICAgICAgICAgZW1pdENvZGVUb0dldEFyZ3Vt ZW50c0FycmF5TGVuZ3RoIHNob3VsZCBub3QgY3Jhc2ggb24gUGhhbnRvbU5ld0FycmF5V2l0aFNw cmVhZApJbmRleDogSlNUZXN0cy9taWNyb2JlbmNobWFya3MvZ2V0LWN1c3RvbS1nZXR0ZXIuanMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSlNUZXN0cy9taWNyb2JlbmNobWFya3MvZ2V0LWN1c3RvbS1nZXR0ZXIu anMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9taWNyb2JlbmNobWFya3MvZ2V0LWN1c3RvbS1n ZXR0ZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyMSBAQAorLy8gUmVnRXhwLmlucHV0 IGlzIGEgaGFuZHkgZ2V0dGVyCisKK3ZhciBvID0gUmVnRXhwOworby5pbnB1dCA9ICJmb28iOwor CitmdW5jdGlvbiB0ZXN0KG8pIHsKKyAgICB2YXIgcmVzdWx0ID0gbnVsbDsKKyAgICBmb3IgKHZh ciBpID0gMDsgaSA8IDMwMDAwOyBpKyspCisgICAgICAgIHJlc3VsdCA9IG8uaW5wdXQ7CisKKyAg ICByZXR1cm4gcmVzdWx0OworfQorCitmb3IgKHZhciBrID0gMDsgayA8IDk7IGsrKykgeworICAg IHZhciBuZXdSZXN1bHQgPSB0ZXN0KG8pCisgICAgaWYgKG5ld1Jlc3VsdCAhPSAiZm9vIikKKyAg ICAgICAgdGhyb3cgIkZhaWxlZCBhdCAiICsgayArICIgd2l0aCAiICtuZXdSZXN1bHQ7CisgICAg cmVzdWx0ID0gbmV3UmVzdWx0OyAKKyAgICBvID0ge19fcHJvdG9fXyA6IG8gfQorfQorCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMTI1OCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAx OC0wNS0wMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgorCisgICAgICAgIEpTQyBz aG91bGQga25vdyBob3cgdG8gY2FjaGUgY3VzdG9tIGdldHRlciBhY2Nlc3NlcyBvbiB0aGUgcHJv dG90eXBlIGNoYWluCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODUyMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIHdhcyBhIHNpbXBsZSBmaXggYWZ0ZXIgdGhlIHdvcmsgSSBkaWQgZm9yIGJ1ZyAx ODUxNzQuID40eCBzcGVlZC11cCBvbiB0aGUgbmV3IGdldC1jdXN0b20tZ2V0dGVyLmpzIHRlc3Qu CisKKyAgICAgICAgKiBqaXQvUmVwYXRjaC5jcHA6CisgICAgICAgIChKU0M6OnRyeUNhY2hlR2V0 QnlJRCk6CisKIDIwMTgtMDUtMDEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAog ICAgICAgICBKU0Mgc2hvdWxkIGJlIGFibGUgdG8gY2FjaGUgY3VzdG9tIHNldHRlciBjYWxscyBv biB0aGUgcHJvdG90eXBlIGNoYWluCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1Jl cGF0Y2guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVwYXRj aC5jcHAJKHJldmlzaW9uIDIzMTI1MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVw YXRjaC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwMSwxMyArMzAxLDE5IEBAIHN0YXRpYyBJbmxp bmVDYWNoZUFjdGlvbiB0cnlDYWNoZUdldEJ5SUQKICAgICAgICAgICAgICAgICAgICAgICAgIC8v IFdlIHVzZSBPYmplY3RQcm9wZXJ0eUNvbmRpdGlvblNldCBpbnN0ZWFkIGZvciBmYXN0ZXIgYWNj ZXNzZXMuCiAgICAgICAgICAgICAgICAgICAgICAgICBwcm90b3R5cGVBY2Nlc3NDaGFpbiA9IG51 bGxwdHI7CiAKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBNYXliZSB0aGlzIGBp ZmAgc2hvdWxkIGJlIGluc2lkZSBnZW5lcmF0ZUNvbmRpdGlvbnNGb3JQcm9wZXJ0eUJsYWguCisg ICAgICAgICAgICAgICAgICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg1MjE1CiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoc2xvdC5pc1Vuc2V0 KCkpIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25kaXRpb25TZXQgPSBnZW5lcmF0 ZUNvbmRpdGlvbnNGb3JQcm9wZXJ0eU1pc3MoCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHZtLCBjb2RlQmxvY2ssIGV4ZWMsIHN0cnVjdHVyZSwgcHJvcGVydHlOYW1lLmltcGwoKSk7 Ci0gICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgICAgICAg ICAgfSBlbHNlIGlmICghc2xvdC5pc0NhY2hlYWJsZUN1c3RvbSgpKSB7CiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY29uZGl0aW9uU2V0ID0gZ2VuZXJhdGVDb25kaXRpb25zRm9yUHJvdG90 eXBlUHJvcGVydHlIaXQoCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZtLCBjb2Rl QmxvY2ssIGV4ZWMsIHN0cnVjdHVyZSwgc2xvdC5zbG90QmFzZSgpLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBwcm9wZXJ0eU5hbWUuaW1wbCgpKTsKKyAgICAgICAgICAgICAgICAg ICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uZGl0aW9uU2V0 ID0gZ2VuZXJhdGVDb25kaXRpb25zRm9yUHJvdG90eXBlUHJvcGVydHlIaXRDdXN0b20oCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZtLCBjb2RlQmxvY2ssIGV4ZWMsIHN0cnVjdHVy ZSwgc2xvdC5zbG90QmFzZSgpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcm9w ZXJ0eU5hbWUuaW1wbCgpKTsKICAgICAgICAgICAgICAgICAgICAgICAgIH0KIAogICAgICAgICAg ICAgICAgICAgICAgICAgaWYgKCFjb25kaXRpb25TZXQuaXNWYWxpZCgpKQo=