185188 2018-05-02 00:51:32 -0700 [JSC] Add MacroAssembler::and16 and store16 2018-05-02 17:54:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist jfbastien keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1419594 0 ysuzuki 2018-05-02 00:51:32 -0700 [JSC] Add MacroAssembler::and16 1419597 1 339289 ysuzuki 2018-05-02 01:05:03 -0700 Created attachment 339289 Patch 1419698 2 339289 mark.lam 2018-05-02 09:55:39 -0700 Comment on attachment 339289 Patch Sorry, I didn't see this patch before I reviewed and r+'ed https://bugs.webkit.org/show_bug.cgi?id=185196 and https://bugs.webkit.org/show_bug.cgi?id=185195. r+ anyway for Source/JavaScriptCore/assembler/MacroAssemblerARM.h part. You'll probably have to remove the ARMv7 and MIPS parts to resolve a conflict before landing. 1419960 3 ysuzuki 2018-05-02 17:51:54 -0700 (In reply to Mark Lam from comment #2) > Comment on attachment 339289 [details] > Patch > > Sorry, I didn't see this patch before I reviewed and r+'ed > https://bugs.webkit.org/show_bug.cgi?id=185196 and > https://bugs.webkit.org/show_bug.cgi?id=185195. > > r+ anyway for Source/JavaScriptCore/assembler/MacroAssemblerARM.h part. > You'll probably have to remove the ARMv7 and MIPS parts to resolve a > conflict before landing. OK, I'll land ARM traditional part. 1419962 4 ysuzuki 2018-05-02 17:53:46 -0700 Committed r231289: <https://trac.webkit.org/changeset/231289> 1419963 5 webkit-bug-importer 2018-05-02 17:54:21 -0700 <rdar://problem/39927259> 339289 2018-05-02 01:05:03 -0700 2018-05-02 09:55:39 -0700 Patch bug-185188-20180502170502.patch text/plain 5250 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 YTExNjI3NDFhNGVhMDcyMTk5M2FjMmE0ZmNiMzAwYjk5MTBiNjNlLi4yOGNmZGEyMDYzMjE4YWVl NTgzYWY1MTUwNzQzYzQwZmRkOGNlOGNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxOC0wNS0wMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBBZGQgTWFjcm9Bc3NlbWJsZXI6OmFuZDE2IGFuZCBzdG9y ZTE2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODUx ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjMx MTI5IHJlcXVpcmVzIGFuZDE2KEltcGxpY2l0QWRkcmVzcywgUmVnaXN0ZXJJRCkgYW5kIHN0b3Jl MTYoUmVnaXN0ZXJJRCwgSW1wbGljaXRBZGRyZXNzKSBpbXBsZW1lbnRhdGlvbnMuCisgICAgICAg IEJ1dCBvbmx5IEFSTTY0IGFuZCBYODYgZmFtaWxpZXMgaGF2ZSB0aGVtLiBUaGlzIHBhdGNoIGFk ZHMgdGhlc2UgbWV0aG9kcyBmb3IgQVJNLCBBUk12NywgYW5kIE1JUFMuCisKKyAgICAgICAgKiBh c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJs ZXJBUk06OmFuZDE2KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OnN0b3JlMTYp OgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3Lmg6CisgICAgICAgIChK U0M6Ok1hY3JvQXNzZW1ibGVyQVJNdjc6OmFuZDE2KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3Nl bWJsZXJBUk12Nzo6c3RvcmUxNik6CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy TUlQUy5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlck1JUFM6OmFuZDE2KToKKyAgICAg ICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjpzdG9yZTE2KToKKwogMjAxOC0wNS0wMSAgWXVz dWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbSlNDXSBBZGQg U2FtZVZhbHVlIERGRyBub2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1i bGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKaW5kZXggZTE0NGFjNGVjNzJlMjI3ZDA3MDA1NzBjODlk OTNmYzhhZWNkNTg1ZS4uMjY2YTgxOGY1NzA5NDNiNGNkOWZmNWQzZTBjY2YyZWUyYTZhOTAxOCAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxl ckFSTS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJBUk0uaApAQCAtMTc2LDYgKzE3NiwxMiBAQCBjbGFzcyBNYWNyb0Fzc2VtYmxlckFSTSA6IHB1 YmxpYyBBYnN0cmFjdE1hY3JvQXNzZW1ibGVyPEFzc2VtYmxlcj4gewogICAgICAgICBhbmQzMihk YXRhVGVtcFJlZ2lzdGVyLCBkZXN0KTsKICAgICB9CiAKKyAgICB2b2lkIGFuZDE2KEFkZHJlc3Mg c3JjLCBSZWdpc3RlcklEIGRlc3QpCisgICAgeworICAgICAgICBsb2FkMTYoc3JjLCBkYXRhVGVt cFJlZ2lzdGVyKTsKKyAgICAgICAgYW5kMzIoZGF0YVRlbXBSZWdpc3RlciwgZGVzdCk7CisgICAg fQorCiAgICAgdm9pZCBsc2hpZnQzMihSZWdpc3RlcklEIHNoaWZ0QW1vdW50LCBSZWdpc3RlcklE IGRlc3QpCiAgICAgewogICAgICAgICBsc2hpZnQzMihkZXN0LCBzaGlmdEFtb3VudCwgZGVzdCk7 CkBAIC01NjMsNiArNTY5LDExIEBAIGNsYXNzIE1hY3JvQXNzZW1ibGVyQVJNIDogcHVibGljIEFi c3RyYWN0TWFjcm9Bc3NlbWJsZXI8QXNzZW1ibGVyPiB7CiAgICAgICAgIG1fYXNzZW1ibGVyLmJh c2VJbmRleFRyYW5zZmVyMTYoQVJNQXNzZW1ibGVyOjpTdG9yZVVpbnQxNiwgc3JjLCBhZGRyZXNz LmJhc2UsIGFkZHJlc3MuaW5kZXgsIHN0YXRpY19jYXN0PGludD4oYWRkcmVzcy5zY2FsZSksIGFk ZHJlc3Mub2Zmc2V0KTsKICAgICB9CiAKKyAgICB2b2lkIHN0b3JlMTYoUmVnaXN0ZXJJRCBzcmMs IEltcGxpY2l0QWRkcmVzcyBhZGRyZXNzKQorICAgIHsKKyAgICAgICAgbV9hc3NlbWJsZXIuZGF0 YVRyYW5zZmVyMTYoQVJNQXNzZW1ibGVyOjpTdG9yZVVpbnQxNiwgc3JjLCBhZGRyZXNzLmJhc2Us IGFkZHJlc3Mub2Zmc2V0KTsKKyAgICB9CisKICAgICB2b2lkIHN0b3JlMzIoUmVnaXN0ZXJJRCBz cmMsIEltcGxpY2l0QWRkcmVzcyBhZGRyZXNzKQogICAgIHsKICAgICAgICAgbV9hc3NlbWJsZXIu ZGF0YVRyYW5zZmVyMzIoQVJNQXNzZW1ibGVyOjpTdG9yZVVpbnQzMiwgc3JjLCBhZGRyZXNzLmJh c2UsIGFkZHJlc3Mub2Zmc2V0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3LmgKaW5kZXggY2QxMDQ1OTBjNDk5ZjFkOTM0MjMy MmU0MjM5YzU3MmFhZWFmNmU0Yy4uM2Q0MTc4M2Y3YWM3NWUyN2M0NjM1NzA3MTYxMjI4NWY3YTI1 NjBlMSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlckFSTXY3LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlckFSTXY3LmgKQEAgLTI5OSw2ICsyOTksMTIgQEAgY2xhc3MgTWFjcm9Bc3NlbWJs ZXJBUk12NyA6IHB1YmxpYyBBYnN0cmFjdE1hY3JvQXNzZW1ibGVyPEFzc2VtYmxlcj4gewogICAg ICAgICBhbmQzMihkYXRhVGVtcFJlZ2lzdGVyLCBkZXN0KTsKICAgICB9CiAKKyAgICB2b2lkIGFu ZDE2KEFkZHJlc3Mgc3JjLCBSZWdpc3RlcklEIGRlc3QpCisgICAgeworICAgICAgICBsb2FkMTYo c3JjLCBkYXRhVGVtcFJlZ2lzdGVyKTsKKyAgICAgICAgYW5kMzIoZGF0YVRlbXBSZWdpc3Rlciwg ZGVzdCk7CisgICAgfQorCiAgICAgdm9pZCBjb3VudExlYWRpbmdaZXJvczMyKFJlZ2lzdGVySUQg c3JjLCBSZWdpc3RlcklEIGRlc3QpCiAgICAgewogICAgICAgICBtX2Fzc2VtYmxlci5jbHooZGVz dCwgc3JjKTsKQEAgLTg2OCw2ICs4NzQsMTEgQEAgY2xhc3MgTWFjcm9Bc3NlbWJsZXJBUk12NyA6 IHB1YmxpYyBBYnN0cmFjdE1hY3JvQXNzZW1ibGVyPEFzc2VtYmxlcj4gewogICAgICAgICBtb3Zl KGltbTgsIGRhdGFUZW1wUmVnaXN0ZXIpOwogICAgICAgICBzdG9yZTgoZGF0YVRlbXBSZWdpc3Rl ciwgYWRkcmVzcyk7CiAgICAgfQorCisgICAgdm9pZCBzdG9yZTE2KFJlZ2lzdGVySUQgc3JjLCBJ bXBsaWNpdEFkZHJlc3MgYWRkcmVzcykKKyAgICB7CisgICAgICAgIHN0b3JlMTYoc3JjLCBzZXR1 cEFybUFkZHJlc3MoYWRkcmVzcykpOworICAgIH0KICAgICAKICAgICB2b2lkIHN0b3JlMTYoUmVn aXN0ZXJJRCBzcmMsIEJhc2VJbmRleCBhZGRyZXNzKQogICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmggYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCmluZGV4IDUyNGU1 NTBjMjg5YzgzMTAxMWZjMjA3ZDc1NDMwOWM0MjBiMGI3YmIuLjAxNDJmOTA0NTg0MmUzYmIwOGI2 MTg2YzU5NDZmZDU2NGJjNTMxZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaApAQCAtMzYyLDYgKzM2MiwxMiBAQCBjbGFz cyBNYWNyb0Fzc2VtYmxlck1JUFMgOiBwdWJsaWMgQWJzdHJhY3RNYWNyb0Fzc2VtYmxlcjxBc3Nl bWJsZXI+IHsKICAgICAgICAgfQogICAgIH0KIAorICAgIHZvaWQgYW5kMTYoQWRkcmVzcyBzcmMs IFJlZ2lzdGVySUQgZGVzdCkKKyAgICB7CisgICAgICAgIGxvYWQxNihzcmMsIGRhdGFUZW1wUmVn aXN0ZXIpOworICAgICAgICBhbmQzMihkYXRhVGVtcFJlZ2lzdGVyLCBkZXN0KTsKKyAgICB9CisK ICAgICB2b2lkIGNvdW50TGVhZGluZ1plcm9zMzIoUmVnaXN0ZXJJRCBzcmMsIFJlZ2lzdGVySUQg ZGVzdCkKICAgICB7CiAjaWYgV1RGX01JUFNfSVNBX0FUX0xFQVNUKDMyKQpAQCAtMTM1OSw2ICsx MzY1LDIzIEBAIGNsYXNzIE1hY3JvQXNzZW1ibGVyTUlQUyA6IHB1YmxpYyBBYnN0cmFjdE1hY3Jv QXNzZW1ibGVyPEFzc2VtYmxlcj4gewogICAgICAgICB9CiAgICAgfQogCisgICAgdm9pZCBzdG9y ZTE2KFJlZ2lzdGVySUQgc3JjLCBJbXBsaWNpdEFkZHJlc3MgYWRkcmVzcykKKyAgICB7CisgICAg ICAgIGlmIChhZGRyZXNzLm9mZnNldCA+PSAtMzI3NjggJiYgYWRkcmVzcy5vZmZzZXQgPD0gMzI3 NjcKKyAgICAgICAgICAgICYmICFtX2ZpeGVkV2lkdGgpCisgICAgICAgICAgICBtX2Fzc2VtYmxl ci5zaChzcmMsIGFkZHJlc3MuYmFzZSwgYWRkcmVzcy5vZmZzZXQpOworICAgICAgICBlbHNlIHsK KyAgICAgICAgICAgIC8qCisgICAgICAgICAgICAgICAgbHVpICAgICBhZGRyVGVtcCwgKG9mZnNl dCArIDB4ODAwMCkgPj4gMTYKKyAgICAgICAgICAgICAgICBhZGR1ICAgIGFkZHJUZW1wLCBhZGRy VGVtcCwgYmFzZQorICAgICAgICAgICAgICAgIHNoICAgICAgc3JjLCAob2Zmc2V0ICYgMHhmZmZm KShhZGRyVGVtcCkKKyAgICAgICAgICAgICAgKi8KKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmx1 aShhZGRyVGVtcFJlZ2lzdGVyLCAoYWRkcmVzcy5vZmZzZXQgKyAweDgwMDApID4+IDE2KTsKKyAg ICAgICAgICAgIG1fYXNzZW1ibGVyLmFkZHUoYWRkclRlbXBSZWdpc3RlciwgYWRkclRlbXBSZWdp c3RlciwgYWRkcmVzcy5iYXNlKTsKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLnNoKHNyYywgYWRk clRlbXBSZWdpc3RlciwgYWRkcmVzcy5vZmZzZXQpOworICAgICAgICB9CisgICAgfQorCiAgICAg dm9pZCBzdG9yZTE2KFJlZ2lzdGVySUQgc3JjLCBCYXNlSW5kZXggYWRkcmVzcykKICAgICB7CiAg ICAgICAgIGlmIChhZGRyZXNzLm9mZnNldCA+PSAtMzI3NjggJiYgYWRkcmVzcy5vZmZzZXQgPD0g MzI3NjcK