185181 2018-05-01 19:50:29 -0700 Add release assertions in CFNetwork's SocketStreamHandleImpl to help debug a threading issue 2018-05-01 20:35:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 185073 1 cdumez cdumez ap commit-queue ggaren rniwa webkit-bug-importer oldest_to_newest 1419519 0 cdumez 2018-05-01 19:50:29 -0700 Add release assertions in CFNetwork's SocketStreamHandleImpl to help debug a threading issue on iOS WebKitLegacy (Bug 185073). 1419520 1 339260 cdumez 2018-05-01 19:52:50 -0700 Created attachment 339260 Patch 1419521 2 339260 ggaren 2018-05-01 19:54:41 -0700 Comment on attachment 339260 Patch r=me 1419533 3 339260 commit-queue 2018-05-01 20:34:00 -0700 Comment on attachment 339260 Patch Clearing flags on attachment: 339260 Committed r231221: <https://trac.webkit.org/changeset/231221> 1419534 4 commit-queue 2018-05-01 20:34:02 -0700 All reviewed patches have been landed. Closing bug. 1419535 5 webkit-bug-importer 2018-05-01 20:35:20 -0700 <rdar://problem/39890066> 339260 2018-05-01 19:52:50 -0700 2018-05-01 20:34:00 -0700 Patch bug-185181-20180501195249.patch text/plain 2518 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE1YWI3MzQzMGJlOTk4 MmNlYzNhZGY1ZWZiZTllNDBjNDVkZDgxNi4uZDQ5ZTI5NWJjNzVlMzgyZTc0NjExMTQ4YzAzNmNk ODVkZGFjNmUyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA1LTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHJlbGVhc2UgYXNzZXJ0 aW9ucyBpbiBDRk5ldHdvcmsncyBTb2NrZXRTdHJlYW1IYW5kbGVJbXBsIHRvIGhlbHAgZGVidWcg YSB0aHJlYWRpbmcgaXNzdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NTE4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCByZWxlYXNlIGFzc2VydGlvbnMgaW4gQ0ZOZXR3b3JrJ3MgU29ja2V0U3Ry ZWFtSGFuZGxlSW1wbCB0byBoZWxwIGRlYnVnIGEgdGhyZWFkaW5nIGlzc3VlCisgICAgICAgIG9u IGlPUyBXZWJLaXRMZWdhY3kgKEJ1ZyAxODUwNzMpLiBJdCBhcHBlYXJzIHJlYWRTdHJlYW1DYWxs YmFjaygpIGNhbiBnZXQgY2FsbGVkIG9uIHRoZSBVSVRocmVhZCwKKyAgICAgICAgd2hpY2ggc2hv dWxkIG5vdCBiZSBwb3NzaWJsZSBpZiBzY2hlZHVsZVN0cmVhbXMoKSB3YXMgY2FsbGVkIG9uIHRo ZSBXZWJUaHJlYWQsIGFzIGl0IGlzIHN1cHBvc2VkCisgICAgICAgIHRvLiBUaGUgbmV3IHJlbGVh c2UgYXNzZXJ0aW9uIGluIHNjaGVkdWxlU3RyZWFtcygpIHNob3VsZCB0ZWxsIHVzIGlmIHNvbWVi b2R5IGlzIGNhbGxpbmcgaXQgZnJvbQorICAgICAgICB0aGUgVUl0aHJlYWQgaW5zdGVhZCBvZiB0 aGUgV2ViVGhyZWFkIG9uIGlPUyBXZWJLaXRMZWdhY3kuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL2NmL1NvY2tldFN0cmVhbUhhbmRsZUltcGxDRk5ldC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpTb2NrZXRTdHJlYW1IYW5kbGVJbXBsOjpzY2hlZHVsZVN0cmVhbXMpOgorICAgICAgICAo V2ViQ29yZTo6U29ja2V0U3RyZWFtSGFuZGxlSW1wbDo6cmVhZFN0cmVhbUNhbGxiYWNrKToKKwog MjAxOC0wNS0wMSAgT2xla3NhbmRyIFNrYWNoa292ICA8Z3NrYWNoa292QGdtYWlsLmNvbT4KIAog ICAgICAgICBXZWJBc3NlbWJseTogYWRkIHN1cHBvcnQgZm9yIHN0cmVhbSBBUElzIC0gSmF2YVNj cmlwdCBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2Yv U29ja2V0U3RyZWFtSGFuZGxlSW1wbENGTmV0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY2YvU29ja2V0U3RyZWFtSGFuZGxlSW1wbENGTmV0LmNwcAppbmRleCBmMTg2MTUx N2Y4Mzg4NWQ4YjQzNGMzMjdiN2I0NTA4MTZlOWFiMWFmLi4zM2NhNmNjM2YyNzJjZWQ4MzRhYTNk N2FiZjhlY2QzMjU1ODBlYmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2NmL1NvY2tldFN0cmVhbUhhbmRsZUltcGxDRk5ldC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Tb2NrZXRTdHJlYW1IYW5kbGVJbXBsQ0ZOZXQuY3Bw CkBAIC0xMjMsNiArMTIzLDcgQEAgdm9pZCBTb2NrZXRTdHJlYW1IYW5kbGVJbXBsOjpzY2hlZHVs ZVN0cmVhbXMoKQogICAgIENGUmVhZFN0cmVhbVNjaGVkdWxlV2l0aFJ1bkxvb3AobV9yZWFkU3Ry ZWFtLmdldCgpLCBsb2FkZXJSdW5Mb29wKCksIGtDRlJ1bkxvb3BEZWZhdWx0TW9kZSk7CiAgICAg Q0ZXcml0ZVN0cmVhbVNjaGVkdWxlV2l0aFJ1bkxvb3AobV93cml0ZVN0cmVhbS5nZXQoKSwgbG9h ZGVyUnVuTG9vcCgpLCBrQ0ZSdW5Mb29wRGVmYXVsdE1vZGUpOwogI2Vsc2UKKyAgICBSRUxFQVNF X0FTU0VSVChpc01haW5UaHJlYWQoKSk7CiAgICAgQ0ZSZWFkU3RyZWFtU2NoZWR1bGVXaXRoUnVu TG9vcChtX3JlYWRTdHJlYW0uZ2V0KCksIENGUnVuTG9vcEdldEN1cnJlbnQoKSwga0NGUnVuTG9v cENvbW1vbk1vZGVzKTsKICAgICBDRldyaXRlU3RyZWFtU2NoZWR1bGVXaXRoUnVuTG9vcChtX3dy aXRlU3RyZWFtLmdldCgpLCBDRlJ1bkxvb3BHZXRDdXJyZW50KCksIGtDRlJ1bkxvb3BDb21tb25N b2Rlcyk7CiAjZW5kaWYKQEAgLTQ2OSw3ICs0NzAsNyBAQCB2b2lkIFNvY2tldFN0cmVhbUhhbmRs ZUltcGw6OnJlYWRTdHJlYW1DYWxsYmFjayhDRlJlYWRTdHJlYW1SZWYgc3RyZWFtLCBDRlN0cmVh bQogICAgICAgICAgICAgaGFuZGxlLT5yZWFkU3RyZWFtQ2FsbGJhY2sodHlwZSk7CiAgICAgfSk7 CiAjZWxzZQotICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CisgICAgUkVMRUFTRV9BU1NFUlQo aXNNYWluVGhyZWFkKCkpOwogICAgIGhhbmRsZS0+cmVhZFN0cmVhbUNhbGxiYWNrKHR5cGUpOwog I2VuZGlmCiB9Cg==