<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>185165</bug_id>
          
          <creation_ts>2018-05-01 09:00:09 -0700</creation_ts>
          <short_desc>WebKit should send fake macOS user agent to docs.google.com</short_desc>
          <delta_ts>2021-02-17 07:08:20 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=142074</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1419315</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-05-01 09:00:09 -0700</bug_when>
    <thetext>WebKit should send fake macOS user agent to docs.google.com, to eliminate the unsupported browser warning.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1419320</commentid>
    <comment_count>1</comment_count>
      <attachid>339200</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-05-01 09:05:00 -0700</bug_when>
    <thetext>Created attachment 339200
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1420053</commentid>
    <comment_count>2</comment_count>
      <attachid>339200</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-05-03 01:23:23 -0700</bug_when>
    <thetext>Comment on attachment 339200
Patch

Rejecting attachment 339200 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-02&apos;, &apos;apply-attachment&apos;, &apos;--no-update&apos;, &apos;--non-interactive&apos;, 339200, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/platform/UserAgentQuirks.cpp
Hunk #1 succeeded at 106 (offset 5 lines).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
Hunk #1 FAILED at 93.
1 out of 1 hunk FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp.rej

Failed to run &quot;[u&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply&apos;, &apos;--force&apos;, &apos;--reviewer&apos;, u&apos;Carlos Garcia Campos&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/7548669</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1420191</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-05-03 10:08:29 -0700</bug_when>
    <thetext>Committed r231311: &lt;https://trac.webkit.org/changeset/231311&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>339200</attachid>
            <date>2018-05-01 09:05:00 -0700</date>
            <delta_ts>2018-05-03 01:23:23 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-185165-20180501110459.patch</filename>
            <type>text/plain</type>
            <size>2980</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjJhMDM0MDExZTBhYWFk
OTBiYjVhOWE1ZGIxZGFjODgwODQzMDRmZi4uMzhjZjAyMmEzNGU2ZGI5OGRlYmNkOGJhMTY1NzJl
MDBiYjljNjY5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA1LTAxICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJLaXQg
c2hvdWxkIHNlbmQgZmFrZSBtYWNPUyB1c2VyIGFnZW50IHRvIGRvY3MuZ29vZ2xlLmNvbQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1MTY1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9V
c2VyQWdlbnRRdWlya3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dXJsUmVxdWlyZXNNYWNpbnRv
c2hQbGF0Zm9ybSk6CisgICAgICAgIChXZWJDb3JlOjp1cmxSZXF1aXJlc0xpbnV4RGVza3RvcFBs
YXRmb3JtKToKKwogMjAxOC0wNC0yOSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog
CiAgICAgICAgIFtMRkNdIEltcGxlbWVudCBEaXNwbGF5OjpCb3ggZnVuY3Rpb25zCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Vc2VyQWdlbnRRdWlya3MuY3BwIGIvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcAppbmRleCBlMzQ3NDI2YTljMTM4
MTk4NDQ0ZDdlY2ExZjM5YmM4MzdlZDJjZjcxLi5jN2Q5YjhlYmI4ZTIwMjM1Y2RjZTljNjE5Njdj
MDIyMjM3ZDgwNjc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Vc2VyQWdl
bnRRdWlya3MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VzZXJBZ2VudFF1aXJr
cy5jcHAKQEAgLTEwMSwxMiArMTAxLDE4IEBAIHN0YXRpYyBib29sIHVybFJlcXVpcmVzTWFjaW50
b3NoUGxhdGZvcm0oY29uc3QgVVJMJiB1cmwpCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0K
IAorICAgIC8vIEdvb2dsZSBEb2NzIHNob3dzIGEgc2NhcnkgdW5zdXBwb3J0ZWQgYnJvd3NlciB3
YXJuaW5nIHdpdGggV2ViS2l0R1RLKydzCisgICAgLy8gc3RhbmRhcmQgdXNlciBhZ2VudC4KKyAg
ICBpZiAoZG9tYWluID09ICJkb2NzLmdvb2dsZS5jb20iKQorICAgICAgICByZXR1cm4gdHJ1ZTsK
KwogICAgIHJldHVybiBmYWxzZTsKIH0KIAogc3RhdGljIGJvb2wgdXJsUmVxdWlyZXNMaW51eERl
c2t0b3BQbGF0Zm9ybShjb25zdCBVUkwmIHVybCkKIHsKLSAgICByZXR1cm4gaXNHb29nbGUodXJs
KTsKKyAgICAvLyBkb2NzLmdvb2dsZS5jb20gcmVxdWlyZXMgdGhlIG1hY09TIHBsYXRmb3JtIHF1
aXJrLgorICAgIHJldHVybiBpc0dvb2dsZSh1cmwpICYmIHVybC5ob3N0KCkgIT0gImRvY3MuZ29v
Z2xlLmNvbSI7CiB9CiAKIFVzZXJBZ2VudFF1aXJrcyBVc2VyQWdlbnRRdWlya3M6OnF1aXJrc0Zv
clVSTChjb25zdCBVUkwmIHVybCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz
L0NoYW5nZUxvZwppbmRleCA1Zjc5NDQwNzU3ZDQzYmJjMmE1MzM2NzY0NDU2OWRkZmYyNzg3NDFh
Li5mMTY2MjY0NTc4MDJkODIwNjkwZThhOWM0ZGM5ZjAzYzdjYzZhNzBiIDEwMDY0NAotLS0gYS9U
b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw
MTgtMDUtMDEgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisg
ICAgICAgIFdlYktpdCBzaG91bGQgc2VuZCBmYWtlIG1hY09TIHVzZXIgYWdlbnQgdG8gZG9jcy5n
b29nbGUuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0xODUxNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9Vc2VyQWdlbnRRdWlya3MuY3BwOgorICAg
ICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMTgtMDQtMjggIFNpaHVpIExpdSAgPHNp
aHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBTZXQgSFRUUE9ubHkgZmxhZyB3
aGVuIGNvbnZlcnRpbmcgQ29va2llIHRvIE5TSFRUUENvb2tpZQpkaWZmIC0tZ2l0IGEvVG9vbHMv
VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL1VzZXJBZ2VudFF1aXJrcy5jcHAgYi9Ub29scy9U
ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvVXNlckFnZW50UXVpcmtzLmNwcAppbmRleCAyYTE3
NjllM2Y5Nzg3YTMwMjVkMTg1NDc5ZWFiNWU4YTk2ODc0ODg5Li5iYjMzNWQ0YjcxOWJhMjM2ZjNj
Mjg5M2I1ZTI1ZjM3NDFkNTQ0OGFlIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl
c3RzL1dlYkNvcmUvVXNlckFnZW50UXVpcmtzLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJ
L1Rlc3RzL1dlYkNvcmUvVXNlckFnZW50UXVpcmtzLmNwcApAQCAtOTMsNiArOTMsNyBAQCBURVNU
KFVzZXJBZ2VudFRlc3QsIFF1aXJrcykKICAgICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNNYWNQ
bGF0Zm9ybVF1aXJrKCJodHRwOi8vd3d3LndoYXRzYXBwLmNvbS8iKTsKICAgICBhc3NlcnRVc2Vy
QWdlbnRGb3JVUkxIYXNNYWNQbGF0Zm9ybVF1aXJrKCJodHRwOi8vd2ViLndoYXRzYXBwLmNvbS8i
KTsKICAgICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNNYWNQbGF0Zm9ybVF1aXJrKCJodHRwOi8v
b3V0bG9vay5saXZlLmNvbS8iKTsKKyAgICBhc3NlcnRVc2VyQWdlbnRGb3JVUkxIYXNNYWNQbGF0
Zm9ybVF1aXJrKCJodHRwOi8vZG9jcy5nb29nbGUuY29tLyIpOwogfQogCiB9IC8vIG5hbWVzcGFj
ZSBUZXN0V2ViS2l0QVBJCg==
</data>
<flag name="review"
          id="357443"
          type_id="1"
          status="+"
          setter="cgarcia"
    />
    <flag name="commit-queue"
          id="357444"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
      

    </bug>

</bugzilla>