185126 2018-04-29 18:05:00 -0700 LICM shouldn't hoist nodes if hoisted nodes exited in that code block 2018-04-30 17:08:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1418938 0 fpizlo 2018-04-29 18:05:00 -0700 We allow speculative hoisting, but only once per codeBlock. 1418939 1 339102 fpizlo 2018-04-29 18:14:58 -0700 Created attachment 339102 the patch 1418991 2 339102 saam 2018-04-30 09:21:00 -0700 Comment on attachment 339102 the patch r=me 1419183 3 fpizlo 2018-04-30 17:05:02 -0700 Landed in https://trac.webkit.org/changeset/231185/webkit 1419184 4 webkit-bug-importer 2018-04-30 17:08:04 -0700 <rdar://problem/39855250> 339102 2018-04-29 18:14:58 -0700 2018-04-30 09:21:00 -0700 the patch blah.patch text/plain 3173 fpizlo SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzExNTQpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE4IEBACisyMDE4LTA0LTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CisKKyAgICAgICAgTElDTSBzaG91bGRuJ3QgaG9pc3Qgbm9kZXMgaWYgaG9pc3RlZCBub2Rl cyBleGl0ZWQgaW4gdGhhdCBjb2RlIGJsb2NrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODUxMjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEkgZm91bmQgdGhpcyBidWcgYnkgYWNjaWRlbnQg d2hlbiBJIHdhcyB3cml0aW5nIHRoaXMgdGVzdCBmb3Igc29tZXRoaW5nIGVsc2UuCisgICAgICAg IAorICAgICAgICBUaGlzIGNoYW5nZSBhbHNvIHNwZWVkcyB1cCBvdGhlciBiZW5jaG1hcmtzIG9m IHRoaXMgY2FzZSB0aGF0IHdlIGFscmVhZHkgaGFkLiBUaGV5IGFyZSBhbGwgY2FsbGVkCisgICAg ICAgIHRoZSBsaWNtLWRyYWdvbnMgdGVzdHMuCisKKyAgICAgICAgKiBtaWNyb2JlbmNobWFya3Mv bGljbS1kcmFnb25zLXR3by1zdHJ1Y3R1cmVzLmpzOiBBZGRlZC4KKyAgICAgICAgKGZvbyk6CisK IDIwMTgtMDQtMjkgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzExMzcuCkluZGV4OiBKU1Rlc3RzL21p Y3JvYmVuY2htYXJrcy9saWNtLWRyYWdvbnMtdHdvLXN0cnVjdHVyZXMuanMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gSlNUZXN0cy9taWNyb2JlbmNobWFya3MvbGljbS1kcmFnb25zLXR3by1zdHJ1Y3R1cmVzLmpz CShub25leGlzdGVudCkKKysrIEpTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2xpY20tZHJhZ29ucy10 d28tc3RydWN0dXJlcy5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDI0IEBACitmdW5jdGlv biBmb28obykKK3sKKyAgICB2YXIgcmVzdWx0ID0gMDsKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8 IDEwMDsgKytpKSB7CisgICAgICAgIGlmIChvLnApCisgICAgICAgICAgICByZXN1bHQgKz0gby5m OworICAgICAgICBlbHNlCisgICAgICAgICAgICByZXN1bHQgKz0gby5nOworICAgICAgICBpZiAo by5wKQorICAgICAgICAgICAgby5mID0gaTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgby5n ID0gaTsKKyAgICB9CisgICAgcmV0dXJuIHJlc3VsdDsKK30KKworbm9JbmxpbmUoZm9vKTsKKwor Zm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwMDA7ICsraSkgeworICAgIHZhciByZXN1bHQgPSBmb28o aSAmIDEgPyB7cDp0cnVlLCBmOjQyfSA6IHtwOmZhbHNlLCBnOjQyfSk7CisgICAgaWYgKHJlc3Vs dCAhPSAoOTkgKiA5OCkgLyAyICsgNDIpCisgICAgICAgIHRocm93ICJFcnJvcjogYmFkIHJlc3Vs dDogIiArIHJlc3VsdDsKK30KKwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lv biAyMzExNTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDQtMjkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFw cGxlLmNvbT4KKworICAgICAgICBMSUNNIHNob3VsZG4ndCBob2lzdCBub2RlcyBpZiBob2lzdGVk IG5vZGVzIGV4aXRlZCBpbiB0aGF0IGNvZGUgYmxvY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTEyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhpcyBjaGFuZ2UgaXMganVzdCByZXN0 b3JpbmcgZnVuY3Rpb25hbGl0eSB0aGF0IHdlJ3ZlIGFscmVhZHkgaGFkIGZvciBhIHdoaWxlLiBJ dCBoYWQgYmVlbgorICAgICAgICBhY2NpZGVudGFsbHkgYnJva2VuIGR1ZSB0byBhbiB1bnJlbGF0 ZWQgQ29kZUJsb2NrIHJlZmFjdG9yaW5nLgorCisgICAgICAgICogZGZnL0RGR0xJQ01QaGFzZS5j cHA6CisgICAgICAgIChKU0M6OkRGRzo6TElDTVBoYXNlOjphdHRlbXB0SG9pc3QpOgorCiAyMDE4 LTA0LTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQjMgc2hv dWxkIHJ1biB0YWlsIGR1cGxpY2F0aW9uIGF0IHRoZSBiaXR0ZXIgZW5kCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0xJQ01QaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdMSUNNUGhhc2UuY3BwCShyZXZpc2lvbiAyMzExNTQpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0xJQ01QaGFzZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTI4MSw3ICsyODEsNyBAQCBwcml2YXRlOgogICAgICAgICAgICAgJiYgIW1fZ3JhcGgu bV9jb250cm9sRXF1aXZhbGVuY2VBbmFseXNpcy0+ZG9taW5hdGVzRXF1aXZhbGVudGx5KGRhdGEu cHJlSGVhZGVyLCBmcm9tQmxvY2spOwogICAgICAgICAKICAgICAgICAgaWYgKGFkZHNCbGluZFNw ZWN1bGF0aW9uCi0gICAgICAgICAgICAmJiBtX2dyYXBoLmhhc0V4aXRTaXRlKG9yaWdpbmFsT3Jp Z2luLnNlbWFudGljLCBIb2lzdGluZ0ZhaWxlZCkpIHsKKyAgICAgICAgICAgICYmIG1fZ3JhcGgu aGFzR2xvYmFsRXhpdFNpdGUob3JpZ2luYWxPcmlnaW4uc2VtYW50aWMsIEhvaXN0aW5nRmFpbGVk KSkgewogICAgICAgICAgICAgaWYgKHZlcmJvc2UpIHsKICAgICAgICAgICAgICAgICBkYXRhTG9n KAogICAgICAgICAgICAgICAgICAgICAiICAgIE5vdCBob2lzdGluZyAiLCBub2RlLCAiIGJlY2F1 c2UgaXQgbWF5IGV4aXQgYW5kIHRoZSBwcmUtaGVhZGVyICgiLAo=