185117 2018-04-28 21:19:49 -0700 Fixed a very unlikely race condition in WTF::WordLock 2022-04-06 03:33:01 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren benjamin cdumez clucier cmarcelo dbates ews-watchlist fpizlo saam webkit-bug-importer ysuzuki oldest_to_newest 1418864 0 ggaren 2018-04-28 21:19:49 -0700 Fixed a very unlikely race condition in WTF::WordLock 1418865 1 339088 ggaren 2018-04-28 21:34:07 -0700 Created attachment 339088 Patch 1418866 2 ggaren 2018-04-28 21:36:08 -0700 I'm not sure which arguments are best for LockSpeedTest. These results looked OK to me: ~/OpenSource> ./LockSpeedTest-baseline wordlock 1 4 10 20 40 2 WTFWordLock: 15528.899 KHz WTFWordLock = {15528.899}; ===== ~/OpenSource> ./LockSpeedTest wordlock 1 4 10 20 40 2 WTFWordLock: 15297.111 KHz WTFWordLock = {15297.111}; ~/OpenSource> ./LockSpeedTest-baseline wordlock 1 4 128 1024 40 2 WTFWordLock: 1505.704 KHz WTFWordLock = {1505.704}; ===== ~/OpenSource> ./LockSpeedTest wordlock 1 4 128 1024 40 2 WTFWordLock: 1499.678 KHz WTFWordLock = {1499.678}; 1418867 3 ggaren 2018-04-28 21:42:51 -0700 Side note: ParkingLot does not have this bug. (It uses reference counting instead of the "lock more" solution I used here.) 1418881 4 ggaren 2018-04-29 08:23:54 -0700 Committed r231148: <https://trac.webkit.org/changeset/231148> 1418882 5 webkit-bug-importer 2018-04-29 08:24:18 -0700 <rdar://problem/39824505> 1858757 6 ysuzuki 2022-04-06 03:33:01 -0700 *** Bug 185547 has been marked as a duplicate of this bug. *** 339088 2018-04-28 21:34:07 -0700 2018-04-28 22:07:44 -0700 Patch bug-185117-20180428213407.patch text/plain 3214 ggaren SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzExNDUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDM2IEBACisyMDE4LTA0LTI4ICBHZW9mZnJleSBHYXJlbiAgPGdn YXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4ZWQgYSB2ZXJ5IHVubGlrZWx5IHJhY2UgY29u ZGl0aW9uIGluIFdURjo6V29yZExvY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NTExNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSByYWNlIGdvZXMgbGlrZSB0aGlzOgorCisgICAgICAgIFRocmVh ZCBMIGlzIGluIGxvY2tTbG93Q2FzZSgpIGFuZCB0aHJlYWQgVSBpcyBpbiB1bmxvY2tTbG93Q2Fz ZSgpOworCisgICAgICAgIC0gVSBhY3F1aXJlcyBxdWV1ZUhlYWQtPnBhcmtpbmdMb2NrLgorICAg ICAgICAtIFUgc2V0cyBxdWV1ZUhlYWQtPnNob3VsZFBhcmsgPSBmYWxzZQorICAgICAgICAtIFUg cmVsZWFzZXMgcXVldWVIZWFkLT5wYXJraW5nTG9jay4KKyAgICAgICAgLSBMIHNwdXJpb3VzbHkg d2FrZXMgdXAgZnJvbSBxdWV1ZUhlYWQtPnBhcmtpbmdMb2NrLndhaXQoKQorICAgICAgICAtIEwg YWNxdWlyZXMgcXVldWVIZWFkLT5wYXJraW5nTG9jay4KKyAgICAgICAgLSBMIG5vdGljZXMgdGhh dCBxdWV1ZUhlYWQtPnNob3VsZFBhcmsgPSBmYWxzZSwgYW5kIGFjcXVpcmVzIHRoZSBXb3JkTG9j aworICAgICAgICAtIEwgZmluaXNoZXMgYWxsIGl0cyB3b3JrIGFuZCBleGl0cywgZnJlZWluZyBx dWV1ZUhlYWQKKyAgICAgICAgLSBVIG5vdGlmaWVzIHF1ZXVlSGVhZC0+cGFya2luZ0xvY2sgKGFm dGVyIGZyZWUpIGFuZCBjcmFzaGVzIG9yIGRlYWRsb2NrcworCisgICAgICAgIFRoZXNlIGNvbmRp dGlvbnMgYXJlIGN1cnJlbnRseSBzbyB1bmxpa2VseSB0aGF0IEkgZG9uJ3Qga25vdyBob3cgdG8g dGVzdAorICAgICAgICB0aGVtLiBJIG5vdGljZWQgdGhpcyByYWNlIGJlY2F1c2UgSSBjaGFuZ2Vk IFdvcmRMb2NrJ3MgYWxsb2NhdGlvbiBwYXR0ZXJuCisgICAgICAgIHRvIGFsbG93IHF1ZXVlSGVh ZCB0byBiZSBmcmVlZCBtb3JlIG9mdGVuLCBhbmQgSSBjcmFzaGVkIC8gZGVhZGxvY2tlZCAxMDAl LgorCisgICAgICAgIFNob3V0IG91dCB0byA8aHR0cDovL2VuLmNwcHJlZmVyZW5jZS5jb20vdy9j cHAvdGhyZWFkL2NvbmRpdGlvbl92YXJpYWJsZS9ub3RpZnlfb25lPgorICAgICAgICBmb3IgZXhw bGFpbmluZyB0aGlzLgorCisgICAgICAgICogYmVuY2htYXJrcy9Ub3lMb2Nrcy5oOiBGaXhlZCBi dWlsZC4KKworICAgICAgICAqIHd0Zi9Xb3JkTG9jay5jcHA6CisgICAgICAgIChXVEY6OldvcmRM b2NrOjp1bmxvY2tTbG93KTogSG9sZCB0aGUgbG9jayBhIGxpdHRsZSBsb25nZXIgdG8gYXZvaWQK KyAgICAgICAgdGhpcyByYWNlLgorCiAyMDE4LTA0LTI3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHpl ckBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGxvZ2dpbmcgd2hlbiBTcHJpbmdCb2FyZCBlbmFi bGVzIFdlYlRocmVhZApJbmRleDogU291cmNlL1dURi9iZW5jaG1hcmtzL1RveUxvY2tzLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dURi9iZW5jaG1hcmtzL1RveUxvY2tzLmgJKHJldmlzaW9uIDIy ODAyMykKKysrIFNvdXJjZS9XVEYvYmVuY2htYXJrcy9Ub3lMb2Nrcy5oCSh3b3JraW5nIGNvcHkp CkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSA8d3RmL0F0b21pY3MuaD4KICNpbmNsdWRlIDx3 dGYvTG9jay5oPgogI2luY2x1ZGUgPHd0Zi9QYXJraW5nTG90Lmg+CisjaW5jbHVkZSA8d3RmL1Ro cmVhZGluZy5oPgogI2luY2x1ZGUgPHd0Zi9Xb3JkTG9jay5oPgogCiAjaWYgX19oYXNfaW5jbHVk ZSg8b3MvbG9jay5oPikKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1dvcmRMb2NrLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Xb3JkTG9jay5jcHAJKHJldmlzaW9uIDIyODAyMykKKysr IFNvdXJjZS9XVEYvd3RmL1dvcmRMb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU0LDEyICsy NTQsMTUgQEAgTkVWRVJfSU5MSU5FIHZvaWQgV29yZExvY2s6OnVubG9ja1Nsb3coKQogICAgIC8v IFdlIGRvIHRoaXMgY2FyZWZ1bGx5IGJlY2F1c2UgdGhpcyBtYXkgcnVuIGVpdGhlciBiZWZvcmUg b3IgZHVyaW5nIHRoZSBwYXJraW5nTG9jayBjcml0aWNhbAogICAgIC8vIHNlY3Rpb24gaW4gbG9j a1Nsb3coKS4KICAgICB7CisgICAgICAgIC8vIEJlIHN1cmUgdG8gaG9sZCB0aGUgbG9jayBhY3Jv c3Mgb3VyIGNhbGwgdG8gbm90aWZ5X29uZSgpIGJlY2F1c2UgYSBzcHVyaW91cyB3YWtldXAgY291 bGQKKyAgICAgICAgLy8gY2F1c2UgdGhlIHRocmVhZCBhdCB0aGUgaGVhZCBvZiB0aGUgcXVldWUg dG8gZXhpdCBhbmQgZGVsZXRlIHF1ZXVlSGVhZC4KICAgICAgICAgc3RkOjpsb2NrX2d1YXJkPHN0 ZDo6bXV0ZXg+IGxvY2tlcihxdWV1ZUhlYWQtPnBhcmtpbmdMb2NrKTsKICAgICAgICAgcXVldWVI ZWFkLT5zaG91bGRQYXJrID0gZmFsc2U7CisKKyAgICAgICAgLy8gRG9lc24ndCBtYXR0ZXIgaWYg d2Ugbm90aWZ5X2FsbCgpIG9yIG5vdGlmeV9vbmUoKSBoZXJlIHNpbmNlIHRoZSBvbmx5IHRocmVh ZCB0aGF0IGNvdWxkIGJlCisgICAgICAgIC8vIHdhaXRpbmcgaXMgcXVldWVIZWFkLgorICAgICAg ICBxdWV1ZUhlYWQtPnBhcmtpbmdDb25kaXRpb24ubm90aWZ5X29uZSgpOwogICAgIH0KLSAgICAv LyBEb2Vzbid0IG1hdHRlciBpZiB3ZSBub3RpZnlfYWxsKCkgb3Igbm90aWZ5X29uZSgpIGhlcmUg c2luY2UgdGhlIG9ubHkgdGhyZWFkIHRoYXQgY291bGQgYmUKLSAgICAvLyB3YWl0aW5nIGlzIHF1 ZXVlSGVhZC4KLSAgICBxdWV1ZUhlYWQtPnBhcmtpbmdDb25kaXRpb24ubm90aWZ5X29uZSgpOwog CiAgICAgLy8gVGhlIG9sZCBxdWV1ZSBoZWFkIGNhbiBub3cgY29udGVuZCBmb3IgdGhlIGxvY2sg YWdhaW4uIFdlJ3JlIGRvbmUhCiB9Cg==