185088 2018-04-27 13:44:23 -0700 Fix crash in DocumentLoader::startLoadingMainResource 2018-04-27 18:09:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin cdumez commit-queue dbates ews-watchlist japhet ryanhaddad webkit-bug-importer oldest_to_newest 1418601 0 krollin 2018-04-27 13:44:23 -0700 Testing turned up a crash in: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x0000000312612e26 WebCore::DocumentLoader::startLoadingMainResource(WebCore::ShouldContinue) + 598 1 com.apple.WebCore 0x00000003126321d0 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::ShouldContinue, WebCore::AllowNavigationToInvalidURL)::$_14::operator()() const + 352 This corresponds to this source: if (maybeLoadEmpty()) { RELEASE_LOG_IF_ALLOWED("startLoadingMainResource: Returning empty document (frame = %p, main = %d)", m_frame, m_frame ? m_frame->isMainFrame() : false); return; } The problem is that maybeLoadEmpty() can release "this". Fix this by adding a "protectedThis". <rdar://problem/39689263> 1418602 1 339019 krollin 2018-04-27 13:51:51 -0700 Created attachment 339019 Patch 1418708 2 339019 commit-queue 2018-04-27 18:09:16 -0700 Comment on attachment 339019 Patch Clearing flags on attachment: 339019 Committed r231128: <https://trac.webkit.org/changeset/231128> 1418709 3 commit-queue 2018-04-27 18:09:18 -0700 All reviewed patches have been landed. Closing bug. 339019 2018-04-27 13:51:51 -0700 2018-04-27 18:09:16 -0700 Patch bug-185088-20180427135150.patch text/plain 2312 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Q5OTg0NmIwOWU4Mjg3 MTliYTAwMTAzY2EzMmRjYWY4YWE4MGNkMi4uNDBjMTM4MTIzNmMxNGQ2ZWMzZmRiM2E0NWZiZDNk ODU2MzQ1NjRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA0LTI3ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggY3Jhc2ggaW4gRG9j dW1lbnRMb2FkZXI6OnN0YXJ0TG9hZGluZ01haW5SZXNvdXJjZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1MDg4CisgICAgICAgIHJkYXI6Ly9wcm9i bGVtLzM5Njg5MjYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGEgInByb3RlY3RlZFRoaXMiIHRvIGFkZHJlc3MgYSBjYXNlIHdoZXJlIGEgZGVs ZXRlZCAidGhpcyIgd2FzCisgICAgICAgIGFjY2Vzc2VkIGluIGEgUkVMRUFTRV9MT0cgc3RhdGVt ZW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAtLSBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3Rz LCB3aGljaCBub3cgcGFzcy4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6c3RhcnRMb2FkaW5nTWFpblJlc291 cmNlKToKKwogMjAxOC0wNC0yNyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFtMRkNdIEltcGxlbWVudCBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpsYXlvdXQgbG9n aWMgYW5kIGl0cyBkZXBlbmRlbmNpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2Fk ZXIuY3BwCmluZGV4IGQwZjE0NzQwMjJlNDJjYzg5OTlhYjgyMDhjNDQ1ZDY3MGE1NjBlNDUuLjRj YzFiMTg0NDk3MTYwNDliNDEyZjNhYzYyM2FkMTEwYzkxZmEwMWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcApAQCAtMTY3NCw2ICsxNjc0LDggQEAgdm9pZCBEb2N1 bWVudExvYWRlcjo6c3RhcnRMb2FkaW5nTWFpblJlc291cmNlKFNob3VsZENvbnRpbnVlIHNob3Vs ZENvbnRpbnVlKQogICAgIEFTU0VSVCghbV9sb2FkaW5nTWFpblJlc291cmNlKTsKICAgICBtX2xv YWRpbmdNYWluUmVzb3VyY2UgPSB0cnVlOwogCisgICAgUmVmPERvY3VtZW50TG9hZGVyPiBwcm90 ZWN0ZWRUaGlzKCp0aGlzKTsKKwogICAgIGlmIChtYXliZUxvYWRFbXB0eSgpKSB7CiAgICAgICAg IFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoInN0YXJ0TG9hZGluZ01haW5SZXNvdXJjZTogUmV0dXJu aW5nIGVtcHR5IGRvY3VtZW50IChmcmFtZSA9ICVwLCBtYWluID0gJWQpIiwgbV9mcmFtZSwgbV9m cmFtZSA/IG1fZnJhbWUtPmlzTWFpbkZyYW1lKCkgOiBmYWxzZSk7CiAgICAgICAgIHJldHVybjsK QEAgLTE2OTQsNyArMTY5Niw3IEBAIHZvaWQgRG9jdW1lbnRMb2FkZXI6OnN0YXJ0TG9hZGluZ01h aW5SZXNvdXJjZShTaG91bGRDb250aW51ZSBzaG91bGRDb250aW51ZSkKICAgICBBU1NFUlQodGlt aW5nKCkuc3RhcnRUaW1lKCkpOwogICAgIEFTU0VSVCh0aW1pbmcoKS5mZXRjaFN0YXJ0KCkpOwog Ci0gICAgd2lsbFNlbmRSZXF1ZXN0KFJlc291cmNlUmVxdWVzdChtX3JlcXVlc3QpLCBSZXNvdXJj ZVJlc3BvbnNlKCksIHNob3VsZENvbnRpbnVlLCBbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VS ZWYoKnRoaXMpXSAoUmVzb3VyY2VSZXF1ZXN0JiYgcmVxdWVzdCkgbXV0YWJsZSB7CisgICAgd2ls bFNlbmRSZXF1ZXN0KFJlc291cmNlUmVxdWVzdChtX3JlcXVlc3QpLCBSZXNvdXJjZVJlc3BvbnNl KCksIHNob3VsZENvbnRpbnVlLCBbdGhpcywgcHJvdGVjdGVkVGhpcyA9IFdURk1vdmUocHJvdGVj dGVkVGhpcyldIChSZXNvdXJjZVJlcXVlc3QmJiByZXF1ZXN0KSBtdXRhYmxlIHsKICAgICAgICAg bV9yZXF1ZXN0ID0gcmVxdWVzdDsKIAogICAgICAgICAvLyB3aWxsU2VuZFJlcXVlc3QoKSBtYXkg bGVhZCB0byBvdXIgRnJhbWUgYmVpbmcgZGV0YWNoZWQgb3IgY2FuY2VsbGluZyB0aGUgbG9hZCB2 aWEgbnVsbGluZyB0aGUgUmVzb3VyY2VSZXF1ZXN0Lgo=