<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>185072</bug_id>
          
          <creation_ts>2018-04-27 04:43:44 -0700</creation_ts>
          <short_desc>[GTK] Some event tests failing after r230817</short_desc>
          <delta_ts>2018-05-04 03:12:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=163976</see_also>
          <bug_file_loc>https://bugs.webkit.org/show_bug.cgi?id=184462</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Claudio Saavedra">csaavedra</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bburg</cc>
    
    <cc>berto</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gustavo</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1418462</commentid>
    <comment_count>0</comment_count>
    <who name="Claudio Saavedra">csaavedra</who>
    <bug_when>2018-04-27 04:43:44 -0700</bug_when>
    <thetext>+fast/events/mouse-click-events.html [ Failure ]
+fast/events/context-activated-by-key-event.html [ Failure ]
+fast/events/mouse-cursor-change.html [ Failure ]

These started failing in the GTK+ port after r230743 was landed, then started working again when it was reverted, and started failing again when r230817 landed. Carlos reviewed that patch so I&apos;m adding him in CC.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418464</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2018-04-27 05:00:16 -0700</bug_when>
    <thetext>I&apos;ll investigate it, thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418961</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2018-04-30 02:23:07 -0700</bug_when>
    <thetext>They fail on x11, but not in wayland.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418965</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2018-04-30 05:02:33 -0700</bug_when>
    <thetext>Ok, I know what&apos;s going on. Tests are finishing before all events are processed and logged. r230817 changed the behavior of mouse events and made it slower too, specially in the case of X11 that generates several crossing events (handled by WebKit as mouse move events). Before r230817 mouse down/up events were always sent to the web process immediately, now we wait for the response of all the previous mouse events sent to the web process. Also before r230817, when several mouse move events were received by the web view, we discarded the ones in the middle of the sequence, now we are always sending all of them and waiting for their responses. In the case of mouse events we don&apos;t really need to wait for previous events to send new ones.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1418968</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2018-04-30 07:04:38 -0700</bug_when>
    <thetext>One problem we have in X11 is that mouse events are not always processed in the order they are sent. The main difference is that when the context menu is shown, a crossing event is generated in the web view, a leave happens in the view and enter in the context menu. That crossing is processed during the press:

1- ButtonPress is received in the web process
2- handleContextMenuEvent()
3- MouseMove is received in the web process
4- DidReceiveEvent for the MouseMove is sent to the UI process
5- DidReceiveEvent for the ButtonPress is sent to the Ui process

This breaks the queue model used in the UI process.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1420075</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2018-05-03 03:10:15 -0700</bug_when>
    <thetext>The problem with messages handled in different order is because WTR uses fully sync mode for testing for their events, but crossing events are not generated by WTr, but by the xserver (or GTK+, I&apos;m not sure). That confuses everything and sometimes a move after a press or release can be processed before the press or release. I think we can simply ignore crossing events during testing, since WTR never generates them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1420085</commentid>
    <comment_count>6</comment_count>
      <attachid>339401</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2018-05-03 04:11:40 -0700</bug_when>
    <thetext>Created attachment 339401
Patch

It seems those crossing events were confusing other tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1420086</commentid>
    <comment_count>7</comment_count>
      <attachid>339402</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2018-05-03 04:16:30 -0700</bug_when>
    <thetext>Created attachment 339402
Patch

Now the right patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1420089</commentid>
    <comment_count>8</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2018-05-03 04:18:09 -0700</bug_when>
    <thetext>Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1420137</commentid>
    <comment_count>9</comment_count>
      <attachid>339402</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-05-03 08:58:16 -0700</bug_when>
    <thetext>Comment on attachment 339402
Patch

Not great....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1420159</commentid>
    <comment_count>10</comment_count>
      <attachid>339402</attachid>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2018-05-03 09:30:13 -0700</bug_when>
    <thetext>Comment on attachment 339402
Patch

Well, I certainly didn&apos;t expect that the WM would reorder mouse moves and mouse downs... :|</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1420605</commentid>
    <comment_count>11</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2018-05-04 03:08:09 -0700</bug_when>
    <thetext>(In reply to Brian Burg from comment #10)
&gt; Comment on attachment 339402 [details]
&gt; Patch
&gt; 
&gt; Well, I certainly didn&apos;t expect that the WM would reorder mouse moves and
&gt; mouse downs... :|

Sure, the problem is that all events generated by WTR are handled synchronously, but crossing events generated by the xserver/gtk are handled normally. It took me a while to understand was going on.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1420607</commentid>
    <comment_count>12</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2018-05-04 03:12:17 -0700</bug_when>
    <thetext>Committed r231349: &lt;https://trac.webkit.org/changeset/231349&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>339401</attachid>
            <date>2018-05-03 04:11:40 -0700</date>
            <delta_ts>2018-05-03 04:16:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk2-wtr-crossing-events.diff</filename>
            <type>text/plain</type>
            <size>6033</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBjNWQwOTFmMTc5OS4uNjdhMDBhY2UyNGYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz
L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor
MjAxOC0wNS0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK
KyAgICAgICAgW0dUS10gU29tZSBldmVudCB0ZXN0cyBmYWlsaW5nIGFmdGVyIHIyMzA4MTcKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTA3MgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBleHBl
Y3RhdGlvbnMgZm9yIHRlc3RzIHRoYXQgYXJlIHBhc3Npbmcgbm93LgorCisgICAgICAgICogcGxh
dGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTgtMDUtMDIgIFNhaWQgQWJvdS1IYWxs
YXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBIaWRpbmcgdGhlbiBzaG93
aW5nIGFuIDxvYmplY3Q+IG9mIHR5cGUgaW1hZ2UgbWFrZXMgdGhlIHVuZGVybGF5aW5nIGltYWdl
IGRpc2FwcGVhcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl
Y3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRl
eCAyNWU2ZTU3ZWQ2MC4uOTc0NmVkYmUzMzggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm
b3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9U
ZXN0RXhwZWN0YXRpb25zCkBAIC0yMzQ5LDcgKzIzNDksNiBAQCB3ZWJraXQub3JnL2IvMTU3MTc5
IGVkaXRpbmcvcGFzdGVib2FyZC9kcmFnLXNlbGVjdGVkLWltYWdlLXRvLWNvbnRlbnRlZGl0YWJs
ZS5odAogd2Via2l0Lm9yZy9iLzE1NzE3OSBlZGl0aW5nL3Bhc3RlYm9hcmQvZHJvcC1maWxlLXN2
Zy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTU3MTc5IGVkaXRpbmcvcGFzdGVib2Fy
ZC9kcm9wLWlucHV0dGV4dC1hY3F1aXJlcy1zdHlsZS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQu
b3JnL2IvMTU3MTc5IGVkaXRpbmcvcGFzdGVib2FyZC9kcm9wLWxpbmsuaHRtbCBbIEZhaWx1cmUg
XQotd2Via2l0Lm9yZy9iLzE1NzE3OSBlZGl0aW5nL3Bhc3RlYm9hcmQvZHJhZy1saW5rLXdpdGgt
ZGF0YS10cmFuc2Zlci1hZGRzLXRydXN0ZWQtbGluay10by1wYXN0ZWJvYXJkLmh0bWwgWyBGYWls
dXJlIF0KIHdlYmtpdC5vcmcvYi8xNTcxNzkgZWRpdGluZy9wYXN0ZWJvYXJkL2Ryb3AtdGV4dC13
aXRob3V0LXNlbGVjdGlvbi5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTU3MTc5IGVk
aXRpbmcvcGFzdGVib2FyZC9nZXQtZGF0YS10ZXh0LXBsYWluLWRyb3AuaHRtbCBbIEZhaWx1cmUg
XQogd2Via2l0Lm9yZy9iLzE1NzE3OSBlZGl0aW5nL3Bhc3RlYm9hcmQvc21hcnQtZHJhZy1kcm9w
Lmh0bWwgWyBGYWlsdXJlIF0KQEAgLTIzNzAsNyArMjM2OSw2IEBAIHdlYmtpdC5vcmcvYi8xNTcx
NzkgZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC5odG1sIFsgRmFpbHVyZSBUaW1lb3V0IF0KIHdl
YmtpdC5vcmcvYi8xNTcxNzkgZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC1zdWJmcmFtZS1kYXRh
VHJhbnNmZXIuaHRtbCBbIEZhaWx1cmUgVGltZW91dCBdCiB3ZWJraXQub3JnL2IvNDIxOTQgZmFz
dC9ldmVudHMvZHJhZy1hbmQtZHJvcC1saW5rLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcv
Yi8xNTcxNzkgZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC1saW5rLWludG8tZm9jdXNlZC1jb250
ZW50ZWRpdGFibGUuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE1NzE3OSBmYXN0L2V2
ZW50cy9kcmFnLXNlbGVjdHMtaW1hZ2UuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE1
NzE3OSBmYXN0L2V2ZW50cy9kcmFnZ2FibGUtZGl2LWN1c3RvbWRhdGEuaHRtbCBbIEZhaWx1cmUg
XQogd2Via2l0Lm9yZy9iLzE1NzE3OSBmYXN0L2V2ZW50cy9kcmFnZ2FibGUtZGl2LW5vZGF0YS5o
dG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTU3MTc5IGZhc3QvZXZlbnRzL2Ryb3B6b25l
LTAwMS5odG1sIFsgRmFpbHVyZSBUaW1lb3V0IF0KQEAgLTI2MDMsOCArMjYwMSw2IEBAIHdlYmtp
dC5vcmcvYi81ODg0NSBmYXN0L2RvbS90aXRsZS1kaXJlY3Rpb25hbGl0eS1yZW1vdmVDaGlsZC5o
dG1sIFsgRmFpbHVyZSBdCiAjIEhUVFAgMjA0IChObyBDb250ZW50KSBzaG91bGQgYmUgaWdub3Jl
ZAogd2Via2l0Lm9yZy9iLzYwMjA2IGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNwb25zZTIwNC5o
dG1sIFsgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi82MTYzMCBmYXN0L2V2ZW50cy9kcm9wem9u
ZS0wMDUuaHRtbCBbIEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvNjgyNzggaHR0cC90ZXN0cy9o
aXN0b3J5L2JhY2std2l0aC1mcmFnbWVudC1jaGFuZ2UucGhwIFsgUGFzcyBGYWlsdXJlIF0KIAog
d2Via2l0Lm9yZy9iLzY4NTEyIGFjY2Vzc2liaWxpdHkvYXJpYS1oaWRkZW4tdXBkYXRlcy1hbGxk
ZXNjZW5kYW50cy5odG1sIFsgRmFpbHVyZSBdCkBAIC0zMDc5LDggKzMwNzUsNiBAQCB3ZWJraXQu
b3JnL2IvMTYzOTcyIGZhc3QvY2FudmFzL2NhbnZhcy1ncmFkaWVudC1hZGRTdG9wLWVycm9yLmh0
bWwgWyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzE2Mzk3NCBmYXN0L2NhbnZhcy9kcmF3SW1h
Z2Utd2l0aC1uZWdhdGl2ZS1zb3VyY2UtZGVzdGluYXRpb24uaHRtbCBbIEZhaWx1cmUgXQogCi13
ZWJraXQub3JnL2IvMTYzOTc2IGZhc3QvY3NzL3VzZXItZHJhZy1ub25lLmh0bWwgWyBGYWlsdXJl
IF0KLQogd2Via2l0Lm9yZy9iLzE2Mzk3NyBmYXN0L2Nzcy93aWxsLWNoYW5nZS93aWxsLWNoYW5n
ZS1jcmVhdGVzLXN0YWNraW5nLWNvbnRleHQtaW5saW5lLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJl
IF0KIHdlYmtpdC5vcmcvYi8xNjM5NzkgZmFzdC9jc3Mvd2lsbC1jaGFuZ2Uvd2lsbC1jaGFuZ2Ut
Y3JlYXRlcy1zdGFja2luZy1jb250ZXh0Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIApAQCAt
MzM2NywxMCArMzM2MSw2IEBAIHdlYmtpdC5vcmcvYi8xODQ3NzggaW5zcGVjdG9yL2NhbnZhcy9z
ZXRTaGFkZXJQcm9ncmFtSGlnaGxpZ2h0ZWQuaHRtbCBbIEZhaWx1cmUKIHdlYmtpdC5vcmcvYi8x
ODQ3NzkgdHJhbnNpdGlvbnMvY2xpcC1wYXRoLXBhdGgtdHJhbnNpdGlvbnMuaHRtbCBbIEZhaWx1
cmUgXQogd2Via2l0Lm9yZy9iLzE4NDc3OSB0cmFuc2l0aW9ucy9jbGlwLXBhdGgtdHJhbnNpdGlv
bnMuaHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTg1MDcyIGZhc3QvZXZlbnRzL21v
dXNlLWNsaWNrLWV2ZW50cy5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTg1MDcyIGZh
c3QvZXZlbnRzL2NvbnRleHQtYWN0aXZhdGVkLWJ5LWtleS1ldmVudC5odG1sIFsgRmFpbHVyZSBd
Ci13ZWJraXQub3JnL2IvMTg1MDcyIGZhc3QvZXZlbnRzL21vdXNlLWN1cnNvci1jaGFuZ2UuaHRt
bCBbIEZhaWx1cmUgXQotCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v
Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIyBFbmQg
b2Ygbm9uLWNyYXNoaW5nLCBub24tZmxha3kgdGVzdHMgZmFpbGluZwogIy8vLy8vLy8vLy8vLy8v
Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v
Ly8vLy8vLy8vLy8vLy8vLy8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIv
U291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggYTdkYjM1ZmY3OTAuLmIxYzk1OTU2OTA0IDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTA1LTAzICBDYXJsb3MgR2FyY2lhIENhbXBv
cyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTb21lIGV2ZW50IHRlc3Rz
IGZhaWxpbmcgYWZ0ZXIgcjIzMDgxNworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTg1MDcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgRG8gbm90IHNlbmQgbW91c2UgbW92ZSBldmVudHMgdG8gdGhlIFdlYlBy
b2Nlc3MgZm9yIGNyb3NzaW5nIGV2ZW50cyBkdXJpbmcgdGVzdGluZy4gV1RSIG5ldmVyIGdlbmVy
YXRlcyBjcm9zc2luZworICAgICAgICBldmVudHMgYW5kIHRoZXkgY2FuIGNvbmZ1c2UgdGVzdHMu
CisKKyAgICAgICAgRml4ZXM6IGVkaXRpbmcvcGFzdGVib2FyZC9kcmFnLWxpbmstd2l0aC1kYXRh
LXRyYW5zZmVyLWFkZHMtdHJ1c3RlZC1saW5rLXRvLXBhc3RlYm9hcmQuaHRtbAorICAgICAgICAg
ICAgICAgZmFzdC9jc3MvdXNlci1kcmFnLW5vbmUuaHRtbAorICAgICAgICAgICAgICAgZmFzdC9l
dmVudHMvY29udGV4dC1hY3RpdmF0ZWQtYnkta2V5LWV2ZW50Lmh0bWwKKyAgICAgICAgICAgICAg
IGZhc3QvZXZlbnRzL2RyYWctc2VsZWN0cy1pbWFnZS5odG1sCisgICAgICAgICAgICAgICBmYXN0
L2V2ZW50cy9kcm9wem9uZS0wMDUuaHRtbAorICAgICAgICAgICAgICAgZmFzdC9ldmVudHMvbW91
c2UtY2xpY2stZXZlbnRzLmh0bWwKKyAgICAgICAgICAgICAgIGZhc3QvZXZlbnRzL21vdXNlLWN1
cnNvci1jaGFuZ2UuaHRtbAorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi
Vmlld0Jhc2UuY3BwOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VDcm9zc2luZ05vdGlmeUV2
ZW50KToKKwogMjAxOC0wNS0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp
YS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjIyNzcyKTogW0dUS11bV1BFXSBXZWJQcm9j
ZXNzIGZyb20gV2ViS2l0R3RrKyAyLjE5Ljl4IFNJR1NFVnMgaW4gV2ViS2l0OjpXZWJQcm9jZXNz
OjplbnN1cmVOZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb24oKSBhdCBTb3VyY2UvV2ViS2l0L1dlYlBy
b2Nlc3MvV2ViUHJvY2Vzcy5jcHA6MTEyNwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy
b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv
Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRleCA2ZjhlZWFiOGE3OS4uM2I0
ZTk4OGEyYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi
S2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsv
V2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC04OTcsNyArODk3LDcgQEAgc3RhdGljIGdib29sZWFu
IHdlYmtpdFdlYlZpZXdCYXNlQ3Jvc3NpbmdOb3RpZnlFdmVudChHdGtXaWRnZXQqIHdpZGdldCwg
R2RrRXZlbnQKICAgICAvLyBEbyBub3Qgc2VuZCBtb3VzZSBtb3ZlIGV2ZW50cyB0byB0aGUgV2Vi
UHJvY2VzcyBmb3IgY3Jvc3NpbmcgZXZlbnRzIGR1cmluZyB0ZXN0aW5nLgogICAgIC8vIFdUUiBu
ZXZlciBnZW5lcmF0ZXMgY3Jvc3NpbmcgZXZlbnRzIGFuZCB0aGV5IGNhbiBjb25mdXNlIHRlc3Rz
LgogICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODUwNzIu
Ci0gICAgaWYgKHByaXYtPnBhZ2VQcm94eS0+cHJvY2VzcygpLnByb2Nlc3NQb29sKCkuY29uZmln
dXJhdGlvbigpLmZ1bGx5U3luY2hyb25vdXNNb2RlSXNBbGxvd2VkRm9yVGVzdGluZygpKQorICAg
IGlmIChVTkxJS0VMWShwcml2LT5wYWdlUHJveHktPnByb2Nlc3MoKS5wcm9jZXNzUG9vbCgpLmNv
bmZpZ3VyYXRpb24oKS5mdWxseVN5bmNocm9ub3VzTW9kZUlzQWxsb3dlZEZvclRlc3RpbmcoKSkp
CiAgICAgICAgIHJldHVybiBHREtfRVZFTlRfUFJPUEFHQVRFOwogI2VuZGlmCiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>339402</attachid>
            <date>2018-05-03 04:16:30 -0700</date>
            <delta_ts>2018-05-03 08:58:16 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk2-wtr-crossing-events.diff</filename>
            <type>text/plain</type>
            <size>6456</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBjNWQwOTFmMTc5OS4uNjdhMDBhY2UyNGYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz
L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor
MjAxOC0wNS0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK
KyAgICAgICAgW0dUS10gU29tZSBldmVudCB0ZXN0cyBmYWlsaW5nIGFmdGVyIHIyMzA4MTcKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTA3MgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBleHBl
Y3RhdGlvbnMgZm9yIHRlc3RzIHRoYXQgYXJlIHBhc3Npbmcgbm93LgorCisgICAgICAgICogcGxh
dGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTgtMDUtMDIgIFNhaWQgQWJvdS1IYWxs
YXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBIaWRpbmcgdGhlbiBzaG93
aW5nIGFuIDxvYmplY3Q+IG9mIHR5cGUgaW1hZ2UgbWFrZXMgdGhlIHVuZGVybGF5aW5nIGltYWdl
IGRpc2FwcGVhcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl
Y3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRl
eCAyNWU2ZTU3ZWQ2MC4uOTc0NmVkYmUzMzggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm
b3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9U
ZXN0RXhwZWN0YXRpb25zCkBAIC0yMzQ5LDcgKzIzNDksNiBAQCB3ZWJraXQub3JnL2IvMTU3MTc5
IGVkaXRpbmcvcGFzdGVib2FyZC9kcmFnLXNlbGVjdGVkLWltYWdlLXRvLWNvbnRlbnRlZGl0YWJs
ZS5odAogd2Via2l0Lm9yZy9iLzE1NzE3OSBlZGl0aW5nL3Bhc3RlYm9hcmQvZHJvcC1maWxlLXN2
Zy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTU3MTc5IGVkaXRpbmcvcGFzdGVib2Fy
ZC9kcm9wLWlucHV0dGV4dC1hY3F1aXJlcy1zdHlsZS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQu
b3JnL2IvMTU3MTc5IGVkaXRpbmcvcGFzdGVib2FyZC9kcm9wLWxpbmsuaHRtbCBbIEZhaWx1cmUg
XQotd2Via2l0Lm9yZy9iLzE1NzE3OSBlZGl0aW5nL3Bhc3RlYm9hcmQvZHJhZy1saW5rLXdpdGgt
ZGF0YS10cmFuc2Zlci1hZGRzLXRydXN0ZWQtbGluay10by1wYXN0ZWJvYXJkLmh0bWwgWyBGYWls
dXJlIF0KIHdlYmtpdC5vcmcvYi8xNTcxNzkgZWRpdGluZy9wYXN0ZWJvYXJkL2Ryb3AtdGV4dC13
aXRob3V0LXNlbGVjdGlvbi5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTU3MTc5IGVk
aXRpbmcvcGFzdGVib2FyZC9nZXQtZGF0YS10ZXh0LXBsYWluLWRyb3AuaHRtbCBbIEZhaWx1cmUg
XQogd2Via2l0Lm9yZy9iLzE1NzE3OSBlZGl0aW5nL3Bhc3RlYm9hcmQvc21hcnQtZHJhZy1kcm9w
Lmh0bWwgWyBGYWlsdXJlIF0KQEAgLTIzNzAsNyArMjM2OSw2IEBAIHdlYmtpdC5vcmcvYi8xNTcx
NzkgZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC5odG1sIFsgRmFpbHVyZSBUaW1lb3V0IF0KIHdl
YmtpdC5vcmcvYi8xNTcxNzkgZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC1zdWJmcmFtZS1kYXRh
VHJhbnNmZXIuaHRtbCBbIEZhaWx1cmUgVGltZW91dCBdCiB3ZWJraXQub3JnL2IvNDIxOTQgZmFz
dC9ldmVudHMvZHJhZy1hbmQtZHJvcC1saW5rLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcv
Yi8xNTcxNzkgZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC1saW5rLWludG8tZm9jdXNlZC1jb250
ZW50ZWRpdGFibGUuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE1NzE3OSBmYXN0L2V2
ZW50cy9kcmFnLXNlbGVjdHMtaW1hZ2UuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE1
NzE3OSBmYXN0L2V2ZW50cy9kcmFnZ2FibGUtZGl2LWN1c3RvbWRhdGEuaHRtbCBbIEZhaWx1cmUg
XQogd2Via2l0Lm9yZy9iLzE1NzE3OSBmYXN0L2V2ZW50cy9kcmFnZ2FibGUtZGl2LW5vZGF0YS5o
dG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTU3MTc5IGZhc3QvZXZlbnRzL2Ryb3B6b25l
LTAwMS5odG1sIFsgRmFpbHVyZSBUaW1lb3V0IF0KQEAgLTI2MDMsOCArMjYwMSw2IEBAIHdlYmtp
dC5vcmcvYi81ODg0NSBmYXN0L2RvbS90aXRsZS1kaXJlY3Rpb25hbGl0eS1yZW1vdmVDaGlsZC5o
dG1sIFsgRmFpbHVyZSBdCiAjIEhUVFAgMjA0IChObyBDb250ZW50KSBzaG91bGQgYmUgaWdub3Jl
ZAogd2Via2l0Lm9yZy9iLzYwMjA2IGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNwb25zZTIwNC5o
dG1sIFsgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi82MTYzMCBmYXN0L2V2ZW50cy9kcm9wem9u
ZS0wMDUuaHRtbCBbIEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvNjgyNzggaHR0cC90ZXN0cy9o
aXN0b3J5L2JhY2std2l0aC1mcmFnbWVudC1jaGFuZ2UucGhwIFsgUGFzcyBGYWlsdXJlIF0KIAog
d2Via2l0Lm9yZy9iLzY4NTEyIGFjY2Vzc2liaWxpdHkvYXJpYS1oaWRkZW4tdXBkYXRlcy1hbGxk
ZXNjZW5kYW50cy5odG1sIFsgRmFpbHVyZSBdCkBAIC0zMDc5LDggKzMwNzUsNiBAQCB3ZWJraXQu
b3JnL2IvMTYzOTcyIGZhc3QvY2FudmFzL2NhbnZhcy1ncmFkaWVudC1hZGRTdG9wLWVycm9yLmh0
bWwgWyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzE2Mzk3NCBmYXN0L2NhbnZhcy9kcmF3SW1h
Z2Utd2l0aC1uZWdhdGl2ZS1zb3VyY2UtZGVzdGluYXRpb24uaHRtbCBbIEZhaWx1cmUgXQogCi13
ZWJraXQub3JnL2IvMTYzOTc2IGZhc3QvY3NzL3VzZXItZHJhZy1ub25lLmh0bWwgWyBGYWlsdXJl
IF0KLQogd2Via2l0Lm9yZy9iLzE2Mzk3NyBmYXN0L2Nzcy93aWxsLWNoYW5nZS93aWxsLWNoYW5n
ZS1jcmVhdGVzLXN0YWNraW5nLWNvbnRleHQtaW5saW5lLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJl
IF0KIHdlYmtpdC5vcmcvYi8xNjM5NzkgZmFzdC9jc3Mvd2lsbC1jaGFuZ2Uvd2lsbC1jaGFuZ2Ut
Y3JlYXRlcy1zdGFja2luZy1jb250ZXh0Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIApAQCAt
MzM2NywxMCArMzM2MSw2IEBAIHdlYmtpdC5vcmcvYi8xODQ3NzggaW5zcGVjdG9yL2NhbnZhcy9z
ZXRTaGFkZXJQcm9ncmFtSGlnaGxpZ2h0ZWQuaHRtbCBbIEZhaWx1cmUKIHdlYmtpdC5vcmcvYi8x
ODQ3NzkgdHJhbnNpdGlvbnMvY2xpcC1wYXRoLXBhdGgtdHJhbnNpdGlvbnMuaHRtbCBbIEZhaWx1
cmUgXQogd2Via2l0Lm9yZy9iLzE4NDc3OSB0cmFuc2l0aW9ucy9jbGlwLXBhdGgtdHJhbnNpdGlv
bnMuaHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTg1MDcyIGZhc3QvZXZlbnRzL21v
dXNlLWNsaWNrLWV2ZW50cy5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTg1MDcyIGZh
c3QvZXZlbnRzL2NvbnRleHQtYWN0aXZhdGVkLWJ5LWtleS1ldmVudC5odG1sIFsgRmFpbHVyZSBd
Ci13ZWJraXQub3JnL2IvMTg1MDcyIGZhc3QvZXZlbnRzL21vdXNlLWN1cnNvci1jaGFuZ2UuaHRt
bCBbIEZhaWx1cmUgXQotCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v
Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIyBFbmQg
b2Ygbm9uLWNyYXNoaW5nLCBub24tZmxha3kgdGVzdHMgZmFpbGluZwogIy8vLy8vLy8vLy8vLy8v
Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v
Ly8vLy8vLy8vLy8vLy8vLy8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIv
U291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggYTdkYjM1ZmY3OTAuLmIxYzk1OTU2OTA0IDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTA1LTAzICBDYXJsb3MgR2FyY2lhIENhbXBv
cyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTb21lIGV2ZW50IHRlc3Rz
IGZhaWxpbmcgYWZ0ZXIgcjIzMDgxNworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTg1MDcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgRG8gbm90IHNlbmQgbW91c2UgbW92ZSBldmVudHMgdG8gdGhlIFdlYlBy
b2Nlc3MgZm9yIGNyb3NzaW5nIGV2ZW50cyBkdXJpbmcgdGVzdGluZy4gV1RSIG5ldmVyIGdlbmVy
YXRlcyBjcm9zc2luZworICAgICAgICBldmVudHMgYW5kIHRoZXkgY2FuIGNvbmZ1c2UgdGVzdHMu
CisKKyAgICAgICAgRml4ZXM6IGVkaXRpbmcvcGFzdGVib2FyZC9kcmFnLWxpbmstd2l0aC1kYXRh
LXRyYW5zZmVyLWFkZHMtdHJ1c3RlZC1saW5rLXRvLXBhc3RlYm9hcmQuaHRtbAorICAgICAgICAg
ICAgICAgZmFzdC9jc3MvdXNlci1kcmFnLW5vbmUuaHRtbAorICAgICAgICAgICAgICAgZmFzdC9l
dmVudHMvY29udGV4dC1hY3RpdmF0ZWQtYnkta2V5LWV2ZW50Lmh0bWwKKyAgICAgICAgICAgICAg
IGZhc3QvZXZlbnRzL2RyYWctc2VsZWN0cy1pbWFnZS5odG1sCisgICAgICAgICAgICAgICBmYXN0
L2V2ZW50cy9kcm9wem9uZS0wMDUuaHRtbAorICAgICAgICAgICAgICAgZmFzdC9ldmVudHMvbW91
c2UtY2xpY2stZXZlbnRzLmh0bWwKKyAgICAgICAgICAgICAgIGZhc3QvZXZlbnRzL21vdXNlLWN1
cnNvci1jaGFuZ2UuaHRtbAorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi
Vmlld0Jhc2UuY3BwOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VDcm9zc2luZ05vdGlmeUV2
ZW50KToKKwogMjAxOC0wNS0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp
YS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjIyNzcyKTogW0dUS11bV1BFXSBXZWJQcm9j
ZXNzIGZyb20gV2ViS2l0R3RrKyAyLjE5Ljl4IFNJR1NFVnMgaW4gV2ViS2l0OjpXZWJQcm9jZXNz
OjplbnN1cmVOZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb24oKSBhdCBTb3VyY2UvV2ViS2l0L1dlYlBy
b2Nlc3MvV2ViUHJvY2Vzcy5jcHA6MTEyNwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy
b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv
Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRleCBiOWQ2ZGNkYzMyNS4uM2I0
ZTk4OGEyYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi
S2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsv
V2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC04OTMsNiArODkzLDE0IEBAIHN0YXRpYyBnYm9vbGVh
biB3ZWJraXRXZWJWaWV3QmFzZUNyb3NzaW5nTm90aWZ5RXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQs
IEdka0V2ZW50CiAgICAgaWYgKHByaXYtPmF1dGhlbnRpY2F0aW9uRGlhbG9nKQogICAgICAgICBy
ZXR1cm4gR0RLX0VWRU5UX1BST1BBR0FURTsKIAorI2lmIEVOQUJMRShERVZFTE9QRVJfTU9ERSkK
KyAgICAvLyBEbyBub3Qgc2VuZCBtb3VzZSBtb3ZlIGV2ZW50cyB0byB0aGUgV2ViUHJvY2VzcyBm
b3IgY3Jvc3NpbmcgZXZlbnRzIGR1cmluZyB0ZXN0aW5nLgorICAgIC8vIFdUUiBuZXZlciBnZW5l
cmF0ZXMgY3Jvc3NpbmcgZXZlbnRzIGFuZCB0aGV5IGNhbiBjb25mdXNlIHRlc3RzLgorICAgIC8v
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODUwNzIuCisgICAgaWYg
KFVOTElLRUxZKHByaXYtPnBhZ2VQcm94eS0+cHJvY2VzcygpLnByb2Nlc3NQb29sKCkuY29uZmln
dXJhdGlvbigpLmZ1bGx5U3luY2hyb25vdXNNb2RlSXNBbGxvd2VkRm9yVGVzdGluZygpKSkKKyAg
ICAgICAgcmV0dXJuIEdES19FVkVOVF9QUk9QQUdBVEU7CisjZW5kaWYKKwogICAgIC8vIEluIHRo
ZSBjYXNlIG9mIGNyb3NzaW5nIGV2ZW50cywgaXQncyB2ZXJ5IGltcG9ydGFudCB0aGUgYWN0dWFs
IGNvb3JkaW5hdGVzIHRoZSBXZWJQcm9jZXNzIHJlY2VpdmVzLCBiZWNhdXNlIG9uY2UgdGhlIG1v
dXNlIGxlYXZlcwogICAgIC8vIHRoZSB3ZWIgdmlldywgdGhlIFdlYlByb2Nlc3Mgd29uJ3QgcmVj
ZWl2ZSBtb3JlIGV2ZW50cyB1bnRpbCB0aGUgbW91c2UgZW50ZXJzIGFnYWluIGluIHRoZSB3ZWIg
dmlldy4gU28sIGlmIHRoZSBjb29yZGluYXRlcyBvZiB0aGUgbGVhdmUKICAgICAvLyBldmVudCBh
cmUgbm90IGFjY3VyYXRlLCB0aGUgV2ViUHJvY2VzcyBtaWdodCBub3Qga25vdyB0aGUgbW91c2Ug
bGVmdCB0aGUgdmlldy4gVGhpcyBjYW4gaGFwcGVuIGJlY2F1c2Ugb2YgZG91YmxlIHRvIGludGVn
ZXIgY29udmVyc2lvbiwK
</data>
<flag name="review"
          id="357650"
          type_id="1"
          status="+"
          setter="mcatanzaro"
    />
          </attachment>
      

    </bug>

</bugzilla>