18507 2008-04-14 23:20:16 -0700 compilation error while building with gcc < 4.x compilers on latest nightlies 2008-04-17 23:41:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 0 msrinirao webkit-unassigned oldest_to_newest 77655 0 msrinirao 2008-04-14 23:20:16 -0700 While trying to build WebKit-r31848(or any latest nightlies), Compilation breaks if we compile using GCC compilers with gcc version less than 4. I got this error with my gcc version 3.4.6. compilation breaks while doing: arm-linux-g++ -DHAVE_CONFIG_H -I. -I.. -DWTF_USE_ICU_UNICODE=1 -DBUILDING_GTK__=1 -DWTF_CHANGES -DNDEBUG -DENABLE_ICONDATABASE=0 -I../JavaScriptCore -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf -I../JavaScriptCore/kjs -I./DerivedSources -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf/unicode -I./JavaScriptCore/pcre -I./JavaScriptCore/kjs -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -fno-rtti -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -fno-exceptions -pthread -I/home/srinirao/webkit/myprefix/include/glib-2.0 -I/home/srinirao/webkit/myprefix/lib/glib-2.0/include -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -I/home/srinirao/webkit/myprefix/include/readline -D_REENTRANT -I/home/srinirao/webkit/myprefix/include -fno-strict-aliasing -O2 -MT JavaScriptCore/kjs/libJavaScriptCore_la-JSGlobalObject.lo -MD -MP -MF JavaScriptCore/kjs/.deps/libJavaScriptCore_la-JSGlobalObject.Tpo -c ../JavaScriptCore/kjs/JSGlobalObject.cpp -fPIC -DPIC -o JavaScriptCore/kjs/.libs/libJavaScriptCore_la-JSGlobalObject.o mv -f JavaScriptCore/kjs/.deps/libJavaScriptCore_la-JSGlobalObject.Tpo JavaScriptCore/kjs/.deps/libJavaScriptCore_la-JSGlobalObject.Plo /bin/sh ./libtool --tag=CXX --mode=compile arm-linux-g++ -DHAVE_CONFIG_H -I. -I.. -DWTF_USE_ICU_UNICODE=1 -DBUILDING_GTK__=1 -DWTF_CHANGES -DNDEBUG -DENABLE_ICONDATABASE=0 -I../JavaScriptCore -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf -I../JavaScriptCore/kjs -I./DerivedSources -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf/unicode -I./JavaScriptCore/pcre -I./JavaScriptCore/kjs -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -fno-rtti -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -fno-exceptions -pthread -I/home/srinirao/webkit/myprefix/include/glib-2.0 -I/home/srinirao/webkit/myprefix/lib/glib-2.0/include -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -I/home/srinirao/webkit/myprefix/include/readline -D_REENTRANT -I/home/srinirao/webkit/myprefix/include -fno-strict-aliasing -O2 -MT JavaScriptCore/kjs/libJavaScriptCore_la-AllInOneFile.lo -MD -MP -MF JavaScriptCore/kjs/.deps/libJavaScriptCore_la-AllInOneFile.Tpo -c -o JavaScriptCore/kjs/libJavaScriptCore_la-AllInOneFile.lo `test -f 'JavaScriptCore/kjs/AllInOneFile.cpp' || echo '../'`JavaScriptCore/kjs/AllInOneFile.cpp arm-linux-g++ -DHAVE_CONFIG_H -I. -I.. -DWTF_USE_ICU_UNICODE=1 -DBUILDING_GTK__=1 -DWTF_CHANGES -DNDEBUG -DENABLE_ICONDATABASE=0 -I../JavaScriptCore -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf -I../JavaScriptCore/kjs -I./DerivedSources -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf/unicode -I./JavaScriptCore/pcre -I./JavaScriptCore/kjs -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -fno-rtti -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -fno-exceptions -pthread -I/home/srinirao/webkit/myprefix/include/glib-2.0 -I/home/srinirao/webkit/myprefix/lib/glib-2.0/include -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -I/home/srinirao/webkit/myprefix/include/readline -D_REENTRANT -I/home/srinirao/webkit/myprefix/include -fno-strict-aliasing -O2 -MT JavaScriptCore/kjs/libJavaScriptCore_la-AllInOneFile.lo -MD -MP -MF JavaScriptCore/kjs/.deps/libJavaScriptCore_la-AllInOneFile.Tpo -c ../JavaScriptCore/kjs/AllInOneFile.cpp -fPIC -DPIC -o JavaScriptCore/kjs/.libs/libJavaScriptCore_la-AllInOneFile.o In file included from ../JavaScriptCore/kjs/AllInOneFile.cpp:40: ../JavaScriptCore/kjs/dtoa.cpp: In function `void kjs_freedtoa(char*)': ../JavaScriptCore/kjs/dtoa.cpp:2259: warning: cast from `char*' to `int*' increases required alignment of target type In file included from ../JavaScriptCore/kjs/AllInOneFile.cpp:55: ../JavaScriptCore/kjs/nodes.cpp: At global scope: ../JavaScriptCore/kjs/nodes.h:213: error: `typedef enum KJS::ExpressionNode::CallerType KJS::ExpressionNode::CallerType' is protected ../JavaScriptCore/kjs/nodes.cpp:1090: error: within this context make[1]: *** [JavaScriptCore/kjs/libJavaScriptCore_la-AllInOneFile.lo] Error 1 make[1]: Leaving directory `/home/srinirao/webkit/WebKit-r31848/objdir' make: *** [all] Error 2 I will be submitting a patch for this bug. 77656 1 20545 msrinirao 2008-04-14 23:24:37 -0700 Created attachment 20545 Suggested patch for this bug Attaching the patch for this bug. I am not sure whether it affects any other module. Please review it. 77657 2 20545 eric 2008-04-14 23:39:56 -0700 Comment on attachment 20545 Suggested patch for this bug Although darin's comment was kinda confusing on the list, the proper behavior is to mark the patch review=? instead of review=+ This patch requires a ChangeLog (see prepare-ChangeLog) before we can land it. Thanks! 77660 3 20546 msrinirao 2008-04-15 00:22:52 -0700 Created attachment 20546 latest patch Patch created using svn-createpatch on 31896 Prepared a Changelog entry 77766 4 20577 msrinirao 2008-04-15 23:53:41 -0700 Created attachment 20577 better patch This patch contains no ifdefs to check the compiler. But the line with typedef is made public in order for the compilation with GCC 3.x go through. Done after discussing with Eric Seidel and Maciej Stachowiak on IRC 77891 5 20612 msrinirao 2008-04-16 22:40:42 -0700 Created attachment 20612 corrected patch Added the Changelog comment 77892 6 20612 mjs 2008-04-16 22:43:06 -0700 Comment on attachment 20612 corrected patch r=me 78067 7 mrowe 2008-04-17 23:41:53 -0700 Landed in r31991. 20545 2008-04-14 23:24:37 -0700 2008-04-15 00:22:52 -0700 Suggested patch for this bug gcc_3.4.6.compiler.patch text/plain 656 msrinirao LS0tIGEvV2ViS2l0LXIzMTg0OC9KYXZhU2NyaXB0Q29yZS9ranMvbm9kZXMuaAkyMDA4LTA0LTEy IDA0OjI4OjAwLjAwMDAwMDAwMCArMDUzMAorKysgYi9XZWJLaXQtcjMxODQ4L0phdmFTY3JpcHRD b3JlL2tqcy9ub2Rlcy5oCTIwMDgtMDQtMTQgMTk6MDQ6MjYuMDAwMDAwMDAwICswNTMwCkBAIC0y MDcsNyArMjA3LDkgQEAKICAgICAgICAgLy8gVXNlZCB0byBvcHRpbWl6ZSB0aG9zZSBub2RlcyB0 aGF0IGRvIGV4dHJhIHdvcmsgd2hlbiByZXR1cm5pbmcgYSByZXN1bHQsIGV2ZW4gaWYgdGhlIHJl c3VsdCBoYXMgbm8gc2VtYW50aWMgcmVsZXZhbmNlCiAgICAgICAgIHZpcnR1YWwgdm9pZCBvcHRp bWl6ZUZvclVubmVjZXNzYXJ5UmVzdWx0KCkgeyB9CiAKKyNpZiAhQ09NUElMRVIoR0NDKSB8fCAo Q09NUElMRVIoR0NDKSAmJiBfX0dOVUNfXyA+PSA0KQogICAgIHByb3RlY3RlZDoKKyNlbmRpZgog ICAgICAgICB0eXBlZGVmIGVudW0geyBFdmFsT3BlcmF0b3IsIEZ1bmN0aW9uQ2FsbCB9IENhbGxl clR5cGU7CiAgICAgICAgIHRlbXBsYXRlIDxDYWxsZXJUeXBlLCBib29sPiBpbmxpbmUgSlNWYWx1 ZSogcmVzb2x2ZUFuZENhbGwoRXhlY1N0YXRlKiwgY29uc3QgSWRlbnRpZmllciYsIEFyZ3VtZW50 c05vZGUqLCBzaXplX3QgPSAwKTsKICAgICB9Owo= 20546 2008-04-15 00:22:52 -0700 2008-04-15 23:53:41 -0700 latest patch svn-patch.txt text/plain 1135 msrinirao SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDMxODk2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDgtMDQtMTUgIFNyaW5pdmFz IFJhby4gTSBIYW1zZSA8bXNyaW5pcmFvQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENoYW5nZUxvZzoKKyAgICAgICAgKiBranMv bm9kZXMuaDoKKwogMjAwOC0wNC0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9r anMvbm9kZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvbm9kZXMuaAkocmV2 aXNpb24gMzE4OTYpCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvbm9kZXMuaAkod29ya2luZyBjb3B5 KQpAQCAtMjA3LDcgKzIwNyw5IEBAIG5hbWVzcGFjZSBLSlMgewogICAgICAgICAvLyBVc2VkIHRv IG9wdGltaXplIHRob3NlIG5vZGVzIHRoYXQgZG8gZXh0cmEgd29yayB3aGVuIHJldHVybmluZyBh IHJlc3VsdCwgZXZlbiBpZiB0aGUgcmVzdWx0IGhhcyBubyBzZW1hbnRpYyByZWxldmFuY2UKICAg ICAgICAgdmlydHVhbCB2b2lkIG9wdGltaXplRm9yVW5uZWNlc3NhcnlSZXN1bHQoKSB7IH0KIAor I2lmICFDT01QSUxFUihHQ0MpIHx8IChDT01QSUxFUihHQ0MpICYmIF9fR05VQ19fID49IDQpCiAg ICAgcHJvdGVjdGVkOgorI2VuZGlmCiAgICAgICAgIHR5cGVkZWYgZW51bSB7IEV2YWxPcGVyYXRv ciwgRnVuY3Rpb25DYWxsIH0gQ2FsbGVyVHlwZTsKICAgICAgICAgdGVtcGxhdGUgPENhbGxlclR5 cGUsIGJvb2w+IGlubGluZSBKU1ZhbHVlKiByZXNvbHZlQW5kQ2FsbChFeGVjU3RhdGUqLCBjb25z dCBJZGVudGlmaWVyJiwgQXJndW1lbnRzTm9kZSosIHNpemVfdCA9IDApOwogICAgIH07Cg== 20577 2008-04-15 23:53:41 -0700 2008-04-16 22:40:42 -0700 better patch svn-patch.txt text/plain 1162 msrinirao SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDMxOTMzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDgtMDQtMTUgIFNyaW5pdmFz IFJhby4gTSBIYW1zZSAgPG1zcmluaXJhb0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDaGFuZ2VMb2c6CisgICAgICAgICoga2pz L25vZGVzLmg6CisKIDIwMDgtMDQtMTUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtLgpJbmRleDogSmF2YVNjcmlwdENvcmUv a2pzL25vZGVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL25vZGVzLmgJKHJl dmlzaW9uIDMxOTMzKQorKysgSmF2YVNjcmlwdENvcmUva2pzL25vZGVzLmgJKHdvcmtpbmcgY29w eSkKQEAgLTIwNyw4ICsyMDcsOSBAQCBuYW1lc3BhY2UgS0pTIHsKICAgICAgICAgLy8gVXNlZCB0 byBvcHRpbWl6ZSB0aG9zZSBub2RlcyB0aGF0IGRvIGV4dHJhIHdvcmsgd2hlbiByZXR1cm5pbmcg YSByZXN1bHQsIGV2ZW4gaWYgdGhlIHJlc3VsdCBoYXMgbm8gc2VtYW50aWMgcmVsZXZhbmNlCiAg ICAgICAgIHZpcnR1YWwgdm9pZCBvcHRpbWl6ZUZvclVubmVjZXNzYXJ5UmVzdWx0KCkgeyB9CiAK LSAgICBwcm90ZWN0ZWQ6CisgICAgICAgIC8vVGhpcyBuZWVkIHRvIGJlIGluIHB1YmxpYyBpbiBv cmRlciB0byBjb21waWxlIHVzaW5nIEdDQyAzLnggCiAgICAgICAgIHR5cGVkZWYgZW51bSB7IEV2 YWxPcGVyYXRvciwgRnVuY3Rpb25DYWxsIH0gQ2FsbGVyVHlwZTsKKyAgICBwcm90ZWN0ZWQ6CiAg ICAgICAgIHRlbXBsYXRlIDxDYWxsZXJUeXBlLCBib29sPiBpbmxpbmUgSlNWYWx1ZSogcmVzb2x2 ZUFuZENhbGwoRXhlY1N0YXRlKiwgY29uc3QgSWRlbnRpZmllciYsIEFyZ3VtZW50c05vZGUqLCBz aXplX3QgPSAwKTsKICAgICB9OwogCg== 20612 2008-04-16 22:40:42 -0700 2008-04-16 22:43:06 -0700 corrected patch svn-patch.txt text/plain 1198 msrinirao SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDMxOTMzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDgtMDQtMTUgIFNyaW5pdmFz IFJhby4gTSBIYW1zZSAgPG1zcmluaXJhb0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBranMvbm9kZXMuaDogQ2FsbGVyVHlwZSBk ZWZpbml0aW9uIG1hZGUgcHVibGljIGZvciBnY2MgMy54IGNvbXBpbGF0aW9uCisKIDIwMDgtMDQt MTUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtLgpJbmRleDogSmF2YVNjcmlwdENvcmUva2pzL25vZGVzLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL25vZGVzLmgJKHJldmlzaW9uIDMxOTMzKQorKysgSmF2 YVNjcmlwdENvcmUva2pzL25vZGVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTIwNyw4ICsyMDcsOSBA QCBuYW1lc3BhY2UgS0pTIHsKICAgICAgICAgLy8gVXNlZCB0byBvcHRpbWl6ZSB0aG9zZSBub2Rl cyB0aGF0IGRvIGV4dHJhIHdvcmsgd2hlbiByZXR1cm5pbmcgYSByZXN1bHQsIGV2ZW4gaWYgdGhl IHJlc3VsdCBoYXMgbm8gc2VtYW50aWMgcmVsZXZhbmNlCiAgICAgICAgIHZpcnR1YWwgdm9pZCBv cHRpbWl6ZUZvclVubmVjZXNzYXJ5UmVzdWx0KCkgeyB9CiAKLSAgICBwcm90ZWN0ZWQ6CisgICAg ICAgIC8vVGhpcyBuZWVkIHRvIGJlIGluIHB1YmxpYyBpbiBvcmRlciB0byBjb21waWxlIHVzaW5n IEdDQyAzLnggCiAgICAgICAgIHR5cGVkZWYgZW51bSB7IEV2YWxPcGVyYXRvciwgRnVuY3Rpb25D YWxsIH0gQ2FsbGVyVHlwZTsKKyAgICBwcm90ZWN0ZWQ6CiAgICAgICAgIHRlbXBsYXRlIDxDYWxs ZXJUeXBlLCBib29sPiBpbmxpbmUgSlNWYWx1ZSogcmVzb2x2ZUFuZENhbGwoRXhlY1N0YXRlKiwg Y29uc3QgSWRlbnRpZmllciYsIEFyZ3VtZW50c05vZGUqLCBzaXplX3QgPSAwKTsKICAgICB9Owog Cg==