185061 2018-04-26 17:34:44 -0700 REGRESSION (r231039): RunUnitTests step reports disabled tests as failures 2018-04-26 18:26:19 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=184982 InRadar P2 Normal --- 1 ryanhaddad ryanhaddad aakash_jain commit-queue webkit-bug-importer oldest_to_newest 1418336 0 ryanhaddad 2018-04-26 17:34:44 -0700 After https://trac.webkit.org/changeset/231039, the RunUnitTests step reports 13 test failures even though none actually failed. This is because it is comparing the total number of tests to the number that passed without taking into account those that are disabled. See: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/builds/4950 1418338 1 338942 ryanhaddad 2018-04-26 17:43:44 -0700 Created attachment 338942 Patch 1418340 2 338942 ryanhaddad 2018-04-26 17:46:51 -0700 Comment on attachment 338942 Patch Thanks, Aakash! 1418351 3 338942 commit-queue 2018-04-26 18:25:16 -0700 Comment on attachment 338942 Patch Clearing flags on attachment: 338942 Committed r231083: <https://trac.webkit.org/changeset/231083> 1418352 4 commit-queue 2018-04-26 18:25:17 -0700 All reviewed patches have been landed. Closing bug. 1418353 5 webkit-bug-importer 2018-04-26 18:26:19 -0700 <rdar://problem/39778914> 338942 2018-04-26 17:43:44 -0700 2018-04-26 18:25:16 -0700 Patch bug-185061-20180426174344.patch text/plain 2819 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMDgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzg2ZWZkZDU3NGE4ZWU5ZmQ3OGYyMDYwYzA4Mjg5YTIz NzljZTdmMS4uZDhjZDUyYjY0ODViZWY3ODc5N2U2MWUxY2Y3ZDBmNmIwM2QwNGViNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTA0LTI2ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIFJFR1JFU1NJT04gKHIyMzEwMzkpOiBSdW5Vbml0VGVzdHMgc3RlcCByZXBvcnRzIGRp c2FibGVkIHRlc3RzIGFzIGZhaWx1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODUwNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3N0ZXBzLnB5OgorICAgICAgICAoUnVuVW5pdFRlc3RzLmNvdW50RmFpbHVyZXMpOiBSZXR1 cm4gdGhlIGRpZmZlcmVuY2UgYmV0d2VlbiB0aGUgdG90YWwgbnVtYmVyIG9mIHRlc3RzIHJ1biBh bmQgdGhlIG51bWJlciB0aGF0IHBhc3NlZC4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9zdGVwc191bml0dGVzdC5weTogQWRkIGEgdGVzdC4KKwog MjAxOC0wNC0yNiAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAg ICAgICAgQWRkIHJlbGVhc2UgYm90cyBmb3IgV2luQ2Fpcm8uCmRpZmYgLS1naXQgYS9Ub29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9zdGVwcy5weSBiL1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3N0ZXBzLnB5CmluZGV4 IDdlYTExZjJjZjAzNjczZTlmMjMzZDVhMDlhYzU0YzNjZmUzOWRmMGYuLmQxYzY1NzExOTI4ZWQz NGQ1MmFlYzUzN2Y0ZWE2NWJkNTZjYzQwMGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3N0ZXBzLnB5CisrKyBiL1Rvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3N0ZXBzLnB5CkBAIC00OTgsMTIg KzQ5OCwxMSBAQCBjbGFzcyBSdW5Vbml0VGVzdHMoVGVzdFdpdGhGYWlsdXJlQ291bnQpOgogCiAg ICAgZGVmIGNvdW50RmFpbHVyZXMoc2VsZiwgY21kKToKICAgICAgICAgbG9nX3RleHQgPSBjbWQu bG9nc1snc3RkaW8nXS5nZXRUZXh0KCkKLSAgICAgICAgY291bnQgPSAwCiAKICAgICAgICAgbWF0 Y2ggPSByZS5zZWFyY2gocidSYW4gKD9QPHJhbj5cZCspIHRlc3RzIG9mICg/UDx0b3RhbD5cZCsp IHdpdGggKD9QPHBhc3NlZD5cZCspIHN1Y2Nlc3NmdWwnLCBsb2dfdGV4dCkKICAgICAgICAgaWYg bm90IG1hdGNoOgogICAgICAgICAgICAgcmV0dXJuIC0xCi0gICAgICAgIHJldHVybiBpbnQobWF0 Y2guZ3JvdXAoJ3RvdGFsJykpIC0gaW50KG1hdGNoLmdyb3VwKCdwYXNzZWQnKSkKKyAgICAgICAg cmV0dXJuIGludChtYXRjaC5ncm91cCgncmFuJykpIC0gaW50KG1hdGNoLmdyb3VwKCdwYXNzZWQn KSkKIAogCiBjbGFzcyBSdW5QeXRob25UZXN0cyhUZXN0V2l0aEZhaWx1cmVDb3VudCk6CmRpZmYg LS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9z dGVwc191bml0dGVzdC5weSBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL3N0ZXBzX3VuaXR0ZXN0LnB5CmluZGV4IGUzNzk3MmE0NTRjMWM1NWZkMzQ0ODVj NWEzYmE2NjhkZTQ5ZGNjYmYuLjY0ZDI3NDZkZjA4NzcwOTE4NjJhZjA1ZWZjZjhiNTdkODQ5MzAx N2UgMTAwNzU1Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL3N0ZXBzX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3N0ZXBzX3VuaXR0ZXN0LnB5CkBAIC0yMzksNiArMjM5LDIw IEBAIHdvcmtlci8wIGV4aXRpbmcKIFJhbiAxODg4IHRlc3RzIG9mIDE4ODggd2l0aCAxODg4IHN1 Y2Nlc3NmdWwKIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogQWxsIHRlc3RzIHN1Y2Nl c3NmdWxseSBwYXNzZWQhCisiIiIpCisKKyAgICBkZWYgdGVzdF9ub19mYWlsdXJlc19vcl90aW1l b3V0c193aXRoX2Rpc2FibGVkKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydEZhaWx1cmVzKDAs ICIiIi4uLgord29ya2VyLzAgVGVzdFdURi5XVEZfVmFyaWFudC5PcGVyYXRvckFtcGVyc2FuZCBQ YXNzZWQKK3dvcmtlci8wIFRlc3RXVEYuV1RGX1ZhcmlhbnQuUmVmIFBhc3NlZAord29ya2VyLzAg VGVzdFdURi5XVEZfVmFyaWFudC5SZWZQdHIgUGFzc2VkCit3b3JrZXIvMCBUZXN0V1RGLldURl9W YXJpYW50LlJldGFpblB0ciBQYXNzZWQKK3dvcmtlci8wIFRlc3RXVEYuV1RGX1ZhcmlhbnQuVmlz aXRvclVzaW5nTWFrZVZpc2l0b3IgUGFzc2VkCit3b3JrZXIvMCBUZXN0V1RGLldURl9WYXJpYW50 LlZpc2l0b3JVc2luZ1N3aXRjaE9uIFBhc3NlZAord29ya2VyLzAgZXhpdGluZworUmFuIDE4ODEg dGVzdHMgb2YgMTg4OCB3aXRoIDE4ODEgc3VjY2Vzc2Z1bAorLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCitBbGwgdGVzdHMgc3VjY2Vzc2Z1bGx5IHBhc3NlZCEKICIiIikKIAogICAgIGRl ZiB0ZXN0X29uZV9mYWlsdXJlKHNlbGYpOgo=