185037 2018-04-26 11:34:08 -0700 Remove WebCore::-qualifier in NetworkLoadChecker.cpp 2018-04-26 11:43:24 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aestes beidson webkit-bug-importer youennf oldest_to_newest 1418167 0 dbates 2018-04-26 11:34:08 -0700 Notice that NetworkLoadChecker.cpp as a "using namespace WebCore" at the top of the file. It is unnecessary to qualify WebCore types following this directive. 1418168 1 338899 dbates 2018-04-26 11:36:00 -0700 Created attachment 338899 Patch 1418169 2 338899 dbates 2018-04-26 11:37:17 -0700 Comment on attachment 338899 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338899&action=review > Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:183 > + m_storedCredentialsPolicy = m_isSameOriginRequest && m_origin->canRequest(request.url()) ? StoredCredentialsPolicy::Use : StoredCredentialsPolicy::DoNotUse; Will add a remark about this change in the ChangeLog before landing. While I was here I noticed there was an extra space character on the right-hand side of the assignment and the parentheses are not necessary in the right-hand side of the assignment. 1418171 3 dbates 2018-04-26 11:42:13 -0700 Committed r231060: <https://trac.webkit.org/changeset/231060> 1418172 4 webkit-bug-importer 2018-04-26 11:43:24 -0700 <rdar://problem/39765096> 338899 2018-04-26 11:36:00 -0700 2018-04-26 11:38:26 -0700 Patch bug-185037-20180426113559.patch text/plain 4377 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYwZTM5NGU2ZjA3NWFhYmI4 MDViMDYwNzkyZDczOGM2MjBjODdlNTIuLmU1MjE4YWI0ZDg1OGUwYjcxNTJkMjlkZWZhNjhjNjY5 YmQ1ZTJjZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDQtMjYgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBXZWJDb3JlOjotcXVh bGlmaWVyIGluIE5ldHdvcmtMb2FkQ2hlY2tlci5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTAzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGlzIHVubmNlc3NzYXJ5IHRvIHF1YWxpZnkgV2Vi Q29yZSB0eXBlcyBpbiBOZXR3b3JrTG9hZENoZWNrZXIuY3BwIGFzIGl0IGhhcyBhCisgICAgICAg ICJ1c2luZyBuYW1lc3BhY2UgV2ViQ29yZSIgZGlyZWN0aXZlLgorCisgICAgICAgICogTmV0d29y a1Byb2Nlc3MvTmV0d29ya0xvYWRDaGVja2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29y a0xvYWRDaGVja2VyOjpOZXR3b3JrTG9hZENoZWNrZXIpOgorICAgICAgICAoV2ViS2l0OjpOZXR3 b3JrTG9hZENoZWNrZXI6OmNoZWNrUmVkaXJlY3Rpb24pOgorICAgICAgICAoV2ViS2l0OjpOZXR3 b3JrTG9hZENoZWNrZXI6OnZhbGlkYXRlUmVzcG9uc2UpOgorICAgICAgICAoV2ViS2l0OjpOZXR3 b3JrTG9hZENoZWNrZXI6OmNvbnRpbnVlQ2hlY2tpbmdSZXF1ZXN0KToKKyAgICAgICAgKFdlYktp dDo6TmV0d29ya0xvYWRDaGVja2VyOjpwcm9jZXNzQ29udGVudEV4dGVuc2lvblJ1bGVzRm9yTG9h ZCk6CisKIDIwMTgtMDQtMjYgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbmFtZSBOZXR3b3JrTG9hZENoZWNrZXI6OnJldHVybkVycm9yKCkgdG8gTmV0d29y a0xvYWRDaGVja2VyOjphY2Nlc3NDb250cm9sRXJyb3JGb3JWYWxpZGF0aW9uSGFuZGxlcigpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkQ2hlY2tl ci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkQ2hlY2tlci5j cHAKaW5kZXggZmY3NGU4ODlkOTA3ZGY2NzhiOTc4YjJiZjYwNWQ3OTkzNDZhMmQyNy4uYTdjNWVi OGJiYmRhN2RmMTY0N2VjYjhkOGRlM2JlOTNiNjZhMzA5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZENoZWNrZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWRDaGVja2VyLmNwcApAQCAtNDIsNyArNDIs NyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKLU5l dHdvcmtMb2FkQ2hlY2tlcjo6TmV0d29ya0xvYWRDaGVja2VyKFdlYkNvcmU6OkZldGNoT3B0aW9u cyYmIG9wdGlvbnMsIFBBTDo6U2Vzc2lvbklEIHNlc3Npb25JRCwgV2ViQ29yZTo6SFRUUEhlYWRl ck1hcCYmIG9yaWdpbmFsUmVxdWVzdEhlYWRlcnMsIFVSTCYmIHVybCwgUmVmUHRyPFNlY3VyaXR5 T3JpZ2luPiYmIHNvdXJjZU9yaWdpbiwgUHJlZmxpZ2h0UG9saWN5IHByZWZsaWdodFBvbGljeSkK K05ldHdvcmtMb2FkQ2hlY2tlcjo6TmV0d29ya0xvYWRDaGVja2VyKEZldGNoT3B0aW9ucyYmIG9w dGlvbnMsIFBBTDo6U2Vzc2lvbklEIHNlc3Npb25JRCwgSFRUUEhlYWRlck1hcCYmIG9yaWdpbmFs UmVxdWVzdEhlYWRlcnMsIFVSTCYmIHVybCwgUmVmUHRyPFNlY3VyaXR5T3JpZ2luPiYmIHNvdXJj ZU9yaWdpbiwgUHJlZmxpZ2h0UG9saWN5IHByZWZsaWdodFBvbGljeSkKICAgICA6IG1fb3B0aW9u cyhXVEZNb3ZlKG9wdGlvbnMpKQogICAgICwgbV9zZXNzaW9uSUQoc2Vzc2lvbklEKQogICAgICwg bV9vcmlnaW5hbFJlcXVlc3RIZWFkZXJzKFdURk1vdmUob3JpZ2luYWxSZXF1ZXN0SGVhZGVycykp CkBAIC04Nyw3ICs4Nyw3IEBAIHZvaWQgTmV0d29ya0xvYWRDaGVja2VyOjpwcmVwYXJlUmVkaXJl Y3RlZFJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0KQogICAgICAgICByZXF1ZXN0LnNl dEhUVFBIZWFkZXJGaWVsZChIVFRQSGVhZGVyTmFtZTo6RE5ULCBtX2RudEhlYWRlclZhbHVlKTsK IH0KIAotdm9pZCBOZXR3b3JrTG9hZENoZWNrZXI6OmNoZWNrUmVkaXJlY3Rpb24oV2ViQ29yZTo6 UmVzb3VyY2VSZXNwb25zZSYgcmVkaXJlY3RSZXNwb25zZSwgUmVzb3VyY2VSZXF1ZXN0JiYgcmVx dWVzdCwgVmFsaWRhdGlvbkhhbmRsZXImJiBoYW5kbGVyKQordm9pZCBOZXR3b3JrTG9hZENoZWNr ZXI6OmNoZWNrUmVkaXJlY3Rpb24oUmVzb3VyY2VSZXNwb25zZSYgcmVkaXJlY3RSZXNwb25zZSwg UmVzb3VyY2VSZXF1ZXN0JiYgcmVxdWVzdCwgVmFsaWRhdGlvbkhhbmRsZXImJiBoYW5kbGVyKQog ewogICAgIEFTU0VSVCghaXNDaGVja2luZygpKTsKIApAQCAtMTM1LDcgKzEzNSw3IEBAIFJlc291 cmNlRXJyb3IgTmV0d29ya0xvYWRDaGVja2VyOjp2YWxpZGF0ZVJlc3BvbnNlKFJlc291cmNlUmVz cG9uc2UmIHJlc3BvbnNlKQogICAgIEFTU0VSVChtX29wdGlvbnMubW9kZSA9PSBGZXRjaE9wdGlv bnM6Ok1vZGU6OkNvcnMpOwogCiAgICAgU3RyaW5nIGVycm9yTWVzc2FnZTsKLSAgICBpZiAoIVdl YkNvcmU6OnBhc3Nlc0FjY2Vzc0NvbnRyb2xDaGVjayhyZXNwb25zZSwgbV9zdG9yZWRDcmVkZW50 aWFsc1BvbGljeSwgKm1fb3JpZ2luLCBlcnJvck1lc3NhZ2UpKQorICAgIGlmICghcGFzc2VzQWNj ZXNzQ29udHJvbENoZWNrKHJlc3BvbnNlLCBtX3N0b3JlZENyZWRlbnRpYWxzUG9saWN5LCAqbV9v cmlnaW4sIGVycm9yTWVzc2FnZSkpCiAgICAgICAgIHJldHVybiBSZXNvdXJjZUVycm9yIHsgU3Ry aW5nIHsgfSwgMCwgbV91cmwsIFdURk1vdmUoZXJyb3JNZXNzYWdlKSwgUmVzb3VyY2VFcnJvcjo6 VHlwZTo6QWNjZXNzQ29udHJvbCB9OwogCiAgICAgcmVzcG9uc2Uuc2V0VGFpbnRpbmcoUmVzb3Vy Y2VSZXNwb25zZTo6VGFpbnRpbmc6OkNvcnMpOwpAQCAtMTgwLDcgKzE4MCw3IEBAIHZvaWQgTmV0 d29ya0xvYWRDaGVja2VyOjpjb250aW51ZUNoZWNraW5nUmVxdWVzdChSZXNvdXJjZVJlcXVlc3Qm JiByZXF1ZXN0LCBWYWxpCiAgICAgfQogCiAgICAgaWYgKG1fb3B0aW9ucy5jcmVkZW50aWFscyA9 PSBGZXRjaE9wdGlvbnM6OkNyZWRlbnRpYWxzOjpTYW1lT3JpZ2luKQotICAgICAgICBtX3N0b3Jl ZENyZWRlbnRpYWxzUG9saWN5ID0gIChtX2lzU2FtZU9yaWdpblJlcXVlc3QgJiYgbV9vcmlnaW4t PmNhblJlcXVlc3QocmVxdWVzdC51cmwoKSkpID8gU3RvcmVkQ3JlZGVudGlhbHNQb2xpY3k6OlVz ZSA6IFN0b3JlZENyZWRlbnRpYWxzUG9saWN5OjpEb05vdFVzZTsKKyAgICAgICAgbV9zdG9yZWRD cmVkZW50aWFsc1BvbGljeSA9IG1faXNTYW1lT3JpZ2luUmVxdWVzdCAmJiBtX29yaWdpbi0+Y2Fu UmVxdWVzdChyZXF1ZXN0LnVybCgpKSA/IFN0b3JlZENyZWRlbnRpYWxzUG9saWN5OjpVc2UgOiBT dG9yZWRDcmVkZW50aWFsc1BvbGljeTo6RG9Ob3RVc2U7CiAKICAgICBpZiAoZG9lc05vdE5lZWRD T1JTQ2hlY2socmVxdWVzdC51cmwoKSkpIHsKICAgICAgICAgaGFuZGxlcihXVEZNb3ZlKHJlcXVl c3QpKTsKQEAgLTMwOCw3ICszMDgsNyBAQCBDb250ZW50U2VjdXJpdHlQb2xpY3kqIE5ldHdvcmtM b2FkQ2hlY2tlcjo6Y29udGVudFNlY3VyaXR5UG9saWN5KCkgY29uc3QKIH0KIAogI2lmIEVOQUJM RShDT05URU5UX0VYVEVOU0lPTlMpCi12b2lkIE5ldHdvcmtMb2FkQ2hlY2tlcjo6cHJvY2Vzc0Nv bnRlbnRFeHRlbnNpb25SdWxlc0ZvckxvYWQoUmVzb3VyY2VSZXF1ZXN0JiYgcmVxdWVzdCwgQ29t cGxldGlvbkhhbmRsZXI8dm9pZChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmJiwgY29uc3QgQ29u dGVudEV4dGVuc2lvbnM6OkJsb2NrZWRTdGF0dXMmKT4mJiBjYWxsYmFjaykKK3ZvaWQgTmV0d29y a0xvYWRDaGVja2VyOjpwcm9jZXNzQ29udGVudEV4dGVuc2lvblJ1bGVzRm9yTG9hZChSZXNvdXJj ZVJlcXVlc3QmJiByZXF1ZXN0LCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKFJlc291cmNlUmVxdWVz dCYmLCBjb25zdCBDb250ZW50RXh0ZW5zaW9uczo6QmxvY2tlZFN0YXR1cyYpPiYmIGNhbGxiYWNr KQogewogICAgIGlmICghbV91c2VyQ29udGVudENvbnRyb2xsZXJJZGVudGlmaWVyKSB7CiAgICAg ICAgIENvbnRlbnRFeHRlbnNpb25zOjpCbG9ja2VkU3RhdHVzIHN0YXR1czsK