185004 2018-04-25 15:44:09 -0700 DocumentLoader::loadMainResource() does not use main document's cache partition name for subframe document contrary to comment 2018-04-25 16:50:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build All All NEW InRadar P2 Normal --- 168806 1 dbates webkit-unassigned achristensen beidson webkit-bug-importer oldest_to_newest 1417825 0 dbates 2018-04-25 15:44:09 -0700 In DocumentLoader::loadMainResource() there is a comment that we should use the cache partition of the main document when loading a subframe. But we do not do that. Should we do it? Is the comment incorrect? [[ void DocumentLoader::loadMainResource(ResourceRequest&& request) { static NeverDestroyed<ResourceLoaderOptions> mainResourceLoadOptions(SendCallbacks, SniffContent, BufferData, StoredCredentialsPolicy::Use, ClientCredentialPolicy::MayAskClientForCredentials, FetchOptions::Credentials::Include, SkipSecurityCheck, FetchOptions::Mode::Navigate, IncludeCertificateInfo, ContentSecurityPolicyImposition::SkipPolicyCheck, DefersLoadingPolicy::AllowDefersLoading, CachingPolicy::AllowCaching); CachedResourceRequest mainResourceRequest(ResourceRequest(request), mainResourceLoadOptions); if (!m_frame->isMainFrame() && m_frame->document()) { // If we are loading the main resource of a subframe, use the cache partition of the main document. mainResourceRequest.setDomainForCachePartition(*m_frame->document()); ... ]] <https://trac.webkit.org/browser/trunk/Source/WebCore/loader/DocumentLoader.cpp?rev=+230944#L1732> 1417870 1 webkit-bug-importer 2018-04-25 16:50:15 -0700 <rdar://problem/39740615>