184999 2018-04-25 13:37:34 -0700 Missing closing parenthesis when determining INSTALL_PATH build setting in WebCore.xcconfig 2018-04-25 16:23:07 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh commit-queue mitz thorton webkit-bug-importer oldest_to_newest 1417743 0 wenson_hsieh 2018-04-25 13:37:34 -0700 This doesn't appear to have any impact, since the resulting build settings are the same before and after the change (using `xcodebuild -showBuildSettings`). Just a bit of tidying. 1417748 1 338784 wenson_hsieh 2018-04-25 13:40:43 -0700 Created attachment 338784 Patch 1417759 2 338784 thorton 2018-04-25 13:51:54 -0700 Comment on attachment 338784 Patch Why is this not just using WK_COCOA_TOUCH the normal way? Why all this notting and emptying? 1417762 3 wenson_hsieh 2018-04-25 13:59:37 -0700 (In reply to Tim Horton from comment #2) > Comment on attachment 338784 [details] > Patch > > Why is this not just using WK_COCOA_TOUCH the normal way? Why all this > notting and emptying? Good point...perhaps it should be something like this? INSTALL_PATH = $(INSTALL_PATH_$(WK_COCOA_TOUCH)); INSTALL_PATH_cocoatouch = $(WK_ALTERNATE_WEBKIT_SDK_PATH)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks; INSTALL_PATH_ = $(WEBCORE_FRAMEWORKS_DIR); 1417767 4 thorton 2018-04-25 14:14:07 -0700 Yes 1417771 5 338791 wenson_hsieh 2018-04-25 14:21:13 -0700 Created attachment 338791 Patch 1417848 6 338791 commit-queue 2018-04-25 16:23:06 -0700 Comment on attachment 338791 Patch Clearing flags on attachment: 338791 Committed r231032: <https://trac.webkit.org/changeset/231032> 1417849 7 commit-queue 2018-04-25 16:23:07 -0700 All reviewed patches have been landed. Closing bug. 338784 2018-04-25 13:40:43 -0700 2018-04-25 14:21:12 -0700 Patch bug-184999-20180425134043.patch text/plain 1844 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwOTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTk1ZGY1MjE5NTE4Njhh NmQyNzZhMzA0MjlmMmIzZDFjZTEyNjkyZC4uNDljMDFhODgxMzY3ZWNjNWM1NTEzMjUxMTZiMGVm MDBkZTFlNmUxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA0LTI1ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIE1pc3NpbmcgY2xv c2luZyBwYXJlbnRoZXNpcyB3aGVuIGRldGVybWluaW5nIElOU1RBTExfUEFUSCBidWlsZCBzZXR0 aW5nIGluIFdlYkNvcmUueGNjb25maWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NDk5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZHMgYSBtaXNzaW5nIHBhcmVudGhlc2lzLiBObyBjaGFuZ2UgaW4g YmVoYXZpb3IuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9XZWJDb3JlLnhjY29uZmlnOgor CiAyMDE4LTA0LTI0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAg IFJlbGVhc2UgYXNzZXJ0IGluIFNjcmlwdENvbnRyb2xsZXI6OmNhbkV4ZWN1dGVTY3JpcHRzIHZp YSBDYWNoZWRTVkdGb250OjplbnN1cmVDdXN0b21Gb250RGF0YSBkdXJpbmcKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL1dlYkNvcmUueGNjb25maWcgYi9Tb3VyY2Uv V2ViQ29yZS9Db25maWd1cmF0aW9ucy9XZWJDb3JlLnhjY29uZmlnCmluZGV4IGJiMTUyNGQ5Yjc5 YmYxMDQ3MWUzMWJlYjU4ZGFlODFmZTZiZDcyODIuLjdmNzliYmJkZDZlZWJmZjVhYWExYzQzNzU3 MTI4ZTViYTljMDk0M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25z L1dlYkNvcmUueGNjb25maWcKKysrIGIvU291cmNlL1dlYkNvcmUvQ29uZmlndXJhdGlvbnMvV2Vi Q29yZS54Y2NvbmZpZwpAQCAtNTAsNyArNTAsNyBAQCBMSUJXRUJSVENfSEVBREVSX1NFQVJDSF9Q QVRIUyA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKS91c3IvbG9jYWwvaW5jbHVkZS93ZWJydGMgJAog SEVBREVSX1NFQVJDSF9QQVRIUyA9IFBBTCBGb3J3YXJkaW5nSGVhZGVycyAvdXNyL2luY2x1ZGUv bGlieHNsdCAvdXNyL2luY2x1ZGUvbGlieG1sMiAiJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2 ZWRTb3VyY2VzL1dlYkNvcmUiICIkKEJVSUxUX1BST0RVQ1RTX0RJUikvdXNyL2xvY2FsL2luY2x1 ZGUiICQoV0VCS0lUQURESVRJT05TX0hFQURFUl9TRUFSQ0hfUEFUSFMpICQoTElCV0VCUlRDX0hF QURFUl9TRUFSQ0hfUEFUSFMpICQoSEVBREVSX1NFQVJDSF9QQVRIUykgJChTUkNST09UKTsKIElO Rk9QTElTVF9GSUxFID0gSW5mby5wbGlzdDsKIAotSU5TVEFMTF9QQVRIID0gJChJTlNUQUxMX1BB VEhfQ09DT0FfVE9VQ0hfJChXS19OT1RfJChXS19FTVBUWV8kKFdLX0NPQ09BX1RPVUNIKSkpOwor SU5TVEFMTF9QQVRIID0gJChJTlNUQUxMX1BBVEhfQ09DT0FfVE9VQ0hfJChXS19OT1RfJChXS19F TVBUWV8kKFdLX0NPQ09BX1RPVUNIKSkpKTsKIElOU1RBTExfUEFUSF9DT0NPQV9UT1VDSF9ZRVMg PSAkKFdLX0FMVEVSTkFURV9XRUJLSVRfU0RLX1BBVEgpJChTWVNURU1fTElCUkFSWV9ESVIpL1By aXZhdGVGcmFtZXdvcmtzOwogSU5TVEFMTF9QQVRIX0NPQ09BX1RPVUNIX05PID0gJChXRUJDT1JF X0ZSQU1FV09SS1NfRElSKTsKIAo= 338791 2018-04-25 14:21:13 -0700 2018-04-25 16:23:06 -0700 Patch bug-184999-20180425142113.patch text/plain 2109 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTIyYmJjZDg0YTVmODI2 NWU3ODY2ZTZiNzk3Yzg3ZTYwZDVmZWM4Zi4uYWY4YzBhMWIzODc1MmVhZTFlMWFmZGFlN2Q5Y2Zh OGM3NTM4YzdiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA0LTI1ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIE1pc3NpbmcgY2xv c2luZyBwYXJlbnRoZXNpcyB3aGVuIGRldGVybWluaW5nIElOU1RBTExfUEFUSCBidWlsZCBzZXR0 aW5nIGluIFdlYkNvcmUueGNjb25maWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NDk5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFR3ZWFrcyBhIGxpbmUgaW4gV2ViQ29yZS54Y2NvbmZpZyB0aGF0IGNv bXB1dGVzIElOU1RBTExfUEFUSCwgc28gdGhhdCBpdCBkb2Vzbid0IHVzZSBXS19OT1Qgb3IgV0tf RU1QVFkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9XZWJDb3JlLnhjY29uZmlnOgorCiAy MDE4LTA0LTI1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xG Q10gSW1wbGVtZW50IExheW91dDo6QmxvY2tDb250YWluZXIgZnVuY3Rpb25zLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvQ29uZmlndXJhdGlvbnMvV2ViQ29yZS54Y2NvbmZpZyBiL1NvdXJj ZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL1dlYkNvcmUueGNjb25maWcKaW5kZXggYmIxNTI0ZDli NzliZjEwNDcxZTMxYmViNThkYWU4MWZlNmJkNzI4Mi4uNmU2YTI0NDFhYzJkM2ExOGM0ZjFmODZi MGU2YmM3MGFmZDc5NmQ3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ29uZmlndXJhdGlv bnMvV2ViQ29yZS54Y2NvbmZpZworKysgYi9Tb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9X ZWJDb3JlLnhjY29uZmlnCkBAIC01MCw5ICs1MCw5IEBAIExJQldFQlJUQ19IRUFERVJfU0VBUkNI X1BBVEhTID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL3Vzci9sb2NhbC9pbmNsdWRlL3dlYnJ0YyAk CiBIRUFERVJfU0VBUkNIX1BBVEhTID0gUEFMIEZvcndhcmRpbmdIZWFkZXJzIC91c3IvaW5jbHVk ZS9saWJ4c2x0IC91c3IvaW5jbHVkZS9saWJ4bWwyICIkKEJVSUxUX1BST0RVQ1RTX0RJUikvRGVy aXZlZFNvdXJjZXMvV2ViQ29yZSIgIiQoQlVJTFRfUFJPRFVDVFNfRElSKS91c3IvbG9jYWwvaW5j bHVkZSIgJChXRUJLSVRBRERJVElPTlNfSEVBREVSX1NFQVJDSF9QQVRIUykgJChMSUJXRUJSVENf SEVBREVSX1NFQVJDSF9QQVRIUykgJChIRUFERVJfU0VBUkNIX1BBVEhTKSAkKFNSQ1JPT1QpOwog SU5GT1BMSVNUX0ZJTEUgPSBJbmZvLnBsaXN0OwogCi1JTlNUQUxMX1BBVEggPSAkKElOU1RBTExf UEFUSF9DT0NPQV9UT1VDSF8kKFdLX05PVF8kKFdLX0VNUFRZXyQoV0tfQ09DT0FfVE9VQ0gpKSk7 Ci1JTlNUQUxMX1BBVEhfQ09DT0FfVE9VQ0hfWUVTID0gJChXS19BTFRFUk5BVEVfV0VCS0lUX1NE S19QQVRIKSQoU1lTVEVNX0xJQlJBUllfRElSKS9Qcml2YXRlRnJhbWV3b3JrczsKLUlOU1RBTExf UEFUSF9DT0NPQV9UT1VDSF9OTyA9ICQoV0VCQ09SRV9GUkFNRVdPUktTX0RJUik7CitJTlNUQUxM X1BBVEggPSAkKElOU1RBTExfUEFUSF8kKFdLX0NPQ09BX1RPVUNIKSk7CitJTlNUQUxMX1BBVEhf Y29jb2F0b3VjaCA9ICQoV0tfQUxURVJOQVRFX1dFQktJVF9TREtfUEFUSCkkKFNZU1RFTV9MSUJS QVJZX0RJUikvUHJpdmF0ZUZyYW1ld29ya3M7CitJTlNUQUxMX1BBVEhfID0gJChXRUJDT1JFX0ZS QU1FV09SS1NfRElSKTsKIAogRFlMSUJfSU5TVEFMTF9OQU1FX0JBU0UgPSAkKERZTElCX0lOU1RB TExfTkFNRV9CQVNFX1BMQVRGT1JNKTsKIERZTElCX0lOU1RBTExfTkFNRV9CQVNFX1BMQVRGT1JN W3Nkaz1pcGhvbmUqXSA9ICQoU1lTVEVNX0xJQlJBUllfRElSKS9Qcml2YXRlRnJhbWV3b3JrczsK