<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>184998</bug_id>
          
          <creation_ts>2018-04-25 13:37:30 -0700</creation_ts>
          <short_desc>getUnlinkedGlobalFunctionExecutable should only save things to the code cache if the option is set</short_desc>
          <delta_ts>2018-04-25 13:43:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Keith Miller">keith_miller</reporter>
          <assigned_to name="Keith Miller">keith_miller</assigned_to>
          <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1417742</commentid>
    <comment_count>0</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-04-25 13:37:30 -0700</bug_when>
    <thetext>getUnlinkedGlobalFunctionExecutable should only save things to the code cache if the option is set</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1417745</commentid>
    <comment_count>1</comment_count>
      <attachid>338782</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-04-25 13:39:13 -0700</bug_when>
    <thetext>Created attachment 338782
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1417749</commentid>
    <comment_count>2</comment_count>
      <attachid>338785</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-04-25 13:41:52 -0700</bug_when>
    <thetext>Created attachment 338785
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1417750</commentid>
    <comment_count>3</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-04-25 13:43:07 -0700</bug_when>
    <thetext>&lt;rdar://problem/39676828&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1417751</commentid>
    <comment_count>4</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-04-25 13:43:51 -0700</bug_when>
    <thetext>Committed r231018: &lt;https://trac.webkit.org/changeset/231018&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>338782</attachid>
            <date>2018-04-25 13:39:13 -0700</date>
            <delta_ts>2018-04-25 13:41:51 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-184998-20180425133912.patch</filename>
            <type>text/plain</type>
            <size>1703</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2
NDMxMzM4Y2M5NjFlNTA3NGJkYjJjNmI3ZTgzOWFlOTkxMWJmYjU5Li43ZWJiZDc0ZDcxMDc5OGNk
ZDBmYmVkMzNhOWViMTEyODhmNjc4MDU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNSBAQAorMjAxOC0wNC0yNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl
LmNvbT4KKworICAgICAgICBnZXRVbmxpbmtlZEdsb2JhbEZ1bmN0aW9uRXhlY3V0YWJsZSBzaG91
bGQgb25seSBzYXZlIHRoaW5ncyB0byB0aGUgY29kZSBjYWNoZSBpZiB0aGUgb3B0aW9uIGlzIHNl
dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0OTk4
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxzbyBv
bmx5IGlmIHdhcyBzdWNjZXNzZnVsbHkgYWJsZSB0byBwYXJzZSB0aGUgZnVuY3Rpb24uCisKKyAg
ICAgICAgKiBydW50aW1lL0NvZGVDYWNoZS5jcHA6CisgICAgICAgIChKU0M6OkNvZGVDYWNoZTo6
Z2V0VW5saW5rZWRHbG9iYWxGdW5jdGlvbkV4ZWN1dGFibGUpOgorCiAyMDE4LTA0LTI1ICBLZWl0
aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBtaXNzaW5n
IHNjb3BlIHJlbGVhc2UgdG8gZnVuY3Rpb25Qcm90b0Z1bmNUb1N0cmluZwpkaWZmIC0tZ2l0IGEv
U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcCBiL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9ydW50aW1lL0NvZGVDYWNoZS5jcHAKaW5kZXggYWQyNTQzOTE4N2NkMWQ0Yzg3
MWFjMDhhZjE5ZmNlYjBkYTMyMmU4OC4uNDQzY2QxMDQ2NWI1YjAzNWYwMmIyYTQ5OGYzZGNlYzBh
M2ViYjk0YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNh
Y2hlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuY3Bw
CkBAIC0xNTgsNyArMTU4LDggQEAgVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGUqIENvZGVDYWNo
ZTo6Z2V0VW5saW5rZWRHbG9iYWxGdW5jdGlvbkV4ZWN1dGFibGUoVk0mIHYKICAgICBmdW5jdGlv
bkV4ZWN1dGFibGUtPnNldFNvdXJjZVVSTERpcmVjdGl2ZShzb3VyY2UucHJvdmlkZXIoKS0+c291
cmNlVVJMKCkpOwogICAgIGZ1bmN0aW9uRXhlY3V0YWJsZS0+c2V0U291cmNlTWFwcGluZ1VSTERp
cmVjdGl2ZShzb3VyY2UucHJvdmlkZXIoKS0+c291cmNlTWFwcGluZ1VSTCgpKTsKIAotICAgIG1f
c291cmNlQ29kZS5hZGRDYWNoZShrZXksIFNvdXJjZUNvZGVWYWx1ZSh2bSwgZnVuY3Rpb25FeGVj
dXRhYmxlLCBtX3NvdXJjZUNvZGUuYWdlKCkpKTsKKyAgICBpZiAoZnVuY3Rpb25FeGVjdXRhYmxl
ICYmIE9wdGlvbnM6OnVzZUNvZGVDYWNoZSgpKQorICAgICAgICBtX3NvdXJjZUNvZGUuYWRkQ2Fj
aGUoa2V5LCBTb3VyY2VDb2RlVmFsdWUodm0sIGZ1bmN0aW9uRXhlY3V0YWJsZSwgbV9zb3VyY2VD
b2RlLmFnZSgpKSk7CiAgICAgcmV0dXJuIGZ1bmN0aW9uRXhlY3V0YWJsZTsKIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>338785</attachid>
            <date>2018-04-25 13:41:52 -0700</date>
            <delta_ts>2018-04-25 13:43:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-184998-20180425134152.patch</filename>
            <type>text/plain</type>
            <size>1612</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2
NDMxMzM4Y2M5NjFlNTA3NGJkYjJjNmI3ZTgzOWFlOTkxMWJmYjU5Li43ZDM0NDkzY2NjZTg3YzEw
ZmUwZTVhYmU2NTViNTI3ZTIwODhmMGIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxMyBAQAorMjAxOC0wNC0yNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl
LmNvbT4KKworICAgICAgICBnZXRVbmxpbmtlZEdsb2JhbEZ1bmN0aW9uRXhlY3V0YWJsZSBzaG91
bGQgb25seSBzYXZlIHRoaW5ncyB0byB0aGUgY29kZSBjYWNoZSBpZiB0aGUgb3B0aW9uIGlzIHNl
dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0OTk4
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50
aW1lL0NvZGVDYWNoZS5jcHA6CisgICAgICAgIChKU0M6OkNvZGVDYWNoZTo6Z2V0VW5saW5rZWRH
bG9iYWxGdW5jdGlvbkV4ZWN1dGFibGUpOgorCiAyMDE4LTA0LTI1ICBLZWl0aCBNaWxsZXIgIDxr
ZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBtaXNzaW5nIHNjb3BlIHJlbGVh
c2UgdG8gZnVuY3Rpb25Qcm90b0Z1bmNUb1N0cmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT
Y3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y
dW50aW1lL0NvZGVDYWNoZS5jcHAKaW5kZXggYWQyNTQzOTE4N2NkMWQ0Yzg3MWFjMDhhZjE5ZmNl
YjBkYTMyMmU4OC4uMTA2ZmZjZDFhZjYxZmVlYzBjOTA2YWIxMjQ5NjQwNjMwODQzNTEwYSAxMDA2
NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcAorKysg
Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuY3BwCkBAIC0xNTgsNyAr
MTU4LDggQEAgVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGUqIENvZGVDYWNoZTo6Z2V0VW5saW5r
ZWRHbG9iYWxGdW5jdGlvbkV4ZWN1dGFibGUoVk0mIHYKICAgICBmdW5jdGlvbkV4ZWN1dGFibGUt
PnNldFNvdXJjZVVSTERpcmVjdGl2ZShzb3VyY2UucHJvdmlkZXIoKS0+c291cmNlVVJMKCkpOwog
ICAgIGZ1bmN0aW9uRXhlY3V0YWJsZS0+c2V0U291cmNlTWFwcGluZ1VSTERpcmVjdGl2ZShzb3Vy
Y2UucHJvdmlkZXIoKS0+c291cmNlTWFwcGluZ1VSTCgpKTsKIAotICAgIG1fc291cmNlQ29kZS5h
ZGRDYWNoZShrZXksIFNvdXJjZUNvZGVWYWx1ZSh2bSwgZnVuY3Rpb25FeGVjdXRhYmxlLCBtX3Nv
dXJjZUNvZGUuYWdlKCkpKTsKKyAgICBpZiAoT3B0aW9uczo6dXNlQ29kZUNhY2hlKCkpCisgICAg
ICAgIG1fc291cmNlQ29kZS5hZGRDYWNoZShrZXksIFNvdXJjZUNvZGVWYWx1ZSh2bSwgZnVuY3Rp
b25FeGVjdXRhYmxlLCBtX3NvdXJjZUNvZGUuYWdlKCkpKTsKICAgICByZXR1cm4gZnVuY3Rpb25F
eGVjdXRhYmxlOwogfQogCg==
</data>
<flag name="review"
          id="357058"
          type_id="1"
          status="+"
          setter="saam"
    />
          </attachment>
      

    </bug>

</bugzilla>