184994 2018-04-25 13:18:22 -0700 [LFC] Implement Layout::BlockContainer functions. 2018-04-25 13:36:22 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1417719 0 zalan 2018-04-25 13:18:22 -0700 ssia 1417721 1 338778 zalan 2018-04-25 13:22:48 -0700 Created attachment 338778 Patch 1417730 2 338778 koivisto 2018-04-25 13:30:31 -0700 Comment on attachment 338778 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338778&action=review > Source/WebCore/layout/layouttree/LayoutBlockContainer.cpp:53 > +bool BlockContainer::establishesInlineFormattingContext() const > +{ > + // 9.4.2 Inline formatting contexts > + // An inline formatting context is established by a block container box that contains no block-level boxes. > + for (auto* child = firstInFlowChild(); child; child = child->nextInFlowSibling()) { > + if (child->isBlockLevelBox()) > + return false; > + } > + return hasInFlowOrFloatingChild(); > +} We'll probably need some sort of caching scheme for things like this. The result only changes on tree mutation after all. 1417736 3 zalan 2018-04-25 13:35:48 -0700 Committed r231017: <https://trac.webkit.org/changeset/231017> 1417738 4 webkit-bug-importer 2018-04-25 13:36:22 -0700 <rdar://problem/39732558> 338778 2018-04-25 13:22:48 -0700 2018-04-25 13:24:41 -0700 Patch bug-184994-20180425132247.patch text/plain 1943 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDRkM2NhYmZkN2FkYzY5 Zjk4YmI0YWYxZjIxYTA1YTdlYjFjMjVkMy4uMDNmNDMwNGUzN2EzN2I0ZGE1ZGYyMjc2MWVmMmQz MmIzNDkxOGYwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA0LTI1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gSW1wbGVtZW50IExh eW91dDo6QmxvY2tDb250YWluZXIgZnVuY3Rpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0OTk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCbG9ja0Nv bnRhaW5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrQ29udGFpbmVyOjpC bG9ja0NvbnRhaW5lcik6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrQ29udGFpbmVy Ojplc3RhYmxpc2hlc0lubGluZUZvcm1hdHRpbmdDb250ZXh0IGNvbnN0KToKKwogMjAxOC0wNC0y NSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdIEltcGxl bWVudCBMYXlvdXQ6OkNvbnRhaW5lciBmdW5jdGlvbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCbG9ja0NvbnRhaW5lci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCbG9ja0NvbnRhaW5lci5jcHAKaW5kZXgg YTY0ZWYxZTljZjVkY2FkZDVmYjYyOGQwZGY3YjI2YmY5NDM1MzI5NS4uZDg0N2NkNDQ5YmQwYjlh OWE2YjZkMGFlYjE3YzUyOGMxZGY3MjM5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2xheW91dHRyZWUvTGF5b3V0QmxvY2tDb250YWluZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJsb2NrQ29udGFpbmVyLmNwcApAQCAtMjUsMyAr MjUsMzQgQEAKIAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkxheW91dEJsb2NrQ29u dGFpbmVyLmgiCisKKyNpZiBFTkFCTEUoTEFZT1VUX0ZPUk1BVFRJTkdfQ09OVEVYVCkKKworI2lu Y2x1ZGUgIlJlbmRlclN0eWxlLmgiCisjaW5jbHVkZSA8d3RmL0lzb01hbGxvY0lubGluZXMuaD4K KworbmFtZXNwYWNlIFdlYkNvcmUgeworbmFtZXNwYWNlIExheW91dCB7CisKK1dURl9NQUtFX0lT T19BTExPQ0FURURfSU1QTChCbG9ja0NvbnRhaW5lcik7CisKK0Jsb2NrQ29udGFpbmVyOjpCbG9j a0NvbnRhaW5lcihSZW5kZXJTdHlsZSYmIHN0eWxlKQorICAgIDogQ29udGFpbmVyKFdURk1vdmUo c3R5bGUpKQoreworfQorCitib29sIEJsb2NrQ29udGFpbmVyOjplc3RhYmxpc2hlc0lubGluZUZv cm1hdHRpbmdDb250ZXh0KCkgY29uc3QKK3sKKyAgICAvLyA5LjQuMiBJbmxpbmUgZm9ybWF0dGlu ZyBjb250ZXh0cworICAgIC8vIEFuIGlubGluZSBmb3JtYXR0aW5nIGNvbnRleHQgaXMgZXN0YWJs aXNoZWQgYnkgYSBibG9jayBjb250YWluZXIgYm94IHRoYXQgY29udGFpbnMgbm8gYmxvY2stbGV2 ZWwgYm94ZXMuCisgICAgZm9yIChhdXRvKiBjaGlsZCA9IGZpcnN0SW5GbG93Q2hpbGQoKTsgY2hp bGQ7IGNoaWxkID0gY2hpbGQtPm5leHRJbkZsb3dTaWJsaW5nKCkpIHsKKyAgICAgICAgaWYgKGNo aWxkLT5pc0Jsb2NrTGV2ZWxCb3goKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9 CisgICAgcmV0dXJuIGhhc0luRmxvd09yRmxvYXRpbmdDaGlsZCgpOworfQorCit9Cit9CisKKyNl bmRpZgo=