184983 2018-04-25 11:12:07 -0700 [WPE] Should load injected bundle from builddir in developer builds 2018-04-30 08:02:26 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply clopez commit-queue mcatanzaro pnormand oldest_to_newest 1417633 0 mcatanzaro 2018-04-25 11:12:07 -0700 ** (WPEWebProcess:6695): WARNING **: Error loading the injected bundle (/usr/local/lib64/wpe-webkit-0.1/injected-bundle/libWPEInjectedBundle.so): /usr/local/lib64/wpe-webkit-0.1/injected-bundle/libWPEInjectedBundle.so: cannot open shared object file: No such file or directory It's bonkers that we never noticed this with WebKitGTK+, but we always load the installed injected bundle, never the built version. 1417714 1 mcatanzaro 2018-04-25 13:12:06 -0700 Not a problem for GTK. GTK MiniBrowser uses WEBKIT_INJECTED_BUNDLE_PATH to control this. 1417720 2 338777 mcatanzaro 2018-04-25 13:20:06 -0700 Created attachment 338777 Patch 1417769 3 338777 commit-queue 2018-04-25 14:16:56 -0700 Comment on attachment 338777 Patch Clearing flags on attachment: 338777 Committed r231021: <https://trac.webkit.org/changeset/231021> 1417770 4 commit-queue 2018-04-25 14:16:57 -0700 All reviewed patches have been landed. Closing bug. 1418962 5 pnormand 2018-04-30 02:27:26 -0700 Why is LD_LIBRARY_PATH set only for WPE? 1418971 6 mcatanzaro 2018-04-30 08:02:26 -0700 (In reply to Philippe Normand from comment #5) > Why is LD_LIBRARY_PATH set only for WPE? It should not be needed because for ELF binaries, CMake sets rpath to point to the build directory when linking (and then zeros it at install time). Otherwise, nothing built by CMake would work before it's installed. 338777 2018-04-25 13:20:06 -0700 2018-04-25 14:16:56 -0700 Patch bug-184983-20180425152005.patch text/plain 1428 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwOTk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmVmMjg3NGY0OTZmOGZjYjE3NDEwZGQ1NWM0YTQwMGE4 NzE3NmU4YS4uNzUwNGFiZGQ3MDY2ZjJkNDRhNTZmYjk5MjA4NTMzMmNkNDU2MmI4NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTA0LTI1ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbV1BFXSBTaG91bGQgbG9hZCBpbmplY3RlZCBidW5kbGUgZnJvbSBidWls ZGRpciBpbiBkZXZlbG9wZXIgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODQ5ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTZXQgV0VCS0lUX0lOSkVDVEVEX0JVTkRMRV9QQVRIIHdoZW4gcnVu bmluZyBXUEUgTWluaUJyb3dzZXIuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1taW5pYnJvd3Nl cjoKKwogMjAxOC0wNC0yNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgSW5jb3JyZWN0IG51bWJlciBvZiBXZWJEcml2ZXIgdGVzdCBmYWlsdXJl cyBzaG93biBpbiB0aGUgYm90cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tbWluaWJy b3dzZXIgYi9Ub29scy9TY3JpcHRzL3J1bi1taW5pYnJvd3NlcgppbmRleCAxM2M2ZWE3NjY5ZmJl MGM2MWVkYzYyYTUyNTc2NjdhMjhmODFmMGEzLi44NmNjY2EwZTMzZmE3MGY5OWMzOTAxMjZmMWNj Njg0NTY3MmZmOWEyIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1taW5pYnJvd3Nlcgor KysgYi9Ub29scy9TY3JpcHRzL3J1bi1taW5pYnJvd3NlcgpAQCAtNjAsNiArNjAsNyBAQCBpZiAo aXNHdGsoKSkgewogICAgICRsYXVuY2hlck5hbWUgPSBsYXVuY2hlck5hbWUoKTsKICAgICBAamhi dWlsZFdyYXBwZXIgPSB3cmFwcGVyUHJlZml4SWZOZWVkZWQoKTsKICAgICAkRU5WeyJXRUJLSVRf RVhFQ19QQVRIIn0gPSBjYXRkaXIocHJvZHVjdERpcigpLCAiYmluIik7CisgICAgJEVOVnsiV0VC S0lUX0lOSkVDVEVEX0JVTkRMRV9QQVRIIn0gPSBjYXRkaXIocHJvZHVjdERpcigpLCAibGliIik7 CiAgICAgJEVOVnsiTERfTElCUkFSWV9QQVRIIn0gPSBjYXRkaXIocHJvZHVjdERpcigpLCAibGli IikgLiAoZGVmaW5lZCAkRU5WeyJMRF9MSUJSQVJZX1BBVEgifSA/ICI6IiAuICRFTlZ7IkxEX0xJ QlJBUllfUEFUSCJ9IDogIiIgKTsKICAgICBwcmludCAiU3RhcnRpbmcgJGxhdW5jaGVyTmFtZSBc biI7CiAgICAgZXhlYyBAamhidWlsZFdyYXBwZXIsICRsYXVuY2hlck5hbWUsIEBBUkdWIG9yIGRp ZTsK