18498 2008-04-14 11:09:10 -0700 REGRESSION: Tips are not shown for resources anymore 2009-12-15 13:53:43 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P1 Normal --- 1 timothy bweinstein bweinstein joepeck timothy oldest_to_newest 77593 0 timothy 2008-04-14 11:09:10 -0700 This is a regression for bug 17773, the UI refresh. 83078 1 aroben 2008-06-11 18:52:38 -0700 This bug refers to little tip balloons that we used to show in the Inspector. In the old Inspector UI, when you went into the Network view we'd show a tip balloon next to each resource that we had a "tip" for. The idea was that the tips would be little suggestions for how web authors could improve the loading performance of each resource. The only tip that we had implemented would tell you to use server-side gzip compression. Clicking on the tip balloon once would show the tip in a message bubble. Clicking it again would hide the tip. You can see a screenshot containing the tip balloons at http://webkit.org/blog/wp-content/uploads/2007/06/newinspector.png 86613 2 kmccullough 2008-07-21 16:44:42 -0700 rdar://problem/6091749 165515 3 timothy 2009-11-20 17:00:42 -0800 The consensus is Tips are not coming back and the feature will live in a future Audits panel (tracked by bug 31665). 165521 4 bweinstein 2009-11-20 17:03:45 -0800 Should we close this bug then? 165526 5 timothy 2009-11-20 17:10:32 -0800 We should use this bug to remove the tips code. 172005 6 44906 bweinstein 2009-12-15 13:47:16 -0800 Created attachment 44906 [PATCH] Remove Tips Code + Resources 172009 7 bweinstein 2009-12-15 13:53:43 -0800 Transmitting file data ..... Committed revision 52170. 44906 2009-12-15 13:47:16 -0800 2009-12-15 13:50:01 -0800 [PATCH] Remove Tips Code + Resources remove_tips.patch text/plain 7128 bweinstein SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjE2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMDktMTItMTUgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeGVzIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0OTg+ LgorICAgICAgICBSRUdSRVNTSU9OOiBUaXBzIGFyZSBub3Qgc2hvd24gZm9yIHJlc291cmNlcyBh bnltb3JlLgorICAgICAgICAKKyAgICAgICAgQXMgZGlzY3Vzc2VkIGluIHRoZSBidWcsIFRpcHMg YXJlIG5vdCBjb21pbmcgYmFjaywgYW5kIHRoZSBmZWF0dXJlCisgICAgICAgIHdpbGwgYmUgbW92 ZWQgdG8gdGhlIGF1ZGl0cyBwYW5lbC4gVGhpcyBwYXRjaCBpcyB0byByZW1vdmUgdGhlIFRpcHMK KyAgICAgICAgY29kZSBhbmQgdGhlIHJlc291cmNlcyB0aGF0IGl0IG5lZWRlZC4KKworICAgICAg ICAqIFdlYkNvcmUuZ3lwaTogUmVtb3ZlZCB0aXBzIGZpbGVzLgorICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvSW1hZ2VzL3RpcEJhbGxvb24ucG5nOiBSZW1vdmVkLgorICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvSW1hZ2VzL3RpcEJhbGxvb25Cb3R0b20ucG5nOiBSZW1vdmVkLgor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSW1hZ2VzL3RpcEljb24ucG5nOiBSZW1vdmVk LgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSW1hZ2VzL3RpcEljb25QcmVzc2VkLnBu ZzogUmVtb3ZlZC4KKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlLmpzOiBS ZW1vdmVkIHRpcHMgY29kZS4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZS5wcm90b3R5 cGUuc2V0IGZpbmlzaGVkKTogCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9XZWJLaXQu cXJjOiBSZW1vdmVkIHRpcHMgZmlsZXMuCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9p bnNwZWN0b3IuY3NzOiBSZW1vdmVzIHRpcHMgc3R5bGUgcnVsZXMuCisKIDIwMDktMTItMTUgIEJy aWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCkluZGV4OiBXZWJDb3JlL1dl YkNvcmUuZ3lwaQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUuZ3lwaQkocmV2aXNpb24g NTIxMTcpCisrKyBXZWJDb3JlL1dlYkNvcmUuZ3lwaQkod29ya2luZyBjb3B5KQpAQCAtMzg0MSwx MCArMzg0MSw2IEBACiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9JbWFnZXMvdGlt ZWxpbmVQaWxsUHVycGxlLnBuZycsCiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9J bWFnZXMvdGltZWxpbmVQaWxsUmVkLnBuZycsCiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250 LWVuZC9JbWFnZXMvdGltZWxpbmVQaWxsWWVsbG93LnBuZycsCi0gICAgICAgICAgICAnaW5zcGVj dG9yL2Zyb250LWVuZC9JbWFnZXMvdGlwQmFsbG9vbi5wbmcnLAotICAgICAgICAgICAgJ2luc3Bl Y3Rvci9mcm9udC1lbmQvSW1hZ2VzL3RpcEJhbGxvb25Cb3R0b20ucG5nJywKLSAgICAgICAgICAg ICdpbnNwZWN0b3IvZnJvbnQtZW5kL0ltYWdlcy90aXBJY29uLnBuZycsCi0gICAgICAgICAgICAn aW5zcGVjdG9yL2Zyb250LWVuZC9JbWFnZXMvdGlwSWNvblByZXNzZWQucG5nJywKICAgICAgICAg ICAgICdpbnNwZWN0b3IvZnJvbnQtZW5kL0ltYWdlcy90b29sYmFySXRlbVNlbGVjdGVkLnBuZycs CiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9JbWFnZXMvdHJlZURvd25Ucmlhbmds ZUJsYWNrLnBuZycsCiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9JbWFnZXMvdHJl ZURvd25UcmlhbmdsZVdoaXRlLnBuZycsCkluZGV4OiBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvUmVzb3VyY2UuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1Jlc291cmNlLmpzCShyZXZpc2lvbiA1MjExNykKKysrIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9SZXNvdXJjZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMzIzLDcgKzMyMyw2IEBAIFdlYklu c3BlY3Rvci5SZXNvdXJjZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2ZpbmlzaGVkID0g eDsKIAogICAgICAgICBpZiAoeCkgewotICAgICAgICAgICAgdGhpcy5fY2hlY2tUaXBzKCk7CiAg ICAgICAgICAgICB0aGlzLl9jaGVja1dhcm5pbmdzKCk7CiAgICAgICAgICAgICB0aGlzLmRpc3Bh dGNoRXZlbnRUb0xpc3RlbmVycygiZmluaXNoZWQiKTsKICAgICAgICAgfQpAQCAtNTM5LDU4ICs1 MzgsNiBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2UucHJvdG90eXBlID0gewogICAgICAgICB0aGlz Ll93YXJuaW5ncyA9IHg7CiAgICAgfSwKIAotICAgIGdldCB0aXBzKCkKLSAgICB7Ci0gICAgICAg IGlmICghKCJfdGlwcyIgaW4gdGhpcykpCi0gICAgICAgICAgICB0aGlzLl90aXBzID0ge307Ci0g ICAgICAgIHJldHVybiB0aGlzLl90aXBzOwotICAgIH0sCi0KLSAgICBfYWRkVGlwOiBmdW5jdGlv bih0aXApCi0gICAgewotICAgICAgICBpZiAodGlwLmlkIGluIHRoaXMudGlwcykKLSAgICAgICAg ICAgIHJldHVybjsKLQotICAgICAgICB0aGlzLnRpcHNbdGlwLmlkXSA9IHRpcDsKLQotICAgICAg ICAvLyBGSVhNRTogUmUtZW5hYmxlIHRoaXMgY29kZSBvbmNlIHdlIGhhdmUgYSBzY29wZSBiYXIg aW4gdGhlIENvbnNvbGUuCi0gICAgICAgIC8vIE90aGVyd2lzZSwgd2UgZmxvb2QgdGhlIENvbnNv bGUgd2l0aCB0b28gbWFueSB0aXBzLgotICAgICAgICAvKgotICAgICAgICB2YXIgbXNnID0gbmV3 IFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZShXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2Uu TWVzc2FnZVNvdXJjZS5PdGhlciwKLSAgICAgICAgICAgIFdlYkluc3BlY3Rvci5Db25zb2xlTWVz c2FnZS5NZXNzYWdlVHlwZS5Mb2csIFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZS5NZXNzYWdl TGV2ZWwuVGlwLCAKLSAgICAgICAgICAgIC0xLCB0aGlzLnVybCwgbnVsbCwgMSwgdGlwLm1lc3Nh Z2UpOwotICAgICAgICBXZWJJbnNwZWN0b3IuY29uc29sZS5hZGRNZXNzYWdlKG1zZyk7Ci0gICAg ICAgICovCi0gICAgfSwKLQotICAgIF9jaGVja1RpcHM6IGZ1bmN0aW9uKCkKLSAgICB7Ci0gICAg ICAgIGZvciAodmFyIHRpcCBpbiBXZWJJbnNwZWN0b3IuVGlwcykKLSAgICAgICAgICAgIHRoaXMu X2NoZWNrVGlwKFdlYkluc3BlY3Rvci5UaXBzW3RpcF0pOwotICAgIH0sCi0KLSAgICBfY2hlY2tU aXA6IGZ1bmN0aW9uKHRpcCkKLSAgICB7Ci0gICAgICAgIHZhciBhZGRUaXAgPSBmYWxzZTsKLSAg ICAgICAgc3dpdGNoICh0aXAuaWQpIHsKLSAgICAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLlRp cHMuUmVzb3VyY2VOb3RDb21wcmVzc2VkLmlkOgotICAgICAgICAgICAgICAgIGFkZFRpcCA9IHRo aXMuX3Nob3VsZENvbXByZXNzKCk7Ci0gICAgICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0K LQotICAgICAgICBpZiAoYWRkVGlwKQotICAgICAgICAgICAgdGhpcy5fYWRkVGlwKHRpcCk7Ci0g ICAgfSwKLQotICAgIF9zaG91bGRDb21wcmVzczogZnVuY3Rpb24oKQotICAgIHsKLSAgICAgICAg cmV0dXJuIFdlYkluc3BlY3Rvci5SZXNvdXJjZS5UeXBlLmlzVGV4dFR5cGUodGhpcy50eXBlKQot ICAgICAgICAgICAgJiYgdGhpcy5kb21haW4KLSAgICAgICAgICAgICYmICEoIkNvbnRlbnQtRW5j b2RpbmciIGluIHRoaXMucmVzcG9uc2VIZWFkZXJzKQotICAgICAgICAgICAgJiYgdGhpcy5jb250 ZW50TGVuZ3RoICE9PSB1bmRlZmluZWQKLSAgICAgICAgICAgICYmIHRoaXMuY29udGVudExlbmd0 aCA+PSA1MTI7Ci0gICAgfSwKLQogICAgIF9taW1lVHlwZUlzQ29uc2lzdGVudFdpdGhUeXBlOiBm dW5jdGlvbigpCiAgICAgewogICAgICAgICBpZiAodHlwZW9mIHRoaXMudHlwZSA9PT0gInVuZGVm aW5lZCIKSW5kZXg6IFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XZWJLaXQucXJjCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XZWJLaXQucXJjCShyZXZpc2lv biA1MjExNykKKysrIFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XZWJLaXQucXJjCSh3b3Jr aW5nIGNvcHkpCkBAIC0xOTEsMTAgKzE5MSw2IEBACiAgICAgPGZpbGU+SW1hZ2VzL3RpbWVsaW5l UGlsbFB1cnBsZS5wbmc8L2ZpbGU+CiAgICAgPGZpbGU+SW1hZ2VzL3RpbWVsaW5lUGlsbFJlZC5w bmc8L2ZpbGU+CiAgICAgPGZpbGU+SW1hZ2VzL3RpbWVsaW5lUGlsbFllbGxvdy5wbmc8L2ZpbGU+ Ci0gICAgPGZpbGU+SW1hZ2VzL3RpcEJhbGxvb24ucG5nPC9maWxlPgotICAgIDxmaWxlPkltYWdl cy90aXBCYWxsb29uQm90dG9tLnBuZzwvZmlsZT4KLSAgICA8ZmlsZT5JbWFnZXMvdGlwSWNvbi5w bmc8L2ZpbGU+Ci0gICAgPGZpbGU+SW1hZ2VzL3RpcEljb25QcmVzc2VkLnBuZzwvZmlsZT4KICAg ICA8ZmlsZT5JbWFnZXMvdG9vbGJhckl0ZW1TZWxlY3RlZC5wbmc8L2ZpbGU+CiAgICAgPGZpbGU+ SW1hZ2VzL3RyZWVEb3duVHJpYW5nbGVCbGFjay5wbmc8L2ZpbGU+CiAgICAgPGZpbGU+SW1hZ2Vz L3RyZWVEb3duVHJpYW5nbGVXaGl0ZS5wbmc8L2ZpbGU+CkluZGV4OiBXZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcwkocmV2aXNpb24gNTIxMTcpCisrKyBXZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzcwkod29ya2luZyBjb3B5KQpAQCAtMjgxMCw1 MSArMjgxMCw2IEBAIGJ1dHRvbi5lbmFibGUtdG9nZ2xlLXN0YXR1cy1iYXItaXRlbS50b2cKICAg ICAtd2Via2l0LWJvcmRlci1pbWFnZTogdXJsKEltYWdlcy90aW1lbGluZUhvbGxvd1BpbGxZZWxs b3cucG5nKSA2IDcgNiA3OwogfQogCi0udGlwLWJ1dHRvbiB7Ci0gICAgYmFja2dyb3VuZC1pbWFn ZTogdXJsKEltYWdlcy90aXBJY29uLnBuZyk7Ci0gICAgYm9yZGVyOiBub25lOwotICAgIHdpZHRo OiAxNnB4OwotICAgIGhlaWdodDogMTZweDsKLSAgICBmbG9hdDogcmlnaHQ7Ci0gICAgYmFja2dy b3VuZC1jb2xvcjogdHJhbnNwYXJlbnQ7Ci0gICAgbWFyZ2luLXRvcDogMXB4OwotfQotCi0udGlw LWJ1dHRvbjphY3RpdmUgewotICAgIGJhY2tncm91bmQtaW1hZ2U6IHVybChJbWFnZXMvdGlwSWNv blByZXNzZWQucG5nKTsKLX0KLQotLnRpcC1iYWxsb29uIHsKLSAgICBwb3NpdGlvbjogYWJzb2x1 dGU7Ci0gICAgbGVmdDogMTQ1cHg7Ci0gICAgdG9wOiAtNXB4OwotICAgIHotaW5kZXg6IDEwMDA7 Ci0gICAgYm9yZGVyLXdpZHRoOiA1MXB4IDE1cHggMThweCAzN3B4OwotICAgIC13ZWJraXQtYm9y ZGVyLWltYWdlOiB1cmwoSW1hZ2VzL3RpcEJhbGxvb24ucG5nKSA1MSAxNSAxOCAzNzsKLSAgICB3 aWR0aDogMjY1cHg7Ci19Ci0KLS50aXAtYmFsbG9vbi5ib3R0b20gewotICAgIHBvc2l0aW9uOiBh YnNvbHV0ZTsKLSAgICBsZWZ0OiAxNDVweDsKLSAgICB0b3A6IGF1dG87Ci0gICAgYm90dG9tOiAt N3B4OwotICAgIHotaW5kZXg6IDEwMDA7Ci0gICAgYm9yZGVyLXdpZHRoOiAxOHB4IDE1cHggNTFw eCAzN3B4OwotICAgIC13ZWJraXQtYm9yZGVyLWltYWdlOiB1cmwoSW1hZ2VzL3RpcEJhbGxvb25C b3R0b20ucG5nKSAxOCAxNSA1MSAzNzsKLX0KLQotLnRpcC1iYWxsb29uLWNvbnRlbnQgewotICAg IG1hcmdpbi10b3A6IC00MHB4OwotICAgIG1hcmdpbi1ib3R0b206IC0ycHg7Ci0gICAgbWFyZ2lu LWxlZnQ6IDJweDsKLX0KLQotLnRpcC1iYWxsb29uLmJvdHRvbSAudGlwLWJhbGxvb24tY29udGVu dCB7Ci0gICAgbWFyZ2luLXRvcDogLTEwcHg7Ci0gICAgbWFyZ2luLWJvdHRvbTogLTM1cHg7Ci19 Ci0KICNyZXNvdXJjZS12aWV3cyB7CiAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgIHRvcDog MjNweDsKSW5kZXg6IFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbWFnZXMvdGlwQmFsbG9v bi5wbmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQpDYW5ub3QgZGlzcGxheTogZmlsZSBtYXJrZWQgYXMgYSBiaW5hcnkg dHlwZS4Kc3ZuOm1pbWUtdHlwZSA9IGltYWdlL3BuZwpJbmRleDogV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0ltYWdlcy90aXBCYWxsb29uQm90dG9tLnBuZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CkNhbm5vdCBk aXNwbGF5OiBmaWxlIG1hcmtlZCBhcyBhIGJpbmFyeSB0eXBlLgpzdm46bWltZS10eXBlID0gaW1h Z2UvcG5nCkluZGV4OiBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW1hZ2VzL3RpcEljb24u cG5nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KQ2Fubm90IGRpc3BsYXk6IGZpbGUgbWFya2VkIGFzIGEgYmluYXJ5IHR5 cGUuCnN2bjptaW1lLXR5cGUgPSBpbWFnZS9wbmcKSW5kZXg6IFdlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9JbWFnZXMvdGlwSWNvblByZXNzZWQucG5nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KQ2Fubm90IGRpc3Bs YXk6IGZpbGUgbWFya2VkIGFzIGEgYmluYXJ5IHR5cGUuCnN2bjptaW1lLXR5cGUgPSBpbWFnZS9w bmcK