184978 2018-04-25 10:35:28 -0700 WebLoaderStrategy::networkMetricsFromResourceLoadIdentifier should use DoNotProcessIncomingMessagesWhenWaitingForSyncReply 2018-04-25 15:27:56 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf cdumez commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1417601 0 youennf 2018-04-25 10:35:28 -0700 Otherwise we end up in a crash like: Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BREAKPOINT (SIGTRAP) Exception Codes: 0x0000000000000002, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Trace/BPT trap: 5 Termination Reason: Namespace SIGNAL, Code 0x5 Terminating Process: exc handler [0] Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x000000010e59dbe2 WebKit::WebLoaderStrategy::isDoingLoadingSecurityChecks() const + 0 1 ??? 000000000000000000 0 + 0 2 com.apple.WebKit 0x000000010e59da7d WebKit::WebLoaderStrategy::networkMetricsFromResourceLoadIdentifier(unsigned long long) + 71 3 com.apple.WebCore 0x000000010ffc6f2c WTF::Function<void ()>::CallableWrapper<WebCore::InspectorNetworkAgent::didFinishLoading(unsigned long, WebCore::DocumentLoader*, WebCore::NetworkLoadMetrics const&, WebCore::ResourceLoader*)::$_4>::call() + 76 4 com.apple.WebCore 0x000000010ffb89f9 WebCore::InspectorNetworkAgent::didFinishLoading(unsigned long, WebCore::DocumentLoader*, WebCore::NetworkLoadMetrics const&, WebCore::ResourceLoader*) + 1193 5 com.apple.WebCore 0x000000010f15c4b6 WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages(WebCore::DocumentLoader*, unsigned long, WebCore::ResourceRequest const&, WebCore::ResourceResponse const&, char const*, int, int, WebCore::ResourceError const&) + 1078 6 com.apple.WebCore 0x000000010fff07c3 WebCore::FrameLoader::loadedResourceFromMemoryCache(WebCore::CachedResource&, WebCore::ResourceRequest&, WebCore::ResourceError&) + 515 7 com.apple.WebCore 0x000000011004183d WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache(WebCore::CachedResourceRequest const&, WebCore::CachedResource&, WebCore::ResourceError&) + 253 8 com.apple.WebCore 0x000000011003ed2d WebCore::CachedResourceLoader::requestResource(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&&,  1417602 1 youennf 2018-04-25 10:35:42 -0700 <rdar://problem/39667094> 1417617 2 338755 youennf 2018-04-25 10:52:32 -0700 Created attachment 338755 Patch 1417816 3 338755 commit-queue 2018-04-25 15:27:55 -0700 Comment on attachment 338755 Patch Clearing flags on attachment: 338755 Committed r231026: <https://trac.webkit.org/changeset/231026> 1417818 4 commit-queue 2018-04-25 15:27:56 -0700 All reviewed patches have been landed. Closing bug. 338755 2018-04-25 10:52:32 -0700 2018-04-25 15:27:55 -0700 Patch bug-184978-20180425105231.patch text/plain 3177 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk5YjJjNzZlMmEzNmIwOTdi MGY5ZWZlOWE1ZDRiODkxMjI1MzIxOWYuLmZmNWMwMDQ4NmNjNDdjZjJiMmZlODkxZmI0ZGU4NGZj OTVkODFiMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDQtMjUgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYkxvYWRlclN0cmF0ZWd5Ojpu ZXR3b3JrTWV0cmljc0Zyb21SZXNvdXJjZUxvYWRJZGVudGlmaWVyIHNob3VsZCB1c2UgRG9Ob3RQ cm9jZXNzSW5jb21pbmdNZXNzYWdlc1doZW5XYWl0aW5nRm9yU3luY1JlcGx5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ5NzgKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzM5NjY3MDk0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVzZSBEb05vdFByb2Nlc3NJbmNvbWluZ01lc3NhZ2VzV2hlbldhaXRp bmdGb3JTeW5jUmVwbHkgdG8ga2VlcCBhIGNvbnNpc3RlbnQgc3RhdGUgYWZ0ZXIgdGhlIHN5bmMg SVBDIGNhbGwuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3RyYXRl Z3kuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJMb2FkZXJTdHJhdGVneTo6cmVzcG9uc2VGcm9t UmVzb3VyY2VMb2FkSWRlbnRpZmllcik6CisgICAgICAgIChXZWJLaXQ6OldlYkxvYWRlclN0cmF0 ZWd5OjpuZXR3b3JrTWV0cmljc0Zyb21SZXNvdXJjZUxvYWRJZGVudGlmaWVyKToKKwogMjAxOC0w NC0yNCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0Nv b3JkR3JhcGhpY3NdIFJlbW92ZSB1bnVzZWQgZml4ZWQgbGF5b3V0IGZ1bmN0aW9uYWxpdHkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0 ZWd5LmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0 ZWd5LmNwcAppbmRleCAwZDQ3NWI3M2MxMjczYmViYTBjZTVlNTZhMWI2ZWVmM2M3YWVjMmU0Li4w MDFiNWU3YjljYTliZWYxYjcyZWFkZTRjOWM0YTkwMGNkYjRkYTJjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVneS5jcHAKKysrIGIv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3RyYXRlZ3kuY3BwCkBA IC02MzgsMTQgKzYzOCwxNCBAQCB2b2lkIFdlYkxvYWRlclN0cmF0ZWd5OjpzZXRDYXB0dXJlRXh0 cmFOZXR3b3JrTG9hZE1ldHJpY3NFbmFibGVkKGJvb2wgZW5hYmxlZCkKIFJlc291cmNlUmVzcG9u c2UgV2ViTG9hZGVyU3RyYXRlZ3k6OnJlc3BvbnNlRnJvbVJlc291cmNlTG9hZElkZW50aWZpZXIo dWludDY0X3QgcmVzb3VyY2VMb2FkSWRlbnRpZmllcikKIHsKICAgICBSZXNvdXJjZVJlc3BvbnNl IHJlc3BvbnNlOwotICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLmVuc3VyZU5ldHdvcmtQcm9j ZXNzQ29ubmVjdGlvbigpLmNvbm5lY3Rpb24oKS5zZW5kU3luYyhNZXNzYWdlczo6TmV0d29ya0Nv bm5lY3Rpb25Ub1dlYlByb2Nlc3M6OlRha2VOZXR3b3JrTG9hZEluZm9ybWF0aW9uUmVzcG9uc2Ug eyByZXNvdXJjZUxvYWRJZGVudGlmaWVyIH0sIE1lc3NhZ2VzOjpOZXR3b3JrQ29ubmVjdGlvblRv V2ViUHJvY2Vzczo6VGFrZU5ldHdvcmtMb2FkSW5mb3JtYXRpb25SZXNwb25zZTo6UmVwbHkgeyBy ZXNwb25zZSB9LCAwKTsKKyAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5lbnN1cmVOZXR3b3Jr UHJvY2Vzc0Nvbm5lY3Rpb24oKS5jb25uZWN0aW9uKCkuc2VuZFN5bmMoTWVzc2FnZXM6Ok5ldHdv cmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpUYWtlTmV0d29ya0xvYWRJbmZvcm1hdGlvblJlc3Bv bnNlIHsgcmVzb3VyY2VMb2FkSWRlbnRpZmllciB9LCBNZXNzYWdlczo6TmV0d29ya0Nvbm5lY3Rp b25Ub1dlYlByb2Nlc3M6OlRha2VOZXR3b3JrTG9hZEluZm9ybWF0aW9uUmVzcG9uc2U6OlJlcGx5 IHsgcmVzcG9uc2UgfSwgMCwgU2Vjb25kczo6aW5maW5pdHkoKSwgSVBDOjpTZW5kU3luY09wdGlv bjo6RG9Ob3RQcm9jZXNzSW5jb21pbmdNZXNzYWdlc1doZW5XYWl0aW5nRm9yU3luY1JlcGx5KTsK ICAgICByZXR1cm4gcmVzcG9uc2U7CiB9CiAKIE5ldHdvcmtMb2FkTWV0cmljcyBXZWJMb2FkZXJT dHJhdGVneTo6bmV0d29ya01ldHJpY3NGcm9tUmVzb3VyY2VMb2FkSWRlbnRpZmllcih1aW50NjRf dCByZXNvdXJjZUxvYWRJZGVudGlmaWVyKQogewogICAgIE5ldHdvcmtMb2FkTWV0cmljcyBuZXR3 b3JrTWV0cmljczsKLSAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5lbnN1cmVOZXR3b3JrUHJv Y2Vzc0Nvbm5lY3Rpb24oKS5jb25uZWN0aW9uKCkuc2VuZFN5bmMoTWVzc2FnZXM6Ok5ldHdvcmtD b25uZWN0aW9uVG9XZWJQcm9jZXNzOjpUYWtlTmV0d29ya0xvYWRJbmZvcm1hdGlvbk1ldHJpY3Mg eyByZXNvdXJjZUxvYWRJZGVudGlmaWVyIH0sIE1lc3NhZ2VzOjpOZXR3b3JrQ29ubmVjdGlvblRv V2ViUHJvY2Vzczo6VGFrZU5ldHdvcmtMb2FkSW5mb3JtYXRpb25NZXRyaWNzOjpSZXBseSB7IG5l dHdvcmtNZXRyaWNzIH0sIDApOworICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLmVuc3VyZU5l dHdvcmtQcm9jZXNzQ29ubmVjdGlvbigpLmNvbm5lY3Rpb24oKS5zZW5kU3luYyhNZXNzYWdlczo6 TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OlRha2VOZXR3b3JrTG9hZEluZm9ybWF0aW9u TWV0cmljcyB7IHJlc291cmNlTG9hZElkZW50aWZpZXIgfSwgTWVzc2FnZXM6Ok5ldHdvcmtDb25u ZWN0aW9uVG9XZWJQcm9jZXNzOjpUYWtlTmV0d29ya0xvYWRJbmZvcm1hdGlvbk1ldHJpY3M6OlJl cGx5IHsgbmV0d29ya01ldHJpY3MgfSwgMCwgU2Vjb25kczo6aW5maW5pdHkoKSwgSVBDOjpTZW5k U3luY09wdGlvbjo6RG9Ob3RQcm9jZXNzSW5jb21pbmdNZXNzYWdlc1doZW5XYWl0aW5nRm9yU3lu Y1JlcGx5KTsKICAgICByZXR1cm4gbmV0d29ya01ldHJpY3M7CiB9CiAK