184972 2018-04-25 08:44:12 -0700 [CMake] Some options should be marked as advanced 2018-04-25 12:59:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro annulen commit-queue lforschler mcatanzaro svillar webkit-bug-importer oldest_to_newest 1417561 0 mcatanzaro 2018-04-25 08:44:12 -0700 There are also a couple build options that should be advanced, but are not. BUILD_SHARED is definitely not going to work. LIBGCRYPTCONFIG_SCRIPT and the WEBP options should also be advanced. I'm not sure about USE_CUSTOM_LIBCXX and USE_LIBCXX. 1417574 1 mcatanzaro 2018-04-25 09:18:07 -0700 Let's handle BUILD_SHARED, USE_CUSTOM_LIBCXX, and USE_LIBCXX in bug #184973 1417575 2 338744 mcatanzaro 2018-04-25 09:19:53 -0700 Created attachment 338744 Patch 1417697 3 338744 commit-queue 2018-04-25 12:58:59 -0700 Comment on attachment 338744 Patch Clearing flags on attachment: 338744 Committed r231012: <https://trac.webkit.org/changeset/231012> 1417698 4 commit-queue 2018-04-25 12:59:00 -0700 All reviewed patches have been landed. Closing bug. 1417700 5 webkit-bug-importer 2018-04-25 12:59:18 -0700 <rdar://problem/39731293> 338744 2018-04-25 09:19:53 -0700 2018-04-25 12:58:59 -0700 Patch bug-184972-20180425111952.patch text/plain 2067 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwOTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZExpYkdjcnlwdC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kTGliR2NyeXB0LmNtYWtlCmluZGV4 IGYyOTU2ODJhNzQyNDMyZWUwZjlhYWEzYjc3ODhjZjRiYzVkNWRmZmIuLjFhM2Q0YTVkNmU4Nzli NDBmNGNjYTNhY2NlMWE5NzdkMDc3NDZhNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9GaW5k TGliR2NyeXB0LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kTGliR2NyeXB0LmNtYWtlCkBA IC04MSw3ICs4MSw3IEBAIGlmIChMSUJHQ1JZUFRfRk9VTkQpCiAgICAgc2V0KExJQkdDUllQVF9J TkNMVURFX0RJUlMgJHtMSUJHQ1JZUFRfSU5DTFVERV9ESVJ9KQogZW5kaWYgKCkKIAotbWFya19h c19hZHZhbmNlZChMSUJHQ1JZUFRfTElCUkFSWSBMSUJHQ1JZUFRfSU5DTFVERV9ESVIpCittYXJr X2FzX2FkdmFuY2VkKExJQkdDUllQVF9MSUJSQVJZIExJQkdDUllQVF9JTkNMVURFX0RJUiBMSUJH Q1JZUFRDT05GSUdfU0NSSVBUKQogCiBpbmNsdWRlKEZlYXR1cmVTdW1tYXJ5KQogc2V0X3BhY2th Z2VfcHJvcGVydGllcyhMaWJHY3J5cHQgUFJPUEVSVElFUwpkaWZmIC0tZ2l0IGEvU291cmNlL2Nt YWtlL0ZpbmRXZWJQLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRXZWJQLmNtYWtlCmluZGV4IDgx ZThhYTMxYzllMjc1MWM1ZjlkNGU4OTRmN2FjNmQyZTIxZDdhZDEuLjhkZWZhMjI0NmU2ZTQ0ZDRl OGI4MTQ4ODI0NzJjNmVkNGQ4ZmUyMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9GaW5kV2Vi UC5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvRmluZFdlYlAuY21ha2UKQEAgLTQ3LDcgKzQ3LDYg QEAgZmluZF9saWJyYXJ5KAogICAgIEhJTlRTICR7UENfV0VCUF9MSUJESVJ9ICR7UENfV0VCUF9M SUJSQVJZX0RJUlN9CiApCiBsaXN0KEFQUEVORCBXRUJQX0xJQlJBUklFUyAke1dFQlBfTElCUkFS WX0pCi1tYXJrX2FzX2FkdmFuY2VkKFdFQlBfTElCUkFSSUVTKQogCiBmaW5kX3BhdGgoV0VCUF9E RU1VWF9JTkNMVURFX0RJUgogICAgIE5BTUVTIHdlYnAvZGVtdXguaApAQCAtNjEsNiArNjAsOCBA QCBmaW5kX2xpYnJhcnkoV0VCUF9ERU1VWF9MSUJSQVJZCiApCiBsaXN0KEFQUEVORCBXRUJQX0xJ QlJBUklFUyAke1dFQlBfREVNVVhfTElCUkFSWX0pCiAKK21hcmtfYXNfYWR2YW5jZWQoV0VCUF9E RU1VWF9JTkNMVURFX0RJUiBXRUJQX0RFTVVYX0xJQlJBUlkgV0VCUF9JTkNMVURFX0RJUiBXRUJQ X0xJQlJBUlkgV0VCUF9MSUJSQVJJRVMpCisKIGluY2x1ZGUoRmluZFBhY2thZ2VIYW5kbGVTdGFu ZGFyZEFyZ3MpCiBmaW5kX3BhY2thZ2VfaGFuZGxlX3N0YW5kYXJkX2FyZ3MoV2ViUCBSRVFVSVJF RF9WQVJTIFdFQlBfSU5DTFVERV9ESVJTIFdFQlBfTElCUkFSSUVTCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgRk9VTkRfVkFSIFdFQlBfRk9VTkQpCmRpZmYgLS1naXQgYS9DaGFu Z2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMGUwMmNjN2M5YmZjYzE2YjZmMDBlZmE1NGVjOWE2MmVi MTQ4NzMzZS4uNzA2YzY2YWE1MGUyNjI3MDk2YzE0MDAyMjY2MTcwZWRmNGQ4NjJhZiAxMDA2NDQK LS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTA0 LTI1ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAg ICBbQ01ha2VdIFNvbWUgb3B0aW9ucyBzaG91bGQgYmUgbWFya2VkIGFzIGFkdmFuY2VkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ5NzIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFr ZS9GaW5kTGliR2NyeXB0LmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kV2ViUC5j bWFrZToKKwogMjAxOC0wNC0yNCAgTGVvIEJhbHRlciAgPGxlb25hcmRvLmJhbHRlckBnbWFpbC5j b20+CiAKICAgICAgICAgTGFuZCB0ZXN0MjYyIHRlc3QgcmVzdWx0cyBhc3NvY2lhdGVkIHdpdGgg VGVzdDI2MiBydW5uZXIK