184944 2018-04-24 16:45:40 -0700 Don't activate Selection Assistant unless it is actually needed. 2018-04-25 13:36:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner bdakin thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1417345 0 megan_gardner 2018-04-24 16:45:40 -0700 Don't activate Selection Assistant unless it is actually needed. 1417346 1 338685 megan_gardner 2018-04-24 16:53:34 -0700 Created attachment 338685 Patch 1417347 2 338685 thorton 2018-04-24 16:56:28 -0700 Comment on attachment 338685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338685&action=review > Source/WebKit/ChangeLog:9 > + Don't activate the selection unless we need to. Activating on init is overeager and allowing Javascript to JavaScript > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-1937 > - if (self.isFirstResponder && !self.suppressAssistantSelectionView) > - [_textSelectionAssistant activateSelection]; What does not having this break? :) Do you know why it was here? The fact that the tests are happy is promising, though? > LayoutTests/ChangeLog:9 > + Turning on previously flakey tests that a fixed with this change. "a fixed" 1417639 3 megan_gardner 2018-04-25 11:20:41 -0700 I do not know why it was here before, but it seems to work fine without it. Much of the code around these assistants is crufty, so I expect it was needed for some reason and that reason is now either handled elsewhere or just not relevant anymore. 1417737 4 megan_gardner 2018-04-25 13:36:02 -0700 https://trac.webkit.org/changeset/231016/webkit 1417739 5 webkit-bug-importer 2018-04-25 13:36:23 -0700 <rdar://problem/39732559> 338685 2018-04-24 16:53:34 -0700 2018-04-25 13:23:20 -0700 Patch bug-184944-20180424165334.patch text/plain 4064 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzA5NzcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA0LTI0ICBNZWdhbiBHYXJk bmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgYWN0aXZhdGUg U2VsZWN0aW9uIEFzc2lzdGFudCB1bmxlc3MgaXQgaXMgYWN0dWFsbHkgbmVlZGVkLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0OTQ0CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8zOTQ2OTY3MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIERvbid0IGFjdGl2YXRlIHRoZSBzZWxlY3Rpb24g dW5sZXNzIHdlIG5lZWQgdG8uIEFjdGl2YXRpbmcgb24gaW5pdCBpcyBvdmVyZWFnZXIgYW5kIGFs bG93aW5nIEphdmFzY3JpcHQgdG8gCisgICAgICAgIGFjdGl2YXRlIHNlbGVjdGlvbnMgd2l0aG91 dCB1c2VyIGlucHV0LgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgdXNlU2VsZWN0aW9uQXNzaXN0 YW50V2l0aEdyYW51bGFyaXR5Ol0pOgorCiAyMDE4LTA0LTI0ICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgogCiAgICAgICAgIEtlZXAgYXJvdW5kIGEgcHJlLXdhcm1lZCBwcm9jZXNz IHdoZW4gZG9pbmcgcHJvY2VzcyBzd2FwIG9uIG5hdmlnYXRpb24KSW5kZXg6IFNvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQkocmV2aXNpb24gMjMwOTE1KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQkod29ya2luZyBjb3B5KQpAQCAtMTkzMiw5ICsxOTMyLDYg QEAgLSAodm9pZCl1c2VTZWxlY3Rpb25Bc3Npc3RhbnRXaXRoR3JhbnVsYQogICAgICAgICAvLyBS ZXNldCB0aGUgZ2VzdHVyZSByZWNvZ25pemVycyBpbiBjYXNlIGVkaXRpYmlsaXR5IGhhcyBjaGFu Z2VkLgogICAgICAgICBbX3RleHRTZWxlY3Rpb25Bc3Npc3RhbnQgc2V0R2VzdHVyZVJlY29nbml6 ZXJzXTsKICAgICB9Ci0KLSAgICBpZiAoc2VsZi5pc0ZpcnN0UmVzcG9uZGVyICYmICFzZWxmLnN1 cHByZXNzQXNzaXN0YW50U2VsZWN0aW9uVmlldykKLSAgICAgICAgW190ZXh0U2VsZWN0aW9uQXNz aXN0YW50IGFjdGl2YXRlU2VsZWN0aW9uXTsKIH0KIAogLSAodm9pZCljbGVhclNlbGVjdGlvbgpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gMjMwOTE1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDQtMjQgIE1lZ2FuIEdhcmRuZXIgIDxt ZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBhY3RpdmF0ZSBTZWxlY3Rp b24gQXNzaXN0YW50IHVubGVzcyBpdCBpcyBhY3R1YWxseSBuZWVkZWQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ5NDQKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzM5NDY5NjcxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorICAgICAgICAKKyAgICAgICAgVHVybmluZyBvbiBwcmV2aW91c2x5IGZsYWtleSB0ZXN0cyB0 aGF0IGEgZml4ZWQgd2l0aCB0aGlzIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy13 azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxOC0wNC0yMiAgV2Vuc29uIEhzaWVoICA8d2Vuc29u X2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBsYXlvdXQgdGVzdCBmb3IgcjIzMDc4 NQpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9u cwkocmV2aXNpb24gMjMwOTE1KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0 RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0xMzQ5LDIxICsxMzQ5LDQgQEAgd2Via2l0 Lm9yZy9iLzE4Mzg2MCBbIFJlbGVhc2UgXSBodHRwL3dwdAogCiB3ZWJraXQub3JnL2IvMTg0MjQ1 IGh0dHAvdGVzdHMvd29ya2Vycy9zZXJ2aWNlL3NlcnZpY2Utd29ya2VyLWNhY2hlLWFwaS5odHRw cy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAotI0ZJWE1FOiA8cmRhcjovL3Byb2JsZW0vMzk0Njk2 NzE+IFRlc3RzIHRoYXQgZmFpbCB3aGVuIHJ1biBhZnRlciBmYXN0L2V2ZW50cy9pb3MvZG91Ymxl LXRhcC16b29tLmh0bWwgd2l0aCBVSVdLVGV4dEludGVyYWN0aW9uQXNzaXN0YW50IHR1cm5lZCBv bgotZmFzdC9mbGV4Ym94L2ZsZXhib3gtZmFpbC10by1zZWxlY3Qtc2FtZS1saW5lLmh0bWwgWyBJ bWFnZU9ubHlGYWlsdXJlIFBhc3MgXQotZmFzdC9odG1sL21hcnF1ZWUtY2hpbGQtd3JhcC5odG1s IFsgSW1hZ2VPbmx5RmFpbHVyZSBQYXNzIF0KLWZhc3QvbWlzYy9zdWJ0cmVlLWxheW91dHMuaHRt bCBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCi1mYXN0L211bHRpY29sL3NpbXBsZS1saW5lLWxh eW91dC13aWRvd3Mtd2hlbi1zd2l0Y2hpbmctb3Zlci10by1ub3JtYWwtbGluZS1sYXlvdXQuaHRt bCBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCi1mYXN0L3RleHQvaW50ZXJuYXRpb25hbC9oZWJy ZXctc2VsZWN0aW9uLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIFBhc3MgXQotaW1wb3J0ZWQvYmxp bmsvZWRpdGluZy9zZWxlY3Rpb24vZGVsZXRlRnJvbURvY3VtZW50LWNyYXNoLmh0bWwgWyBJbWFn ZU9ubHlGYWlsdXJlIFBhc3MgXQotaW1wb3J0ZWQvYmxpbmsvZWRpdGluZy9zdHlsZS9qdXN0aWZ5 LWxlZnQtY3Jhc2guaHRtbCBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCi1pbXBvcnRlZC9ibGlu ay9mYXN0L2Nzcy91c2VyLXNlbGVjdC1ub25lLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIFBhc3Mg XQotaW1wb3J0ZWQvYmxpbmsvZmFzdC90ZXh0L2ludGVybmF0aW9uYWwvcmVwYWludC1nbHlwaC1i b3VuZHMuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCi1pbXBvcnRlZC9tb3ppbGxhL3N2 Zy90ZXh0L211bHRpcGxlLWNodW5rcy1zZWxlY3Rpb24uc3ZnIFsgSW1hZ2VPbmx5RmFpbHVyZSBQ YXNzIF0KLWltcG9ydGVkL21vemlsbGEvc3ZnL3RleHQvc2VsZWN0U3ViU3RyaW5nLTIuc3ZnIFsg SW1hZ2VPbmx5RmFpbHVyZSBQYXNzIF0KLWltcG9ydGVkL21vemlsbGEvc3ZnL3RleHQvc2VsZWN0 U3ViU3RyaW5nLTMuc3ZnIFsgSW1hZ2VPbmx5RmFpbHVyZSBQYXNzIF0KLWltcG9ydGVkL21vemls bGEvc3ZnL3RleHQvc2VsZWN0U3ViU3RyaW5nLnN2ZyBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBd Ci1pbXBvcnRlZC9tb3ppbGxhL3N2Zy90ZXh0L3RleHRwYXRoLXNlbGVjdGlvbi5zdmcgWyBJbWFn ZU9ubHlGYWlsdXJlIFBhc3MgXQotc3ZnL2ZvcmVpZ25PYmplY3Qvdmlld3BvcnQtZm9yZWlnbm9i amVjdC1jcmFzaC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBQYXNzIF0KLQogd2Via2l0Lm9yZy9i LzE4NDc4MyBjb21wb3NpdGluZy9pb3Mvb3ZlcmZsb3ctc2Nyb2xsLXRvdWNoLXRpbGVzLmh0bWwg WyBQYXNzIEZhaWx1cmUgXQo=