184924 2018-04-24 11:55:11 -0700 Need to acquire the VM lock before calling toNumber on a JSValue. 2018-04-24 12:20:28 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam saam webkit-bug-importer oldest_to_newest 1417217 0 mark.lam 2018-04-24 11:55:11 -0700 <rdar://problem/39690679> 1417220 1 338661 mark.lam 2018-04-24 12:01:04 -0700 Created attachment 338661 proposed patch. 1417224 2 mark.lam 2018-04-24 12:20:28 -0700 Thanks for the review. Landed in r230965: <http://trac.webkit.org/r230965>. 338661 2018-04-24 12:01:04 -0700 2018-04-24 12:16:43 -0700 proposed patch. bug-184924.patch text/plain 1598 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMDk2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA0LTI0ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBOZWVkIHRvIGFjcXVpcmUgdGhlIFZN IGxvY2sgYmVmb3JlIGNhbGxpbmcgdG9OdW1iZXIgb24gYSBKU1ZhbHVlLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0OTI0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zOTY5MDY3OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGJyaWRnZS9vYmpjL29iamNfdXRpbGl0eS5tbToKKyAgICAgICAgKEpT Qzo6QmluZGluZ3M6OmNvbnZlcnRWYWx1ZVRvT2JqY1ZhbHVlKToKKwogMjAxOC0wNC0yNCAgVGFk ZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIy MjE4MzkpOiBGaXggcmVxdWVzdHMgd2l0aCBGb3JtRGF0YSBjb250YWluaW5nIGVtcHR5IGZpbGVz CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9icmlkZ2Uvb2JqYy9vYmpjX3V0aWxpdHkubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvYnJpZGdlL29iamMvb2JqY191dGlsaXR5Lm1tCShyZXZp c2lvbiAyMzA5NjMpCisrKyBTb3VyY2UvV2ViQ29yZS9icmlkZ2Uvb2JqYy9vYmpjX3V0aWxpdHku bW0JKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAy MDA0LCAyMDEzLCAyMDE2IEFwcGxlIEluYy4gIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5 cmlnaHQgKEMpIDIwMDQtMjAxOCBBcHBsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoK ICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdp dGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRo YXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC04MSw4ICs4MSwxMCBAQCBPYmpjVmFsdWUg Y29udmVydFZhbHVlVG9PYmpjVmFsdWUoRXhlY1N0CiAgICAgT2JqY1ZhbHVlIHJlc3VsdDsKICAg ICBkb3VibGUgZCA9IDA7CiAKLSAgICBpZiAodmFsdWUuaXNOdW1iZXIoKSB8fCB2YWx1ZS5pc1N0 cmluZygpIHx8IHZhbHVlLmlzQm9vbGVhbigpKQorICAgIGlmICh2YWx1ZS5pc051bWJlcigpIHx8 IHZhbHVlLmlzU3RyaW5nKCkgfHwgdmFsdWUuaXNCb29sZWFuKCkpIHsKKyAgICAgICAgSlNMb2Nr SG9sZGVyIGxvY2soZXhlYyk7CiAgICAgICAgIGQgPSB2YWx1ZS50b051bWJlcihleGVjKTsKKyAg ICB9CiAKICAgICBzd2l0Y2ggKHR5cGUpIHsKICAgICAgICAgY2FzZSBPYmpjT2JqZWN0VHlwZTog ewo=