184921 2018-04-24 11:25:23 -0700 Throw in case of PeerConnection created for detached documents 2018-04-24 13:22:58 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson jonlee youennf oldest_to_newest 1417204 0 youennf 2018-04-24 11:25:23 -0700 Currently we are crashing 1417205 1 youennf 2018-04-24 11:25:44 -0700 <rdar://problem/39629216> 1417207 2 338657 youennf 2018-04-24 11:29:14 -0700 Created attachment 338657 Patch 1417255 3 338657 commit-queue 2018-04-24 13:22:57 -0700 Comment on attachment 338657 Patch Clearing flags on attachment: 338657 Committed r230970: <https://trac.webkit.org/changeset/230970> 1417256 4 commit-queue 2018-04-24 13:22:58 -0700 All reviewed patches have been landed. Closing bug. 338657 2018-04-24 11:29:14 -0700 2018-04-24 13:22:57 -0700 Patch bug-184921-20180424112914.patch text/plain 7219 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwOTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWE4M2VmNWMzM2FlODc1 MWE5NTgxMmZjOGE3YTU4MjkyNDRhMThhOS4uODEzZWFjMjkwYzI5NzhlZDhjYjVjNzQwMTc4ZjE3 YzI0M2MzMDRjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTA0LTI0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBUaHJvdyBpbiBjYXNlIG9m IFBlZXJDb25uZWN0aW9uIGNyZWF0ZWQgZm9yIGRldGFjaGVkIGRvY3VtZW50cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0OTIxCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zOTYyOTIxNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYSBjaGVjayB0byBlbnN1cmUgdGhhdCBwYWdlIGlzIG5vdCBu dWxsIHdoZW4gY3JlYXRpbmcgYSBwZWVyIGNvbm5lY3Rpb24gYmFja2VuZC4KKyAgICAgICAgSW4g dGhhdCBjYXNlLCB0aGUgcGVlciBjb25uZWN0aW9uIGNvbnN0cnVjdG9yIHdpbGwgbGF0ZXIgb24g dGhyb3cuCisgICAgICAgIFRoZSBzYW1lIGZvciBzZXRDb25maWd1cmF0aW9uIGlzIGRvbmUuCisg ICAgICAgIEJlaGF2aW9yIGlzIGNvbnNpc3RlbnQgd2l0aCBDaHJvbWUuCisKKyAgICAgICAgVGVz dDogd2VicnRjL3BjLWRldGFjaGVkLWRvY3VtZW50Lmh0bWwKKworICAgICAgICAqIE1vZHVsZXMv bWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1BlZXJDb25uZWN0aW9uQmFja2VuZC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVMaWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQp OgorICAgICAgICAoV2ViQ29yZTo6TGliV2ViUlRDUGVlckNvbm5lY3Rpb25CYWNrZW5kOjpMaWJX ZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQpOgorICAgICAgICAoV2ViQ29yZTo6TGliV2ViUlRD UGVlckNvbm5lY3Rpb25CYWNrZW5kOjpzZXRDb25maWd1cmF0aW9uKToKKyAgICAgICAgKFdlYkNv cmU6OmxpYldlYlJUQ1Byb3ZpZGVyKTogRGVsZXRlZC4KKyAgICAgICAgKiBNb2R1bGVzL21lZGlh c3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQuaDoKKwogMjAx OC0wNC0yNCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBEb24n dCBhZGQgc3lzdGVtIGZyYW1ld29yayBwYXRocyB0byBGUkFNRVdPUktfU0VBUkNIX1BBVEhTCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9M aWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUGVlckNvbm5lY3Rpb25CYWNrZW5kLmNw cAppbmRleCAzMWQyMmI4M2RmZTdiYTk0NzIwMWQzMTMyZjZmNGYxZWJmOTEzZDU5Li5jMGI5ODg2 OTU2MTJiY2EyODUzMzQ3NGEyMGY1MzVmM2Q1ZDM1NGQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQZWVyQ29ubmVjdGlv bkJhY2tlbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGli d2VicnRjL0xpYldlYlJUQ1BlZXJDb25uZWN0aW9uQmFja2VuZC5jcHAKQEAgLTQ5LDE5ICs0OSwx OCBAQCBzdGF0aWMgc3RkOjp1bmlxdWVfcHRyPFBlZXJDb25uZWN0aW9uQmFja2VuZD4gY3JlYXRl TGliV2ViUlRDUGVlckNvbm5lY3Rpb25CYWNrZQogewogICAgIGlmICghTGliV2ViUlRDUHJvdmlk ZXI6OndlYlJUQ0F2YWlsYWJsZSgpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKLSAgICByZXR1 cm4gc3RkOjptYWtlX3VuaXF1ZTxMaWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQ+KHBlZXJD b25uZWN0aW9uKTsKKworICAgIGF1dG8qIHBhZ2UgPSBkb3duY2FzdDxEb2N1bWVudD4oKnBlZXJD b25uZWN0aW9uLnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkucGFnZSgpOworICAgIGlmICghcGFn ZSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgcmV0dXJuIHN0ZDo6bWFrZV91bmlxdWU8 TGliV2ViUlRDUGVlckNvbm5lY3Rpb25CYWNrZW5kPihwZWVyQ29ubmVjdGlvbiwgcGFnZS0+bGli V2ViUlRDUHJvdmlkZXIoKSk7CiB9CiAKIENyZWF0ZVBlZXJDb25uZWN0aW9uQmFja2VuZCBQZWVy Q29ubmVjdGlvbkJhY2tlbmQ6OmNyZWF0ZSA9IGNyZWF0ZUxpYldlYlJUQ1BlZXJDb25uZWN0aW9u QmFja2VuZDsKIAotc3RhdGljIGlubGluZSBMaWJXZWJSVENQcm92aWRlciYgbGliV2ViUlRDUHJv dmlkZXIoUlRDUGVlckNvbm5lY3Rpb24mIHBlZXJDb25uZWN0aW9uKQotewotICAgIHJldHVybiBk b3duY2FzdDxEb2N1bWVudD4oKnBlZXJDb25uZWN0aW9uLnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQo KSkucGFnZSgpLT5saWJXZWJSVENQcm92aWRlcigpOwotfQotCi1MaWJXZWJSVENQZWVyQ29ubmVj dGlvbkJhY2tlbmQ6OkxpYldlYlJUQ1BlZXJDb25uZWN0aW9uQmFja2VuZChSVENQZWVyQ29ubmVj dGlvbiYgcGVlckNvbm5lY3Rpb24pCitMaWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQ6Okxp YldlYlJUQ1BlZXJDb25uZWN0aW9uQmFja2VuZChSVENQZWVyQ29ubmVjdGlvbiYgcGVlckNvbm5l Y3Rpb24sIExpYldlYlJUQ1Byb3ZpZGVyJiBwcm92aWRlcikKICAgICA6IFBlZXJDb25uZWN0aW9u QmFja2VuZChwZWVyQ29ubmVjdGlvbikKLSAgICAsIG1fZW5kcG9pbnQoTGliV2ViUlRDTWVkaWFF bmRwb2ludDo6Y3JlYXRlKCp0aGlzLCBsaWJXZWJSVENQcm92aWRlcihwZWVyQ29ubmVjdGlvbikp KQorICAgICwgbV9lbmRwb2ludChMaWJXZWJSVENNZWRpYUVuZHBvaW50OjpjcmVhdGUoKnRoaXMs IHByb3ZpZGVyKSkKIHsKIH0KIApAQCAtMTIwLDcgKzExOSwxMSBAQCBzdGF0aWMgd2VicnRjOjpQ ZWVyQ29ubmVjdGlvbkludGVyZmFjZTo6UlRDQ29uZmlndXJhdGlvbiBjb25maWd1cmF0aW9uRnJv bU1lZGlhRQogCiBib29sIExpYldlYlJUQ1BlZXJDb25uZWN0aW9uQmFja2VuZDo6c2V0Q29uZmln dXJhdGlvbihNZWRpYUVuZHBvaW50Q29uZmlndXJhdGlvbiYmIGNvbmZpZ3VyYXRpb24pCiB7Ci0g ICAgcmV0dXJuIG1fZW5kcG9pbnQtPnNldENvbmZpZ3VyYXRpb24obGliV2ViUlRDUHJvdmlkZXIo bV9wZWVyQ29ubmVjdGlvbiksIGNvbmZpZ3VyYXRpb25Gcm9tTWVkaWFFbmRwb2ludENvbmZpZ3Vy YXRpb24oV1RGTW92ZShjb25maWd1cmF0aW9uKSkpOworICAgIGF1dG8qIHBhZ2UgPSBkb3duY2Fz dDxEb2N1bWVudD4oKm1fcGVlckNvbm5lY3Rpb24uc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKS5w YWdlKCk7CisgICAgaWYgKCFwYWdlKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICByZXR1 cm4gbV9lbmRwb2ludC0+c2V0Q29uZmlndXJhdGlvbihwYWdlLT5saWJXZWJSVENQcm92aWRlcigp LCBjb25maWd1cmF0aW9uRnJvbU1lZGlhRW5kcG9pbnRDb25maWd1cmF0aW9uKFdURk1vdmUoY29u ZmlndXJhdGlvbikpKTsKIH0KIAogdm9pZCBMaWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQ6 OmdldFN0YXRzKE1lZGlhU3RyZWFtVHJhY2sqIHRyYWNrLCBSZWY8RGVmZXJyZWRQcm9taXNlPiYm IHByb21pc2UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L2xpYndlYnJ0Yy9MaWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQuaCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1BlZXJDb25uZWN0aW9u QmFja2VuZC5oCmluZGV4IDI4M2E3MTY4M2MyZWE0ZmE5ZTQ2NzUyNGU2ZjBhYWMwMDQwMzAxODEu LjFiNzA2NzVmYjAzNGJjZGM4Y2IyNDdmMWIwZDRlOGZhMTIzOTQ0NTEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1BlZXJD b25uZWN0aW9uQmFja2VuZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vbGlid2VicnRjL0xpYldlYlJUQ1BlZXJDb25uZWN0aW9uQmFja2VuZC5oCkBAIC0zNiw2ICsz Niw3IEBAIGNsYXNzIEljZUNhbmRpZGF0ZUludGVyZmFjZTsKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAogY2xhc3MgTGliV2ViUlRDTWVkaWFFbmRwb2ludDsKK2NsYXNzIExpYldlYlJUQ1Byb3ZpZGVy OwogY2xhc3MgUlRDUnRwUmVjZWl2ZXI7CiBjbGFzcyBSVENTZXNzaW9uRGVzY3JpcHRpb247CiBj bGFzcyBSVENTdGF0c1JlcG9ydDsKQEAgLTQ2LDcgKzQ3LDcgQEAgY2xhc3MgUmVhbHRpbWVPdXRn b2luZ1ZpZGVvU291cmNlOwogCiBjbGFzcyBMaWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQg ZmluYWwgOiBwdWJsaWMgUGVlckNvbm5lY3Rpb25CYWNrZW5kIHsKIHB1YmxpYzoKLSAgICBleHBs aWNpdCBMaWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQoUlRDUGVlckNvbm5lY3Rpb24mKTsK KyAgICBMaWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQoUlRDUGVlckNvbm5lY3Rpb24mLCBM aWJXZWJSVENQcm92aWRlciYpOwogICAgIH5MaWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQo KTsKIAogICAgIGJvb2wgaGFzQXVkaW9Tb3VyY2VzKCkgY29uc3QgeyByZXR1cm4gbV9hdWRpb1Nv dXJjZXMuc2l6ZSgpOyB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODEwODI2MWVkNjFlMThjZGM5OTUzMWJkYzg0OWNmYjg3 Y2U4MWQ0Mi4uZWRhMmEyOWRiNDdmYWZiYjMzYmFmMjk1NWJiNWVkYzg4NDlkY2EwMCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDE4LTA0LTI0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxl LmNvbT4KKworICAgICAgICBUaHJvdyBpbiBjYXNlIG9mIFBlZXJDb25uZWN0aW9uIGNyZWF0ZWQg Zm9yIGRldGFjaGVkIGRvY3VtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg0OTIxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTYyOTIxNj4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdlYnJ0 Yy9wYy1kZXRhY2hlZC1kb2N1bWVudC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHdl YnJ0Yy9wYy1kZXRhY2hlZC1kb2N1bWVudC5odG1sOiBBZGRlZC4KKwogMjAxOC0wNC0yMyAgRGFu aWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IFNhbWUt U2l0ZSBjb29raWVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJydGMvcGMtZGV0YWNoZWQt ZG9jdW1lbnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvd2VicnRjL3BjLWRldGFjaGVkLWRv Y3VtZW50LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44OWNiZjRiZjI3ZDRhZmQ2ZGEwZGJkYWRl YTczZDQ0MzViYjM3ZTRmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvd2VicnRjL3Bj LWRldGFjaGVkLWRvY3VtZW50LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDQgQEAKKworUEFTUyBQ ZWVyIENvbm5lY3Rpb24gb2JqZWN0cyBzaG91bGQgbm90IGJlIGNyZWF0ZWQgaW4gZGV0YWNoZWQg ZG9jdW1lbnRzIAorUEFTUyBQZWVyIENvbm5lY3Rpb24gb2JqZWN0cyBzaG91bGQgbm90IGJlIGNy ZWF0ZWQgaW4gZGV0YWNoZWQgZG9jdW1lbnRzIAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93 ZWJydGMvcGMtZGV0YWNoZWQtZG9jdW1lbnQuaHRtbCBiL0xheW91dFRlc3RzL3dlYnJ0Yy9wYy1k ZXRhY2hlZC1kb2N1bWVudC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjcxMDFlNmQxZjM2ZTdhNjM2ZDNmMDcx MTRmN2EwNWFhYTZjMzNlYTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy93ZWJydGMv cGMtZGV0YWNoZWQtZG9jdW1lbnQuaHRtbApAQCAtMCwwICsxLDI1IEBACis8IWRvY3R5cGUgaHRt bD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL3Rlc3RoYXJuZXNz LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvdGVzdGhhcm5lc3NyZXBv cnQuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK3Rlc3QoKCkgPT4geworICAgIHZhciBmcmFtZSA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlmcmFtZSIpOworICAgIGZyYW1lLnNldEF0dHJpYnV0 ZSgic3JjIiwgIi8iKTsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGZyYW1lKTsKKyAg ICB2YXIgY29uc3RydWN0b3IgPSBmcmFtZS5jb250ZW50V2luZG93LlJUQ1BlZXJDb25uZWN0aW9u OworICAgIGRvY3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQoZnJhbWUpOworICAgIGFzc2VydF90aHJv d3MoJ05vdFN1cHBvcnRlZEVycm9yJywgKCkgPT4geyBuZXcgY29uc3RydWN0b3IoKSB9KTsKK30s ICJQZWVyIENvbm5lY3Rpb24gb2JqZWN0cyBzaG91bGQgbm90IGJlIGNyZWF0ZWQgaW4gZGV0YWNo ZWQgZG9jdW1lbnRzIik7Cit0ZXN0KCgpID0+IHsKKyAgICB2YXIgZnJhbWUgPSBkb2N1bWVudC5j cmVhdGVFbGVtZW50KCJpZnJhbWUiKTsKKyAgICBmcmFtZS5zZXRBdHRyaWJ1dGUoInNyYyIsICIv Iik7CisgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChmcmFtZSk7CisgICAgdmFyIHBjID0g bmV3IGZyYW1lLmNvbnRlbnRXaW5kb3cuUlRDUGVlckNvbm5lY3Rpb24oKTsKKyAgICBkb2N1bWVu dC5ib2R5LnJlbW92ZUNoaWxkKGZyYW1lKTsKKyAgICBhc3NlcnRfdGhyb3dzKCdJbnZhbGlkU3Rh dGVFcnJvcicsICgpID0+IHsgcGMuc2V0Q29uZmlndXJhdGlvbih7fSkgfSk7Cit9LCAiUGVlciBD b25uZWN0aW9uIG9iamVjdHMgc2hvdWxkIG5vdCBiZSBjcmVhdGVkIGluIGRldGFjaGVkIGRvY3Vt ZW50cyIpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==