184919 2018-04-24 09:32:52 -0700 AX: soft link libAccessibility.dylb 2018-04-24 22:52:59 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 184939 1 n_wang webkit-unassigned aestes benjamin cdumez cfleizach cmarcelo commit-queue dbates ews-watchlist mitz n_wang rniwa thorton webkit-bug-importer oldest_to_newest 1417173 0 n_wang 2018-04-24 09:32:52 -0700 Crash on some machine Dyld Error Message: Library not loaded: /usr/lib/libAccessibility.dylib Referenced from: /System/Library/Frameworks/WebKit.framework/Versions/A/WebKit Reason: image not found <rdar://problem/39669349> 1417175 1 338655 n_wang 2018-04-24 09:42:33 -0700 Created attachment 338655 patch 1417283 2 338655 commit-queue 2018-04-24 14:27:06 -0700 Comment on attachment 338655 patch Clearing flags on attachment: 338655 Committed r230971: <https://trac.webkit.org/changeset/230971> 1417284 3 commit-queue 2018-04-24 14:27:08 -0700 All reviewed patches have been landed. Closing bug. 1417294 4 338655 mitz 2018-04-24 14:51:19 -0700 Comment on attachment 338655 patch This is not an appropriate way to resolve this sort of issue. The correct fix would have been to use $(WK_MACOS_WEAK_FRAMEWORK) instead of -framework, and to perform the appropriate nil checks. 1417301 5 commit-queue 2018-04-24 15:05:03 -0700 Re-opened since this is blocked by bug 184939 1417303 6 n_wang 2018-04-24 15:05:31 -0700 (In reply to mitz from comment #4) > Comment on attachment 338655 [details] > patch > > This is not an appropriate way to resolve this sort of issue. The correct > fix would have been to use $(WK_MACOS_WEAK_FRAMEWORK) instead of -framework, > and to perform the appropriate nil checks. Ok I rolled it out and will fix that again 1417381 7 338695 n_wang 2018-04-24 18:40:42 -0700 Created attachment 338695 patch weak link instead 1417404 8 338695 mitz 2018-04-24 20:10:26 -0700 Comment on attachment 338695 patch View in context: https://bugs.webkit.org/attachment.cgi?id=338695&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:3079 > + if (functionPtr) You generally can’t null-check function pointers like this. Consider using isNullFunctionPointer() from <https://trac.webkit.org/browser/webkit/trunk/Source/WTF/wtf/darwin/WeakLinking.h>. 1417430 9 338706 n_wang 2018-04-24 21:43:41 -0700 Created attachment 338706 patch update from review 1417433 10 338706 mitz 2018-04-24 21:49:51 -0700 Comment on attachment 338706 patch View in context: https://bugs.webkit.org/attachment.cgi?id=338706&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:706 > + CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(), (__bridge const void *)(self), accessibilityEventsEnabledChangedCallback, kAXSWebAccessibilityEventsEnabledNotification, 0, CFNotificationSuspensionBehaviorDeliverImmediately); Not new to this patch, but why is it OK to add this observer and never remove it? 1417436 11 338706 n_wang 2018-04-24 21:55:43 -0700 Comment on attachment 338706 patch View in context: https://bugs.webkit.org/attachment.cgi?id=338706&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:706 >> + CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(), (__bridge const void *)(self), accessibilityEventsEnabledChangedCallback, kAXSWebAccessibilityEventsEnabledNotification, 0, CFNotificationSuspensionBehaviorDeliverImmediately); > > Not new to this patch, but why is it OK to add this observer and never remove it? Good catch, there is CFNotificationCenterRemoveObserver in dealloc but it's guarded in PLATFORM(IOS). I will move that into #if ENABLE(ACCESSIBILITY_EVENTS) since that's the only place with CFNotification 1417453 12 n_wang 2018-04-24 22:52:59 -0700 Committed r230987: <https://trac.webkit.org/changeset/230987> 338655 2018-04-24 09:42:33 -0700 2018-04-24 18:40:42 -0700 patch patch.txt text/plain 7674 n_wang SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzA5NDIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE4LTA0LTI0ICBOYW4gV2FuZyAgPG5fd2FuZ0Bh cHBsZS5jb20+CisKKyAgICAgICAgQVg6IHNvZnQgbGluayBsaWJBY2Nlc3NpYmlsaXR5LmR5bGIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDkxOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL2Nv Y29hL1NvZnRMaW5raW5nLmg6CisKIDIwMTgtMDQtMjMgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFw cGxlLmNvbT4KIAogICAgICAgICBbTGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRdIEluaXRpYWwgY29t bWl0LgpJbmRleDogU291cmNlL1dURi93dGYvY29jb2EvU29mdExpbmtpbmcuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV1RGL3d0Zi9jb2NvYS9Tb2Z0TGlua2luZy5oCShyZXZpc2lvbiAyMzA5NDIp CisrKyBTb3VyY2UvV1RGL3d0Zi9jb2NvYS9Tb2Z0TGlua2luZy5oCSh3b3JraW5nIGNvcHkpCkBA IC00MSw2ICs0MSwxMyBAQAogICAgICAgICByZXR1cm4gZHlsaWI7IFwKICAgICB9CiAKKyNkZWZp bmUgU09GVF9MSU5LX0xJQlJBUllfT1BUSU9OQUwobGliKSBcCisgICAgc3RhdGljIHZvaWQqIGxp YiMjTGlicmFyeSgpIFwKKyAgICB7IFwKKyAgICAgICAgc3RhdGljIHZvaWQqIGR5bGliID0gZGxv cGVuKCIvdXNyL2xpYi8iICNsaWIgIi5keWxpYiIsIFJUTERfTk9XKTsgXAorICAgICAgICByZXR1 cm4gZHlsaWI7IFwKKyAgICB9CisKICNkZWZpbmUgU09GVF9MSU5LX0ZSQU1FV09SSyhmcmFtZXdv cmspIFwKICAgICBzdGF0aWMgdm9pZCogZnJhbWV3b3JrIyNMaWJyYXJ5KCkgXAogICAgIHsgXApJ bmRleDogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMDk1OSkKKysrIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDQtMjQgIE5hbiBXYW5nICA8 bl93YW5nQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogc29mdCBsaW5rIGxpYkFjY2Vzc2liaWxp dHkuZHlsYgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTg0OTE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TWFrZSBzdXJlIHdlIHNvZnQgbGluayB0aGUgbGlicmFyeSBzbyB0aGF0IGl0IHdvbid0IGNyYXNo CisgICAgICAgIGlmIGl0J3MgbWlzc2luZyBpbiB0aGUgc3lzdGVtLgorCisgICAgICAgICogQ29u ZmlndXJhdGlvbnMvV2ViS2l0LnhjY29uZmlnOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgX2luaXRpYWxpemVXaXRoQ29u ZmlndXJhdGlvbjpdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF91cGRhdGVBY2Nlc3NpYmlsaXR5 RXZlbnRzRW5hYmxlZF0pOgorCiAyMDE4LTA0LTI0ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBw bGUuY29tPgogCiAgICAgICAgIERvbid0IGFkZCBzeXN0ZW0gZnJhbWV3b3JrIHBhdGhzIHRvIEZS QU1FV09SS19TRUFSQ0hfUEFUSFMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMv V2ViS2l0LnhjY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlv bnMvV2ViS2l0LnhjY29uZmlnCShyZXZpc2lvbiAyMzA5NDIpCisrKyBTb3VyY2UvV2ViS2l0L0Nv bmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtMzksMTQgKzM5 LDYgQEAgRFlMSUJfSU5TVEFMTF9OQU1FX0JBU0VfWUVTID0gJChEWUxJQl9JTgogCiBMSUJSQVJZ X1NFQVJDSF9QQVRIUyA9ICQoaW5oZXJpdGVkKSAiJChMSUJXRUJSVENfTElCUkFSWV9ESVIpIjsK IAotV0tfQUNDRVNTSUJJTElUWV9MREZMQUdTID0gJChXS19BQ0NFU1NJQklMSVRZX0xERkxBR1Nf JChXS19QTEFURk9STV9OQU1FKSk7Ci1XS19BQ0NFU1NJQklMSVRZX0xERkxBR1NfaXBob25lb3Mg PSAtbEFjY2Vzc2liaWxpdHk7Ci1XS19BQ0NFU1NJQklMSVRZX0xERkxBR1NfaXBob25lc2ltdWxh dG9yID0gJChXS19BQ0NFU1NJQklMSVRZX0xERkxBR1NfaXBob25lb3MpOwotV0tfQUNDRVNTSUJJ TElUWV9MREZMQUdTX3dhdGNob3MgPSAkKFdLX0FDQ0VTU0lCSUxJVFlfTERGTEFHU19pcGhvbmVv cyk7Ci1XS19BQ0NFU1NJQklMSVRZX0xERkxBR1NfYXBwbGV0dm9zID0gJChXS19BQ0NFU1NJQklM SVRZX0xERkxBR1NfaXBob25lb3MpOwotV0tfQUNDRVNTSUJJTElUWV9MREZMQUdTX21hY29zeCA9 ICQoV0tfQUNDRVNTSUJJTElUWV9MREZMQUdTJChXS19NQUNPU18xMDE0KSk7Ci1XS19BQ0NFU1NJ QklMSVRZX0xERkxBR1NfTUFDT1NfU0lOQ0VfMTAxNCA9IC1sQWNjZXNzaWJpbGl0eTsKLQogV0tf QVBQS0lUX0xERkxBR1MgPSAkKFdLX0FQUEtJVF9MREZMQUdTXyQoV0tfUExBVEZPUk1fTkFNRSkp OwogV0tfQVBQS0lUX0xERkxBR1NfbWFjb3N4ID0gLWZyYW1ld29yayBBcHBLaXQ7CiAKQEAgLTEx Miw3ICsxMDQsNyBAQCBXS19TQUZFX0JST1dTSU5HX0xERkxBR1NfTUFDT1NfU0lOQ0VfMTAxCiBX S19VSUtJVF9MREZMQUdTID0gJChXS19VSUtJVF9MREZMQUdTXyQoV0tfQ09DT0FfVE9VQ0gpKTsK IFdLX1VJS0lUX0xERkxBR1NfY29jb2F0b3VjaCA9IC1mcmFtZXdvcmsgVUlLaXQ7CiAKLUZSQU1F V09SS19BTkRfTElCUkFSWV9MREZMQUdTID0gLWxvYmpjIC1mcmFtZXdvcmsgQ0ZOZXR3b3JrIC1m cmFtZXdvcmsgQ29yZUF1ZGlvIC1mcmFtZXdvcmsgQ29yZUZvdW5kYXRpb24gLWZyYW1ld29yayBD b3JlR3JhcGhpY3MgLWZyYW1ld29yayBDb3JlVGV4dCAtZnJhbWV3b3JrIEZvdW5kYXRpb24gLWZy YW1ld29yayBJbWFnZUlPIC1mcmFtZXdvcmsgSU9LaXQgLWZyYW1ld29yayBXZWJLaXRMZWdhY3kg JChXS19BQ0NFU1NJQklMSVRZX0xERkxBR1MpICQoV0tfQVBQS0lUX0xERkxBR1MpICQoV0tfQVNT RVJUSU9OX1NFUlZJQ0VTX0xERkxBR1MpICQoV0tfQ0FSQk9OX0xERkxBR1MpICQoV0tfQ09SRV9Q REZfTERGTEFHUykgJChXS19DT1JFX1BSRURJQ1RJT05fTERGTEFHUykgJChXS19DT1JFX1NFUlZJ Q0VTX0xERkxBR1MpICQoV0tfR1JBUEhJQ1NfU0VSVklDRVNfTERGTEFHUykgJChXS19JT1NVUkZB Q0VfTERGTEFHUykgJChXS19MSUJXRUJSVENfTERGTEFHUykgJChXS19NT0JJTEVfQ09SRV9TRVJW SUNFU19MREZMQUdTKSAkKFdLX01PQklMRV9HRVNUQUxUX0xERkxBR1MpICQoV0tfT1BFTkdMX0xE RkxBR1MpICQoV0tfUERGS0lUX0xERkxBR1MpICQoV0tfU0FGRV9CUk9XU0lOR19MREZMQUdTKSAk KFdLX1VJS0lUX0xERkxBR1MpOworRlJBTUVXT1JLX0FORF9MSUJSQVJZX0xERkxBR1MgPSAtbG9i amMgLWZyYW1ld29yayBDRk5ldHdvcmsgLWZyYW1ld29yayBDb3JlQXVkaW8gLWZyYW1ld29yayBD b3JlRm91bmRhdGlvbiAtZnJhbWV3b3JrIENvcmVHcmFwaGljcyAtZnJhbWV3b3JrIENvcmVUZXh0 IC1mcmFtZXdvcmsgRm91bmRhdGlvbiAtZnJhbWV3b3JrIEltYWdlSU8gLWZyYW1ld29yayBJT0tp dCAtZnJhbWV3b3JrIFdlYktpdExlZ2FjeSAkKFdLX0FQUEtJVF9MREZMQUdTKSAkKFdLX0FTU0VS VElPTl9TRVJWSUNFU19MREZMQUdTKSAkKFdLX0NBUkJPTl9MREZMQUdTKSAkKFdLX0NPUkVfUERG X0xERkxBR1MpICQoV0tfQ09SRV9QUkVESUNUSU9OX0xERkxBR1MpICQoV0tfQ09SRV9TRVJWSUNF U19MREZMQUdTKSAkKFdLX0dSQVBISUNTX1NFUlZJQ0VTX0xERkxBR1MpICQoV0tfSU9TVVJGQUNF X0xERkxBR1MpICQoV0tfTElCV0VCUlRDX0xERkxBR1MpICQoV0tfTU9CSUxFX0NPUkVfU0VSVklD RVNfTERGTEFHUykgJChXS19NT0JJTEVfR0VTVEFMVF9MREZMQUdTKSAkKFdLX09QRU5HTF9MREZM QUdTKSAkKFdLX1BERktJVF9MREZMQUdTKSAkKFdLX1NBRkVfQlJPV1NJTkdfTERGTEFHUykgJChX S19VSUtJVF9MREZMQUdTKTsKIAogLy8gUHJldmVudCBDKysgc3RhbmRhcmQgbGlicmFyeSBvcGVy YXRvciBuZXcsIGRlbGV0ZSBhbmQgdGhlaXIgcmVsYXRlZCBleGNlcHRpb24gdHlwZXMgZnJvbSBi ZWluZyBleHBvcnRlZCBhcyB3ZWFrIHN5bWJvbHMuCiBVTkVYUE9SVEVEX1NZTUJPTF9MREZMQUdT ID0gLVdsLC11bmV4cG9ydGVkX3N5bWJvbCAtV2wsX19aVElTdDliYWRfYWxsb2MgLVdsLC11bmV4 cG9ydGVkX3N5bWJvbCAtV2wsX19aVElTdDlleGNlcHRpb24gLVdsLC11bmV4cG9ydGVkX3N5bWJv bCAtV2wsX19aVFNTdDliYWRfYWxsb2MgLVdsLC11bmV4cG9ydGVkX3N5bWJvbCAtV2wsX19aVFNT dDlleGNlcHRpb24gLVdsLC11bmV4cG9ydGVkX3N5bWJvbCAtV2wsX19aZGxQdlNfIC1XbCwtdW5l eHBvcnRlZF9zeW1ib2wgLVdsLF9fWm53bVB2IC1XbCwtdW5leHBvcnRlZF9zeW1ib2wgLVdsLF9f Wm53bSAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sLCAtV2wsX19aTlN0M19fMThmdW5jdGlvbklGdk43 V2ViQ29yZTEyUG9saWN5QWN0aW9uRUVFQzJFT1M0XyAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sLCAt V2wsX19aTlN0M19fMThmdW5jdGlvbklGdk43V2ViQ29yZTEyUG9saWN5QWN0aW9uRUVFQzFFT1M0 XyAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sLCAtV2wsX19aTlN0M19fMThmdW5jdGlvbklGdk43V2Vi Q29yZTEyUG9saWN5QWN0aW9uRUVFYVNFRG4gLVdsLC11bmV4cG9ydGVkX3N5bWJvbCwgLVdsLF9f Wk5LU3QzX18xOGZ1bmN0aW9uSUZ2TjdXZWJDb3JlMTJQb2xpY3lBY3Rpb25FRUVjbEVTMl8gLVds LC11bmV4cG9ydGVkX3N5bWJvbCwgLVdsLF9fWk5TdDNfXzE4ZnVuY3Rpb25JRnZON1dlYkNvcmUx MlBvbGljeUFjdGlvbkVFRTRzd2FwRVJTNF8gLVdsLC11bmV4cG9ydGVkX3N5bWJvbCwgLVdsLF9f Wk5TdDNfXzE4ZnVuY3Rpb25JRnZON1dlYkNvcmUxMlBvbGljeUFjdGlvbkVFRUMxRVJLUzRfIC1X bCwtdW5leHBvcnRlZF9zeW1ib2wsIC1XbCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2TjdXZWJDb3Jl MTJQb2xpY3lBY3Rpb25FRUVDMkVSS1M0XyAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sLCAtV2wsX19a TlN0M19fMThmdW5jdGlvbklGdk43V2ViQ29yZTEyUG9saWN5QWN0aW9uRUVFRDFFdiAtV2wsLXVu ZXhwb3J0ZWRfc3ltYm9sLCAtV2wsX19aTlN0M19fMThmdW5jdGlvbklGdk43V2ViQ29yZTEyUG9s aWN5QWN0aW9uRUVFRDJFdiAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sLCAtV2wsX19aTlN0M19fMThm dW5jdGlvbklGdk43V2ViQ29yZTEyUG9saWN5QWN0aW9uRUVFYVNFUktTNF8gLVdsLC11bmV4cG9y dGVkX3N5bWJvbCwgLVdsLF9fWlRWTlN0M19fMTE3YmFkX2Z1bmN0aW9uX2NhbGxFOwpJbmRleDog U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCShyZXZp c2lvbiAyMzA5NDIpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMDcsMTQgKzIwNywxMCBAQCBAaW50ZXJmYWNlIFdL V2ViVmlldyAoKSA8TlNUb3VjaEJhclByb3ZpCiAjZW5kaWYgLy8gUExBVEZPUk0oTUFDKQogCiAj aWYgRU5BQkxFKEFDQ0VTU0lCSUxJVFlfRVZFTlRTKQotI2lmIF9faGFzX2luY2x1ZGUoPEFjY2Vz c2liaWxpdHlTdXBwb3J0Lmg+KQotI2luY2x1ZGUgPEFjY2Vzc2liaWxpdHlTdXBwb3J0Lmg+Ci0j ZWxzZQotZXh0ZXJuICJDIiB7Ci1DRlN0cmluZ1JlZiBrQVhTV2ViQWNjZXNzaWJpbGl0eUV2ZW50 c0VuYWJsZWROb3RpZmljYXRpb247Ci1Cb29sZWFuIF9BWFNXZWJBY2Nlc3NpYmlsaXR5RXZlbnRz RW5hYmxlZCgpOwotfQotI2VuZGlmCisjaW5jbHVkZSA8d3RmL1NvZnRMaW5raW5nLmg+CitTT0ZU X0xJTktfTElCUkFSWV9PUFRJT05BTChsaWJBY2Nlc3NpYmlsaXR5KQorU09GVF9MSU5LX01BWV9G QUlMKGxpYkFjY2Vzc2liaWxpdHksIF9BWFNXZWJBY2Nlc3NpYmlsaXR5RXZlbnRzRW5hYmxlZCwg Qm9vbGVhbiwgKCksICgpKQorU09GVF9MSU5LX0NPTlNUQU5UX01BWV9GQUlMKGxpYkFjY2Vzc2li aWxpdHksIGtBWFNXZWJBY2Nlc3NpYmlsaXR5RXZlbnRzRW5hYmxlZE5vdGlmaWNhdGlvbiwgQ0ZT dHJpbmdSZWYpCiAjZW5kaWYKIAogc3RhdGljIEhhc2hNYXA8V2ViS2l0OjpXZWJQYWdlUHJveHkq LCBXS1dlYlZpZXcgKj4mIHBhZ2VUb1ZpZXdNYXAoKQpAQCAtNzAwLDcgKzY5Niw4IEBAICAgICAv LyBXZSBhcmUgaW4gdGhlIFZpZXcncyBpbml0aWFsaXphdGkKICNlbmRpZgogCiAjaWYgRU5BQkxF KEFDQ0VTU0lCSUxJVFlfRVZFTlRTKQotICAgIENGTm90aWZpY2F0aW9uQ2VudGVyQWRkT2JzZXJ2 ZXIoQ0ZOb3RpZmljYXRpb25DZW50ZXJHZXREYXJ3aW5Ob3RpZnlDZW50ZXIoKSwgKF9fYnJpZGdl IGNvbnN0IHZvaWQgKikoc2VsZiksIGFjY2Vzc2liaWxpdHlFdmVudHNFbmFibGVkQ2hhbmdlZENh bGxiYWNrLCBrQVhTV2ViQWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJsZWROb3RpZmljYXRpb24sIDAs IENGTm90aWZpY2F0aW9uU3VzcGVuc2lvbkJlaGF2aW9yRGVsaXZlckltbWVkaWF0ZWx5KTsKKyAg ICBpZiAoY2FuTG9hZGtBWFNXZWJBY2Nlc3NpYmlsaXR5RXZlbnRzRW5hYmxlZE5vdGlmaWNhdGlv bigpKQorICAgICAgICBDRk5vdGlmaWNhdGlvbkNlbnRlckFkZE9ic2VydmVyKENGTm90aWZpY2F0 aW9uQ2VudGVyR2V0RGFyd2luTm90aWZ5Q2VudGVyKCksIChfX2JyaWRnZSBjb25zdCB2b2lkICop KHNlbGYpLCBhY2Nlc3NpYmlsaXR5RXZlbnRzRW5hYmxlZENoYW5nZWRDYWxsYmFjaywgZ2V0a0FY U1dlYkFjY2Vzc2liaWxpdHlFdmVudHNFbmFibGVkTm90aWZpY2F0aW9uKCksIDAsIENGTm90aWZp Y2F0aW9uU3VzcGVuc2lvbkJlaGF2aW9yRGVsaXZlckltbWVkaWF0ZWx5KTsKICAgICBbc2VsZiBf dXBkYXRlQWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJsZWRdOwogI2VuZGlmCiAKQEAgLTMwNzMsNiAr MzA3MCw4IEBAIHN0YXRpYyB2b2lkIGFjY2Vzc2liaWxpdHlFdmVudHNFbmFibGVkQ2gKIAogLSAo dm9pZClfdXBkYXRlQWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJsZWQKIHsKKyAgICBpZiAoIWNhbkxv YWRfQVhTV2ViQWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJsZWQoKSkKKyAgICAgICAgcmV0dXJuOwog ICAgIF9wYWdlLT51cGRhdGVBY2Nlc3NpYmlsaXR5RXZlbnRzRW5hYmxlZChfQVhTV2ViQWNjZXNz aWJpbGl0eUV2ZW50c0VuYWJsZWQoKSk7CiB9CiAjZW5kaWYK 338695 2018-04-24 18:40:42 -0700 2018-04-24 21:43:41 -0700 patch patch.txt text/plain 3014 n_wang SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzA5NzcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA0LTI0ICBOYW4gV2FuZyAg PG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IHNvZnQgbGluayBsaWJBY2Nlc3NpYmls aXR5LmR5bGIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NDkxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlYWtseSBsaW5rZWQgbGliQWNjZXNzaWJpbGl0eS5keWxpYiBvbiBtYWNPUy4KKworICAgICAg ICAqIENvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZzoKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9pbml0aWFsaXpl V2l0aENvbmZpZ3VyYXRpb246XSk6CisgICAgICAgICgtW1dLV2ViVmlldyBfdXBkYXRlQWNjZXNz aWJpbGl0eUV2ZW50c0VuYWJsZWRdKToKKwogMjAxOC0wNC0yNCAgU2FhbSBCYXJhdGkgIDxzYmFy YXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBLZWVwIGFyb3VuZCBhIHByZS13YXJtZWQgcHJvY2Vz cyB3aGVuIGRvaW5nIHByb2Nlc3Mgc3dhcCBvbiBuYXZpZ2F0aW9uCkluZGV4OiBTb3VyY2UvV2Vi S2l0L0NvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L0NvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZwkocmV2aXNpb24gMjMwOTQyKQor KysgU291cmNlL1dlYktpdC9Db25maWd1cmF0aW9ucy9XZWJLaXQueGNjb25maWcJKHdvcmtpbmcg Y29weSkKQEAgLTQ1LDcgKzQ1LDcgQEAgV0tfQUNDRVNTSUJJTElUWV9MREZMQUdTX2lwaG9uZXNp bXVsYXRvcgogV0tfQUNDRVNTSUJJTElUWV9MREZMQUdTX3dhdGNob3MgPSAkKFdLX0FDQ0VTU0lC SUxJVFlfTERGTEFHU19pcGhvbmVvcyk7CiBXS19BQ0NFU1NJQklMSVRZX0xERkxBR1NfYXBwbGV0 dm9zID0gJChXS19BQ0NFU1NJQklMSVRZX0xERkxBR1NfaXBob25lb3MpOwogV0tfQUNDRVNTSUJJ TElUWV9MREZMQUdTX21hY29zeCA9ICQoV0tfQUNDRVNTSUJJTElUWV9MREZMQUdTJChXS19NQUNP U18xMDE0KSk7Ci1XS19BQ0NFU1NJQklMSVRZX0xERkxBR1NfTUFDT1NfU0lOQ0VfMTAxNCA9IC1s QWNjZXNzaWJpbGl0eTsKK1dLX0FDQ0VTU0lCSUxJVFlfTERGTEFHU19NQUNPU19TSU5DRV8xMDE0 ID0gLXdlYWtfbGlicmFyeSAvdXNyL2xpYi9saWJBY2Nlc3NpYmlsaXR5LmR5bGliOwogCiBXS19B UFBLSVRfTERGTEFHUyA9ICQoV0tfQVBQS0lUX0xERkxBR1NfJChXS19QTEFURk9STV9OQU1FKSk7 CiBXS19BUFBLSVRfTERGTEFHU19tYWNvc3ggPSAtZnJhbWV3b3JrIEFwcEtpdDsKSW5kZXg6IFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQkocmV2aXNp b24gMjMwOTQyKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5tbQkod29ya2luZyBjb3B5KQpAQCAtNzAwLDcgKzcwMCw5IEBAICAgICAvLyBXZSBhcmUgaW4g dGhlIFZpZXcncyBpbml0aWFsaXphdGkKICNlbmRpZgogCiAjaWYgRU5BQkxFKEFDQ0VTU0lCSUxJ VFlfRVZFTlRTKQotICAgIENGTm90aWZpY2F0aW9uQ2VudGVyQWRkT2JzZXJ2ZXIoQ0ZOb3RpZmlj YXRpb25DZW50ZXJHZXREYXJ3aW5Ob3RpZnlDZW50ZXIoKSwgKF9fYnJpZGdlIGNvbnN0IHZvaWQg Kikoc2VsZiksIGFjY2Vzc2liaWxpdHlFdmVudHNFbmFibGVkQ2hhbmdlZENhbGxiYWNrLCBrQVhT V2ViQWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJsZWROb3RpZmljYXRpb24sIDAsIENGTm90aWZpY2F0 aW9uU3VzcGVuc2lvbkJlaGF2aW9yRGVsaXZlckltbWVkaWF0ZWx5KTsKKyAgICBjb25zdCBhdXRv KiBub3RpZmljYXRpb25QdHIgPSAma0FYU1dlYkFjY2Vzc2liaWxpdHlFdmVudHNFbmFibGVkTm90 aWZpY2F0aW9uOworICAgIGlmIChub3RpZmljYXRpb25QdHIpCisgICAgICAgIENGTm90aWZpY2F0 aW9uQ2VudGVyQWRkT2JzZXJ2ZXIoQ0ZOb3RpZmljYXRpb25DZW50ZXJHZXREYXJ3aW5Ob3RpZnlD ZW50ZXIoKSwgKF9fYnJpZGdlIGNvbnN0IHZvaWQgKikoc2VsZiksIGFjY2Vzc2liaWxpdHlFdmVu dHNFbmFibGVkQ2hhbmdlZENhbGxiYWNrLCBrQVhTV2ViQWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJs ZWROb3RpZmljYXRpb24sIDAsIENGTm90aWZpY2F0aW9uU3VzcGVuc2lvbkJlaGF2aW9yRGVsaXZl ckltbWVkaWF0ZWx5KTsKICAgICBbc2VsZiBfdXBkYXRlQWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJs ZWRdOwogI2VuZGlmCiAKQEAgLTMwNzMsNyArMzA3NSw5IEBAIHN0YXRpYyB2b2lkIGFjY2Vzc2li aWxpdHlFdmVudHNFbmFibGVkQ2gKIAogLSAodm9pZClfdXBkYXRlQWNjZXNzaWJpbGl0eUV2ZW50 c0VuYWJsZWQKIHsKLSAgICBfcGFnZS0+dXBkYXRlQWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJsZWQo X0FYU1dlYkFjY2Vzc2liaWxpdHlFdmVudHNFbmFibGVkKCkpOworICAgIGF1dG8qIGZ1bmN0aW9u UHRyID0gJl9BWFNXZWJBY2Nlc3NpYmlsaXR5RXZlbnRzRW5hYmxlZDsKKyAgICBpZiAoZnVuY3Rp b25QdHIpCisgICAgICAgIF9wYWdlLT51cGRhdGVBY2Nlc3NpYmlsaXR5RXZlbnRzRW5hYmxlZChf QVhTV2ViQWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJsZWQoKSk7CiB9CiAjZW5kaWYKIAo= 338706 2018-04-24 21:43:41 -0700 2018-04-24 21:49:51 -0700 patch patch.txt text/plain 3245 n_wang SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzA5NzcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA0LTI0ICBOYW4gV2FuZyAg PG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IHNvZnQgbGluayBsaWJBY2Nlc3NpYmls aXR5LmR5bGIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NDkxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlYWtseSBsaW5rZWQgbGliQWNjZXNzaWJpbGl0eS5keWxpYiBvbiBtYWNPUy4KKworICAgICAg ICAqIENvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZzoKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9pbml0aWFsaXpl V2l0aENvbmZpZ3VyYXRpb246XSk6CisgICAgICAgICgtW1dLV2ViVmlldyBfdXBkYXRlQWNjZXNz aWJpbGl0eUV2ZW50c0VuYWJsZWRdKToKKwogMjAxOC0wNC0yNCAgU2FhbSBCYXJhdGkgIDxzYmFy YXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBLZWVwIGFyb3VuZCBhIHByZS13YXJtZWQgcHJvY2Vz cyB3aGVuIGRvaW5nIHByb2Nlc3Mgc3dhcCBvbiBuYXZpZ2F0aW9uCkluZGV4OiBTb3VyY2UvV2Vi S2l0L0NvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L0NvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZwkocmV2aXNpb24gMjMwOTQyKQor KysgU291cmNlL1dlYktpdC9Db25maWd1cmF0aW9ucy9XZWJLaXQueGNjb25maWcJKHdvcmtpbmcg Y29weSkKQEAgLTQ1LDcgKzQ1LDcgQEAgV0tfQUNDRVNTSUJJTElUWV9MREZMQUdTX2lwaG9uZXNp bXVsYXRvcgogV0tfQUNDRVNTSUJJTElUWV9MREZMQUdTX3dhdGNob3MgPSAkKFdLX0FDQ0VTU0lC SUxJVFlfTERGTEFHU19pcGhvbmVvcyk7CiBXS19BQ0NFU1NJQklMSVRZX0xERkxBR1NfYXBwbGV0 dm9zID0gJChXS19BQ0NFU1NJQklMSVRZX0xERkxBR1NfaXBob25lb3MpOwogV0tfQUNDRVNTSUJJ TElUWV9MREZMQUdTX21hY29zeCA9ICQoV0tfQUNDRVNTSUJJTElUWV9MREZMQUdTJChXS19NQUNP U18xMDE0KSk7Ci1XS19BQ0NFU1NJQklMSVRZX0xERkxBR1NfTUFDT1NfU0lOQ0VfMTAxNCA9IC1s QWNjZXNzaWJpbGl0eTsKK1dLX0FDQ0VTU0lCSUxJVFlfTERGTEFHU19NQUNPU19TSU5DRV8xMDE0 ID0gLXdlYWtfbGlicmFyeSAvdXNyL2xpYi9saWJBY2Nlc3NpYmlsaXR5LmR5bGliOwogCiBXS19B UFBLSVRfTERGTEFHUyA9ICQoV0tfQVBQS0lUX0xERkxBR1NfJChXS19QTEFURk9STV9OQU1FKSk7 CiBXS19BUFBLSVRfTERGTEFHU19tYWNvc3ggPSAtZnJhbWV3b3JrIEFwcEtpdDsKSW5kZXg6IFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQkocmV2aXNp b24gMjMwOTQyKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjA3LDYgKzIwNyw3IEBAIEBpbnRlcmZhY2UgV0tXZWJW aWV3ICgpIDxOU1RvdWNoQmFyUHJvdmkKICNlbmRpZiAvLyBQTEFURk9STShNQUMpCiAKICNpZiBF TkFCTEUoQUNDRVNTSUJJTElUWV9FVkVOVFMpCisjaW5jbHVkZSA8d3RmL2Rhcndpbi9XZWFrTGlu a2luZy5oPgogI2lmIF9faGFzX2luY2x1ZGUoPEFjY2Vzc2liaWxpdHlTdXBwb3J0Lmg+KQogI2lu Y2x1ZGUgPEFjY2Vzc2liaWxpdHlTdXBwb3J0Lmg+CiAjZWxzZQpAQCAtNzAwLDcgKzcwMSw5IEBA ICAgICAvLyBXZSBhcmUgaW4gdGhlIFZpZXcncyBpbml0aWFsaXphdGkKICNlbmRpZgogCiAjaWYg RU5BQkxFKEFDQ0VTU0lCSUxJVFlfRVZFTlRTKQotICAgIENGTm90aWZpY2F0aW9uQ2VudGVyQWRk T2JzZXJ2ZXIoQ0ZOb3RpZmljYXRpb25DZW50ZXJHZXREYXJ3aW5Ob3RpZnlDZW50ZXIoKSwgKF9f YnJpZGdlIGNvbnN0IHZvaWQgKikoc2VsZiksIGFjY2Vzc2liaWxpdHlFdmVudHNFbmFibGVkQ2hh bmdlZENhbGxiYWNrLCBrQVhTV2ViQWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJsZWROb3RpZmljYXRp b24sIDAsIENGTm90aWZpY2F0aW9uU3VzcGVuc2lvbkJlaGF2aW9yRGVsaXZlckltbWVkaWF0ZWx5 KTsKKyAgICBjb25zdCBhdXRvKiBub3RpZmljYXRpb25QdHIgPSAma0FYU1dlYkFjY2Vzc2liaWxp dHlFdmVudHNFbmFibGVkTm90aWZpY2F0aW9uOworICAgIGlmIChub3RpZmljYXRpb25QdHIpCisg ICAgICAgIENGTm90aWZpY2F0aW9uQ2VudGVyQWRkT2JzZXJ2ZXIoQ0ZOb3RpZmljYXRpb25DZW50 ZXJHZXREYXJ3aW5Ob3RpZnlDZW50ZXIoKSwgKF9fYnJpZGdlIGNvbnN0IHZvaWQgKikoc2VsZiks IGFjY2Vzc2liaWxpdHlFdmVudHNFbmFibGVkQ2hhbmdlZENhbGxiYWNrLCBrQVhTV2ViQWNjZXNz aWJpbGl0eUV2ZW50c0VuYWJsZWROb3RpZmljYXRpb24sIDAsIENGTm90aWZpY2F0aW9uU3VzcGVu c2lvbkJlaGF2aW9yRGVsaXZlckltbWVkaWF0ZWx5KTsKICAgICBbc2VsZiBfdXBkYXRlQWNjZXNz aWJpbGl0eUV2ZW50c0VuYWJsZWRdOwogI2VuZGlmCiAKQEAgLTMwNzMsNyArMzA3Niw4IEBAIHN0 YXRpYyB2b2lkIGFjY2Vzc2liaWxpdHlFdmVudHNFbmFibGVkQ2gKIAogLSAodm9pZClfdXBkYXRl QWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJsZWQKIHsKLSAgICBfcGFnZS0+dXBkYXRlQWNjZXNzaWJp bGl0eUV2ZW50c0VuYWJsZWQoX0FYU1dlYkFjY2Vzc2liaWxpdHlFdmVudHNFbmFibGVkKCkpOwor ICAgIGlmICghaXNOdWxsRnVuY3Rpb25Qb2ludGVyKF9BWFNXZWJBY2Nlc3NpYmlsaXR5RXZlbnRz RW5hYmxlZCkpCisgICAgICAgIF9wYWdlLT51cGRhdGVBY2Nlc3NpYmlsaXR5RXZlbnRzRW5hYmxl ZChfQVhTV2ViQWNjZXNzaWJpbGl0eUV2ZW50c0VuYWJsZWQoKSk7CiB9CiAjZW5kaWYKIAo=