184918 2018-04-24 08:45:26 -0700 REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure 2018-05-01 13:40:29 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad cdumez ap cdumez commit-queue thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1417162 0 ryanhaddad 2018-04-24 08:45:26 -0700 API test WebKit.AutoLayoutIntegration is a flaky failure FAIL WebKit.AutoLayoutIntegration /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:98 Value of: intrinsicContentSize.height Actual: 8 Expected: _expectedIntrinsicContentSize.height Which is: 10 https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/9693 https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/builds/3431 1417361 1 webkit-bug-importer 2018-04-24 17:42:45 -0700 <rdar://problem/39705516> 1417597 2 ryanhaddad 2018-04-25 10:24:08 -0700 The earliest failures I can see from parsing logs on the bots is with https://trac.webkit.org/changeset/230919/webkit, which appears to be unrelated. Looking at changes around that revision, this seems like it *could* be related: https://trac.webkit.org/changeset/230916/webkit 1417599 3 wenson_hsieh 2018-04-25 10:27:24 -0700 (In reply to Ryan Haddad from comment #2) > The earliest failures I can see from parsing logs on the bots is with > https://trac.webkit.org/changeset/230919/webkit, which appears to be > unrelated. > > Looking at changes around that revision, this seems like it *could* be > related: https://trac.webkit.org/changeset/230916/webkit That change only has an effect when EXTRA_ZOOM_MODE is enabled, so I would not expect that to be related. (i.e., shouldIgnoreScalingConstraintsRegardlessOfContentSize() always returns false in non-extra-zoom-mode). 1417600 4 ryanhaddad 2018-04-25 10:28:31 -0700 (In reply to Wenson Hsieh from comment #3) > (In reply to Ryan Haddad from comment #2) > > The earliest failures I can see from parsing logs on the bots is with > > https://trac.webkit.org/changeset/230919/webkit, which appears to be > > unrelated. > > > > Looking at changes around that revision, this seems like it *could* be > > related: https://trac.webkit.org/changeset/230916/webkit > > That change only has an effect when EXTRA_ZOOM_MODE is enabled, so I would > not expect that to be related. (i.e., > shouldIgnoreScalingConstraintsRegardlessOfContentSize() always returns false > in non-extra-zoom-mode). Ok, the search continues. 1418530 5 ryanhaddad 2018-04-27 10:24:39 -0700 I can reproduce this locally, so I'll try to bisect. 1418605 6 ryanhaddad 2018-04-27 13:59:17 -0700 This does indeed appear to have regressed with https://trac.webkit.org/changeset/230919/webkit I cannot reproduce when running this test a few times with a build of r230918, but I can with r230919. Chris, can you take a look? 1418607 7 cdumez 2018-04-27 14:00:22 -0700 (In reply to Ryan Haddad from comment #6) > This does indeed appear to have regressed with > https://trac.webkit.org/changeset/230919/webkit > > I cannot reproduce when running this test a few times with a build of > r230918, but I can with r230919. > > Chris, can you take a look? Sure. 1418629 8 339029 cdumez 2018-04-27 14:30:23 -0700 Created attachment 339029 Patch 1419396 9 cdumez 2018-05-01 13:12:25 -0700 Tim & Wenson: ping review? 1419410 10 339029 commit-queue 2018-05-01 13:40:27 -0700 Comment on attachment 339029 Patch Clearing flags on attachment: 339029 Committed r231208: <https://trac.webkit.org/changeset/231208> 1419411 11 commit-queue 2018-05-01 13:40:29 -0700 All reviewed patches have been landed. Closing bug. 339029 2018-04-27 14:30:23 -0700 2018-05-01 13:40:27 -0700 Patch bug-184918-20180427143022.patch text/plain 5183 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwOTM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWQ3ZTk3NWFmYzZhNzk4ZGY3MTkwMGUwNGUyMWVjYjcx ZWE2OWExNS4uZGFmODZlZWExZTE0NmZkZTFjMWI5YTcyMGIyZGMwMmExYWFjZTIwOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDE4LTA0LTI3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTiAocjIzMDkxOSk6IEFQSSB0ZXN0IFdlYktpdC5BdXRvTGF5b3V0SW50ZWdy YXRpb24gaXMgYSBmbGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODQ5MTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM5NzA1NTE2 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ug c3VyZSBwcm92aXNpb25hbCBsb2FkIGhhcyBzdGFydGVkIGJlZm9yZSBjYWxsaW5nIGJlZ2luTGF5 b3V0QXRNaW5pbXVtV2lkdGgKKyAgICAgICAgb24gdGhlIEF1dG9MYXlvdXRXS1dlYlZpZXcgdG8g cmVzdG9yZSBwcmUtcjIzMDkxOSBiZWhhdmlvci4gVGhlIGxvYWQgbm93IHN0YXJ0cworICAgICAg ICBhc3luY2hyb25vdXNseSBiZWNhdXNlIHdlIGFzayB0aGUgY2xpZW50IGlmIGl0IGlzIE9LIHRv IGRvIHRoZSBsb2FkIGFuZCB0aGUgcG9saWN5CisgICAgICAgIGRlbGVnYXRlcyBhcmUgYXN5bmNo cm9ub3VzIG5vd2FkYXlzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9BdXRvTGF5b3V0SW50ZWdyYXRpb24ubW06CisgICAgICAgICgtW0F1dG9MYXlvdXRXS1dl YlZpZXcgbG9hZDp3aXRoV2lkdGg6ZXhwZWN0aW5nQ29udGVudFNpemU6cmVzZXR0aW5nV2lkdGg6 XSk6CisgICAgICAgICogVGVzdFdlYktpdEFQSS9jb2NvYS9UZXN0TmF2aWdhdGlvbkRlbGVnYXRl Lmg6CisgICAgICAgICogVGVzdFdlYktpdEFQSS9jb2NvYS9UZXN0TmF2aWdhdGlvbkRlbGVnYXRl Lm1tOgorICAgICAgICAoLVtUZXN0TmF2aWdhdGlvbkRlbGVnYXRlIHdlYlZpZXc6ZGlkU3RhcnRQ cm92aXNpb25hbE5hdmlnYXRpb246XSk6CisgICAgICAgICgtW1Rlc3ROYXZpZ2F0aW9uRGVsZWdh dGUgd2FpdEZvckRpZFN0YXJ0UHJvdmlzaW9uYWxOYXZpZ2F0aW9uXSk6CisgICAgICAgICgtW1dL V2ViVmlldyBfdGVzdF93YWl0Rm9yRGlkU3RhcnRQcm92aXNpb25hbE5hdmlnYXRpb25dKToKKwog MjAxOC0wNC0yMyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtM YXlvdXRGb3JtYXR0aW5nQ29udGV4dF0gSW5pdGlhbCBjb21taXQuCmRpZmYgLS1naXQgYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0F1dG9MYXlvdXRJbnRlZ3JhdGlvbi5t bSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvQXV0b0xheW91dEludGVn cmF0aW9uLm1tCmluZGV4IDdjMzljM2NlODIyNDgzOWUxYTU5MTA4NjI2ZjI5ZDlkMzZiNjNjOWUu LmExNDc0NGQ4NmEwNjIwNTE1YTY5ODM5OWQzZjgzZmM3OTkyOGNiMTMgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvQXV0b0xheW91dEludGVncmF0aW9u Lm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvQXV0b0xheW91 dEludGVncmF0aW9uLm1tCkBAIC03MSw2ICs3MSw3IEBAIC0gKHZvaWQpbG9hZDooTlNTdHJpbmcg KilIVE1MU3RyaW5nIHdpdGhXaWR0aDooQ0dGbG9hdCl3aWR0aCBleHBlY3RpbmdDb250ZW50U2l6 CiAgICAgIjwvc3R5bGU+IjsKIAogICAgIFtzZWxmIGxvYWRIVE1MU3RyaW5nOltiYXNlSFRNTCBz dHJpbmdCeUFwcGVuZGluZ1N0cmluZzpIVE1MU3RyaW5nXSBiYXNlVVJMOm5pbF07CisgICAgW3Nl bGYgX3Rlc3Rfd2FpdEZvckRpZFN0YXJ0UHJvdmlzaW9uYWxOYXZpZ2F0aW9uXTsKICAgICBbc2Vs ZiBiZWdpbkxheW91dEF0TWluaW11bVdpZHRoOndpZHRoIGFuZEV4cGVjdENvbnRlbnRTaXplQ2hh bmdlOnNpemVdOwogICAgIFtzZWxmIF90ZXN0X3dhaXRGb3JEaWRGaW5pc2hOYXZpZ2F0aW9uXTsK IApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9jb2NvYS9UZXN0TmF2aWdhdGlvbkRl bGVnYXRlLmggYi9Ub29scy9UZXN0V2ViS2l0QVBJL2NvY29hL1Rlc3ROYXZpZ2F0aW9uRGVsZWdh dGUuaAppbmRleCA3YTM4MmM3YzljMmE3NDQxY2FhOGRkMjdhMjg5ZmJiNDIxOGNkODM0Li4xNmEw YmNlYWRlZTllOTEyMzM3YmUyZTc1NzAwNjk2NDU3ZjEzNmY1IDEwMDY0NAotLS0gYS9Ub29scy9U ZXN0V2ViS2l0QVBJL2NvY29hL1Rlc3ROYXZpZ2F0aW9uRGVsZWdhdGUuaAorKysgYi9Ub29scy9U ZXN0V2ViS2l0QVBJL2NvY29hL1Rlc3ROYXZpZ2F0aW9uRGVsZWdhdGUuaApAQCAtMzMsMTUgKzMz LDE4IEBACiBAaW50ZXJmYWNlIFRlc3ROYXZpZ2F0aW9uRGVsZWdhdGUgOiBOU09iamVjdCA8V0tO YXZpZ2F0aW9uRGVsZWdhdGU+CiAKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBjb3B5KSB2b2lkIChe ZGlkRmFpbFByb3Zpc2lvbmFsTmF2aWdhdGlvbikoV0tXZWJWaWV3ICosIFdLTmF2aWdhdGlvbiAq LCBOU0Vycm9yICopOworQHByb3BlcnR5IChub25hdG9taWMsIGNvcHkpIHZvaWQgKF5kaWRTdGFy dFByb3Zpc2lvbmFsTmF2aWdhdGlvbikoV0tXZWJWaWV3ICosIFdLTmF2aWdhdGlvbiAqKTsKIEBw cm9wZXJ0eSAobm9uYXRvbWljLCBjb3B5KSB2b2lkICheZGlkRmluaXNoTmF2aWdhdGlvbikoV0tX ZWJWaWV3ICosIFdLTmF2aWdhdGlvbiAqKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBjb3B5KSB2 b2lkIChecmVuZGVyaW5nUHJvZ3Jlc3NEaWRDaGFuZ2UpKFdLV2ViVmlldyAqLCBfV0tSZW5kZXJp bmdQcm9ncmVzc0V2ZW50cyk7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgY29weSkgdm9pZCAoXndl YkNvbnRlbnRQcm9jZXNzRGlkVGVybWluYXRlKShXS1dlYlZpZXcgKik7CiAKKy0gKHZvaWQpd2Fp dEZvckRpZFN0YXJ0UHJvdmlzaW9uYWxOYXZpZ2F0aW9uOwogLSAodm9pZCl3YWl0Rm9yRGlkRmlu aXNoTmF2aWdhdGlvbjsKIAogQGVuZAogCiBAaW50ZXJmYWNlIFdLV2ViVmlldyAoVGVzdFdlYktp dEFQSUV4dHJhcykKKy0gKHZvaWQpX3Rlc3Rfd2FpdEZvckRpZFN0YXJ0UHJvdmlzaW9uYWxOYXZp Z2F0aW9uOwogLSAodm9pZClfdGVzdF93YWl0Rm9yRGlkRmluaXNoTmF2aWdhdGlvbjsKIEBlbmQK IApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9jb2NvYS9UZXN0TmF2aWdhdGlvbkRl bGVnYXRlLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9jb2NvYS9UZXN0TmF2aWdhdGlvbkRlbGVn YXRlLm1tCmluZGV4IGY1ZGZkNWRmOGNiYTJlNWM2OWQ1ODAzNWY5YjU2MTQyODMyYmY0NGUuLjRk NWJjOGI4MTQ0MmUzMjEwNDRkNTdjYTU4MDA2YzUyMzIzMDg5MGIgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvY29jb2EvVGVzdE5hdmlnYXRpb25EZWxlZ2F0ZS5tbQorKysgYi9Ub29s cy9UZXN0V2ViS2l0QVBJL2NvY29hL1Rlc3ROYXZpZ2F0aW9uRGVsZWdhdGUubW0KQEAgLTMzLDYg KzMzLDEyIEBACiAKIEBpbXBsZW1lbnRhdGlvbiBUZXN0TmF2aWdhdGlvbkRlbGVnYXRlCiAKKy0g KHZvaWQpd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBkaWRTdGFydFByb3Zpc2lvbmFsTmF2 aWdhdGlvbjooV0tOYXZpZ2F0aW9uICopbmF2aWdhdGlvbgoreworICAgIGlmIChfZGlkU3RhcnRQ cm92aXNpb25hbE5hdmlnYXRpb24pCisgICAgICAgIF9kaWRTdGFydFByb3Zpc2lvbmFsTmF2aWdh dGlvbih3ZWJWaWV3LCBuYXZpZ2F0aW9uKTsKK30KKwogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZp ZXcgKil3ZWJWaWV3IGRpZEZhaWxQcm92aXNpb25hbE5hdmlnYXRpb246KFdLTmF2aWdhdGlvbiAq KW5hdmlnYXRpb24gd2l0aEVycm9yOihOU0Vycm9yICopZXJyb3IKIHsKICAgICBpZiAoX2RpZEZh aWxQcm92aXNpb25hbE5hdmlnYXRpb24pCkBAIC01Nyw2ICs2MywyMCBAQCAtICh2b2lkKV93ZWJW aWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IHJlbmRlcmluZ1Byb2dyZXNzRGlkQ2hhbmdlOihfV0tS ZW5kZXJpbmdQcgogICAgICAgICBfcmVuZGVyaW5nUHJvZ3Jlc3NEaWRDaGFuZ2Uod2ViVmlldywg cHJvZ3Jlc3NFdmVudHMpOwogfQogCistICh2b2lkKXdhaXRGb3JEaWRTdGFydFByb3Zpc2lvbmFs TmF2aWdhdGlvbgoreworICAgIEVYUEVDVF9GQUxTRShzZWxmLmRpZFN0YXJ0UHJvdmlzaW9uYWxO YXZpZ2F0aW9uKTsKKworICAgIF9fYmxvY2sgYm9vbCBmaW5pc2hlZCA9IGZhbHNlOworICAgIHNl bGYuZGlkU3RhcnRQcm92aXNpb25hbE5hdmlnYXRpb24gPSBeKFdLV2ViVmlldyAqLCBXS05hdmln YXRpb24gKikgeworICAgICAgICBmaW5pc2hlZCA9IHRydWU7CisgICAgfTsKKworICAgIFRlc3RX ZWJLaXRBUEk6OlV0aWw6OnJ1bigmZmluaXNoZWQpOworCisgICAgc2VsZi5kaWRTdGFydFByb3Zp c2lvbmFsTmF2aWdhdGlvbiA9IG5pbDsKK30KKwogLSAodm9pZCl3YWl0Rm9yRGlkRmluaXNoTmF2 aWdhdGlvbgogewogICAgIEVYUEVDVF9GQUxTRShzZWxmLmRpZEZpbmlzaE5hdmlnYXRpb24pOwpA QCAtNzUsNiArOTUsMTcgQEAgQGVuZAogCiBAaW1wbGVtZW50YXRpb24gV0tXZWJWaWV3IChUZXN0 V2ViS2l0QVBJRXh0cmFzKQogCistICh2b2lkKV90ZXN0X3dhaXRGb3JEaWRTdGFydFByb3Zpc2lv bmFsTmF2aWdhdGlvbgoreworICAgIEVYUEVDVF9GQUxTRShzZWxmLm5hdmlnYXRpb25EZWxlZ2F0 ZSk7CisKKyAgICBhdXRvIG5hdmlnYXRpb25EZWxlZ2F0ZSA9IGFkb3B0TlMoW1tUZXN0TmF2aWdh dGlvbkRlbGVnYXRlIGFsbG9jXSBpbml0XSk7CisgICAgc2VsZi5uYXZpZ2F0aW9uRGVsZWdhdGUg PSBuYXZpZ2F0aW9uRGVsZWdhdGUuZ2V0KCk7CisgICAgW25hdmlnYXRpb25EZWxlZ2F0ZSB3YWl0 Rm9yRGlkU3RhcnRQcm92aXNpb25hbE5hdmlnYXRpb25dOworCisgICAgc2VsZi5uYXZpZ2F0aW9u RGVsZWdhdGUgPSBuaWw7Cit9CisKIC0gKHZvaWQpX3Rlc3Rfd2FpdEZvckRpZEZpbmlzaE5hdmln YXRpb24KIHsKICAgICBFWFBFQ1RfRkFMU0Uoc2VsZi5uYXZpZ2F0aW9uRGVsZWdhdGUpOwo=