184864 2018-04-21 13:00:11 -0700 Expose whether you've built with the Apple Internal SDK 2018-04-22 17:27:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino ap mitz webkit-bug-importer wenson_hsieh oldest_to_newest 1416678 0 dino 2018-04-21 13:00:11 -0700 Expose whether you've build with the Apple Internal SDK 1416679 1 338532 dino 2018-04-21 13:02:01 -0700 Created attachment 338532 Patch 1416682 2 338534 dino 2018-04-21 13:06:32 -0700 Created attachment 338534 Patch 1416688 3 338534 wenson_hsieh 2018-04-21 13:27:14 -0700 Comment on attachment 338534 Patch I suppose this would be for a test that we want to run (and pass) on OpenSource bots, but may exercise different codepaths if we've built WebKit with an internal SDK? This seems a bit similar to certain iOS layout tests that we skip in OpenSource TestExpectations but mark as Pass in Internal...I wonder if it makes more sense to just skip these tests in OpenSource instead. 1416689 4 dino 2018-04-21 13:29:00 -0700 Committed r230892: <https://trac.webkit.org/changeset/230892> 1416691 5 webkit-bug-importer 2018-04-21 13:29:18 -0700 <rdar://problem/39623401> 1416797 6 ap 2018-04-22 17:27:02 -0700 > I wonder if it makes more sense to just skip these tests in OpenSource instead. +1 338532 2018-04-21 13:02:01 -0700 2018-04-21 13:06:27 -0700 Patch bug-184864-20180422060200.patch text/plain 2378 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkzZTY3MjlkMjM5ODIz NTUyZmMwYjMwMzI4YjRjMjJkMzRjZDI5MS4uOWM3ZmRhZTYyYmMxZDgzMGZkZDkyM2JmYTMxMWM1 NGE5MDRkZmEyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA0LTIxICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBFeHBvc2Ugd2hldGhlciB5b3Un dmUgYnVpbGQgd2l0aCB0aGUgQXBwbGUgSW50ZXJuYWwgU0RLCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ4NjQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnRlcm5hbHMgQVBJIHRvIGxldCBhIHRlc3Qg a25vdyBpZiBpdCBpcyBydW5uaW5nIHdpdGggdGhlCisgICAgICAgIEFwcGxlIGludGVybmFsIFNE Sy4KKworICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OnVzaW5nQXBwbGVJbnRlcm5hbFNESyBjb25zdCk6CisgICAgICAgICogdGVzdGluZy9JbnRlcm5h bHMuaDoKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFscy5pZGw6CisKIDIwMTgtMDQtMjAgIE5h biBXYW5nICA8bl93YW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQU9NIGRvZXMgbm90IHdv cmsgd2l0aCBET00gTGV2ZWwgMSBldmVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rl c3RpbmcvSW50ZXJuYWxzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNw cAppbmRleCA2NDMzMjI3YjkyMWUyMzU3OTc1YmJjNjI1ZjI3YjA2ZDQwY2Q5MmNmLi5hY2VjMjk2 ZTljYTBlMTVhNjM1NmYyMWY1NDBhMDNmNTU4MTQ2NzQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9J bnRlcm5hbHMuY3BwCkBAIC00NDk1LDQgKzQ0OTUsMTMgQEAgYm9vbCBJbnRlcm5hbHM6OmlzU3lz dGVtUHJldmlld0ltYWdlKEVsZW1lbnQmIGVsZW1lbnQpIGNvbnN0CiAgICAgcmV0dXJuIGZhbHNl OwogfQogCitib29sIHVzaW5nQXBwbGVJbnRlcm5hbFNESygpIGNvbnN0Cit7CisjaWYgVVNFKEFQ UExFX0lOVEVSTkFMX1NESykKKyAgICByZXR1cm4gdHJ1ZTsKKyNlbHNlCisgICAgcmV0dXJuIGZh bHNlOworI2VuZGlmCit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFscy5oCmluZGV4IGNkYmE4MTVjYTA0NTQwY2M3ZmFkMGE5NWM2ZGE4YWFmNWFkNDQ5 ODMuLjFiODNiY2IxOGRlNzczYzVmMzRhNTA2MDU3MmQ0OTg1YWI5ZGYyYzEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmgKKysrIGIvU291cmNlL1dlYkNvcmUv dGVzdGluZy9JbnRlcm5hbHMuaApAQCAtNjYxLDYgKzY2MSw4IEBAIHB1YmxpYzoKICAgICBib29s IGlzU3lzdGVtUHJldmlld0xpbmsoRWxlbWVudCYpIGNvbnN0OwogICAgIGJvb2wgaXNTeXN0ZW1Q cmV2aWV3SW1hZ2UoRWxlbWVudCYpIGNvbnN0OwogCisgICAgYm9vbCB1c2luZ0FwcGxlSW50ZXJu YWxTREsoKSBjb25zdDsKKwogcHJpdmF0ZToKICAgICBleHBsaWNpdCBJbnRlcm5hbHMoRG9jdW1l bnQmKTsKICAgICBEb2N1bWVudCogY29udGV4dERvY3VtZW50KCkgY29uc3Q7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS90 ZXN0aW5nL0ludGVybmFscy5pZGwKaW5kZXggMTJlMWQ4MjcxMmQ2MjQ4NTZlN2NjZjVmNmExNTdi YjJmN2NmZjRjYS4uOGQ5YzI2N2NkZGUwZDQ2NWRiZmY3NzM0ZTkyYjY2MGM0NzhmYzM4OCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaWRsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbApAQCAtNTkyLDQgKzU5Miw2IEBAIGVudW0g RXZlbnRUaHJvdHRsaW5nQmVoYXZpb3IgewogICAgIERPTVN0cmluZyBzeXN0ZW1QcmV2aWV3UmVs VHlwZSgpOwogICAgIGJvb2xlYW4gaXNTeXN0ZW1QcmV2aWV3TGluayhFbGVtZW50IGVsZW1lbnQp OwogICAgIGJvb2xlYW4gaXNTeXN0ZW1QcmV2aWV3SW1hZ2UoRWxlbWVudCBlbGVtZW50KTsKKwor ICAgIGJvb2xlYW4gdXNpbmdBcHBsZUludGVybmFsU0RLKCk7CiB9Owo= 338534 2018-04-21 13:06:32 -0700 2018-04-21 13:17:54 -0700 Patch bug-184864-20180422060630.patch text/plain 2389 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkzZTY3MjlkMjM5ODIz NTUyZmMwYjMwMzI4YjRjMjJkMzRjZDI5MS4uOWM3ZmRhZTYyYmMxZDgzMGZkZDkyM2JmYTMxMWM1 NGE5MDRkZmEyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA0LTIxICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBFeHBvc2Ugd2hldGhlciB5b3Un dmUgYnVpbGQgd2l0aCB0aGUgQXBwbGUgSW50ZXJuYWwgU0RLCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ4NjQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnRlcm5hbHMgQVBJIHRvIGxldCBhIHRlc3Qg a25vdyBpZiBpdCBpcyBydW5uaW5nIHdpdGggdGhlCisgICAgICAgIEFwcGxlIGludGVybmFsIFNE Sy4KKworICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OnVzaW5nQXBwbGVJbnRlcm5hbFNESyBjb25zdCk6CisgICAgICAgICogdGVzdGluZy9JbnRlcm5h bHMuaDoKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFscy5pZGw6CisKIDIwMTgtMDQtMjAgIE5h biBXYW5nICA8bl93YW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQU9NIGRvZXMgbm90IHdv cmsgd2l0aCBET00gTGV2ZWwgMSBldmVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rl c3RpbmcvSW50ZXJuYWxzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNw cAppbmRleCA2NDMzMjI3YjkyMWUyMzU3OTc1YmJjNjI1ZjI3YjA2ZDQwY2Q5MmNmLi5kNDRmYzBh MjVlYzM3MjI0ZGU0Njg2OTdiNjQ3YzZkMWFkYTAzZDEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9J bnRlcm5hbHMuY3BwCkBAIC00NDk1LDQgKzQ0OTUsMTMgQEAgYm9vbCBJbnRlcm5hbHM6OmlzU3lz dGVtUHJldmlld0ltYWdlKEVsZW1lbnQmIGVsZW1lbnQpIGNvbnN0CiAgICAgcmV0dXJuIGZhbHNl OwogfQogCitib29sIEludGVybmFsczo6dXNpbmdBcHBsZUludGVybmFsU0RLKCkgY29uc3QKK3sK KyNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQorICAgIHJldHVybiB0cnVlOworI2Vsc2UKKyAg ICByZXR1cm4gZmFsc2U7CisjZW5kaWYKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaCBiL1NvdXJjZS9XZWJD b3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmgKaW5kZXggY2RiYTgxNWNhMDQ1NDBjYzdmYWQwYTk1YzZk YThhYWY1YWQ0NDk4My4uMWI4M2JjYjE4ZGU3NzNjNWYzNGE1MDYwNTcyZDQ5ODVhYjlkZjJjMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oCkBAIC02NjEsNiArNjYxLDggQEAgcHVibGlj OgogICAgIGJvb2wgaXNTeXN0ZW1QcmV2aWV3TGluayhFbGVtZW50JikgY29uc3Q7CiAgICAgYm9v bCBpc1N5c3RlbVByZXZpZXdJbWFnZShFbGVtZW50JikgY29uc3Q7CiAKKyAgICBib29sIHVzaW5n QXBwbGVJbnRlcm5hbFNESygpIGNvbnN0OworCiBwcml2YXRlOgogICAgIGV4cGxpY2l0IEludGVy bmFscyhEb2N1bWVudCYpOwogICAgIERvY3VtZW50KiBjb250ZXh0RG9jdW1lbnQoKSBjb25zdDsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbCBiL1NvdXJj ZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbAppbmRleCAxMmUxZDgyNzEyZDYyNDg1NmU3 Y2NmNWY2YTE1N2JiMmY3Y2ZmNGNhLi44ZDljMjY3Y2RkZTBkNDY1ZGJmZjc3MzRlOTJiNjYwYzQ3 OGZjMzg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5pZGwK KysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaWRsCkBAIC01OTIsNCArNTky LDYgQEAgZW51bSBFdmVudFRocm90dGxpbmdCZWhhdmlvciB7CiAgICAgRE9NU3RyaW5nIHN5c3Rl bVByZXZpZXdSZWxUeXBlKCk7CiAgICAgYm9vbGVhbiBpc1N5c3RlbVByZXZpZXdMaW5rKEVsZW1l bnQgZWxlbWVudCk7CiAgICAgYm9vbGVhbiBpc1N5c3RlbVByZXZpZXdJbWFnZShFbGVtZW50IGVs ZW1lbnQpOworCisgICAgYm9vbGVhbiB1c2luZ0FwcGxlSW50ZXJuYWxTREsoKTsKIH07Cg==