184862 2018-04-21 11:30:19 -0700 [Modern Media Controls] Obtain compact mode icons through WebKitAdditions 2018-05-28 04:18:45 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186034 InRadar P2 Normal --- 1 graouts graouts dino ews-watchlist jonlee webkit-bug-importer oldest_to_newest 1416665 0 graouts 2018-04-21 11:30:19 -0700 For the media controls compact mode some extra icons are provided through WebKitAdditions. We need to update the media controls code to copy them to the WebCore bundle and to know how to load them. 1416666 1 graouts 2018-04-21 11:30:32 -0700 <rdar://problem/39621645> 1416667 2 338527 graouts 2018-04-21 11:34:05 -0700 Created attachment 338527 Patch 1416668 3 ews-watchlist 2018-04-21 11:36:11 -0700 Attachment 338527 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1416674 4 338527 dino 2018-04-21 12:21:51 -0700 Comment on attachment 338527 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338527&action=review > Source/WebCore/ChangeLog:9 > + No new tests (OOPS!). Remember to remove this. 1416708 5 graouts 2018-04-21 14:48:02 -0700 Committed r230894: <https://trac.webkit.org/changeset/230894> 338527 2018-04-21 11:34:05 -0700 2018-04-21 11:55:31 -0700 Patch bug-184862-20180421203404.patch text/plain 6154 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjk3ZDY0ODU2ZjZkYTYx MzY1ZDVlN2E4YjBiZTI2MjBjYTBmZjkyOS4uODRjODhhMWRmODY4OGM4OGJjYjQ0MzYwOWQ0ZjM1 OTk3MzQwZmU1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA0LTIxICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW01vZGVybiBNZWRpYSBD b250cm9sc10gT2J0YWluIGNvbXBhY3QgbW9kZSBpY29ucyB0aHJvdWdoIFdlYktpdEFkZGl0aW9u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0ODYy CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTYyMTY0NT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAg ICAgICAqIE1vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL2J1dHRvbi5qczoK KyAgICAgICAgKEJ1dHRvbi5wcm90b3R5cGUuX3VwZGF0ZUltYWdlTWV0cmljcyk6IEhhbmRsZSBQ REYgYXNzZXRzIHdoZXJlIHRoZSBpbWFnZSBzb3VyY2UncyBpbnRyaW5zaWMgc2l6ZSBuZWVkcwor ICAgICAgICB0byBiZSBhZGp1c3RlZCBmb3IgdGhlIGRldmljZSBwaXhlbCBkZW5zaXR5LgorICAg ICAgICAoQnV0dG9uKToKKyAgICAgICAgKiBNb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9j b250cm9scy9pY29uLXNlcnZpY2UuanM6IEV4cGVjdCB0aHJlZSBhZGRpdGlvbmFsIGljb25zIHBy b3ZpZGVkIHRocm91Z2gKKyAgICAgICAgV2ViS2l0QWRkaXRpb25zLCBpbmNsdWRpbmcgdHdvIGlu IHRoZSBQREYgZm9ybWF0LCBzbyB3ZSBhZGQgc3VwcG9ydCBmb3IgdGhpcyBmb3JtYXQuCisgICAg ICAgICogV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOiBDb3B5IGFkZGl0aW9uYWwg YXNzZXRzIGZyb20gdGhlIFdlYktpdEFkZGl0aW9ucyBidWlsZCBkaXJlY3Rvcnkgc2hvdWxkCisg ICAgICAgIGFueSBiZSBwcmVzZW50LgorCiAyMDE4LTA0LTIwICBDaHJpcyBOYXJkaSAgPGNuYXJk aUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgT21pdCBkZWZhdWx0IHZhbHVlIHdoZW4gc2VyaWFs aXppbmcgZm9udC1mZWF0dXJlLXNldHRpbmdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9idXR0b24uanMgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9idXR0b24uanMK aW5kZXggYzM4NmNjM2JlNDMwZTA0MTUwZDhkZDdkNzFjNWQ4NmFmMjI0ZTg3NC4uMGY2NmJkM2Mz YTAyZTZkNjljZTRhYzUxY2VkNTcwZWJhOTViMTIzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvYnV0dG9uLmpzCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL2J1 dHRvbi5qcwpAQCAtMTk5LDcgKzE5OSw3IEBAIGNsYXNzIEJ1dHRvbiBleHRlbmRzIExheW91dEl0 ZW0KICAgICAgICAgbGV0IHdpZHRoID0gdGhpcy5faW1hZ2VTb3VyY2Uud2lkdGggKiB0aGlzLl9z Y2FsZUZhY3RvcjsKICAgICAgICAgbGV0IGhlaWdodCA9IHRoaXMuX2ltYWdlU291cmNlLmhlaWdo dCAqIHRoaXMuX3NjYWxlRmFjdG9yOwogCi0gICAgICAgIGlmICh0aGlzLl9pY29uTmFtZS50eXBl ID09PSAicG5nIikgeworICAgICAgICBpZiAodGhpcy5faWNvbk5hbWUudHlwZSA9PT0gInBuZyIg fHwgdGhpcy5faWNvbk5hbWUudHlwZSA9PT0gInBkZiIpIHsKICAgICAgICAgICAgIHdpZHRoIC89 IHdpbmRvdy5kZXZpY2VQaXhlbFJhdGlvOwogICAgICAgICAgICAgaGVpZ2h0IC89IHdpbmRvdy5k ZXZpY2VQaXhlbFJhdGlvOwogICAgICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9pY29uLXNlcnZpY2UuanMgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9pY29u LXNlcnZpY2UuanMKaW5kZXggNDkzOTUzZTllODdmZDBkMWRjZDhhNWRhNTVjNGEwMDgzYzMyYjNh MS4uYWUyNDViZDg5ZmE5NzMyYTMxNGFhODU0YzI3YzllMjI2NWFmZjk4YiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvaWNv bi1zZXJ2aWNlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNv bnRyb2xzL2NvbnRyb2xzL2ljb24tc2VydmljZS5qcwpAQCAtMzAsMTMgKzMwLDE2IEBAIGNvbnN0 IEljb25zID0gewogICAgIEVudGVyUGlQICAgICAgICA6IHsgbmFtZTogIlBpcEluIiwgdHlwZTog InN2ZyIsIGxhYmVsOiBVSVN0cmluZygiRW50ZXIgUGljdHVyZSBpbiBQaWN0dXJlIikgfSwKICAg ICBFeGl0RnVsbHNjcmVlbiAgOiB7IG5hbWU6ICJFeGl0RnVsbHNjcmVlbiIsIHR5cGU6ICJzdmci LCBsYWJlbDogVUlTdHJpbmcoIkV4aXQgRnVsbCBTY3JlZW4iKSB9LAogICAgIEZvcndhcmQgICAg ICAgICA6IHsgbmFtZTogIkZvcndhcmQiLCB0eXBlOiAic3ZnIiwgbGFiZWw6IFVJU3RyaW5nKCJG b3J3YXJkIikgfSwKKyAgICBJbnZhbGlkQ29tcGFjdCAgOiB7IG5hbWU6ICJJbnZhbGlkQ29tcGFj dCIsIHR5cGU6ICJwZGYiLCBsYWJlbDogVUlTdHJpbmcoIkludmFsaWQiKSB9LAogICAgIEludmFs aWRQbGFjYXJkICA6IHsgbmFtZTogImludmFsaWQtcGxhY2FyZCIsIHR5cGU6ICJwbmciLCBsYWJl bDogVUlTdHJpbmcoIkludmFsaWQiKSB9LAogICAgIFBhdXNlICAgICAgICAgICA6IHsgbmFtZTog IlBhdXNlIiwgdHlwZTogInN2ZyIsIGxhYmVsOiBVSVN0cmluZygiUGF1c2UiKSB9LAogICAgIFBp UFBsYWNhcmQgICAgICA6IHsgbmFtZTogInBpcC1wbGFjYXJkIiwgdHlwZTogInBuZyIsIGxhYmVs OiBVSVN0cmluZygiUGljdHVyZSBpbiBQaWN0dXJlIikgfSwKICAgICBQbGF5ICAgICAgICAgICAg OiB7IG5hbWU6ICJQbGF5IiwgdHlwZTogInN2ZyIsIGxhYmVsOiBVSVN0cmluZygiUGxheSIpIH0s CisgICAgUGxheUNvbXBhY3QgICAgIDogeyBuYW1lOiAiUGxheUNvbXBhY3QiLCB0eXBlOiAicGRm IiwgbGFiZWw6IFVJU3RyaW5nKCJQbGF5IikgfSwKICAgICBSZXdpbmQgICAgICAgICAgOiB7IG5h bWU6ICJSZXdpbmQiLCB0eXBlOiAic3ZnIiwgbGFiZWw6IFVJU3RyaW5nKCJSZXdpbmQiKSB9LAog ICAgIFNraXBCYWNrICAgICAgICA6IHsgbmFtZTogIlNraXBCYWNrMTUiLCB0eXBlOiAic3ZnIiwg bGFiZWw6IFVJU3RyaW5nKCJTa2lwIEJhY2sgJXMgU2Vjb25kcyIsIFNraXBTZWNvbmRzKSB9LAog ICAgIFNraXBGb3J3YXJkICAgICA6IHsgbmFtZTogIlNraXBGb3J3YXJkMTUiLCB0eXBlOiAic3Zn IiwgbGFiZWw6IFVJU3RyaW5nKCJTa2lwIEZvcndhcmQgJXMgU2Vjb25kcyIsIFNraXBTZWNvbmRz KSB9LAorICAgIFNwaW5uZXJDb21wYWN0ICA6IHsgbmFtZTogIkFjdGl2aXR5SW5kaWNhdG9yU3By aXRlQ29tcGFjdCIsIHR5cGU6ICJwbmciLCBsYWJlbDogVUlTdHJpbmcoIkxvYWRpbmfigKYiKSB9 LAogICAgIFRyYWNrcyAgICAgICAgICA6IHsgbmFtZTogIk1lZGlhU2VsZWN0b3IiLCB0eXBlOiAi c3ZnIiwgbGFiZWw6IFVJU3RyaW5nKCJNZWRpYSBTZWxlY3Rpb24iKSB9LAogICAgIFZvbHVtZSAg ICAgICAgICA6IHsgbmFtZTogIlZvbHVtZUhpIiwgdHlwZTogInN2ZyIsIGxhYmVsOiBVSVN0cmlu ZygiTXV0ZSIpIH0sCiAgICAgVm9sdW1lUlRMICAgICAgIDogeyBuYW1lOiAiVm9sdW1lSGktUlRM IiwgdHlwZTogInN2ZyIsIGxhYmVsOiBVSVN0cmluZygiTXV0ZSIpIH0sCkBAIC00Nyw2ICs1MCw3 IEBAIGNvbnN0IEljb25zID0gewogfTsKIAogY29uc3QgTWltZVR5cGVzID0geworICAgICJwZGYi OiAiYXBwbGljYXRpb24vcGRmIiwKICAgICAicG5nIjogImltYWdlL3BuZyIsCiAgICAgInN2ZyI6 ICJpbWFnZS9zdmcreG1sIgogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUu eGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVw cm9qL3Byb2plY3QucGJ4cHJvagppbmRleCAzOTVhZmY3M2RlZWJhNjkyMDU1NTdlNTc1ZTBhZTJj MTZiMzkxNzI2Li5iOGU4NGY0YmFjYmEzMmQwY2MxNzY4MWIzZTcxM2M2Zjg3MDljN2M2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oK KysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBA IC0zMTAxNyw3ICszMTAxNyw3IEBACiAJCQkpOwogCQkJcnVuT25seUZvckRlcGxveW1lbnRQb3N0 cHJvY2Vzc2luZyA9IDA7CiAJCQlzaGVsbFBhdGggPSAvYmluL3NoOwotCQkJc2hlbGxTY3JpcHQg PSAiU1JDX0RJUj1cIiRTUkNST09UL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzXCJcbkRT VF9ESVI9XCIkQlVJTFRfUFJPRFVDVFNfRElSLyRVTkxPQ0FMSVpFRF9SRVNPVVJDRVNfRk9MREVS X1BBVEgvbW9kZXJuLW1lZGlhLWNvbnRyb2xzXCJcblxubWtkaXIgLXAgXCIkRFNUX0RJUlwiXG5c bmlmIFsgXCIke1dLX1BMQVRGT1JNX05BTUV9XCIgPT0gXCJtYWNvc3hcIiBdOyB0aGVuXG4gICAg SU1HX09TX1BSRUZJWD1cIm1hY09TXCJcbmVsc2VcbiAgICBJTUdfT1NfUFJFRklYPVwiaU9TXCJc bmZpXG5cbmlmIFsgLW4gXCIkSU1HX09TX1BSRUZJWFwiIF07IHRoZW5cbnJzeW5jIC1hcSAtLWV4 Y2x1ZGUgXCIuc3ZuXCIgLS1leGNsdWRlIFwiLkRTX1N0b3JlXCIgXCIkU1JDX0RJUi9pbWFnZXMv JElNR19PU19QUkVGSVgvXCIgXCIkRFNUX0RJUi9pbWFnZXNcIlxuZmlcblxuY2QgXCIkU1JDX0RJ UlwiXG5jYXQgY29udHJvbHMvKi5jc3MgPiBcIiREU1RfRElSL21vZGVybi1tZWRpYS1jb250cm9s cy5jc3NcIlxuICAgICAgICAgICAgIGNhdCBgY2F0IGpzLWZpbGVzYCA+IFwiJERTVF9ESVIvbW9k ZXJuLW1lZGlhLWNvbnRyb2xzLmpzXCJcbiI7CisJCQlzaGVsbFNjcmlwdCA9ICJXS0FfRElSPVwi JEJVSUxUX1BST0RVQ1RTX0RJUi91c3IvbG9jYWwvaW5jbHVkZS9XZWJLaXRBZGRpdGlvbnMvY29t cGFjdC1tZWRpYS1jb250cm9sc1wiXG5TUkNfRElSPVwiJFNSQ1JPT1QvTW9kdWxlcy9tb2Rlcm4t bWVkaWEtY29udHJvbHNcIlxuRFNUX0RJUj1cIiRCVUlMVF9QUk9EVUNUU19ESVIvJFVOTE9DQUxJ WkVEX1JFU09VUkNFU19GT0xERVJfUEFUSC9tb2Rlcm4tbWVkaWEtY29udHJvbHNcIlxuXG5ta2Rp ciAtcCBcIiREU1RfRElSXCJcblxuaWYgWyBcIiR7V0tfUExBVEZPUk1fTkFNRX1cIiA9PSBcIm1h Y29zeFwiIF07IHRoZW5cbiAgICBJTUdfT1NfUFJFRklYPVwibWFjT1NcIlxuZWxzZVxuICAgIElN R19PU19QUkVGSVg9XCJpT1NcIlxuZmlcblxuaWYgWyAtbiBcIiRJTUdfT1NfUFJFRklYXCIgXTsg dGhlblxucnN5bmMgLWFxIC0tZXhjbHVkZSBcIi5zdm5cIiAtLWV4Y2x1ZGUgXCIuRFNfU3RvcmVc IiBcIiRTUkNfRElSL2ltYWdlcy8kSU1HX09TX1BSRUZJWC9cIiBcIiREU1RfRElSL2ltYWdlc1wi XG5maVxuXG5pZiBbIC1kIFwiJFdLQV9ESVJcIiBdOyB0aGVuXG5yc3luYyAtYXEgLS1leGNsdWRl IFwiLnN2blwiIC0tZXhjbHVkZSBcIi5EU19TdG9yZVwiIFwiJFdLQV9ESVIvXCIgXCIkRFNUX0RJ Ui9pbWFnZXMvXCJcbmZpXG5cbmNkIFwiJFNSQ19ESVJcIlxuY2F0IGNvbnRyb2xzLyouY3NzID4g XCIkRFNUX0RJUi9tb2Rlcm4tbWVkaWEtY29udHJvbHMuY3NzXCJcbiAgICAgICAgICAgICBjYXQg YGNhdCBqcy1maWxlc2AgPiBcIiREU1RfRElSL21vZGVybi1tZWRpYS1jb250cm9scy5qc1wiXG4i OwogCQl9OwogCQlBNUU3OUNFQzFFNjdGMkNGMDBGQjgxNTMgLyogTWFrZSBGcmFtZXdvcmtzIFN5 bWJvbGljIExpbmsgKi8gPSB7CiAJCQlpc2EgPSBQQlhTaGVsbFNjcmlwdEJ1aWxkUGhhc2U7Cg==