184854 2018-04-20 17:51:05 -0700 Render a badge on system preview images 2018-04-20 18:35:28 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino thorton webkit-bug-importer zalan oldest_to_newest 1416554 0 dino 2018-04-20 17:51:05 -0700 Render a badge on system preview images 1416555 1 webkit-bug-importer 2018-04-20 17:51:41 -0700 <rdar://problem/39615154> 1416560 2 338503 dino 2018-04-20 18:14:48 -0700 Created attachment 338503 Patch 1416561 3 338503 thorton 2018-04-20 18:19:38 -0700 Comment on attachment 338503 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338503&action=review > Source/WebCore/rendering/RenderTheme.cpp:1374 > + auto roundedMarkerRect = FloatRoundedRect { markerRect, { 8, 8 }, { 8, 8 }, { 8, 8 }, { 8, 8 } }; There is a single-float uniform radii constructor 1416564 4 338503 zalan 2018-04-20 18:22:26 -0700 Comment on attachment 338503 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338503&action=review > Source/WebCore/rendering/RenderTheme.cpp:1360 > +void RenderTheme::paintSystemPreviewBadge(Image& image, const PaintInfo& paintInfo, const FloatRect& rect) const Image& > Source/WebCore/rendering/RenderTheme.cpp:1375 > + auto markerRect = FloatRect {rect.x() + rect.width() - 24, rect.y() + 8, 16, 16 }; > + auto roundedMarkerRect = FloatRoundedRect { markerRect, { 8, 8 }, { 8, 8 }, { 8, 8 }, { 8, 8 } }; > + auto color = Color { 255, 0, 0 }; How do these hardcoded values work in scaled context? 1416571 5 338503 thorton 2018-04-20 18:28:43 -0700 Comment on attachment 338503 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338503&action=review >> Source/WebCore/rendering/RenderTheme.cpp:1375 >> + auto color = Color { 255, 0, 0 }; > > How do these hardcoded values work in scaled context? Assuming the badge should scale up, they'll be fine! 1416572 6 dino 2018-04-20 18:32:05 -0700 Committed r230872: <https://trac.webkit.org/changeset/230872> 1416575 7 dino 2018-04-20 18:35:28 -0700 (In reply to Tim Horton from comment #5) > Comment on attachment 338503 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338503&action=review > > >> Source/WebCore/rendering/RenderTheme.cpp:1375 > >> + auto color = Color { 255, 0, 0 }; > > > > How do these hardcoded values work in scaled context? > > Assuming the badge should scale up, they'll be fine! Yep, the badge should scale with the image. The one we'll implement for Apple is specified to be 10% of the image height. 338503 2018-04-20 18:14:48 -0700 2018-04-20 18:19:38 -0700 Patch bug-184854-20180421111447.patch text/plain 6815 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjA0OWEzODdjMWJhNmY0 YmQ4OWE0OTIyOTRmOTUzODNiOTM2MTgyMC4uNDU0MjdmZTJjYzE2NTVmY2E2MTk4ZTRhMDVkMTUx OGQwODU1YjVkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE4LTA0LTIwICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBSZW5kZXIgYSBiYWRnZSBvbiBz eXN0ZW0gcHJldmlldyBpbWFnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4NDg1NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzk2MTUxNTQ+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXQgcGFpbnQg dGltZSwgaWYgYSBSZW5kZXJJbWFnZSBpcyBhbiBpbWFnZSBlbGVtZW50CisgICAgICAgIHdoaWNo IGlzIGlkZW50aWZpZWQgYXMgYSBzeXN0ZW0gcHJldmlldywgdGhlbiBkcmF3CisgICAgICAgIGEg bGl0dGxlIGJhZGdlIGluIHRoZSB0b3AgcmlnaHQgY29ybmVyLgorCisgICAgICAgIEl0IGlzIGV4 cGVjdGVkIHRoYXQgcGxhdGZvcm1zIHdpbGwgb3ZlcnJpZGUgdGhlCisgICAgICAgIGRlZmF1bHQg cmVuZGVyaW5nIHdpdGggc29tZXRoaW5nIHRoYXQgaWRlbnRpZmllcworICAgICAgICBob3cgYSBz eXN0ZW0gcHJldmlldyB3aWxsIG9wZXJhdGUuIGUuZy4gUXVpY2tMb29rCisgICAgICAgIG9uIEFw cGxlIHN5c3RlbXMuCisKKyAgICAgICAgVGVzdDogc3lzdGVtLXByZXZpZXcvYmFkZ2UuaHRtbAor CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckltYWdlOjpwYWludEludG9SZWN0KTogSWYgd2UgYXJlCisgICAgICAgIGEgc3lzdGVt IHByZXZpZXcsIGNhbGwgUmVuZGVyVGhlbWUgdG8gZHJhdyBhIGJhZGdlLgorICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJUaGVtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZTo6 cGFpbnRTeXN0ZW1QcmV2aWV3QmFkZ2UpOiBBIGRlZmF1bHQKKyAgICAgICAgaW1wbGVtZW50YXRp b24gdGhhdCBkcmF3cyBhIHJlZCBjaXJjbGUuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRo ZW1lLmg6CisKIDIwMTgtMDQtMTggIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAg ICAgICAgIERldGVjdCBzeXN0ZW0gcHJldmlldyBsaW5rcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJJbWFnZS5jcHAKaW5kZXggNzQ0ZThlMzU5YTZiZDA1NWY5ZmM4ODhiYTRiZTQ3ZjM3 OTAzNDY1Zi4uZmJkNzgzNDJjMjE3Nzc3MzllNDJmM2VhYmI0Y2ZlYjVlMzE3MjQ1MiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCkBAIC00OSw2ICs0OSw3IEBACiAj aW5jbHVkZSAiUGFpbnRJbmZvLmgiCiAjaW5jbHVkZSAiUmVuZGVyRnJhZ21lbnRlZEZsb3cuaCIK ICNpbmNsdWRlICJSZW5kZXJJbWFnZVJlc291cmNlU3R5bGVJbWFnZS5oIgorI2luY2x1ZGUgIlJl bmRlclRoZW1lLmgiCiAjaW5jbHVkZSAiUmVuZGVyVmlldy5oIgogI2luY2x1ZGUgIlNWR0ltYWdl LmgiCiAjaW5jbHVkZSA8d3RmL0lzb01hbGxvY0lubGluZXMuaD4KQEAgLTU5MSw2ICs1OTIsMTAg QEAgSW1hZ2VEcmF3UmVzdWx0IFJlbmRlckltYWdlOjpwYWludEludG9SZWN0KFBhaW50SW5mbyYg cGFpbnRJbmZvLCBjb25zdCBGbG9hdFJlY3QKICAgICBhdXRvIGRyYXdSZXN1bHQgPSBwYWludElu Zm8uY29udGV4dCgpLmRyYXdJbWFnZSgqaW1nLCByZWN0LCBJbWFnZVBhaW50aW5nT3B0aW9ucyhj b21wb3NpdGVPcGVyYXRvciwgQmxlbmRNb2RlTm9ybWFsLCBkZWNvZGluZ01vZGUsIG9yaWVudGF0 aW9uRGVzY3JpcHRpb24sIGludGVycG9sYXRpb24pKTsKICAgICBpZiAoZHJhd1Jlc3VsdCA9PSBJ bWFnZURyYXdSZXN1bHQ6OkRpZFJlcXVlc3REZWNvZGluZykKICAgICAgICAgaW1hZ2VSZXNvdXJj ZSgpLmNhY2hlZEltYWdlKCktPmFkZFBlbmRpbmdJbWFnZURyYXdpbmdDbGllbnQoKnRoaXMpOwor CisgICAgaWYgKGltYWdlRWxlbWVudCAmJiBpbWFnZUVsZW1lbnQtPmlzU3lzdGVtUHJldmlld0lt YWdlKCkpCisgICAgICAgIHRoZW1lKCkucGFpbnRTeXN0ZW1QcmV2aWV3QmFkZ2UoKmltZywgcGFp bnRJbmZvLCByZWN0KTsKKwogICAgIHJldHVybiBkcmF3UmVzdWx0OwogfQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcAppbmRleCA2YTRlNWI1ODY5ZGRhNjc4YWM5MmQ0 NzU3MDM3ODcxYmFhZmI4Y2MxLi45MDkzMjUyZGZiMjFiYzI0MmUyMzMzYjc2NTRjMWE3MDI1YTAy Njc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAKQEAgLTEzNTcs NiArMTM1NywyNSBAQCBTdHJpbmcgUmVuZGVyVGhlbWU6OmZpbGVMaXN0TmFtZUZvcldpZHRoKGNv bnN0IEZpbGVMaXN0KiBmaWxlTGlzdCwgY29uc3QgRm9udENhcwogICAgIHJldHVybiBTdHJpbmdU cnVuY2F0b3I6OmNlbnRlclRydW5jYXRlKHN0cmluZywgd2lkdGgsIGZvbnQpOwogfQogCit2b2lk IFJlbmRlclRoZW1lOjpwYWludFN5c3RlbVByZXZpZXdCYWRnZShJbWFnZSYgaW1hZ2UsIGNvbnN0 IFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBGbG9hdFJlY3QmIHJlY3QpCit7CisgICAgLy8g VGhlIGRlZmF1bHQgaW1wbGVtZW50YXRpb24gcGFpbnRzIGEgc21hbGwgbWFya2VyCisgICAgLy8g aW4gdGhlIHVwcGVyIHJpZ2h0IGNvcm5lciwgYXMgbG9uZyBhcyB0aGUgaW1hZ2UgaXMgYmlnIGVu b3VnaC4KKworICAgIFVOVVNFRF9QQVJBTShpbWFnZSk7CisgICAgYXV0byYgY29udGV4dCA9IHBh aW50SW5mby5jb250ZXh0KCk7CisKKyAgICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0YXRl U2F2ZXIgeyBjb250ZXh0IH07CisKKyAgICBpZiAocmVjdC53aWR0aCgpIDwgMzIgfHwgcmVjdC5o ZWlnaHQoKSA8IDMyKQorICAgICAgICByZXR1cm47CisKKyAgICBhdXRvIG1hcmtlclJlY3QgPSBG bG9hdFJlY3Qge3JlY3QueCgpICsgcmVjdC53aWR0aCgpIC0gMjQsIHJlY3QueSgpICsgOCwgMTYs IDE2IH07CisgICAgYXV0byByb3VuZGVkTWFya2VyUmVjdCA9IEZsb2F0Um91bmRlZFJlY3QgeyBt YXJrZXJSZWN0LCB7IDgsIDggfSwgeyA4LCA4IH0sIHsgOCwgOCB9LCB7IDgsIDggfSB9OworICAg IGF1dG8gY29sb3IgPSBDb2xvciB7IDI1NSwgMCwgMCB9OworICAgIGNvbnRleHQuZmlsbFJvdW5k ZWRSZWN0KHJvdW5kZWRNYXJrZXJSZWN0LCBjb2xvcik7Cit9CisKICNpZiBFTkFCTEUoVE9VQ0hf RVZFTlRTKQogCiBDb2xvciBSZW5kZXJUaGVtZTo6cGxhdGZvcm1UYXBIaWdobGlnaHRDb2xvcigp IGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUu aCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5oCmluZGV4IDE1MDNlZWY5 ZTE1OWU3YjAzOTNkZDdhZWIyMWQxYWJmOGI3M2FiMjcuLmFlNjg2NzdmYzg1ZDA3MGZkYjE3ZGI5 Nzk2Njc1NTRmYmQzZjgxNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUaGVtZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5o CkBAIC0yNDYsNiArMjQ2LDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRNb2Nr Qm9sZFN5c3RlbUZvbnRGb3JBY2Nlc3NpYmlsaXR5KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0K ICAgICB2aXJ0dWFsIHZvaWQgc2V0U2hvdWxkTW9ja0JvbGRTeXN0ZW1Gb250Rm9yQWNjZXNzaWJp bGl0eShib29sKSB7IH0KIAorICAgIHZpcnR1YWwgdm9pZCBwYWludFN5c3RlbVByZXZpZXdCYWRn ZShJbWFnZSYsIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEZsb2F0UmVjdCYpOworCiBwcm90ZWN0 ZWQ6CiAgICAgdmlydHVhbCBGb250Q2FzY2FkZURlc2NyaXB0aW9uJiBjYWNoZWRTeXN0ZW1Gb250 RGVzY3JpcHRpb24oQ1NTVmFsdWVJRCBzeXN0ZW1Gb250SUQpIGNvbnN0OwogICAgIHZpcnR1YWwg dm9pZCB1cGRhdGVDYWNoZWRTeXN0ZW1Gb250RGVzY3JpcHRpb24oQ1NTVmFsdWVJRCBzeXN0ZW1G b250SUQsIEZvbnRDYXNjYWRlRGVzY3JpcHRpb24mKSBjb25zdCA9IDA7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjZiMTg4 NTFiNGQ0OWQ1ZmVkNzgwMzhhNDllY2JjNmRjMmI0NTgzYi4uODc4ZGQ4OWU4ZjE3MmFhNzA3ZDc3 YzU0YWUzMjQ0ZWQyOGNmYjQ0ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA0LTIwICBE ZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBSZW5kZXIgYSBiYWRnZSBv biBzeXN0ZW0gcHJldmlldyBpbWFnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NDg1NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzk2MTUxNTQ+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzeXN0 ZW0tcHJldmlldy9iYWRnZS1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBzeXN0ZW0t cHJldmlldy9iYWRnZS5odG1sOiBBZGRlZC4KKwogMjAxOC0wNC0xOCAgRGVhbiBKYWNrc29uICA8 ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgRGV0ZWN0IHN5c3RlbSBwcmV2aWV3IGxpbmtzCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zeXN0ZW0tcHJldmlldy9iYWRnZS1leHBlY3RlZC5odG1s IGIvTGF5b3V0VGVzdHMvc3lzdGVtLXByZXZpZXcvYmFkZ2UtZXhwZWN0ZWQuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi4xYzcxMTY1MTQ5YTY2YWExYWE2OTEzMzRmYjdhN2NlNzJjYzQ2NmMyCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvc3lzdGVtLXByZXZpZXcvYmFkZ2UtZXhwZWN0ZWQuaHRtbApA QCAtMCwwICsxLDE0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxzdHlsZT4KKyAgICBhIHsKKyAgICAg ICAgLXdlYmtpdC1jbGlwLXBhdGg6IHBhdGgoIk0gODIgMTQgTCA4NiAxNCBMIDg2IDE4IEwgODIg MTggeiIpOworICAgIH0KKyAgICBpbWcgeworICAgICAgICB3aWR0aDogMTAwcHg7CisgICAgICAg IGhlaWdodDogMTAwcHg7CisgICAgfQorPC9zdHlsZT4KKzxwPlRoaXMgdGVzdCBvbmx5IHdvcmtz IGluIFdLVFIgb3IgRFJULjwvcD4KKzxhIGhyZWY9Ii8iPgorICAgIDxpbWcgc3JjPSJkYXRhOmlt YWdlL3BuZztiYXNlNjQsaVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FBQUFFQUFBQUJBUU1BQUFBbDIx YktBQUFBQkdkQlRVRUFBSy9JTndXSzZRQUFBQU5RVEZSRi93QUFHZUlKTndBQUFBcEpSRUZVZU5w allBQUFBQUlBQWVVbjN2d0FBQUFaZEVWWWRGTnZablIzWVhKbEFFRmtiMkpsSUVsdFlXZGxVbVZo WkhseHlXVThBQUFBQUVsRlRrU3VRbUNDIj4KKzwvYT4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3N5c3RlbS1wcmV2aWV3L2JhZGdlLmh0bWwgYi9MYXlvdXRUZXN0cy9zeXN0ZW0tcHJldmlldy9i YWRnZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLmIxYzM4ZDI1NzBhNTU0NjU0NzdlODljMGI4OWU3ZjA4MTg4 ZDFlZmQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zeXN0ZW0tcHJldmlldy9iYWRn ZS5odG1sCkBAIC0wLDAgKzEsMjMgQEAKKzwhRE9DVFlQRSBodG1sPgorPHN0eWxlPgorICAgIGEg eworICAgICAgICAtd2Via2l0LWNsaXAtcGF0aDogcGF0aCgiTSA4MiAxNCBMIDg2IDE0IEwgODYg MTggTCA4MiAxOCB6Iik7CisgICAgfQorICAgIGltZyB7CisgICAgICAgIHdpZHRoOiAxMDBweDsK KyAgICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICB9Cis8L3N0eWxlPgorPHNjcmlwdD4KK3dpbmRv dy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgKCkgPT4geworICAgIGlmICghd2luZG93LmludGVy bmFscykKKyAgICAgICAgcmV0dXJuOworCisgICAgY29uc3QgbGluayA9IGRvY3VtZW50LnF1ZXJ5 U2VsZWN0b3IoImEiKTsKKyAgICBsaW5rLnJlbCA9IGludGVybmFscy5zeXN0ZW1QcmV2aWV3UmVs VHlwZSgpOworfSwgZmFsc2UpOworPC9zY3JpcHQ+Cis8cD5UaGlzIHRlc3Qgb25seSB3b3JrcyBp biBXS1RSIG9yIERSVC48L3A+Cis8YSBocmVmPSIvIj4KKyAgICA8aW1nIHNyYz0iZGF0YTppbWFn ZS9wbmc7YmFzZTY0LGlWQk9SdzBLR2dvQUFBQU5TVWhFVWdBQUFBRUFBQUFCQVFNQUFBQWwyMWJL QUFBQUJsQk1WRVVBQVA4QUFBQjdZcjgrQUFBQUVFbEVRVlI0bkdKZ0JRQUFBUC8vQXdBQUJ3QUd6 SEtySmdBQUFBQkpSVTVFcmtKZ2dnPT0iPgorPC9hPgo=