18485 2008-04-14 04:06:11 -0700 Typo and documentation fix for build-webkit 2008-04-24 17:53:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 jmalonzo webkit-unassigned jchaffraix oldest_to_newest 77531 0 jmalonzo 2008-04-14 04:06:11 -0700 build-webkit currently has a typo in foreign object and the documentation for --clean is unclear. Also, the doc for --video currently doesn't show if it's enabled or not. 77532 1 20527 jmalonzo 2008-04-14 04:08:15 -0700 Created attachment 20527 Typo and doc fixes This patch fixes the typo and FO and --clean doc of build-webkit. 77540 2 jchaffraix 2008-04-14 05:14:32 -0700 > This patch fixes the typo and FO and --clean doc of build-webkit. > The fix for the default video option is weird. The real issue is that we do not have a platform check in isCygwin() and thus returns an empty string when we are not under cygwin. I would advise you to make isCygwin() behave as the isOSX() method: check for platforms and add a fallback. 78617 3 20527 mjs 2008-04-22 22:35:34 -0700 Comment on attachment 20527 Typo and doc fixes r=me 78842 4 mrowe 2008-04-24 17:53:35 -0700 Landed in r32527. 20527 2008-04-14 04:08:15 -0700 2008-04-22 22:35:34 -0700 Typo and doc fixes webkit-buildwebkit-fix.patch text/plain 2579 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmMDQyNDZkLi4wNzg2MDYyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDQt MTQgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHVucGx1Z2dhYmxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ4NQorICAgICAgICBUeXBvIGFuZCBkb2N1bWVu dGF0aW9uIGZpeCBmb3IgYnVpbGQtd2Via2l0CisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdl YmtpdDoKKwogMjAwOC0wNC0wOCAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJz LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWls ZC13ZWJraXQKaW5kZXggNzI3M2IwOS4uNjRhZmNmMSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMv U2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQKQEAgLTU0LDcgKzU0LDcgQEAgbXkgJHN2Z0FzSW1hZ2VTdXBwb3J0ID0gMTsKIG15ICR4cGF0 aFN1cHBvcnQgPSAxOwogbXkgJHhzbHRTdXBwb3J0ID0gMTsKIG15ICRjb3ZlcmFnZVN1cHBvcnQg PSAwOwotbXkgJHZpZGVvU3VwcG9ydCA9IGlzT1NYKCkgfHwgaXNDeWd3aW4oKTsgIyBFbmFibGUg YnkgZGVmYXVsdCBvbiBPU1ggYW5kIFdpbmRvd3MKK215ICR2aWRlb1N1cHBvcnQgPSAoaXNPU1go KSB8fCBpc0N5Z3dpbigpKSA/IDEgOiAwOyAjIEVuYWJsZSBieSBkZWZhdWx0IG9uIE9TWCBhbmQg V2luZG93cwogbXkgJHNob3dIZWxwID0gMDsKIG15ICRjbGVhbiA9IDA7CiBteSAkYnVpbGRVbml2 ZXJzYWwgPSAwOwpAQCAtNjQsNyArNjQsNyBAQCBteSAkcHJvZ3JhbU5hbWUgPSBiYXNlbmFtZSgk MCk7CiBteSAkdXNhZ2UgPSA8PEVPRjsKIFVzYWdlOiAkcHJvZ3JhbU5hbWUgW29wdGlvbnNdIFtv cHRpb25zIHRvIHBhc3MgdG8gYnVpbGQgc3lzdGVtXQogICAtLWhlbHAgICAgICAgICAgICAgICAg ICAgICAgICBTaG93IHRoaXMgaGVscCBtZXNzYWdlCi0gIC0tY2xlYW4gICAgICAgICAgICAgICAg ICAgICAgIFBlcmZvcm0gYSBjbGVhbiBidWlsZAorICAtLWNsZWFuICAgICAgICAgICAgICAgICAg ICAgICBDbGVhbnVwIHRoZSBidWlsZCBkaXJlY3RvcnkKICAgLS11bml2ZXJzYWwgICAgICAgICAg ICAgICAgICAgQnVpbGQgMi13YXkgdW5pdmVyc2FsIChQUEMgYW5kIEludGVsIDMyLWJpdCkKICAg LS02NC1iaXQgICAgICAgICAgICAgICAgICAgICAgQnVpbGQgNjQtYml0LCBjb21iaW5lIHdpdGgg LS11bml2ZXJzYWwgdG8gYnVpbGQgNC13YXkgdW5pdmVyc2FsCiAgIC0tW25vLV1jcm9zcy1kb2N1 bWVudC1tZXNzYWdpbmcgICBUb2dnbGUgY3Jvc3MtZG9jdW1lbnQgbWVzc2FnaW5nIHN1cHBvcnQg KGRlZmF1bHQ6ICRjcm9zc0RvY3VtZW50TWVzc2FnaW5nU3VwcG9ydCkKQEAgLTc2LDcgKzc2LDcg QEAgVXNhZ2U6ICRwcm9ncmFtTmFtZSBbb3B0aW9uc10gW29wdGlvbnMgdG8gcGFzcyB0byBidWls ZCBzeXN0ZW1dCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGltcGxpZXMgU1ZHIFN1 cHBvcnQpCiAgIC0tW25vLV1zdmctYW5pbWF0aW9uICAgICAgICAgIFRvZ2dsZSBTVkcgYW5pbWF0 aW9uIHN1cHBvcnQgKGRlZmF1bHQ6ICRzdmdBbmltYXRpb25TdXBwb3J0LCBpbXBsaWVzIFNWRyBT dXBwb3J0KQogICAtLVtuby1dc3ZnLWZpbHRlcnMgICAgICAgICAgICBUb2dnbGUgU1ZHIGZpbHRl cnMgc3VwcG9ydCAoZGVmYXVsdDogJHN2Z0ZpbHRlcnNTdXBwb3J0LCBpbXBsaWVzIFNWRyBTdXBw b3J0KQotICAtLVtuby1dc3ZnLWZvcmVpZ24tb2JqZWN0ICAgICBUb2dnbGUgU1ZHIGZvcmdlaW5n IG9iamVjdCBzdXBwb3J0IChkZWZhdWx0OiAkc3ZnRm9yZWlnbk9iamVjdFN1cHBvcnQsIGltcGxp ZXMgU1ZHIFN1cHBvcnQpCisgIC0tW25vLV1zdmctZm9yZWlnbi1vYmplY3QgICAgIFRvZ2dsZSBT VkcgZm9yZWlnbiBvYmplY3Qgc3VwcG9ydCAoZGVmYXVsdDogJHN2Z0ZvcmVpZ25PYmplY3RTdXBw b3J0LCBpbXBsaWVzIFNWRyBTdXBwb3J0KQogICAtLVtuby1dc3ZnLWZvbnRzICAgICAgICAgICAg ICBUb2dnbGUgU1ZHIGZvbnRzIHN1cHBvcnQgKGRlZmF1bHQ6ICRzdmdGb250c1N1cHBvcnQsIGlt cGxpZXMgU1ZHIFN1cHBvcnQpCiAgIC0tW25vLV1zdmctYXMtaW1hZ2UgICAgICAgICAgIFRvZ2ds ZSBTVkcgYXMgSW1hZ2Ugc3VwcG9ydCAoZGVmYXVsdDogJHN2Z0FzSW1hZ2VTdXBwb3J0LCBpbXBs aWVzIFNWRyBTdXBwb3J0KQogICAtLVtuby1dc3ZnLXVzZSAgICAgICAgICAgICAgICBUb2dnbGUg U1ZHIHVzZSBlbGVtZW50IHN1cHBvcnQgKGRlZmF1bHQ6ICRzdmdVc2VTdXBwb3J0LCBpbXBsaWVz IFNWRyBTdXBwb3J0KQo=