184846 2018-04-20 15:43:52 -0700 Handle more JSON stringify OOM 2018-04-25 08:42:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=184883 InRadar P2 Normal --- 184941 1 jfbastien jfbastien benjamin cdumez cmarcelo commit-queue dbates ews-watchlist fpizlo jfbastien keith_miller mark.lam msaboff rmorisset ryanhaddad saam webkit-bug-importer oldest_to_newest 1416467 0 jfbastien 2018-04-20 15:43:52 -0700 JSON stringinfication can OOM easily. Here's another case. I'm working on a separate patch which teaches StringBuilder that it's fallible, but that's way bigger and more complex, so I'll commit it separately. It'll be much more comprehensive though! 1416468 1 jfbastien 2018-04-20 15:44:10 -0700 <rdar://problem/39390672> 1416470 2 338473 jfbastien 2018-04-20 15:47:38 -0700 Created attachment 338473 patch 1416471 3 ews-watchlist 2018-04-20 15:49:52 -0700 Attachment 338473 did not pass style-queue: ERROR: Source/WTF/wtf/text/StringBuilderJSON.cpp:100: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1416472 4 338473 mark.lam 2018-04-20 15:51:43 -0700 Comment on attachment 338473 patch View in context: https://bugs.webkit.org/attachment.cgi?id=338473&action=review r=me with fixes. > Source/WTF/ChangeLog:9 > + JSON stringinfication can OOM easily. Here's another case. typo: /stringinfication/stringification/. > Source/WTF/ChangeLog:13 > + I'm working on a separate patch which teaches StringBuilder that > + it's fallible, but that's way bigger and more complex, so I'll > + commit it separately. It'll be much more comprehensive though! I don't think you need to say this. > Source/WTF/wtf/text/StringBuilderJSON.cpp:98 > + if (is8Bit() && !string.is8Bit()) { You don't need the curly brace here. > Source/WTF/wtf/text/StringBuilderJSON.cpp:100 > + } else Ditto. 1416487 5 338478 jfbastien 2018-04-20 16:02:22 -0700 Created attachment 338478 patch 1416497 6 338478 commit-queue 2018-04-20 16:18:28 -0700 Comment on attachment 338478 patch Clearing flags on attachment: 338478 Committed r230863: <https://trac.webkit.org/changeset/230863> 1416498 7 commit-queue 2018-04-20 16:18:30 -0700 All reviewed patches have been landed. Closing bug. 1416947 8 ryanhaddad 2018-04-23 12:43:34 -0700 The test added with this change is failing on the 32-bit JSC bot: stress/json-stringified-overflow-2.js.default: Exception: Error: Out of memory https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/1718 1416950 9 jfbastien 2018-04-23 13:23:19 -0700 (In reply to Ryan Haddad from comment #8) > The test added with this change is failing on the 32-bit JSC bot: > > stress/json-stringified-overflow-2.js.default: Exception: Error: Out of > memory > > https://build.webkit.org/builders/Apple%20High%20Sierra%2032- > bit%20JSC%20%28BuildAndTest%29/builds/1718 Shouldn't these bots not run tests marked with: //@ skip if $memoryLimited ? 1417232 10 mark.lam 2018-04-24 12:36:28 -0700 (In reply to JF Bastien from comment #9) > (In reply to Ryan Haddad from comment #8) > > The test added with this change is failing on the 32-bit JSC bot: > > > > stress/json-stringified-overflow-2.js.default: Exception: Error: Out of > > memory > > > > https://build.webkit.org/builders/Apple%20High%20Sierra%2032- > > bit%20JSC%20%28BuildAndTest%29/builds/1718 > > Shouldn't these bots not run tests marked with: > > //@ skip if $memoryLimited > > ? No. The failing bot is a High Sierra bot which is not memory limited. The test should catch the OOM error and verify that it did catch the error. 1417287 11 mark.lam 2018-04-24 14:42:40 -0700 (In reply to Mark Lam from comment #10) > (In reply to JF Bastien from comment #9) > > (In reply to Ryan Haddad from comment #8) > > > The test added with this change is failing on the 32-bit JSC bot: > > > > > > stress/json-stringified-overflow-2.js.default: Exception: Error: Out of > > > memory > > > > > > https://build.webkit.org/builders/Apple%20High%20Sierra%2032- > > > bit%20JSC%20%28BuildAndTest%29/builds/1718 > > > > Shouldn't these bots not run tests marked with: > > > > //@ skip if $memoryLimited > > > > ? > > No. The failing bot is a High Sierra bot which is not memory limited. The > test should catch the OOM error and verify that it did catch the error. I can reproduce this on a 32-bit build but only if I don't run jsc from inside lldb. I'll just land a test fix to get the bots unstuck. 1417295 12 mark.lam 2018-04-24 14:53:59 -0700 Test fix landed in r230972: <http://trac.webkit.org/r230972>. 1417322 13 jfbastien 2018-04-24 15:51:25 -0700 (In reply to Mark Lam from comment #12) > Test fix landed in r230972: <http://trac.webkit.org/r230972>. That fix is incorrect. It's handling OOM from string *and* stringify. We only want to test OOM from stringify. It seems to me like 32-bit bots should be marked as memory limited. 1417326 14 mark.lam 2018-04-24 16:05:17 -0700 (In reply to JF Bastien from comment #13) > (In reply to Mark Lam from comment #12) > > Test fix landed in r230972: <http://trac.webkit.org/r230972>. > > That fix is incorrect. It's handling OOM from string *and* stringify. We > only want to test OOM from stringify. > > It seems to me like 32-bit bots should be marked as memory limited. I disagree. padStart() can throw an OutOfMemoryError, and it did in this case. I understand that the test is to check if JSON.stringify() throws an OOM. But what is the correct behavior for the test then? I think if padStart() throws an OOM, then the test is over ... which is what I changed it to do. How would you do this differently? 1417327 15 jfbastien 2018-04-24 16:07:01 -0700 (In reply to Mark Lam from comment #14) > (In reply to JF Bastien from comment #13) > > (In reply to Mark Lam from comment #12) > > > Test fix landed in r230972: <http://trac.webkit.org/r230972>. > > > > That fix is incorrect. It's handling OOM from string *and* stringify. We > > only want to test OOM from stringify. > > > > It seems to me like 32-bit bots should be marked as memory limited. > > I disagree. padStart() can throw an OutOfMemoryError, and it did in this > case. I understand that the test is to check if JSON.stringify() throws an > OOM. But what is the correct behavior for the test then? I think if > padStart() throws an OOM, then the test is over ... which is what I changed > it to do. > > How would you do this differently? Mark 32-bit bots as memory limited, otherwise we're deluding ourselves that we're testing stringify on *any* bot (64-bit bots aren't testing stringify either as far as we know). 1417333 16 mark.lam 2018-04-24 16:19:12 -0700 (In reply to JF Bastien from comment #15) > (In reply to Mark Lam from comment #14) > > (In reply to JF Bastien from comment #13) > > > (In reply to Mark Lam from comment #12) > > > > Test fix landed in r230972: <http://trac.webkit.org/r230972>. > > > > > > That fix is incorrect. It's handling OOM from string *and* stringify. We > > > only want to test OOM from stringify. > > > > > > It seems to me like 32-bit bots should be marked as memory limited. > > > > I disagree. padStart() can throw an OutOfMemoryError, and it did in this > > case. I understand that the test is to check if JSON.stringify() throws an > > OOM. But what is the correct behavior for the test then? I think if > > padStart() throws an OOM, then the test is over ... which is what I changed > > it to do. > > > > How would you do this differently? > > Mark 32-bit bots as memory limited, otherwise we're deluding ourselves that > we're testing stringify on *any* bot (64-bit bots aren't testing stringify > either as far as we know). The 32-bit bots are not memory limited by any stretch of the imagination. I'm reproducing this on my iMac which tons of memory. We could skip the tests for 32-bit builds, but I think that's not really fixing the core issue. From my cursory look at the code briefly, I think padStart() could just as well throw an OOM on 6-bit as well. I filed https://bugs.webkit.org/show_bug.cgi?id=184941 for us to re-visit these tests later. For now, the tests do get some coverage (thought not guaranteed to be the specific coverage we want) and the bots are green. 1417336 17 mark.lam 2018-04-24 16:20:01 -0700 (In reply to Mark Lam from comment #16) > The 32-bit bots are not memory limited by any stretch of the imagination. > I'm reproducing this on my iMac which tons of memory. We could skip the > tests for 32-bit builds, but I think that's not really fixing the core > issue. From my cursory look at the code briefly, I think padStart() could > just as well throw an OOM on 6-bit as well. > > I filed https://bugs.webkit.org/show_bug.cgi?id=184941 for us to re-visit > these tests later. For now, the tests do get some coverage (thought not > guaranteed to be the specific coverage we want) and the bots are green. By "6-bit", I meant 64-bit. 338473 2018-04-20 15:47:38 -0700 2018-04-20 16:02:22 -0700 patch 0001-Handle-more-JSON-stringify-OOM.patch text/plain 3904 jfbastien RnJvbSAwYTExODJjODM3NTZmNDE0MmNjMDk2NzY5ZjcyZmEyZGRjYTc2OTA3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBGcmksIDIwIEFwciAyMDE4IDE1OjQ3OjEzIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gSGFuZGxl IG1vcmUgSlNPTiBzdHJpbmdpZnkgT09NCgotLS0KIEpTVGVzdHMvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8IDE1ICsrKysrKysrKysrKysrKwogSlNUZXN0cy9zdHJlc3Mv anNvbi1zdHJpbmdpZmllZC1vdmVyZmxvdy0yLmpzIHwgIDUgKysrKysKIEpTVGVzdHMvc3RyZXNz L2pzb24tc3RyaW5naWZpZWQtb3ZlcmZsb3cuanMgICB8ICAzICsrLQogU291cmNlL1dURi9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTcgKysrKysrKysrKysrKysrKysKIFNv dXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQnVpbGRlckpTT04uY3BwICAgICB8ICA4ICsrKysrKy0t CiA1IGZpbGVzIGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCiBjcmVh dGUgbW9kZSAxMDA2NDQgSlNUZXN0cy9zdHJlc3MvanNvbi1zdHJpbmdpZmllZC1vdmVyZmxvdy0y LmpzCgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwpp bmRleCA4MzE0N2FhLi43MzJkZGE2IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysg Yi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA0LTIwICBKRiBCYXN0 aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5kbGUgbW9yZSBKU09OIHN0 cmluZ2lmeSBPT00KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NDg0NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzkzOTA2NzI+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvanNvbi1zdHJp bmdpZmllZC1vdmVyZmxvdy0yLmpzOiBBZGRlZC4gU2FtZSBhcyB0aGUgb25lCisgICAgICAgIGJl bG93LCBidXQgd2l0aCBhIGJpZ2dlciBpbnB1dCB3aGljaCB3aWxsIHRyaWdnZXIgYSBkaWZmZXJl bnQgY29kZQorICAgICAgICBwYXRoLgorICAgICAgICAoY2F0Y2gpOgorICAgICAgICAqIHN0cmVz cy9qc29uLXN0cmluZ2lmaWVkLW92ZXJmbG93LmpzOiBNb2RpZnkgdGhlIHRlc3QgdG8gb25seQor ICAgICAgICBjYXRjaCBPT00gb24gc3RyaW5naWZpY2F0aW9uLiBub3Qgb24gc3RyaW5nIGNyZWF0 aW9uLgorCiAyMDE4LTA0LTE4ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29t PgogCiAgICAgICAgIFtXZWJBc3NlbWJseV1bTW9kdWxlc10gSW1wb3J0IHRhYmxlcyBpbiB3YXNt IG1vZHVsZXMKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2pzb24tc3RyaW5naWZpZWQtb3Zl cmZsb3ctMi5qcyBiL0pTVGVzdHMvc3RyZXNzL2pzb24tc3RyaW5naWZpZWQtb3ZlcmZsb3ctMi5q cwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi41MDZlMGMwCi0tLSAvZGV2L251 bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvanNvbi1zdHJpbmdpZmllZC1vdmVyZmxvdy0yLmpzCkBA IC0wLDAgKzEsNSBAQAorLy9AIHNraXAgaWYgJG1lbW9yeUxpbWl0ZWQKK2NvbnN0IHMgPSAiYSIu cGFkU3RhcnQoMHg4MDAwMDAwMCAtIDEpOwordHJ5IHsKKyAgICBKU09OLnN0cmluZ2lmeShzKTsK K30gY2F0Y2ggKGUpIHt9CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9qc29uLXN0cmluZ2lm aWVkLW92ZXJmbG93LmpzIGIvSlNUZXN0cy9zdHJlc3MvanNvbi1zdHJpbmdpZmllZC1vdmVyZmxv dy5qcwppbmRleCAxYjE3YTM3Li5hNmQxN2MwIDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9q c29uLXN0cmluZ2lmaWVkLW92ZXJmbG93LmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL2pzb24tc3Ry aW5naWZpZWQtb3ZlcmZsb3cuanMKQEAgLTEsNCArMSw1IEBACiAvL0Agc2tpcCBpZiAkbWVtb3J5 TGltaXRlZAorY29uc3QgcyA9ICIxMjMiLnBhZFN0YXJ0KDEwNzM3NDE4MjMpOwogdHJ5IHsKLSAg ICAgIEpTT04uc3RyaW5naWZ5KCIxMjMiLnBhZFN0YXJ0KDEwNzM3NDE4MjMpKQorICAgIEpTT04u c3RyaW5naWZ5KHMpOwogfSBjYXRjaCAoZSkge30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hh bmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggNzhlYTc4My4uNDI0N2JiMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwyMCBAQAorMjAxOC0wNC0yMCAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBs ZS5jb20+CisKKyAgICAgICAgSGFuZGxlIG1vcmUgSlNPTiBzdHJpbmdpZnkgT09NCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ4NDYKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzM5MzkwNjcyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEpTT04gc3RyaW5naW5maWNhdGlvbiBjYW4gT09NIGVhc2lseS4g SGVyZSdzIGFub3RoZXIgY2FzZS4KKworICAgICAgICBJJ20gd29ya2luZyBvbiBhIHNlcGFyYXRl IHBhdGNoIHdoaWNoIHRlYWNoZXMgU3RyaW5nQnVpbGRlciB0aGF0CisgICAgICAgIGl0J3MgZmFs bGlibGUsIGJ1dCB0aGF0J3Mgd2F5IGJpZ2dlciBhbmQgbW9yZSBjb21wbGV4LCBzbyBJJ2xsCisg ICAgICAgIGNvbW1pdCBpdCBzZXBhcmF0ZWx5LiBJdCdsbCBiZSBtdWNoIG1vcmUgY29tcHJlaGVu c2l2ZSB0aG91Z2ghCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdCdWlsZGVySlNPTi5jcHA6 CisgICAgICAgIChXVEY6OlN0cmluZ0J1aWxkZXI6OmFwcGVuZFF1b3RlZEpTT05TdHJpbmcpOgor CiAyMDE4LTA0LTE5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAg ICAgRW5hYmxlIE9iamVjdGl2ZS1DIHdlYWsgcmVmZXJlbmNlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVySlNPTi5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0 L1N0cmluZ0J1aWxkZXJKU09OLmNwcAppbmRleCBhMGViZDYyLi5hNDVjNGZmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXJKU09OLmNwcAorKysgYi9Tb3VyY2Uv V1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXJKU09OLmNwcApAQCAtOTEsOSArOTEsMTMgQEAgYm9v bCBTdHJpbmdCdWlsZGVyOjphcHBlbmRRdW90ZWRKU09OU3RyaW5nKGNvbnN0IFN0cmluZyYgc3Ry aW5nKQogICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzYw ODYKICAgICBhbGxvY2F0aW9uU2l6ZSA9IHN0ZDo6bWF4KGFsbG9jYXRpb25TaXplLCByb3VuZFVw VG9Qb3dlck9mVHdvKGFsbG9jYXRpb25TaXplKSk7CiAKLSAgICBpZiAoaXM4Qml0KCkgJiYgIXN0 cmluZy5pczhCaXQoKSkKKyAgICAvLyBBbGxvY2F0aW5nIHRoaXMgbXVjaCB3aWxsIGRlZmluaXRl bHkgZmFpbC4KKyAgICBpZiAoYWxsb2NhdGlvblNpemUgPj0gMHg4MDAwMDAwMCkKKyAgICAgICAg cmV0dXJuIGZhbHNlOworCisgICAgaWYgKGlzOEJpdCgpICYmICFzdHJpbmcuaXM4Qml0KCkpIHsK ICAgICAgICAgYWxsb2NhdGVCdWZmZXJVcENvbnZlcnQobV9idWZmZXJDaGFyYWN0ZXJzOCwgYWxs b2NhdGlvblNpemUpOwotICAgIGVsc2UKKyAgICB9IGVsc2UKICAgICAgICAgcmVzZXJ2ZUNhcGFj aXR5KGFsbG9jYXRpb25TaXplKTsKICAgICBBU1NFUlQobV9idWZmZXItPmxlbmd0aCgpID49IGFs bG9jYXRpb25TaXplKTsKIAotLSAKMi45LjMKCg== 338478 2018-04-20 16:02:22 -0700 2018-04-20 16:18:28 -0700 patch 0001-Handle-more-JSON-stringify-OOM.patch text/plain 3514 jfbastien RnJvbSBhNzUwMjc0N2FiMzFmMjQxMDdmNjM5NWJiMDE0MDE1MWQ2NWY5NjJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBGcmksIDIwIEFwciAyMDE4IDE1OjQ3OjEzIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gSGFuZGxl IG1vcmUgSlNPTiBzdHJpbmdpZnkgT09NCgotLS0KIEpTVGVzdHMvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8IDE1ICsrKysrKysrKysrKysrKwogSlNUZXN0cy9zdHJlc3Mv anNvbi1zdHJpbmdpZmllZC1vdmVyZmxvdy0yLmpzIHwgIDUgKysrKysKIEpTVGVzdHMvc3RyZXNz L2pzb24tc3RyaW5naWZpZWQtb3ZlcmZsb3cuanMgICB8ICAzICsrLQogU291cmNlL1dURi9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTMgKysrKysrKysrKysrKwogU291cmNl L1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVySlNPTi5jcHAgICAgIHwgIDQgKysrKwogNSBmaWxl cyBjaGFuZ2VkLCAzOSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCiBjcmVhdGUgbW9kZSAx MDA2NDQgSlNUZXN0cy9zdHJlc3MvanNvbi1zdHJpbmdpZmllZC1vdmVyZmxvdy0yLmpzCgpkaWZm IC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCA4MzE0 N2FhLi43YmIxZTA2IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA0LTIwICBKRiBCYXN0aWVuICA8amZi YXN0aWVuQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5kbGUgbW9yZSBKU09OIHN0cmluZ2lmeSBP T00KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDg0 NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzkzOTA2NzI+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTWFyayBMYW0uCisKKyAgICAgICAgKiBzdHJlc3MvanNvbi1zdHJpbmdpZmllZC1vdmVyZmxv dy0yLmpzOiBBZGRlZC4gU2FtZSBhcyB0aGUgb25lCisgICAgICAgIGJlbG93LCBidXQgd2l0aCBh IGJpZ2dlciBpbnB1dCB3aGljaCB3aWxsIHRyaWdnZXIgYSBkaWZmZXJlbnQgY29kZQorICAgICAg ICBwYXRoLgorICAgICAgICAoY2F0Y2gpOgorICAgICAgICAqIHN0cmVzcy9qc29uLXN0cmluZ2lm aWVkLW92ZXJmbG93LmpzOiBNb2RpZnkgdGhlIHRlc3QgdG8gb25seQorICAgICAgICBjYXRjaCBP T00gb24gc3RyaW5naWZpY2F0aW9uLiBub3Qgb24gc3RyaW5nIGNyZWF0aW9uLgorCiAyMDE4LTA0 LTE4ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtX ZWJBc3NlbWJseV1bTW9kdWxlc10gSW1wb3J0IHRhYmxlcyBpbiB3YXNtIG1vZHVsZXMKZGlmZiAt LWdpdCBhL0pTVGVzdHMvc3RyZXNzL2pzb24tc3RyaW5naWZpZWQtb3ZlcmZsb3ctMi5qcyBiL0pT VGVzdHMvc3RyZXNzL2pzb24tc3RyaW5naWZpZWQtb3ZlcmZsb3ctMi5qcwpuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi41MDZlMGMwCi0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0 cy9zdHJlc3MvanNvbi1zdHJpbmdpZmllZC1vdmVyZmxvdy0yLmpzCkBAIC0wLDAgKzEsNSBAQAor Ly9AIHNraXAgaWYgJG1lbW9yeUxpbWl0ZWQKK2NvbnN0IHMgPSAiYSIucGFkU3RhcnQoMHg4MDAw MDAwMCAtIDEpOwordHJ5IHsKKyAgICBKU09OLnN0cmluZ2lmeShzKTsKK30gY2F0Y2ggKGUpIHt9 CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9qc29uLXN0cmluZ2lmaWVkLW92ZXJmbG93Lmpz IGIvSlNUZXN0cy9zdHJlc3MvanNvbi1zdHJpbmdpZmllZC1vdmVyZmxvdy5qcwppbmRleCAxYjE3 YTM3Li5hNmQxN2MwIDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9qc29uLXN0cmluZ2lmaWVk LW92ZXJmbG93LmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL2pzb24tc3RyaW5naWZpZWQtb3ZlcmZs b3cuanMKQEAgLTEsNCArMSw1IEBACiAvL0Agc2tpcCBpZiAkbWVtb3J5TGltaXRlZAorY29uc3Qg cyA9ICIxMjMiLnBhZFN0YXJ0KDEwNzM3NDE4MjMpOwogdHJ5IHsKLSAgICAgIEpTT04uc3RyaW5n aWZ5KCIxMjMiLnBhZFN0YXJ0KDEwNzM3NDE4MjMpKQorICAgIEpTT04uc3RyaW5naWZ5KHMpOwog fSBjYXRjaCAoZSkge30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNl L1dURi9DaGFuZ2VMb2cKaW5kZXggNzhlYTc4My4uN2JmNTZmNSAxMDA2NDQKLS0tIGEvU291cmNl L1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBA QAorMjAxOC0wNC0yMCAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CisKKyAgICAg ICAgSGFuZGxlIG1vcmUgSlNPTiBzdHJpbmdpZnkgT09NCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ4NDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzM5MzkwNjcyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgTGFtLgorCisgICAgICAgIEpT T04gc3RyaW5naWZpY2F0aW9uIGNhbiBPT00gZWFzaWx5LiBIZXJlJ3MgYW5vdGhlciBjYXNlLgor CisgICAgICAgICogd3RmL3RleHQvU3RyaW5nQnVpbGRlckpTT04uY3BwOgorICAgICAgICAoV1RG OjpTdHJpbmdCdWlsZGVyOjphcHBlbmRRdW90ZWRKU09OU3RyaW5nKToKKwogMjAxOC0wNC0xOSAg RGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSBPYmpl Y3RpdmUtQyB3ZWFrIHJlZmVyZW5jZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQv U3RyaW5nQnVpbGRlckpTT04uY3BwIGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVy SlNPTi5jcHAKaW5kZXggYTBlYmQ2Mi4uMjI2Mjk1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93 dGYvdGV4dC9TdHJpbmdCdWlsZGVySlNPTi5jcHAKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9T dHJpbmdCdWlsZGVySlNPTi5jcHAKQEAgLTkxLDYgKzkxLDEwIEBAIGJvb2wgU3RyaW5nQnVpbGRl cjo6YXBwZW5kUXVvdGVkSlNPTlN0cmluZyhjb25zdCBTdHJpbmcmIHN0cmluZykKICAgICAvLyBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2MDg2CiAgICAgYWxsb2Nh dGlvblNpemUgPSBzdGQ6Om1heChhbGxvY2F0aW9uU2l6ZSwgcm91bmRVcFRvUG93ZXJPZlR3byhh bGxvY2F0aW9uU2l6ZSkpOwogCisgICAgLy8gQWxsb2NhdGluZyB0aGlzIG11Y2ggd2lsbCBkZWZp bml0ZWx5IGZhaWwuCisgICAgaWYgKGFsbG9jYXRpb25TaXplID49IDB4ODAwMDAwMDApCisgICAg ICAgIHJldHVybiBmYWxzZTsKKwogICAgIGlmIChpczhCaXQoKSAmJiAhc3RyaW5nLmlzOEJpdCgp KQogICAgICAgICBhbGxvY2F0ZUJ1ZmZlclVwQ29udmVydChtX2J1ZmZlckNoYXJhY3RlcnM4LCBh bGxvY2F0aW9uU2l6ZSk7CiAgICAgZWxzZQotLSAKMi45LjMKCg==