184839 2018-04-20 14:36:46 -0700 Web Inspector: remove some dead code in IdentifiersFactory 2018-04-30 09:54:23 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue darin ews-watchlist inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam timothy webkit-bug-importer oldest_to_newest 1416419 0 bburg 2018-04-20 14:36:46 -0700 This code seems to only have been used by Chromium, and doesn't really make sense given the current architecture. 1416530 1 338492 bburg 2018-04-20 16:53:52 -0700 Created attachment 338492 Patch 1416557 2 338492 commit-queue 2018-04-20 18:12:49 -0700 Comment on attachment 338492 Patch Clearing flags on attachment: 338492 Committed r230870: <https://trac.webkit.org/changeset/230870> 1416558 3 commit-queue 2018-04-20 18:12:51 -0700 All reviewed patches have been landed. Closing bug. 1416559 4 webkit-bug-importer 2018-04-20 18:13:16 -0700 <rdar://problem/39615471> 1419012 5 338492 darin 2018-04-30 09:54:23 -0700 Comment on attachment 338492 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338492&action=review > Source/JavaScriptCore/inspector/IdentifiersFactory.cpp:39 > +static String addPrefixToIdentifier(const String& identifier) > +{ > + return makeString("0.", identifier); > +} If this code was at all performance critical, we should fix it to take an integer rather than a string, since makeString can convert a number to a string in place, avoiding allocating and destroying an additional string. > Source/JavaScriptCore/inspector/IdentifiersFactory.h:35 > static String requestId(unsigned long identifier); The use of "unsigned long" here is peculiar. We almost never use the "long" types in WebKit code rather than the "int" types or types like "uint32_t". unless there is a special reason. What is the reason here? 338492 2018-04-20 16:53:52 -0700 2018-04-20 18:12:49 -0700 Patch bug-184839-20180420165351.patch text/plain 5056 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ODBkYTdkNzg4ODBlNjM0MTlhMzRhNzYzNDRiMGZhMGQ0NDljZTZkLi4yMTA5ODU3MzA3M2ViNTA2 NWJiYjcxNDY5ZTYyNDZjNTk0MGNlYTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOC0wNC0yMCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiByZW1vdmUgc29tZSBkZWFkIGNvZGUgaW4gSWRlbnRpZmll cnNGYWN0b3J5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODQ4MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIHdhcyBuZXZlciB1c2VkIG9uIG5vbi1DaHJvbWUgcG9ydHMsIHNvIHRoZSBpZGVudGlm aWVyIGFsd2F5cyBoYXMgYQorICAgICAgICBwcmVmaXggb2YgJzAuJy4gV2UgbWF5IGNoYW5nZSB0 aGlzIGluIHRoZSBmdXR1cmUsIGJ1dCBmb3Igbm93IHJlbW92ZSB0aGlzLgorICAgICAgICBVc2lu ZyBhIFBJRCBmb3IgdGhpcyBwdXJwb3NlIGlzIHByb2JsZW1hdGljIGFueXdheS4KKworICAgICAg ICAqIGluc3BlY3Rvci9JZGVudGlmaWVyc0ZhY3RvcnkuY3BwOgorICAgICAgICAoSW5zcGVjdG9y OjphZGRQcmVmaXhUb0lkZW50aWZpZXIpOgorICAgICAgICAoSW5zcGVjdG9yOjpJZGVudGlmaWVy c0ZhY3Rvcnk6OmNyZWF0ZUlkZW50aWZpZXIpOgorICAgICAgICAoSW5zcGVjdG9yOjpJZGVudGlm aWVyc0ZhY3Rvcnk6OnJlcXVlc3RJZCk6CisgICAgICAgIChJbnNwZWN0b3I6OklkZW50aWZpZXJz RmFjdG9yeTo6YWRkUHJvY2Vzc0lkUHJlZml4VG8pOiBEZWxldGVkLgorICAgICAgICAqIGluc3Bl Y3Rvci9JZGVudGlmaWVyc0ZhY3RvcnkuaDoKKwogMjAxOC0wNC0yMCAgTWFyayBMYW0gIDxtYXJr LmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4IGZvciBpbnRlcm5hbCBidWlsZHMg YWZ0ZXIgcjIzMDgyNi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlNWYwNGFjMjlkNTNmZGI2NDVjMjliMmEyYzE3 YTQ0Y2MwNzdmY2NjLi5hMzQ3OThjODg2MzljNjNlYjUyNTk5N2JhOWU2NDAyODY5NGFiZTNkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDQtMjAgIEJyaWFuIEJ1cmcgIDxiYnVy Z0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogcmVtb3ZlIHNvbWUgZGVhZCBj b2RlIGluIElkZW50aWZpZXJzRmFjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg0ODM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpzZXRQcm9jZXNzSWQpOiBEZWxl dGVkLgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmg6CisKIDIwMTgt MDQtMjAgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYlBh Z2Ugc29tZXRpbWVzIGluY29ycmVjdGx5IHJ1bGVzIG91dCBQREYgYXMgYSBtaW1lIHR5cGUgdGhh dCBjYW4gYmUgc2hvd2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL0lkZW50aWZpZXJzRmFjdG9yeS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL0lkZW50aWZpZXJzRmFjdG9yeS5jcHAKaW5kZXggN2UxNDViZTNlZDEwYWYxNTRkYjU2ZTBi NDBmZmZhZmIwMzFkN2EwNS4uOTVjZDg3YjAxYjE1Y2I4NjY3ZTU3YmM1YmI1MWE3MWYwNmJjMzc2 MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JZGVudGlmaWVy c0ZhY3RvcnkuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSWRlbnRp ZmllcnNGYWN0b3J5LmNwcApAQCAtMSw2ICsxLDYgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIw MTQgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgotICogQ29weXJpZ2h0IChDKSAyMDEx IEdvb2dsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE0 LTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAy MDExIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRp b24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAg KiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5n IGNvbmRpdGlvbnMKQEAgLTI3LDM2ICsyNywyNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2lu Y2x1ZGUgIklkZW50aWZpZXJzRmFjdG9yeS5oIgogCi0jaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5n QnVpbGRlci5oPgotCiBuYW1lc3BhY2UgSW5zcGVjdG9yIHsKIAogbmFtZXNwYWNlIHsKIHN0YXRp YyBsb25nIHNfbGFzdFVzZWRJZGVudGlmaWVyID0gMDsKIH0KIAotbG9uZyBJZGVudGlmaWVyc0Zh Y3Rvcnk6OnNfcHJvY2Vzc0lkID0gMDsKK3N0YXRpYyBTdHJpbmcgYWRkUHJlZml4VG9JZGVudGlm aWVyKGNvbnN0IFN0cmluZyYgaWRlbnRpZmllcikKK3sKKyAgICByZXR1cm4gbWFrZVN0cmluZygi MC4iLCBpZGVudGlmaWVyKTsKK30KIAogU3RyaW5nIElkZW50aWZpZXJzRmFjdG9yeTo6Y3JlYXRl SWRlbnRpZmllcigpCiB7Ci0gICAgcmV0dXJuIGFkZFByb2Nlc3NJZFByZWZpeFRvKFN0cmluZzo6 bnVtYmVyKCsrc19sYXN0VXNlZElkZW50aWZpZXIpKTsKKyAgICByZXR1cm4gYWRkUHJlZml4VG9J ZGVudGlmaWVyKFN0cmluZzo6bnVtYmVyKCsrc19sYXN0VXNlZElkZW50aWZpZXIpKTsKIH0KIAog U3RyaW5nIElkZW50aWZpZXJzRmFjdG9yeTo6cmVxdWVzdElkKHVuc2lnbmVkIGxvbmcgaWRlbnRp ZmllcikKIHsKICAgICBpZiAoaWRlbnRpZmllcikKLSAgICAgICAgcmV0dXJuIGFkZFByb2Nlc3NJ ZFByZWZpeFRvKFN0cmluZzo6bnVtYmVyKGlkZW50aWZpZXIpKTsKKyAgICAgICAgcmV0dXJuIGFk ZFByZWZpeFRvSWRlbnRpZmllcihTdHJpbmc6Om51bWJlcihpZGVudGlmaWVyKSk7CiAgICAgcmV0 dXJuIFN0cmluZygpOwogfQogCi1TdHJpbmcgSWRlbnRpZmllcnNGYWN0b3J5OjphZGRQcm9jZXNz SWRQcmVmaXhUbyhjb25zdCBTdHJpbmcmIGlkKQotewotICAgIFN0cmluZ0J1aWxkZXIgYnVpbGRl cjsKLSAgICBidWlsZGVyLmFwcGVuZE51bWJlcihzX3Byb2Nlc3NJZCk7Ci0gICAgYnVpbGRlci5h cHBlbmQoJy4nKTsKLSAgICBidWlsZGVyLmFwcGVuZChpZCk7Ci0gICAgcmV0dXJuIGJ1aWxkZXIu dG9TdHJpbmcoKTsKLX0KLQogfSAvLyBuYW1lc3BhY2UgSW5zcGVjdG9yCi0KZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSWRlbnRpZmllcnNGYWN0b3J5LmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0lkZW50aWZpZXJzRmFjdG9yeS5oCmluZGV4 IDNhM2I3NWFiOWVlMDU0MjRiMjIwMjFmZTI4MGQ2NDdmNzQ4MjVlZDIuLmViMjVhZWRlZTRjZDll YmUwMDdlMDZjMjUxNWIzN2VlMDk1YjA2ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnNwZWN0b3IvSWRlbnRpZmllcnNGYWN0b3J5LmgKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9JZGVudGlmaWVyc0ZhY3RvcnkuaApAQCAtMzEsMTQgKzMxLDggQEAg bmFtZXNwYWNlIEluc3BlY3RvciB7CiAKIGNsYXNzIEpTX0VYUE9SVF9QUklWQVRFIElkZW50aWZp ZXJzRmFjdG9yeSB7CiBwdWJsaWM6Ci0gICAgc3RhdGljIHZvaWQgc2V0UHJvY2Vzc0lkKGxvbmcg cHJvY2Vzc0lkKSB7IHNfcHJvY2Vzc0lkID0gcHJvY2Vzc0lkOyB9CiAgICAgc3RhdGljIFN0cmlu ZyBjcmVhdGVJZGVudGlmaWVyKCk7CiAgICAgc3RhdGljIFN0cmluZyByZXF1ZXN0SWQodW5zaWdu ZWQgbG9uZyBpZGVudGlmaWVyKTsKLQotcHJpdmF0ZToKLSAgICBzdGF0aWMgU3RyaW5nIGFkZFBy b2Nlc3NJZFByZWZpeFRvKGNvbnN0IFN0cmluZyYgaWQpOwotCi0gICAgc3RhdGljIGxvbmcgc19w cm9jZXNzSWQ7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBJbnNwZWN0b3IKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCAxYzNhMDMzOTgx NGEyYTc5M2Y5OGU1NDRkYWQ5MmU3ODY3YmNjODBjLi5lOWVhMWM1ZmZjYjI3MzYzMjUwODI4N2Q4 NTdlNDJmYmE1YjU0MWMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvckNvbnRyb2xsZXIuY3BwCkBAIC0zNTYsMTEgKzM1Niw2IEBAIHZvaWQgSW5zcGVjdG9yQ29u dHJvbGxlcjo6c2hvdygpCiAgICAgICAgIGNvbm5lY3RGcm9udGVuZChmcm9udGVuZENoYW5uZWwp OwogfQogCi12b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnNldFByb2Nlc3NJZChsb25nIHByb2Nl c3NJZCkKLXsKLSAgICBJZGVudGlmaWVyc0ZhY3Rvcnk6OnNldFByb2Nlc3NJZChwcm9jZXNzSWQp OwotfQotCiB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnNldElzVW5kZXJUZXN0KGJvb2wgdmFs dWUpCiB7CiAgICAgaWYgKHZhbHVlID09IG1faXNVbmRlclRlc3QpCg==