184834 2018-04-20 12:09:49 -0700 Layout Test accessibility/mac/async-increment-decrement-action.html is flaky 2018-04-20 14:02:57 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=184742 InRadar P2 Normal --- 1 n_wang webkit-unassigned aboxhall apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1416363 0 n_wang 2018-04-20 12:09:49 -0700 The following layout test is flaky on macOS Debug accessibility/mac/async-increment-decrement-action.html Probable cause: [insert probable cause] Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Fasync-increment-decrement-action.html 1416365 1 webkit-bug-importer 2018-04-20 12:10:06 -0700 <rdar://problem/39604753> 1416368 2 338451 n_wang 2018-04-20 12:14:58 -0700 Created attachment 338451 patch fix the test 1416371 3 338451 cfleizach 2018-04-20 12:19:08 -0700 Comment on attachment 338451 patch this seems a bit flaky. is there a better way? 1416372 4 n_wang 2018-04-20 12:22:54 -0700 (In reply to chris fleizach from comment #3) > Comment on attachment 338451 [details] > patch > > this seems a bit flaky. is there a better way? Not easy way since there's no callback from the actions. Or we can just test that these actions are async now and return early with the non changed result without timing out. 1416373 5 cfleizach 2018-04-20 12:27:49 -0700 (In reply to Nan Wang from comment #4) > (In reply to chris fleizach from comment #3) > > Comment on attachment 338451 [details] > > patch > > > > this seems a bit flaky. is there a better way? > > Not easy way since there's no callback from the actions. Or we can just test > that these actions are async now and return early with the non changed > result without timing out. that seems reasonable 1416376 6 338452 n_wang 2018-04-20 12:42:17 -0700 Created attachment 338452 patch updated the test 1416378 7 338452 cfleizach 2018-04-20 12:44:21 -0700 Comment on attachment 338452 patch looks ok, just add a comment why value isn't changing and how that verifies it's async 1416379 8 n_wang 2018-04-20 12:45:39 -0700 (In reply to chris fleizach from comment #7) > Comment on attachment 338452 [details] > patch > > looks ok, just add a comment why value isn't changing and how that verifies > it's async Ok will do after all the tests are passed 1416408 9 n_wang 2018-04-20 14:02:57 -0700 Committed r230855: <https://trac.webkit.org/changeset/230855> 338451 2018-04-20 12:14:58 -0700 2018-04-20 12:42:17 -0700 patch patch.txt text/plain 1286 n_wang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIzMDg0NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA0LTIwICBOYW4gV2FuZyAgPG5fd2Fu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3QgYWNjZXNzaWJpbGl0eS9tYWMvYXN5 bmMtaW5jcmVtZW50LWRlY3JlbWVudC1hY3Rpb24uaHRtbCBpcyBmbGFreQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0ODM0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zOTYwNDc1Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbmNyZWFzZWQgdGhlIHRpbWVvdXQgc2luY2UgaXQgbWlnaHQgYmUgdG9v IHNob3J0IGZvciBzb21lIG9mIHRoZSBtYWNoaW5lcy4KKworICAgICAgICAqIGFjY2Vzc2liaWxp dHkvbWFjL2FzeW5jLWluY3JlbWVudC1kZWNyZW1lbnQtYWN0aW9uLmh0bWw6CisKIDIwMTgtMDQt MjAgIENocmlzIE5hcmRpICA8Y25hcmRpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBPbWl0IGRl ZmF1bHQgdmFsdWUgd2hlbiBzZXJpYWxpemluZyBmb250LWZlYXR1cmUtc2V0dGluZ3MKSW5kZXg6 IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2FzeW5jLWluY3JlbWVudC1kZWNyZW1lbnQt YWN0aW9uLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMv YXN5bmMtaW5jcmVtZW50LWRlY3JlbWVudC1hY3Rpb24uaHRtbAkocmV2aXNpb24gMjMwODQyKQor KysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvYXN5bmMtaW5jcmVtZW50LWRlY3JlbWVu dC1hY3Rpb24uaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMzMsOCArMzMsOCBAQAogICAgICAgICAg ICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgICBzaG91bGRCZSgib2Jq LmludFZhbHVlIiwgIjI1Iik7CiAgICAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7Ci0gICAg ICAgICAgICB9LCA1KTsKLSAgICAgICAgfSwgNSk7CisgICAgICAgICAgICB9LCAzMCk7CisgICAg ICAgIH0sIDMwKTsKICAgICB9CiAKIDwvc2NyaXB0Pgo= 338452 2018-04-20 12:42:17 -0700 2018-04-20 12:44:21 -0700 patch patch.txt text/plain 2843 n_wang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIzMDg0NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA0LTIwICBOYW4gV2FuZyAgPG5fd2Fu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3QgYWNjZXNzaWJpbGl0eS9tYWMvYXN5 bmMtaW5jcmVtZW50LWRlY3JlbWVudC1hY3Rpb24uaHRtbCBpcyBmbGFreQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg0ODM0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zOTYwNDc1Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDaGFuZ2VkIHRoZSB0ZXN0IHRvIGp1c3QgbWFrZSBzdXJlIHRoZSBpbmNy ZW1lbnQvZGVjcmVtZW50IGFjdGlvbnMgYXJlIGFzeW5jLCB0aGF0CisgICAgICAgIHRoZXkgd29u J3QgYmxvY2sgdGhlIHRlc3QgYnkgY2hhbmdpbmcgdGhlIG9iamVjdCdzIHZhbHVlLgorCisgICAg ICAgICogYWNjZXNzaWJpbGl0eS9tYWMvYXN5bmMtaW5jcmVtZW50LWRlY3JlbWVudC1hY3Rpb24t ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL2FzeW5jLWluY3JlbWVu dC1kZWNyZW1lbnQtYWN0aW9uLmh0bWw6CisKIDIwMTgtMDQtMjAgIENocmlzIE5hcmRpICA8Y25h cmRpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBPbWl0IGRlZmF1bHQgdmFsdWUgd2hlbiBzZXJp YWxpemluZyBmb250LWZlYXR1cmUtc2V0dGluZ3MKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2li aWxpdHkvbWFjL2FzeW5jLWluY3JlbWVudC1kZWNyZW1lbnQtYWN0aW9uLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy9hc3luYy1pbmNyZW1l bnQtZGVjcmVtZW50LWFjdGlvbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDIzMDg0MikKKysrIExh eW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2FzeW5jLWluY3JlbWVudC1kZWNyZW1lbnQtYWN0 aW9uLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtNSwxMCArNSwxMCBAQCBPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBCiAKIAogUEFTUyBvYmouaW50VmFsdWUg aXMgMjUKLVBBU1Mgb2JqLmludFZhbHVlIGlzIDI1Ci1QQVNTIG9iai5pbnRWYWx1ZSBpcyA1MAog UEFTUyBvYmouaW50VmFsdWUgaXMgNTAKIFBBU1Mgb2JqLmludFZhbHVlIGlzIDI1CitQQVNTIG9i ai5pbnRWYWx1ZSBpcyAyNQorUEFTUyBvYmouaW50VmFsdWUgaXMgMjUKIFBBU1Mgc3VjY2Vzc2Z1 bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMvYWNj ZXNzaWJpbGl0eS9tYWMvYXN5bmMtaW5jcmVtZW50LWRlY3JlbWVudC1hY3Rpb24uaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy9hc3luYy1pbmNyZW1lbnQt ZGVjcmVtZW50LWFjdGlvbi5odG1sCShyZXZpc2lvbiAyMzA4NDIpCisrKyBMYXlvdXRUZXN0cy9h Y2Nlc3NpYmlsaXR5L21hYy9hc3luYy1pbmNyZW1lbnQtZGVjcmVtZW50LWFjdGlvbi5odG1sCSh3 b3JraW5nIGNvcHkpCkBAIC0xNSwyNiArMTUsMjIgQEAKICAgICBkZXNjcmlwdGlvbigiVGhpcyB0 ZXN0cyB0aGF0IGluY3JlbWVudCBhbmQgZGVjcmVtZW50IGFjdGlvbnMgYXJlIGFzeW5jLiIpOwog CiAgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgewotICAgICAgICBqc1Rl c3RJc0FzeW5jID0gdHJ1ZTsKIAogICAgICAgICB2YXIgb2JqID0gYWNjZXNzaWJpbGl0eUNvbnRy b2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCJyYW5nZTEiKTsKICAgICAgICAgCiAgICAgICAg IHNob3VsZEJlKCJvYmouaW50VmFsdWUiLCAiMjUiKTsKIAotICAgICAgICBvYmouYXN5bmNJbmNy ZW1lbnQoKTsKKyAgICAgICAgLy8gc3luYyB2ZXJzaW9uCisgICAgICAgIG9iai5pbmNyZW1lbnQo KTsKKyAgICAgICAgc2hvdWxkQmUoIm9iai5pbnRWYWx1ZSIsICI1MCIpOworICAgICAgICBvYmou ZGVjcmVtZW50KCk7CiAgICAgICAgIHNob3VsZEJlKCJvYmouaW50VmFsdWUiLCAiMjUiKTsKIAot ICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewotICAgICAgICAgICAgc2hvdWxkQmUoIm9i ai5pbnRWYWx1ZSIsICI1MCIpOwotCi0gICAgICAgICAgICBvYmouYXN5bmNEZWNyZW1lbnQoKTsK LSAgICAgICAgICAgIHNob3VsZEJlKCJvYmouaW50VmFsdWUiLCAiNTAiKTsKLQotICAgICAgICAg ICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKLSAgICAgICAgICAgICAgICBzaG91bGRCZSgib2Jq LmludFZhbHVlIiwgIjI1Iik7Ci0gICAgICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7Ci0gICAg ICAgICAgICB9LCA1KTsKLSAgICAgICAgfSwgNSk7CisgICAgICAgIC8vIGFzeW5jIHZlcnNpb24K KyAgICAgICAgb2JqLmFzeW5jSW5jcmVtZW50KCk7CisgICAgICAgIHNob3VsZEJlKCJvYmouaW50 VmFsdWUiLCAiMjUiKTsKKyAgICAgICAgb2JqLmFzeW5jRGVjcmVtZW50KCk7CisgICAgICAgIHNo b3VsZEJlKCJvYmouaW50VmFsdWUiLCAiMjUiKTsKICAgICB9CiAKIDwvc2NyaXB0Pgo=