184831 2018-04-20 11:20:48 -0700 Pausing should clear m_waitingToEnterFullscreen 2018-04-30 09:55:27 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue darin jer.noble webkit-bug-importer oldest_to_newest 1416333 0 eric.carlson 2018-04-20 11:20:48 -0700 pause() should clear m_waitingToEnterFullscreen so a subsequent play() will go into fullscreen. 1416334 1 webkit-bug-importer 2018-04-20 11:21:26 -0700 <rdar://problem/39602852> 1416337 2 338443 eric.carlson 2018-04-20 11:33:40 -0700 Created attachment 338443 Patch 1416350 3 338443 commit-queue 2018-04-20 12:01:58 -0700 Comment on attachment 338443 Patch Clearing flags on attachment: 338443 Committed r230846: <https://trac.webkit.org/changeset/230846> 1416351 4 commit-queue 2018-04-20 12:01:59 -0700 All reviewed patches have been landed. Closing bug. 1419013 5 338443 darin 2018-04-30 09:55:27 -0700 Comment on attachment 338443 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338443&action=review > Source/WebCore/html/HTMLMediaElement.cpp:3526 > + if (m_waitingToEnterFullscreen) > + m_waitingToEnterFullscreen = false; The if statement here isn’t needed. We don’t need to check a boolean to see if it’s true before setting it false. 338443 2018-04-20 11:33:40 -0700 2018-04-20 12:01:58 -0700 Patch bug-184831-20180420113339.patch text/plain 1297 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQ2NWI3NmQyNjU1ZDFh NTA4MmRkZDZiMjA1ODJhYzQ0ZDg4Y2ZkNi4uNjZhNDY1NWE5NzE5NzBhOGQ4NmY1MTEyM2ZhNjM3 MzdkNmEyOGI2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA0LTIwICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFBhdXNpbmcgc2hv dWxkIGNsZWFyIG1fd2FpdGluZ1RvRW50ZXJGdWxsc2NyZWVuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ4MzEKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzM5NjAyODUyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhU TUxNZWRpYUVsZW1lbnQ6OnBhdXNlKTogQ2xlYXIgbV93YWl0aW5nVG9FbnRlckZ1bGxzY3JlZW4K KwogMjAxOC0wNC0yMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAg ICAgTWFrZSBQbHVnaW5EYXRhIGNhY2hlIGl0cyB3ZWIgdmlzaWJsZSBwbHVnaW5zCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCA4YWEwZjAzOGMwMjcwMTAzYTA5 MGQ4ZGQ0N2Q5NGE4Njk2ZjU1MWQ0Li44ZTJkNTU0ZTFjN2UwMGYwOGQ4NDY2ODUyMTZiMDhkNWUy MWJhMTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTM1 MjIsNiArMzUyMiw5IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6cGF1c2UoKQogCiAgICAgbV90 ZW1wb3JhcmlseUFsbG93aW5nSW5saW5lUGxheWJhY2tBZnRlckZ1bGxzY3JlZW4gPSBmYWxzZTsK IAorICAgIGlmIChtX3dhaXRpbmdUb0VudGVyRnVsbHNjcmVlbikKKyAgICAgICAgbV93YWl0aW5n VG9FbnRlckZ1bGxzY3JlZW4gPSBmYWxzZTsKKwogICAgIGlmICghbV9tZWRpYVNlc3Npb24tPnBs YXliYWNrUGVybWl0dGVkKCp0aGlzKSkKICAgICAgICAgcmV0dXJuOwogCg==