184826 2018-04-20 10:30:37 -0700 Element fullscreen, expose WKWebView _fullScreenPlaceholderView as iOS SPI 2018-04-20 17:09:34 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue thorton webkit-bug-importer oldest_to_newest 1416300 0 jeremyj-wk 2018-04-20 10:30:37 -0700 Element fullscreen, expose WKWebView _fullScreenPlaceholderView as iOS SPI 1416301 1 jeremyj-wk 2018-04-20 10:31:58 -0700 rdar://problem/39600825 1416305 2 338437 jeremyj-wk 2018-04-20 10:36:35 -0700 Created attachment 338437 Patch 1416429 3 338437 thorton 2018-04-20 14:59:53 -0700 Comment on attachment 338437 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338437&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:410 > +- (UIView *)_fullScreenPlaceholderView WK_API_AVAILABLE(ios(WK_IOS_TBA)); What about Mac? (and then, is this in the wrong place?) 1416432 4 jeremyj-wk 2018-04-20 15:03:18 -0700 (In reply to Tim Horton from comment #3) > Comment on attachment 338437 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338437&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:410 > > +- (UIView *)_fullScreenPlaceholderView WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > What about Mac? (and then, is this in the wrong place?) Already exists for Mac with a different return type. 1416440 5 thorton 2018-04-20 15:10:48 -0700 (In reply to Jeremy Jones from comment #4) > (In reply to Tim Horton from comment #3) > > Comment on attachment 338437 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=338437&action=review > > > > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:410 > > > +- (UIView *)_fullScreenPlaceholderView WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > > > What about Mac? (and then, is this in the wrong place?) > > Already exists for Mac with a different return type. Ah! 1416539 6 338437 commit-queue 2018-04-20 17:09:33 -0700 Comment on attachment 338437 Patch Clearing flags on attachment: 338437 Committed r230868: <https://trac.webkit.org/changeset/230868> 1416540 7 commit-queue 2018-04-20 17:09:34 -0700 All reviewed patches have been landed. Closing bug. 338437 2018-04-20 10:36:35 -0700 2018-04-20 17:09:33 -0700 Patch bug-184826-20180420103635.patch text/plain 5562 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwMjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU4ZjQ5MWExZGNhZjMwMzZk Yjg1ZTI1NDFhZmRhZDdlZGJmNTkxMTEuLjRiZDM5ZmFiODI0Zjk1MzI0YWJjMmYzZWE1NTViZWE0 YWFhYzBmNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMDQtMjAgIEplcmVteSBK b25lcyAgPGplcmVteWpAYXBwbGUuY29tPgorCisgICAgICAgIEVsZW1lbnQgZnVsbHNjcmVlbiwg ZXhwb3NlIFdLV2ViVmlldyBfZnVsbFNjcmVlblBsYWNlaG9sZGVyVmlldyBhcyBpT1MgU1BJCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ4MjYKKyAg ICAgICAgcmRhcjovL3Byb2JsZW0vMzk2MDA4MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgX2Z1bGxTY3JlZW5QbGFjZWhvbGRlclZpZXcgZm9y IGlPUyBzaW1pbGFyIHRvIHRoZSBvbmUgZm9yIE1hYy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgX2Z1bGxTY3JlZW5Q bGFjZWhvbGRlclZpZXddKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IGNsb3NlRnVsbFNjcmVlbldp bmRvd0NvbnRyb2xsZXJdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IGZ1bGxTY3JlZW5QbGFjZWhv bGRlclZpZXddKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlld0ludGVybmFsLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQ cml2YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVl bldpbmRvd0NvbnRyb2xsZXJJT1MuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Z1bGxzY3Jl ZW4vV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKC1bV0tGdWxs U2NyZWVuV2luZG93Q29udHJvbGxlciB3ZWJWaWV3UGxhY2Vob2xkZXJdKToKKwogMjAxOC0wNC0w NCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gUmVuYW1l IFdLUERGVmlldyB0byBXS0xlZ2FjeVBERlZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IDFjY2MwODVmOGI0Nzc0NWM4ODJkZWQzNzc4 ZjAyNzJkOGY3MjlmYzIuLjk5NGZiMDE1OTM3ZWE3MzAyYjAyMWFlYjFlMWYwMzZkNTJmMDViMjYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcu bW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpA QCAtNTgwMSw2ICs1ODAxLDE1IEBAIC0gKHZvaWQpX2FjY2Vzc2liaWxpdHlDbGVhclNlbGVjdGlv bgogICAgIFtfY29udGVudFZpZXcgX2FjY2Vzc2liaWxpdHlDbGVhclNlbGVjdGlvbl07CiB9CiAK Ky0gKFVJVmlldyAqKV9mdWxsU2NyZWVuUGxhY2Vob2xkZXJWaWV3Cit7CisjaWYgRU5BQkxFKEZV TExTQ1JFRU5fQVBJKQorICAgIGlmIChbX2Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGlzRnVs bFNjcmVlbl0pCisgICAgICAgIHJldHVybiBbX2Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIHdl YlZpZXdQbGFjZWhvbGRlcl07CisjZW5kaWYgLy8gRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQorICAg IHJldHVybiBuaWw7Cit9CisKIC0gKENHUmVjdClfY29udGVudFZpc2libGVSZWN0CiB7CiAgICAg cmV0dXJuIFtzZWxmIGNvbnZlcnRSZWN0OltzZWxmIGJvdW5kc10gdG9WaWV3OnNlbGYuX2N1cnJl bnRDb250ZW50Vmlld107CkBAIC02MzU4LDEzICs2MzY3LDYgQEAgLSAodm9pZCljbG9zZUZ1bGxT Y3JlZW5XaW5kb3dDb250cm9sbGVyCiAgICAgX2Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyID0g bnVsbHB0cjsKIH0KIAotLSAoV2ViQ29yZUZ1bGxTY3JlZW5QbGFjZWhvbGRlclZpZXcgKilmdWxs U2NyZWVuUGxhY2Vob2xkZXJWaWV3Ci17Ci0gICAgaWYgKFtfZnVsbFNjcmVlbldpbmRvd0NvbnRy b2xsZXIgaXNGdWxsU2NyZWVuXSkKLSAgICAgICAgcmV0dXJuIFtfZnVsbFNjcmVlbldpbmRvd0Nv bnRyb2xsZXIgd2ViVmlld1BsYWNlaG9sZGVyXTsKLSAgICByZXR1cm4gbmlsOwotfQotCiBAZW5k CiAjZW5kaWYgLy8gRU5BQkxFKEZVTExTQ1JFRU5fQVBJKSAmJiBQTEFURk9STShJT1MpCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdJbnRl cm5hbC5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0ludGVy bmFsLmgKaW5kZXggMDM1ZjNmMDg5NzYyNjhlNzY4NTY5MjJlNDE5NTFlOWVjOGViNDliZC4uYzI5 NDQzOTZhMzQ1M2QzNGVhNDc0N2IzZmVhZDIzOTliOTlkYjIyOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0ludGVybmFsLmgKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0ludGVybmFsLmgKQEAgLTE2 Niw3ICsxNjYsNiBAQCBXS1dlYlZpZXcqIGZyb21XZWJQYWdlUHJveHkoV2ViS2l0OjpXZWJQYWdl UHJveHkmKTsKIC0oQk9PTCloYXNGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcjsKIC0oV0tGdWxs U2NyZWVuV2luZG93Q29udHJvbGxlciAqKWZ1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyOwogLSh2 b2lkKWNsb3NlRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXI7Ci0tKFdlYkNvcmVGdWxsU2NyZWVu UGxhY2Vob2xkZXJWaWV3ICopZnVsbFNjcmVlblBsYWNlaG9sZGVyVmlldzsKIEBlbmQKICNlbmRp ZiAvLyBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpICYmIFBMQVRGT1JNKElPUykKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgKaW5k ZXggZGE4OThjZjEzNGYwMTZjZWVkNjkyOWE5ZDgxOTRhYTk4MDFkOWQ5My4uM2I2MmRlNmI3OTQx ZDJiYTc0ZTA1YzRhNjVhZWZmNDNhODU1YzJkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCkBAIC00MDcsNiArNDA3LDcg QEAgdHlwZWRlZiBOU19PUFRJT05TKE5TVUludGVnZXIsIF9XS1JlY3RFZGdlKSB7CiAtICh2b2lk KV9hY2Nlc3NpYmlsaXR5UmV0cmlldmVSZWN0c0F0U2VsZWN0aW9uT2Zmc2V0OihOU0ludGVnZXIp b2Zmc2V0IHdpdGhUZXh0OihOU1N0cmluZyAqKXRleHQgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQg KF4pKE5TQXJyYXk8TlNWYWx1ZSAqPiAqcmVjdHMpKWNvbXBsZXRpb25IYW5kbGVyIFdLX0FQSV9B VkFJTEFCTEUoaW9zKDExLjMpKTsKIC0gKHZvaWQpX2FjY2Vzc2liaWxpdHlTdG9yZVNlbGVjdGlv biBXS19BUElfQVZBSUxBQkxFKGlvcygxMS4zKSk7CiAtICh2b2lkKV9hY2Nlc3NpYmlsaXR5Q2xl YXJTZWxlY3Rpb24gV0tfQVBJX0FWQUlMQUJMRShpb3MoMTEuMykpOworLSAoVUlWaWV3ICopX2Z1 bGxTY3JlZW5QbGFjZWhvbGRlclZpZXcgV0tfQVBJX0FWQUlMQUJMRShpb3MoV0tfSU9TX1RCQSkp OwogCiAjZWxzZQogLSAodm9pZClfZGlzbWlzc0NvbnRlbnRSZWxhdGl2ZUNoaWxkV2luZG93cyBX S19BUElfQVZBSUxBQkxFKG1hY29zeCgxMC4xMy40KSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVy SU9TLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxTY3Jl ZW5XaW5kb3dDb250cm9sbGVySU9TLmgKaW5kZXggYmJlZjJhMTI4OGJlNmZjZDQ2YTQwYWJhMTcx ZWVkMDgwMzA5M2EzZi4uYjcyN2ZiNWRjMjdlYmE4NDM5NGMxZmFkNjk5YTA3NDExNGU0ZTBkMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxs U2NyZWVuV2luZG93Q29udHJvbGxlcklPUy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXJJT1MuaApAQCAtMjcs MTEgKzI3LDEwIEBACiAKICNpbXBvcnQgPFVJS2l0L1VJVmlld0NvbnRyb2xsZXJUcmFuc2l0aW9u aW5nLmg+CiAKLUBjbGFzcyBXZWJDb3JlRnVsbFNjcmVlblBsYWNlaG9sZGVyVmlldzsKIEBjbGFz cyBXS1dlYlZpZXc7CiAKIEBpbnRlcmZhY2UgV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciA6 IE5TT2JqZWN0IDxVSVZpZXdDb250cm9sbGVyVHJhbnNpdGlvbmluZ0RlbGVnYXRlPgotQHByb3Bl cnR5IChyZWFkb25seSwgcmV0YWluLCBub25hdG9taWMpIFdlYkNvcmVGdWxsU2NyZWVuUGxhY2Vo b2xkZXJWaWV3ICp3ZWJWaWV3UGxhY2Vob2xkZXI7CitAcHJvcGVydHkgKHJlYWRvbmx5LCByZXRh aW4sIG5vbmF0b21pYykgVUlWaWV3ICp3ZWJWaWV3UGxhY2Vob2xkZXI7CiBAcHJvcGVydHkgKHJl YWRvbmx5LCBhc3NpZ24sIG5vbmF0b21pYykgQk9PTCBpc0Z1bGxTY3JlZW47CiAKIC0gKGlkKWlu aXRXaXRoV2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xs ZXJJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxT Y3JlZW5XaW5kb3dDb250cm9sbGVySU9TLm1tCmluZGV4IDIzOWFmMmZlM2Y5MzVhZTA3YzE2Yzg4 ZmQ5NDJhMGViMjJjN2YxODcuLjU5NTc0NWIwN2RhZmFlOTY1NjlmNzRlOTY2N2UyNDlhM2Q4NDE3 ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dL RnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXJJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcklPUy5tbQpA QCAtMzk1LDkgKzM5NSw5IEBAIC0gKEJPT0wpaXNGdWxsU2NyZWVuCiAgICAgICAgIHx8IF9mdWxs U2NyZWVuU3RhdGUgPT0gSW5GdWxsU2NyZWVuOwogfQogCi0tIChXZWJDb3JlRnVsbFNjcmVlblBs YWNlaG9sZGVyVmlldyAqKXdlYlZpZXdQbGFjZWhvbGRlcgorLSAoVUlWaWV3ICopd2ViVmlld1Bs YWNlaG9sZGVyCiB7Ci0gICAgcmV0dXJuIG5pbDsKKyAgICByZXR1cm4gX3dlYlZpZXdQbGFjZWhv bGRlci5nZXQoKTsKIH0KIAogI3ByYWdtYSBtYXJrIC0K