184825 2018-04-20 10:20:29 -0700 [iOS] LayoutTest http/tests/quicklook/hide-referer-on-navigation.html is failing 2018-04-26 14:41:46 -0700 1 1 1 Unclassified WebKit Plug-ins WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu commit-queue ggaren sihui_liu webkit-bug-importer oldest_to_newest 1416297 0 sihui_liu 2018-04-20 10:20:29 -0700 After making policy decisions asynchronous https://bugs.webkit.org/show_bug.cgi?id=180568, this test fails. 1416298 1 sihui_liu 2018-04-20 10:22:32 -0700 <rdar://problem/38924997> 1416302 2 338435 sihui_liu 2018-04-20 10:32:39 -0700 Created attachment 338435 Patch 1416431 3 338435 ggaren 2018-04-20 15:00:36 -0700 Comment on attachment 338435 Patch I think you've got the diagnosis right here. That's great! Let's re-use the "runAsync" flag to specify that we don't want UIHelper.wait() to end the test early, rather than adding the "shouldWait" flag. I think the flags philosophically mean the same thing -- with the exception that re-using "runAsync" requires hide-referer-on-navigation.html to call testRunner.waitUntilDone() itself before it calls runTest(). 1416464 4 338471 sihui_liu 2018-04-20 15:39:00 -0700 Created attachment 338471 Patch 1418232 5 338471 ggaren 2018-04-26 14:14:47 -0700 Comment on attachment 338471 Patch r=me 1418258 6 338471 commit-queue 2018-04-26 14:41:44 -0700 Comment on attachment 338471 Patch Clearing flags on attachment: 338471 Committed r231075: <https://trac.webkit.org/changeset/231075> 1418259 7 commit-queue 2018-04-26 14:41:46 -0700 All reviewed patches have been landed. Closing bug. 338435 2018-04-20 10:32:39 -0700 2018-04-20 15:38:59 -0700 Patch bug-184825-20180420103238.patch text/plain 4344 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODI2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODZmYjZiYjBmZjc1ZGFjNWQ0OTJm M2VhNDJiNWIwYTRiZGE3NGRjMy4uNWFiMDc1N2U3MWI0YjkxNmI0MTc3NDE0ZGQxOTU3MTQ1ZmVj N2VkYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA0LTIwICBTaWh1aSBMaXUgIDxzaWh1 aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIExheW91dFRlc3QgaHR0cC90ZXN0cy9x dWlja2xvb2svaGlkZS1yZWZlcmVyLW9uLW5hdmlnYXRpb24uaHRtbCBpcyBmYWlsaW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ4MjUKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzM4OTI0OTk3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgbW9kaWZpZWQgYmVjYXVzZSBvZiBiZWhhdmlvciBj aGFuZ2U6IHBvbGljeSBkZWNpc2lvbiBpcyBtYWRlIGFzeW5jaHJvbm91cyBub3csIHNvIHdlIAor ICAgICAgICBuZWVkIHRvIHdhaXQgZm9yIHJlcG9uc2UgYmVmb3JlIHJldHVybmluZy4KKworICAg ICAgICAqIGh0dHAvdGVzdHMvcXVpY2tsb29rL2hpZGUtcmVmZXJlci1vbi1uYXZpZ2F0aW9uLmh0 bWw6CisgICAgICAgICogaHR0cC90ZXN0cy9xdWlja2xvb2svcmVzb3VyY2VzL3RhcC1ydW4tdGVz dC1oeXBlcmxpbmsuanM6CisgICAgICAgIChydW5UZXN0KToKKyAgICAgICAgKiBodHRwL3Rlc3Rz L3F1aWNrbG9vay9ydGYtZG9jdW1lbnQtZG9tYWluLWlzLWVtcHR5LXN0cmluZy5odG1sOgorICAg ICAgICAqIGh0dHAvdGVzdHMvcXVpY2tsb29rL3NhbWUtb3JpZ2luLXhtbGh0dHByZXF1ZXN0LWFs bG93ZWQuaHRtbDoKKwogMjAxOC0wNC0xOSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFw cGxlLmNvbT4KIAogICAgICAgICBSdW50aW1lIGxvZ2dpbmcgZHVyaW5nIEdDIGNhbiBjYXVzZSBj cmFzaApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9xdWlja2xvb2svaGlkZS1y ZWZlcmVyLW9uLW5hdmlnYXRpb24uaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcXVpY2ts b29rL2hpZGUtcmVmZXJlci1vbi1uYXZpZ2F0aW9uLmh0bWwKaW5kZXggMTBjM2EwYWNiMzc3NjNj NTQ0NGZkNWE1NDAzY2Y4OWJhMTQ0ZDA2Yy4uODRmZjg1YWExMWRlZjRhMzM4NjM2MjU2ZGNmOWM5 ZWRmMWYzMmVjZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9xdWlja2xvb2sv aGlkZS1yZWZlcmVyLW9uLW5hdmlnYXRpb24uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3F1aWNrbG9vay9oaWRlLXJlZmVyZXItb24tbmF2aWdhdGlvbi5odG1sCkBAIC0xMCw3ICsx MCw3IEBAIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogfQogPC9zY3JpcHQ+CiA8L2hlYWQ+Ci08 Ym9keSBvbmxvYWQ9InJ1blRlc3QoZG9jdW1lbnQucXVlcnlTZWxlY3RvcignaWZyYW1lJykpIj4K Kzxib2R5IG9ubG9hZD0icnVuVGVzdChkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdpZnJhbWUnKSwg dHJ1ZSAvKiBzaG91bGRXYWl0ICovKSI+CiA8cD5UaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCB0aGUg SFRUUCByZWZlcnJlciBpcyBoaWRkZW4gd2hlbiBuYXZpZ2F0aW5nIGZyb20gYSBNaWNyb3NvZnQg V29yZCBRdWlja0xvb2sgcHJldmlldy4gVGhpcyB0ZXN0IFBBU1NFRCBvbmx5IGlmIG5vdGhpbmcg aXMgcHJpbnRlZCBiZWxvdy48L3A+CiAKIDxpZnJhbWUgc3JjPSJyZXNvdXJjZXMvaGlkZS1yZWZl cmVyLW9uLW5hdmlnYXRpb24uZG9jeCI+PC9pZnJhbWU+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3F1aWNrbG9vay9yZXNvdXJjZXMvdGFwLXJ1bi10ZXN0LWh5cGVybGluay5q cyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcXVpY2tsb29rL3Jlc291cmNlcy90YXAtcnVuLXRl c3QtaHlwZXJsaW5rLmpzCmluZGV4IDE5ZjE1MjI5NzVmNGJjNGVkMjUzMGFhMzM3MWE3MWRhMGMx ZjQwMmIuLjFlYzczMTc3NDg1MTYwZWVhNjU3ZGE0MjM5OTNkYzA3NTVjMmRmYjEgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcXVpY2tsb29rL3Jlc291cmNlcy90YXAtcnVuLXRl c3QtaHlwZXJsaW5rLmpzCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcXVpY2tsb29rL3Jl c291cmNlcy90YXAtcnVuLXRlc3QtaHlwZXJsaW5rLmpzCkBAIC0xLDQgKzEsNCBAQAotZnVuY3Rp b24gcnVuVGVzdChmcmFtZSwgb2Zmc2V0SW5GcmFtZSwgcnVuQXN5bmMpCitmdW5jdGlvbiBydW5U ZXN0KGZyYW1lLCBzaG91bGRXYWl0LCBvZmZzZXRJbkZyYW1lLCBydW5Bc3luYykKIHsKICAgICBp ZiAoIXdpbmRvdy50ZXN0UnVubmVyKQogICAgICAgICByZXR1cm47CkBAIC0xMiw1ICsxMiw4IEBA IGZ1bmN0aW9uIHJ1blRlc3QoZnJhbWUsIG9mZnNldEluRnJhbWUsIHJ1bkFzeW5jKQogICAgIGlm IChydW5Bc3luYykKICAgICAgICAgcmV0dXJuIHByb21pc2U7CiAKLSAgICBVSUhlbHBlci53YWl0 KHByb21pc2UpOwotfQorICAgIGlmIChzaG91bGRXYWl0KQorICAgICAgICB0ZXN0UnVubmVyLndh aXRVbnRpbERvbmUoKTsKKyAgICBlbHNlCisgICAgICAgIFVJSGVscGVyLndhaXQocHJvbWlzZSk7 Cit9ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9xdWlja2xvb2svcnRmLWRvY3VtZW50LWRvbWFpbi1pcy1lbXB0eS1zdHJpbmcu aHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcXVpY2tsb29rL3J0Zi1kb2N1bWVudC1kb21h aW4taXMtZW1wdHktc3RyaW5nLmh0bWwKaW5kZXggYzkxYjY0ZGYwMDc5NTYxMDM4ZTEyN2VlZjA2 YzkzMDQ0YjE4MzQ5NS4uNDVhMGE5MmQ4NjNiOWZiNzM4MzhmMGQ0NDE0YTQ0ZGIxMmQwN2Y3ZSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9xdWlja2xvb2svcnRmLWRvY3VtZW50 LWRvbWFpbi1pcy1lbXB0eS1zdHJpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L3F1aWNrbG9vay9ydGYtZG9jdW1lbnQtZG9tYWluLWlzLWVtcHR5LXN0cmluZy5odG1sCkBAIC0x MSw2ICsxMSw2IEBAIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogPC9zY3JpcHQ+CiA8L2hlYWQ+ CiA8Ym9keT4KLTxpZnJhbWUgc3JjPSJyZXNvdXJjZXMvZG9jdW1lbnQtZG9tYWluLWlzLWVtcHR5 LXN0cmluZy5ydGYiIG9ubG9hZD0icnVuVGVzdCh0aGlzLCA4IC8qIG9mZnNldEluRnJhbWUgKi8p Ij48L2lmcmFtZT4KKzxpZnJhbWUgc3JjPSJyZXNvdXJjZXMvZG9jdW1lbnQtZG9tYWluLWlzLWVt cHR5LXN0cmluZy5ydGYiIG9ubG9hZD0icnVuVGVzdCh0aGlzLCBmYWxzZSAvKiBzaG91bGRXYWl0 ICovLCA4IC8qIG9mZnNldEluRnJhbWUgKi8pIj48L2lmcmFtZT4KIDwvYm9keT4KIDwvaHRtbD4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcXVpY2tsb29rL3NhbWUtb3JpZ2lu LXhtbGh0dHByZXF1ZXN0LWFsbG93ZWQuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcXVp Y2tsb29rL3NhbWUtb3JpZ2luLXhtbGh0dHByZXF1ZXN0LWFsbG93ZWQuaHRtbAppbmRleCBkNDQ0 ODFmZDIzOTk2OTA5ZjhiMzEwZWYyZDhiMDQyNjFjNDRkYTdkLi5iMDYyNmI5YmRjNWU0OTkyMDUy OGUxMTAwMDRjM2M4YTJmOTZlYjUwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L3F1aWNrbG9vay9zYW1lLW9yaWdpbi14bWxodHRwcmVxdWVzdC1hbGxvd2VkLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9xdWlja2xvb2svc2FtZS1vcmlnaW4teG1saHR0cHJlcXVl c3QtYWxsb3dlZC5odG1sCkBAIC0xMiw2ICsxMiw2IEBAIGlmICh3aW5kb3cudGVzdFJ1bm5lcikg ewogPC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4KLTxpZnJhbWUgc3JjPSJyZXNvdXJjZXMvc2Ft ZS1vcmlnaW4teG1saHR0cHJlcXVlc3QtYWxsb3dlZC5ydGYiIG9ubG9hZD0icnVuVGVzdCh0aGlz LCA4IC8qIG9mZnNldEluRnJhbWUgKi8sIHRydWUgLyogcnVuQXN5bmMgKi8pIj48L2lmcmFtZT4K KzxpZnJhbWUgc3JjPSJyZXNvdXJjZXMvc2FtZS1vcmlnaW4teG1saHR0cHJlcXVlc3QtYWxsb3dl ZC5ydGYiIG9ubG9hZD0icnVuVGVzdCh0aGlzLCBmYWxzZSAvKiBzaG91bGRXYWl0ICovLCA4IC8q IG9mZnNldEluRnJhbWUgKi8sIHRydWUgLyogcnVuQXN5bmMgKi8pIj48L2lmcmFtZT4KIDwvYm9k eT4KIDwvaHRtbD4K 338471 2018-04-20 15:39:00 -0700 2018-04-26 14:41:44 -0700 Patch bug-184825-20180420153859.patch text/plain 1743 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODYxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmZjZGY1NjRkYWJjZGVlNzU1NDA0 YmIzYTMzMjQyOTFmYWIwMDA1YS4uZjY4YzRjMTA1NmE3ZWIxMDk1ZjU5OWYzMjBkZDJjMGRiZWM2 M2U3MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA0LTIwICBTaWh1aSBMaXUgIDxzaWh1 aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIExheW91dFRlc3QgaHR0cC90ZXN0cy9x dWlja2xvb2svaGlkZS1yZWZlcmVyLW9uLW5hdmlnYXRpb24uaHRtbCBpcyBmYWlsaW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ4MjUKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzM4OTI0OTk3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFBvbGljeSBkZWNpc2lvbnMgYXJlIG1hZGUgYXN5bmNocm9u b3VzbHkgbm93LCBzbyB3ZSBuZWVkIHRvIHNldCB0aGUgYXN5bmMgZmxhZyBvZiB0aGlzIHRlc3Qu IAorCisgICAgICAgICogaHR0cC90ZXN0cy9xdWlja2xvb2svaGlkZS1yZWZlcmVyLW9uLW5hdmln YXRpb24uaHRtbDoKKwogMjAxOC0wNC0yMCAgQ2hyaXMgTmFyZGkgIDxjbmFyZGlAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFVwZGF0ZSBIU0wvSFNMQSBwYXJzaW5nIHRvIG1hdGNoIENTUyBDb2xv ciA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3F1aWNrbG9vay9oaWRlLXJl ZmVyZXItb24tbmF2aWdhdGlvbi5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9xdWlja2xv b2svaGlkZS1yZWZlcmVyLW9uLW5hdmlnYXRpb24uaHRtbAppbmRleCAxMGMzYTBhY2IzNzc2M2M1 NDQ0ZmQ1YTU0MDNjZjg5YmExNDRkMDZjLi41NmFlNjU0NWU1ZDI2NjYzYjhhZWU3ZmQ1MGUyNDIz Mzk3NWYxYmU0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3F1aWNrbG9vay9o aWRlLXJlZmVyZXItb24tbmF2aWdhdGlvbi5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvcXVpY2tsb29rL2hpZGUtcmVmZXJlci1vbi1uYXZpZ2F0aW9uLmh0bWwKQEAgLTcsMTAgKzcs MTEgQEAKIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4 dCgpOwogICAgIHRlc3RSdW5uZXIuZHVtcENoaWxkRnJhbWVzQXNUZXh0KCk7CisgICAgdGVzdFJ1 bm5lci53YWl0VW50aWxEb25lKCk7CiB9CiA8L3NjcmlwdD4KIDwvaGVhZD4KLTxib2R5IG9ubG9h ZD0icnVuVGVzdChkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdpZnJhbWUnKSkiPgorPGJvZHkgb25s b2FkPSJydW5UZXN0KGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2lmcmFtZScpLCB1bmRlZmluZWQs IHRydWUgLyogcnVuQXN5bmMgKi8pIj4KIDxwPlRoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IHRoZSBI VFRQIHJlZmVycmVyIGlzIGhpZGRlbiB3aGVuIG5hdmlnYXRpbmcgZnJvbSBhIE1pY3Jvc29mdCBX b3JkIFF1aWNrTG9vayBwcmV2aWV3LiBUaGlzIHRlc3QgUEFTU0VEIG9ubHkgaWYgbm90aGluZyBp cyBwcmludGVkIGJlbG93LjwvcD4KIAogPGlmcmFtZSBzcmM9InJlc291cmNlcy9oaWRlLXJlZmVy ZXItb24tbmF2aWdhdGlvbi5kb2N4Ij48L2lmcmFtZT4K