184816 2018-04-20 06:26:16 -0700 [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests 2018-04-23 23:34:22 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply ews-watchlist lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1416231 0 cgarcia 2018-04-20 06:26:16 -0700 This is supported for google tests, but not for GLib tests, only the test binary is checked. 1416822 1 338572 cgarcia 2018-04-23 00:10:47 -0700 Created attachment 338572 Patch 1416823 2 ews-watchlist 2018-04-23 00:12:21 -0700 Attachment 338572 did not pass style-queue: ERROR: Tools/glib/glib_test_runner.py:101: missing whitespace after ',' [pep8/E231] [5] ERROR: Tools/glib/api_test_runner.py:150: expected 1 blank line, found 0 [pep8/E301] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1417101 3 cgarcia 2018-04-23 23:33:42 -0700 Committed r230943: <https://trac.webkit.org/changeset/230943> 1417102 4 webkit-bug-importer 2018-04-23 23:34:22 -0700 <rdar://problem/39675026> 338572 2018-04-23 00:10:47 -0700 2018-04-23 07:05:44 -0700 Patch wk-glib-test-timeouts.diff text/plain 4373 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlMjc4 NDUwYzQ2Yi4uY2M1ZWNjNzQxNGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxOC0wNC0yMyAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIE1ha2UgaXQg cG9zc2libGUgdG8gdXNlIGEgZGlmZmVyZW50IHRpbWVvdXQgZm9yIHNsb3cgdGVzdCBjYXNlcyBp biBHTGliIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODQ4MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQYXNzIGEgZnVuY3Rpb24gZnJvbSBhcGkgdGVzdCBydW5uZXIgdG8gZ2xpYiB0ZXN0IHJ1 bm5lciB0byBjaGVjayBpZiBhIHRlc3QgaXMgc2xvdyBhbmQgdXNlIHRoZSBnaXZlbiBzbG93Cisg ICAgICAgIHRpbWVvdXQuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL2dsaWIvVGVzdEV4cGVj dGF0aW9ucy5qc29uOgorICAgICAgICAqIGdsaWIvYXBpX3Rlc3RfcnVubmVyLnB5OgorICAgICAg ICAoVGVzdFJ1bm5lci5fcnVuX3Rlc3RfZ2xpYi5pc19zbG93X3Rlc3QpOgorICAgICAgICAoVGVz dFJ1bm5lci5fcnVuX3Rlc3RfZ2xpYik6CisgICAgICAgICogZ2xpYi9nbGliX3Rlc3RfcnVubmVy LnB5OgorICAgICAgICAoR0xpYlRlc3RSdW5uZXIuX19pbml0X18pOgorICAgICAgICAoR0xpYlRl c3RSdW5uZXIuX3N0b3BfdGltZW91dCk6CisgICAgICAgIChHTGliVGVzdFJ1bm5lci5fc3VidGVz dF9zdGFydCk6CisgICAgICAgIChHTGliVGVzdFJ1bm5lci5fc3VidGVzdF9lbmQpOgorCiAyMDE4 LTA0LTIwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR0xJQl0gRVJST1I6IFRocmVhZCB3YXMgdW5hYmxlIHRvIGJlIGRldGFjaGVkIHdoZW4g cnVubmluZyAvanNjL3ZtIHRlc3QgaW4gZGVidWcKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvZ2xpYi9UZXN0RXhwZWN0YXRpb25zLmpzb24gYi9Ub29scy9UZXN0V2ViS2l0QVBJL2ds aWIvVGVzdEV4cGVjdGF0aW9ucy5qc29uCmluZGV4IDI1OWJkMDVmMzU2Li5mYTY1MDgzODVhYiAx MDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMuanNv bgorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL2dsaWIvVGVzdEV4cGVjdGF0aW9ucy5qc29uCkBA IC0yMzMsNiArMjMzLDEwIEBACiAgICAgICAgIH0KICAgICB9LAogICAgICJUZXN0SlNDIjogewot ICAgICAgICAiZXhwZWN0ZWQiOiB7ImFsbEBEZWJ1ZyI6IHsic2xvdyI6IHRydWV9fQorICAgICAg ICAic3VidGVzdHMiOiB7CisgICAgICAgICAgICAiL2pzYy92bSI6IHsKKyAgICAgICAgICAgICAg ICAiZXhwZWN0ZWQiOiB7ImFsbEBEZWJ1ZyI6IHsic2xvdyI6IHRydWV9fQorICAgICAgICAgICAg fQorICAgICAgICB9CiAgICAgfQogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvZ2xpYi9hcGlfdGVzdF9y dW5uZXIucHkgYi9Ub29scy9nbGliL2FwaV90ZXN0X3J1bm5lci5weQppbmRleCBhZTc0Y2U3OTc2 NS4uNmJkZjQwZTBhYjEgMTAwNzU1Ci0tLSBhL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5 CisrKyBiL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5CkBAIC0xNDcsMTAgKzE0Nyw5IEBA IGNsYXNzIFRlc3RSdW5uZXIob2JqZWN0KToKIAogICAgIGRlZiBfcnVuX3Rlc3RfZ2xpYihzZWxm LCB0ZXN0X3Byb2dyYW0pOgogICAgICAgICB0aW1lb3V0ID0gc2VsZi5fb3B0aW9ucy50aW1lb3V0 Ci0gICAgICAgIHRlc3QgPSBvcy5wYXRoLmpvaW4ob3MucGF0aC5iYXNlbmFtZShvcy5wYXRoLmRp cm5hbWUodGVzdF9wcm9ncmFtKSksIG9zLnBhdGguYmFzZW5hbWUodGVzdF9wcm9ncmFtKSkKLSAg ICAgICAgaWYgc2VsZi5fZXhwZWN0YXRpb25zLmlzX3Nsb3cob3MucGF0aC5iYXNlbmFtZSh0ZXN0 X3Byb2dyYW0pKToKLSAgICAgICAgICAgIHRpbWVvdXQgKj0gMTAKLSAgICAgICAgcmV0dXJuIEdM aWJUZXN0UnVubmVyKHRlc3RfcHJvZ3JhbSwgdGltZW91dCkucnVuKHNraXBwZWQ9c2VsZi5fdGVz dF9jYXNlc190b19za2lwKHRlc3RfcHJvZ3JhbSksIGVudj1zZWxmLl90ZXN0X2VudikKKyAgICAg ICAgZGVmIGlzX3Nsb3dfdGVzdCh0ZXN0LCBzdWJ0ZXN0KToKKyAgICAgICAgICAgIHJldHVybiBz ZWxmLl9leHBlY3RhdGlvbnMuaXNfc2xvdyh0ZXN0LCBzdWJ0ZXN0KQorICAgICAgICByZXR1cm4g R0xpYlRlc3RSdW5uZXIodGVzdF9wcm9ncmFtLCB0aW1lb3V0LCBpc19zbG93X3Rlc3QsIHRpbWVv dXQgKiAxMCkucnVuKHNraXBwZWQ9c2VsZi5fdGVzdF9jYXNlc190b19za2lwKHRlc3RfcHJvZ3Jh bSksIGVudj1zZWxmLl90ZXN0X2VudikKIAogICAgIGRlZiBfZ2V0X3Rlc3RzX2Zyb21fZ29vZ2xl X3Rlc3Rfc3VpdGUoc2VsZiwgdGVzdF9wcm9ncmFtKToKICAgICAgICAgdHJ5OgpkaWZmIC0tZ2l0 IGEvVG9vbHMvZ2xpYi9nbGliX3Rlc3RfcnVubmVyLnB5IGIvVG9vbHMvZ2xpYi9nbGliX3Rlc3Rf cnVubmVyLnB5CmluZGV4IDcxNjQzNTgxNmZiLi4zY2NkZmExMTNkMSAxMDA2NDQKLS0tIGEvVG9v bHMvZ2xpYi9nbGliX3Rlc3RfcnVubmVyLnB5CisrKyBiL1Rvb2xzL2dsaWIvZ2xpYl90ZXN0X3J1 bm5lci5weQpAQCAtOTIsOSArOTIsMTQgQEAgY2xhc3MgTWVzc2FnZShvYmplY3QpOgogCiBjbGFz cyBHTGliVGVzdFJ1bm5lcihvYmplY3QpOgogCi0gICAgZGVmIF9faW5pdF9fKHNlbGYsIHRlc3Rf YmluYXJ5LCB0aW1lb3V0KToKKyAgICBkZWYgX19pbml0X18oc2VsZiwgdGVzdF9iaW5hcnksIHRp bWVvdXQsIGlzX3Nsb3dfZnVuY3Rpb249Tm9uZSwgc2xvd190aW1lb3V0PTApOgogICAgICAgICBz ZWxmLl90ZXN0X2JpbmFyeSA9IHRlc3RfYmluYXJ5CiAgICAgICAgIHNlbGYuX3RpbWVvdXQgPSB0 aW1lb3V0CisgICAgICAgIGlmIGlzX3Nsb3dfZnVuY3Rpb24gaXMgbm90IE5vbmU6CisgICAgICAg ICAgICBzZWxmLl9pc190ZXN0X3Nsb3cgPSBpc19zbG93X2Z1bmN0aW9uCisgICAgICAgIGVsc2U6 CisgICAgICAgICAgICBzZWxmLl9pc190ZXN0X3Nsb3cgPSBsYW1iZGEgeCx5OiBGYWxzZQorICAg ICAgICBzZWxmLl9zbG93X3RpbWVvdXQgPSBzbG93X3RpbWVvdXQKIAogICAgICAgICBzZWxmLl9z dGRlcnJfZmQgPSBOb25lCiAgICAgICAgIHNlbGYuX3N1YnRlc3QgPSBOb25lCkBAIC0xNzQsMTAg KzE3OSw3IEBAIGNsYXNzIEdMaWJUZXN0UnVubmVyKG9iamVjdCk6CiAgICAgICAgIGFsYXJtKHRp bWVvdXQpCiAKICAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIF9zdG9wX3RpbWVvdXQodGltZW91 dCk6Ci0gICAgICAgIGlmIHRpbWVvdXQgPD0gMDoKLSAgICAgICAgICAgIHJldHVybgotCisgICAg ZGVmIF9zdG9wX3RpbWVvdXQoKToKICAgICAgICAgYWxhcm0oMCkKIAogICAgIGRlZiBfc3VidGVz dF9zdGFydChzZWxmLCBzdWJ0ZXN0KToKQEAgLTE4NSw3ICsxODcsMTAgQEAgY2xhc3MgR0xpYlRl c3RSdW5uZXIob2JqZWN0KToKICAgICAgICAgbWVzc2FnZSA9IHNlbGYuX3N1YnRlc3QgKyAnOicK ICAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgnICAlLTY4cycgJSBtZXNzYWdlKQogICAgICAgICBz eXMuc3Rkb3V0LmZsdXNoKCkKLSAgICAgICAgc2VsZi5fc3RhcnRfdGltZW91dChzZWxmLl90aW1l b3V0KQorICAgICAgICB0aW1lb3V0ID0gc2VsZi5fdGltZW91dAorICAgICAgICBpZiBzZWxmLl9p c190ZXN0X3Nsb3cob3MucGF0aC5iYXNlbmFtZShzZWxmLl90ZXN0X2JpbmFyeSksIHNlbGYuX3N1 YnRlc3QpOgorICAgICAgICAgICAgdGltZW91dCA9IHNlbGYuX3Nsb3dfdGltZW91dAorICAgICAg ICBzZWxmLl9zdGFydF90aW1lb3V0KHRpbWVvdXQpCiAKICAgICBkZWYgX3N1YnRlc3RfbWVzc2Fn ZShzZWxmLCBtZXNzYWdlKToKICAgICAgICAgaWYgc2VsZi5fc3VidGVzdCBpcyBOb25lOgpAQCAt MjA2LDcgKzIxMSw3IEBAIGNsYXNzIEdMaWJUZXN0UnVubmVyKG9iamVjdCk6CiAgICAgICAgIHN5 cy5zdGRlcnIuZmx1c2goKQogCiAgICAgZGVmIF9zdWJ0ZXN0X2VuZChzZWxmLCByZXN1bHQsIGRp ZF90aW1lb3V0PUZhbHNlKToKLSAgICAgICAgc2VsZi5fc3RvcF90aW1lb3V0KHNlbGYuX3RpbWVv dXQpCisgICAgICAgIHNlbGYuX3N0b3BfdGltZW91dCgpCiAgICAgICAgIGlmIGRpZF90aW1lb3V0 OgogICAgICAgICAgICAgc2VsZi5fcmVzdWx0c1tzZWxmLl9zdWJ0ZXN0XSA9ICdUSU1FT1VUJwog ICAgICAgICBlbGlmIHJlc3VsdCA9PSBURVNUX1JVTl9TVUNDRVNTOgo=