184799 2018-04-19 15:58:50 -0700 Make WAKScrollView delegate a weak property 2018-04-26 11:22:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 184789 1 ddkilzer ddkilzer aestes commit-queue ews-watchlist simon.fraser thorton webkit-bug-importer oldest_to_newest 1416102 0 ddkilzer 2018-04-19 15:58:50 -0700 Make WAKScrollView delegate a weak property to prevent crashes where the delegate has been released. <rdar://problem/39469669> 1416105 1 338374 ddkilzer 2018-04-19 16:07:36 -0700 Created attachment 338374 Patch v1 1416106 2 ddkilzer 2018-04-19 16:09:52 -0700 ERROR: Source/WebCore/platform/ios/wak/WAKScrollView.mm:65: Should not have spaces around = in property synthesis. [whitespace/property] [4] Should I just delete the _delegate instance variable? 1416107 3 ews-watchlist 2018-04-19 16:10:13 -0700 Attachment 338374 did not pass style-queue: ERROR: Source/WebCore/platform/ios/wak/WAKScrollView.mm:65: Should not have spaces around = in property synthesis. [whitespace/property] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1416112 4 ddkilzer 2018-04-19 16:20:16 -0700 (In reply to Build Bot from comment #3) > Attachment 338374 [details] did not pass style-queue: > > > ERROR: Source/WebCore/platform/ios/wak/WAKScrollView.mm:65: Should not have > spaces around = in property synthesis. [whitespace/property] [4] > Total errors found: 1 in 3 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Ha! Even better reason to remove it (build failure on iOS Simulator): In file included from ./platform/ios/wak/WAKScrollView.mm:27: ./platform/ios/wak/WAKScrollView.h:41:8: error: existing instance variable '_delegate' for __weak property 'delegate' must be __weak id _delegate; ^ ./platform/ios/wak/WAKScrollView.h:60:32: note: property declared here @property (nonatomic, weak) id delegate; ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/DerivedSources/WebCore/unified-sources/UnifiedSource45-mm.mm:1: ./platform/ios/wak/WAKScrollView.mm:65:13: note: property synthesized here @synthesize delegate = _delegate; ^ 1 error generated. 1416116 5 338378 ddkilzer 2018-04-19 16:29:07 -0700 Created attachment 338378 Patch v2 1416118 6 338378 simon.fraser 2018-04-19 16:31:39 -0700 Comment on attachment 338378 Patch v2 This patch is effectively a no-op. 'weak' just means non-retained, which is what the old code was doing. 1416120 7 simon.fraser 2018-04-19 16:34:24 -0700 Maybe you're right: https://developer.apple.com/library/content/releasenotes/ObjectiveC/RN-TransitioningToARC/Introduction/Introduction.html "A weak reference does not extend the lifetime of the object it points to, and automatically becomes nil when there are no strong references to the object." Have you tested this? 1418105 8 338887 ddkilzer 2018-04-26 10:19:11 -0700 Created attachment 338887 Source for testing objc-arc and objc-weak 1418110 9 ddkilzer 2018-04-26 10:23:40 -0700 (In reply to Simon Fraser (smfr) from comment #7) > Maybe you're right: > https://developer.apple.com/library/content/releasenotes/ObjectiveC/RN- > TransitioningToARC/Introduction/Introduction.html > "A weak reference does not extend the lifetime of the object it points to, > and automatically becomes nil when there are no strong references to the > object." > > Have you tested this? Using Attachment #338887: With ARC: $ clang -fobjc-arc -x objective-c -o weak-smfr-arc -framework Foundation weak-smfr.m $ ./weak-smfr-arc 2018-04-26 10:17:42.295 weak-smfr-arc[97821:14281815] Before release: 0x7f916d40cb20 2018-04-26 10:17:42.295 weak-smfr-arc[97821:14281815] After release: 0x0 With MRR: $ clang -x objective-c -o weak-smfr-mrr -framework Foundation weak-smfr.m $ ./weak-smfr-mrr 2018-04-26 10:20:25.478 weak-smfr-mrr[97834:14292493] Before release: 0x7f88f2e06b00 2018-04-26 10:20:25.479 weak-smfr-mrr[97834:14292493] After release: 0x7f88f2e06b00 With MRR + WEAK: $ clang -fobjc-weak -x objective-c -o weak-smfr-weak -framework Foundation weak-smfr.m $ ./weak-smfr-weak 2018-04-26 10:20:38.310 weak-smfr-weak[97838:14293436] Before release: 0x7ff2eef04bd0 2018-04-26 10:20:38.310 weak-smfr-weak[97838:14293436] After release: 0x0 So, yes, this feature works as it was designed. :) 1418116 10 338889 ddkilzer 2018-04-26 10:34:00 -0700 Created attachment 338889 Patch v3 (fixed ChangeLog typo from v2) 1418156 11 338889 commit-queue 2018-04-26 11:22:08 -0700 Comment on attachment 338889 Patch v3 (fixed ChangeLog typo from v2) Clearing flags on attachment: 338889 Committed r231058: <https://trac.webkit.org/changeset/231058> 1418157 12 commit-queue 2018-04-26 11:22:09 -0700 All reviewed patches have been landed. Closing bug. 338374 2018-04-19 16:07:36 -0700 2018-04-19 16:29:06 -0700 Patch v1 bug-184799-20180419160736.patch text/plain 3126 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThjYzVhZjNiNjIwYjk5 MzhhZjE4MTY3Y2Q2ZTA1MzBlZGRkZTVhNy4uMTljOTc0MDc1OTdjYTQwMGFiNGMwYmY2ZWUzNTRi MGIxOTQyZGU5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA0LTE5ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBXQUtTY3JvbGxW aWV3IGRlbGVnYXRlIGEgd2VhayBwcm9wZXJ0eQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3Jn L2IvMTg0Nzk5PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzk0Njk2Njk+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvd2Fr L1dBS1Njcm9sbFZpZXcuaDoKKyAgICAgICAgLSBEZWNsYXJlIGBkZWxlZ2F0ZWAgcHJvcGVydHkg YXMgd2Vhay4KKyAgICAgICAgKC1bV0FLU2Nyb2xsVmlldyBzZXREZWxlZ2F0ZTpdKTogRGVsZXRl IGRlY2xhcmF0aW9uLgorICAgICAgICAoLVtXQUtTY3JvbGxWaWV3IGRlbGVnYXRlXSk6IERpdHRv LgorICAgICAgICAqIHBsYXRmb3JtL2lvcy93YWsvV0FLU2Nyb2xsVmlldy5tbToKKyAgICAgICAg LSBTeW50aGVzaXplIGdldHRlci9zZXR0ZXIgbWV0aG9kcyBmb3IgYGRlbGVnYXRlYCBwcm9wZXR5 LgorICAgICAgICAoLVtXQUtTY3JvbGxWaWV3IHNldERlbGVnYXRlOl0pOiBEZWxldGUgaW1wbGVt ZW50YXRpb24uCisgICAgICAgICgtW1dBS1Njcm9sbFZpZXcgZGVsZWdhdGVdKTogRGl0dG8uCisK IDIwMTgtMDQtMTkgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBFbmFibGUgT2JqZWN0aXZlLUMgd2VhayByZWZlcmVuY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1Njcm9sbFZpZXcuaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2lvcy93YWsvV0FLU2Nyb2xsVmlldy5oCmluZGV4IGI3NjlhYThkNWE2NGRjYWVi NWQyMjEwNDRlNmY1ZWI5MjQyOTk1ZWIuLjRiZTIyOWU5YmE0MWQ0OTQzOWY5MDQzZjljNjViNDA5 MWZjNDc5YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FL U2Nyb2xsVmlldy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLU2Ny b2xsVmlldy5oCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwNSwgMjAw NiwgMjAwNywgMjAwOCwgMjAwOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBD b3B5cmlnaHQgKEMpIDIwMDUtMjAxOCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAg KgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywg d2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQg dGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTU3LDggKzU3LDcgQEAgV0VCQ09SRV9F WFBPUlQgQGludGVyZmFjZSBXQUtTY3JvbGxWaWV3IDogV0FLVmlldyA8V2ViQ29yZUZyYW1lU2Ny b2xsVmlldz4KIC0gKEJPT0wpZHJhd3NCYWNrZ3JvdW5kOwogLSAoZmxvYXQpaG9yaXpvbnRhbExp bmVTY3JvbGw7CiAKLS0gKHZvaWQpc2V0RGVsZWdhdGU6KGlkKWRlbGVnYXRlOwotLSAoaWQpZGVs ZWdhdGU7CitAcHJvcGVydHkgKG5vbmF0b21pYywgd2VhaykgaWQgZGVsZWdhdGU7CiAKIC0gKENH UmVjdCl1bm9ic2N1cmVkQ29udGVudFJlY3Q7CiAtICh2b2lkKXNldEFjdHVhbFNjcm9sbFBvc2l0 aW9uOihDR1BvaW50KXBvaW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW9zL3dhay9XQUtTY3JvbGxWaWV3Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dh ay9XQUtTY3JvbGxWaWV3Lm1tCmluZGV4IDc4ZTYxMzI1ODI5NjYwMzRjMmNhMTZjOWE2NmJjMTQ5 MjY1NDZkOTIuLmFmOTYwMjk0NDAxNTk3MDkwZDhiODk2ZGMyNDU3ZjkxZGRjMWZlYWMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLU2Nyb2xsVmlldy5tbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1Njcm9sbFZpZXcubW0KQEAg LTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA1LCAyMDA2LCAyMDA3LCAyMDA4 LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykg MjAwNS0yMDE4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3Ry aWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhv dXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xs b3dpbmcgY29uZGl0aW9ucwpAQCAtNjIsNiArNjIsOCBAQCBzdGF0aWMgdm9pZCBfbm90aWZpY2F0 aW9uQ2FsbGJhY2soV0tWaWV3UmVmIHYsIFdLVmlld05vdGlmaWNhdGlvblR5cGUgdHlwZSwgdm9p ZAogCiBAaW1wbGVtZW50YXRpb24gV0FLU2Nyb2xsVmlldwogCitAc3ludGhlc2l6ZSBkZWxlZ2F0 ZSA9IF9kZWxlZ2F0ZTsKKwogLSAoaWQpaW5pdFdpdGhGcmFtZTooQ0dSZWN0KXJlY3QKIHsKICAg ICBXS1ZpZXdSZWYgdmlldyA9IFdLVmlld0NyZWF0ZVdpdGhGcmFtZShyZWN0LCAmdmlld0NvbnRl eHQpOwpAQCAtMTE0LDE2ICsxMTYsNiBAQCAtIChCT09MKWhhc0hvcml6b250YWxTY3JvbGxlcgog ICAgIHJldHVybiBOTzsKIH0KIAotLSAodm9pZClzZXREZWxlZ2F0ZTooaWQpZGVsZWdhdGUKLXsK LSAgICBfZGVsZWdhdGUgPSBkZWxlZ2F0ZTsKLX0KLQotLSAoaWQpZGVsZWdhdGUKLXsKLSAgICBy ZXR1cm4gX2RlbGVnYXRlOwotfQotCiAtIChDR1JlY3QpZG9jdW1lbnRWaXNpYmxlUmVjdCAKIHsK ICAgICByZXR1cm4gW19jb250ZW50VmlldyBkb2N1bWVudFZpc2libGVSZWN0XTsK 338378 2018-04-19 16:29:07 -0700 2018-04-26 10:33:59 -0700 Patch v2 bug-184799-20180419162906.patch text/plain 3432 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThjYzVhZjNiNjIwYjk5 MzhhZjE4MTY3Y2Q2ZTA1MzBlZGRkZTVhNy4uNDlkZjRlNzYxZjZjNjc4NjgxNzcwMWE2ODM0MzY2 M2UxY2E4ZTE3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA0LTE5ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBXQUtTY3JvbGxW aWV3IGRlbGVnYXRlIGEgd2VhayBwcm9wZXJ0eQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3Jn L2IvMTg0Nzk5PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzk0Njk2Njk+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvd2Fr L1dBS1Njcm9sbFZpZXcuaDoKKyAgICAgICAgLSBSZW1vdmUgYGRlbGVnYXRlYCBpbnN0YW5jZSB2 YXJpYWJsZSBkZWNsYXJhdGlvbi4KKyAgICAgICAgLSBEZWNsYXJlIGBkZWxlZ2F0ZWAgcHJvcGVy dHkgYXMgd2Vhay4KKyAgICAgICAgKC1bV0FLU2Nyb2xsVmlldyBzZXREZWxlZ2F0ZTpdKTogRGVs ZXRlIGRlY2xhcmF0aW9uLgorICAgICAgICAoLVtXQUtTY3JvbGxWaWV3IGRlbGVnYXRlXSk6IERp dHRvLgorICAgICAgICAqIHBsYXRmb3JtL2lvcy93YWsvV0FLU2Nyb2xsVmlldy5tbToKKyAgICAg ICAgLSBTeW50aGVzaXplIGdldHRlci9zZXR0ZXIgbWV0aG9kcyBmb3IgYGRlbGVnYXRlYCBwcm9w ZXR5LgorICAgICAgICAoLVtXQUtTY3JvbGxWaWV3IHNldERlbGVnYXRlOl0pOiBEZWxldGUgaW1w bGVtZW50YXRpb24uCisgICAgICAgICgtW1dBS1Njcm9sbFZpZXcgZGVsZWdhdGVdKTogRGl0dG8u CisKIDIwMTgtMDQtMTkgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBFbmFibGUgT2JqZWN0aXZlLUMgd2VhayByZWZlcmVuY2VzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1Njcm9sbFZpZXcuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLU2Nyb2xsVmlldy5oCmluZGV4IGI3NjlhYThkNWE2NGRj YWViNWQyMjEwNDRlNmY1ZWI5MjQyOTk1ZWIuLjU4NmRjODdiZmJlZmI5NmIwZjgzOGJjMDY1ZmFj OTYxZTAzY2U0MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsv V0FLU2Nyb2xsVmlldy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FL U2Nyb2xsVmlldy5oCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwNSwg MjAwNiwgMjAwNywgMjAwOCwgMjAwOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisg KiBDb3B5cmlnaHQgKEMpIDIwMDUtMjAxOCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlk ZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTM4LDcgKzM4LDYgQEAgV0VCQ09S RV9FWFBPUlQgQGludGVyZmFjZSBXQUtTY3JvbGxWaWV3IDogV0FLVmlldyA8V2ViQ29yZUZyYW1l U2Nyb2xsVmlldz4KIHsKICAgICBXQUtWaWV3ICpfZG9jdW1lbnRWaWV3OyAgLy8gT25seSBoZXJl IHNvIHRoZSBPYmpDIGluc3RhbmNlIHN0YXlzIGFyb3VuZC4KICAgICBXQUtDbGlwVmlldyAqX2Nv bnRlbnRWaWV3OwotICAgIGlkIF9kZWxlZ2F0ZTsKICAgICBOU1BvaW50IF9zY3JvbGxPcmlnaW47 CiB9CiAKQEAgLTU3LDggKzU2LDcgQEAgV0VCQ09SRV9FWFBPUlQgQGludGVyZmFjZSBXQUtTY3Jv bGxWaWV3IDogV0FLVmlldyA8V2ViQ29yZUZyYW1lU2Nyb2xsVmlldz4KIC0gKEJPT0wpZHJhd3NC YWNrZ3JvdW5kOwogLSAoZmxvYXQpaG9yaXpvbnRhbExpbmVTY3JvbGw7CiAKLS0gKHZvaWQpc2V0 RGVsZWdhdGU6KGlkKWRlbGVnYXRlOwotLSAoaWQpZGVsZWdhdGU7CitAcHJvcGVydHkgKG5vbmF0 b21pYywgd2VhaykgaWQgZGVsZWdhdGU7CiAKIC0gKENHUmVjdCl1bm9ic2N1cmVkQ29udGVudFJl Y3Q7CiAtICh2b2lkKXNldEFjdHVhbFNjcm9sbFBvc2l0aW9uOihDR1BvaW50KXBvaW50OwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtTY3JvbGxWaWV3Lm1t IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtTY3JvbGxWaWV3Lm1tCmluZGV4 IDc4ZTYxMzI1ODI5NjYwMzRjMmNhMTZjOWE2NmJjMTQ5MjY1NDZkOTIuLjU5ODMyMmJhNjQ2MDE2 NTc0MTk3ZDFjYTRlMGZjM2I3Y2E1MzNhMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2lvcy93YWsvV0FLU2Nyb2xsVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3Mvd2FrL1dBS1Njcm9sbFZpZXcubW0KQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29w eXJpZ2h0IChDKSAyMDA1LCAyMDA2LCAyMDA3LCAyMDA4LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwNS0yMDE4IEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJj ZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJl IHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNjIs NiArNjIsOCBAQCBzdGF0aWMgdm9pZCBfbm90aWZpY2F0aW9uQ2FsbGJhY2soV0tWaWV3UmVmIHYs IFdLVmlld05vdGlmaWNhdGlvblR5cGUgdHlwZSwgdm9pZAogCiBAaW1wbGVtZW50YXRpb24gV0FL U2Nyb2xsVmlldwogCitAc3ludGhlc2l6ZSBkZWxlZ2F0ZTsKKwogLSAoaWQpaW5pdFdpdGhGcmFt ZTooQ0dSZWN0KXJlY3QKIHsKICAgICBXS1ZpZXdSZWYgdmlldyA9IFdLVmlld0NyZWF0ZVdpdGhG cmFtZShyZWN0LCAmdmlld0NvbnRleHQpOwpAQCAtMTE0LDE2ICsxMTYsNiBAQCAtIChCT09MKWhh c0hvcml6b250YWxTY3JvbGxlcgogICAgIHJldHVybiBOTzsKIH0KIAotLSAodm9pZClzZXREZWxl Z2F0ZTooaWQpZGVsZWdhdGUKLXsKLSAgICBfZGVsZWdhdGUgPSBkZWxlZ2F0ZTsKLX0KLQotLSAo aWQpZGVsZWdhdGUKLXsKLSAgICByZXR1cm4gX2RlbGVnYXRlOwotfQotCiAtIChDR1JlY3QpZG9j dW1lbnRWaXNpYmxlUmVjdCAKIHsKICAgICByZXR1cm4gW19jb250ZW50VmlldyBkb2N1bWVudFZp c2libGVSZWN0XTsK 338887 2018-04-26 10:19:11 -0700 2018-04-26 10:19:11 -0700 Source for testing objc-arc and objc-weak weak-smfr.m text/x-csrc 622 ddkilzer I2luY2x1ZGUgPEZvdW5kYXRpb24vRm91bmRhdGlvbi5oPgoKQGludGVyZmFjZSBXZWFrIDogTlNP YmplY3QKewojaWYgIV9faGFzX2ZlYXR1cmUob2JqY19hcmNfd2VhaykKICAgIE5TU3RyaW5nICpf cHJvcDsKI2VuZGlmCn0KQHByb3BlcnR5ICh3ZWFrLCBub25hdG9taWMpIE5TU3RyaW5nICpwcm9w OwpAZW5kCgpAaW1wbGVtZW50YXRpb24gV2VhawojaWYgIV9faGFzX2ZlYXR1cmUob2JqY19hcmNf d2VhaykKQHN5bnRoZXNpemUgcHJvcCA9IF9wcm9wOwojZW5kaWYKQGVuZAoKaW50IG1haW4oaW50 IGFyZ2MsIGNoYXIqKiBhcmd2KQp7CiAgICBXZWFrICpvYmplY3QgPSBbW1dlYWsgYWxsb2NdIGlu aXRdOwogICAgQGF1dG9yZWxlYXNlcG9vbCB7CiAgICAgICAgTlNTdHJpbmcgKnN0cmluZyA9IFtO U1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAiQXJndW1lbnRzOiAlZFxuIiwgYXJnY107CiAgICAg ICAgb2JqZWN0LnByb3AgPSBzdHJpbmc7CiAgICAgICAgTlNMb2coQCJCZWZvcmUgcmVsZWFzZTog JXAiLCBvYmplY3QucHJvcCk7CiAgICAgICAgc3RyaW5nID0gbmlsOwogICAgfQogICAgTlNMb2co QCJBZnRlciByZWxlYXNlOiAlcCIsIG9iamVjdC5wcm9wKTsKICAgIHJldHVybiAwOwp9Cg== 338889 2018-04-26 10:34:00 -0700 2018-04-26 11:22:08 -0700 Patch v3 (fixed ChangeLog typo from v2) bug-184799-20180426103359.patch text/plain 3433 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThjYzVhZjNiNjIwYjk5 MzhhZjE4MTY3Y2Q2ZTA1MzBlZGRkZTVhNy4uOTA2YjI4M2Q0YWJiOWVlNWExY2IzNDZlZGFlYzgz OTMyZThjNDQzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA0LTI2ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBXQUtTY3JvbGxW aWV3IGRlbGVnYXRlIGEgd2VhayBwcm9wZXJ0eQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3Jn L2IvMTg0Nzk5PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzk0Njk2Njk+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvd2Fr L1dBS1Njcm9sbFZpZXcuaDoKKyAgICAgICAgLSBSZW1vdmUgYGRlbGVnYXRlYCBpbnN0YW5jZSB2 YXJpYWJsZSBkZWNsYXJhdGlvbi4KKyAgICAgICAgLSBEZWNsYXJlIGBkZWxlZ2F0ZWAgcHJvcGVy dHkgYXMgd2Vhay4KKyAgICAgICAgKC1bV0FLU2Nyb2xsVmlldyBzZXREZWxlZ2F0ZTpdKTogRGVs ZXRlIGRlY2xhcmF0aW9uLgorICAgICAgICAoLVtXQUtTY3JvbGxWaWV3IGRlbGVnYXRlXSk6IERp dHRvLgorICAgICAgICAqIHBsYXRmb3JtL2lvcy93YWsvV0FLU2Nyb2xsVmlldy5tbToKKyAgICAg ICAgLSBTeW50aGVzaXplIGdldHRlci9zZXR0ZXIgbWV0aG9kcyBmb3IgYGRlbGVnYXRlYCBwcm9w ZXJ0eS4KKyAgICAgICAgKC1bV0FLU2Nyb2xsVmlldyBzZXREZWxlZ2F0ZTpdKTogRGVsZXRlIGlt cGxlbWVudGF0aW9uLgorICAgICAgICAoLVtXQUtTY3JvbGxWaWV3IGRlbGVnYXRlXSk6IERpdHRv LgorCiAyMDE4LTA0LTE5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAg ICAgICAgRW5hYmxlIE9iamVjdGl2ZS1DIHdlYWsgcmVmZXJlbmNlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtTY3JvbGxWaWV3LmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1Njcm9sbFZpZXcuaAppbmRleCBiNzY5YWE4ZDVhNjRk Y2FlYjVkMjIxMDQ0ZTZmNWViOTI0Mjk5NWViLi41ODZkYzg3YmZiZWZiOTZiMGY4MzhiYzA2NWZh Yzk2MWUwM2NlNDBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2Fr L1dBS1Njcm9sbFZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dB S1Njcm9sbFZpZXcuaApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDUs IDIwMDYsIDIwMDcsIDIwMDgsIDIwMDkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgor ICogQ29weXJpZ2h0IChDKSAyMDA1LTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0zOCw3ICszOCw2IEBAIFdFQkNP UkVfRVhQT1JUIEBpbnRlcmZhY2UgV0FLU2Nyb2xsVmlldyA6IFdBS1ZpZXcgPFdlYkNvcmVGcmFt ZVNjcm9sbFZpZXc+CiB7CiAgICAgV0FLVmlldyAqX2RvY3VtZW50VmlldzsgIC8vIE9ubHkgaGVy ZSBzbyB0aGUgT2JqQyBpbnN0YW5jZSBzdGF5cyBhcm91bmQuCiAgICAgV0FLQ2xpcFZpZXcgKl9j b250ZW50VmlldzsKLSAgICBpZCBfZGVsZWdhdGU7CiAgICAgTlNQb2ludCBfc2Nyb2xsT3JpZ2lu OwogfQogCkBAIC01Nyw4ICs1Niw3IEBAIFdFQkNPUkVfRVhQT1JUIEBpbnRlcmZhY2UgV0FLU2Ny b2xsVmlldyA6IFdBS1ZpZXcgPFdlYkNvcmVGcmFtZVNjcm9sbFZpZXc+CiAtIChCT09MKWRyYXdz QmFja2dyb3VuZDsKIC0gKGZsb2F0KWhvcml6b250YWxMaW5lU2Nyb2xsOwogCi0tICh2b2lkKXNl dERlbGVnYXRlOihpZClkZWxlZ2F0ZTsKLS0gKGlkKWRlbGVnYXRlOworQHByb3BlcnR5IChub25h dG9taWMsIHdlYWspIGlkIGRlbGVnYXRlOwogCiAtIChDR1JlY3QpdW5vYnNjdXJlZENvbnRlbnRS ZWN0OwogLSAodm9pZClzZXRBY3R1YWxTY3JvbGxQb3NpdGlvbjooQ0dQb2ludClwb2ludDsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLU2Nyb2xsVmlldy5t bSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLU2Nyb2xsVmlldy5tbQppbmRl eCA3OGU2MTMyNTgyOTY2MDM0YzJjYTE2YzlhNjZiYzE0OTI2NTQ2ZDkyLi41OTgzMjJiYTY0NjAx NjU3NDE5N2QxY2E0ZTBmYzNiN2NhNTMzYTAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pb3Mvd2FrL1dBS1Njcm9sbFZpZXcubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vaW9zL3dhay9XQUtTY3JvbGxWaWV3Lm1tCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENv cHlyaWdodCAoQykgMjAwNSwgMjAwNiwgMjAwNywgMjAwOCwgMjAwOSBBcHBsZSBJbmMuIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDUtMjAxOCBBcHBsZSBJbmMuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3Vy Y2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFy ZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTYy LDYgKzYyLDggQEAgc3RhdGljIHZvaWQgX25vdGlmaWNhdGlvbkNhbGxiYWNrKFdLVmlld1JlZiB2 LCBXS1ZpZXdOb3RpZmljYXRpb25UeXBlIHR5cGUsIHZvaWQKIAogQGltcGxlbWVudGF0aW9uIFdB S1Njcm9sbFZpZXcKIAorQHN5bnRoZXNpemUgZGVsZWdhdGU7CisKIC0gKGlkKWluaXRXaXRoRnJh bWU6KENHUmVjdClyZWN0CiB7CiAgICAgV0tWaWV3UmVmIHZpZXcgPSBXS1ZpZXdDcmVhdGVXaXRo RnJhbWUocmVjdCwgJnZpZXdDb250ZXh0KTsKQEAgLTExNCwxNiArMTE2LDYgQEAgLSAoQk9PTClo YXNIb3Jpem9udGFsU2Nyb2xsZXIKICAgICByZXR1cm4gTk87CiB9CiAKLS0gKHZvaWQpc2V0RGVs ZWdhdGU6KGlkKWRlbGVnYXRlCi17Ci0gICAgX2RlbGVnYXRlID0gZGVsZWdhdGU7Ci19Ci0KLS0g KGlkKWRlbGVnYXRlCi17Ci0gICAgcmV0dXJuIF9kZWxlZ2F0ZTsKLX0KLQogLSAoQ0dSZWN0KWRv Y3VtZW50VmlzaWJsZVJlY3QgCiB7CiAgICAgcmV0dXJuIFtfY29udGVudFZpZXcgZG9jdW1lbnRW aXNpYmxlUmVjdF07Cg==