184792 2018-04-19 13:49:22 -0700 Runtime logging during GC can cause crash 2018-04-19 15:21:28 -0700 1 1 1 Unclassified WebKit DOM Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson cdumez commit-queue jer.noble webkit-bug-importer oldest_to_newest 1416045 0 eric.carlson 2018-04-19 13:49:22 -0700 It is illegal to allocate during GC, so Document should create the Inspector ConsoleMessage from a task queue in case an object logs during GC. 1416046 1 eric.carlson 2018-04-19 13:50:00 -0700 <rdar://problem/39567927> 1416056 2 338355 eric.carlson 2018-04-19 14:03:22 -0700 Created attachment 338355 Patch 1416073 3 eric.carlson 2018-04-19 14:54:11 -0700 The GTK build failure is unrelated: Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource217.cpp.o -c /home/ews/ltilve-gtk-wk2-ews/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource217.cpp virtual memory exhausted: Cannot allocate memory 1416074 4 338355 cdumez 2018-04-19 14:56:06 -0700 Comment on attachment 338355 Patch LGTM2 1416087 5 338355 commit-queue 2018-04-19 15:21:27 -0700 Comment on attachment 338355 Patch Clearing flags on attachment: 338355 Committed r230822: <https://trac.webkit.org/changeset/230822> 1416088 6 commit-queue 2018-04-19 15:21:28 -0700 All reviewed patches have been landed. Closing bug. 338355 2018-04-19 14:03:22 -0700 2018-04-19 15:21:27 -0700 Patch bug-184792-20180419140321.patch text/plain 5872 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjcxNTFlZmY5N2UxN2Uy N2U5ZTE4NGQ3YWY4N2FmOTY4M2M0ZGVjNC4uNGI5N2FjMmE0ZTE1MTg5Y2M3N2JiMTM3MDBiYzA2 NGUzOGRjMjI3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA0LTE5ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJ1bnRpbWUgbG9n Z2luZyBkdXJpbmcgR0MgY2FuIGNhdXNlIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODQ3OTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM5 NTY3OTI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRlc3Q6IG1lZGlhL2Rlc3RydWN0b3ItbG9nZ2luZy1jcmFzaC5odG1sCisKKyAgICAgICAgKiBk b20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6On5Eb2N1bWVudCk6 IENsZWFyIHRoZSBsb2dnZXIgb2JzZXJ2ZXIgaW1tZWRpYXRlbHkgc28gYW55dGhpbmcgbG9nZ2Vk CisgICAgICAgIGFzIGEgc2lkZSBlZmZlY3Qgb2YgdGhlIGRlc3RydWN0b3Igd29uJ3QgY2F1c2Ug YSBwcm9ibGVtLgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmRpZExvZ01lc3NhZ2UpOiBD cmVhdGUgdGhlIENvbnNvbGVNZXNzYWdlIGluIGEgdGFzay4KKyAgICAgICAgKiBkb20vRG9jdW1l bnQuaDoKKwogMjAxOC0wNC0xOSAgQ2hyaXMgTmFyZGkgIDxjbmFyZGlAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFN1cHBvcnQgY2FsYygpIGluIHdlYmtpdC1ncmFkaWVudCBhbmQgY3Jvc3MtZmFk ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggYTgxMDBhNGViOTJmYzExODU1NDc4MzMwNmQx NTQzNzYwMGYwZGQwNC4uMzRiYjgzMjRiYTlmY2Q0OWRkY2FkMmYwZDQ2NDg0NGEzMTM5YWUyNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC01NzMsNiArNTczLDkgQEAgUmVmPERvY3VtZW50 PiBEb2N1bWVudDo6Y3JlYXRlKERvY3VtZW50JiBjb250ZXh0RG9jdW1lbnQpCiAKIERvY3VtZW50 Ojp+RG9jdW1lbnQoKQogeworICAgIGlmIChtX2xvZ2dlcikKKyAgICAgICAgbV9sb2dnZXItPnJl bW92ZU9ic2VydmVyKCp0aGlzKTsKKwogICAgIEFTU0VSVChhbGxEb2N1bWVudHNNYXAoKS5jb250 YWlucyhtX2lkZW50aWZpZXIpKTsKICAgICBhbGxEb2N1bWVudHNNYXAoKS5yZW1vdmUobV9pZGVu dGlmaWVyKTsKICAgICAvLyBXZSBuZWVkIHRvIHJlbW92ZSBmcm9tIHRoZSBjb250ZXh0cyBtYXAg dmVyeSBlYXJseSBpbiB0aGUgZGVzdHJ1Y3RvciBzbyB0aGF0IGNhbGxpbmcgcG9zdFRhc2soKSBv biB0aGlzIERvY3VtZW50IGZyb20gYW5vdGhlciB0aHJlYWQgaXMgc2FmZS4KQEAgLTY0Niw5ICs2 NDksNiBAQCBEb2N1bWVudDo6fkRvY3VtZW50KCkKIAogICAgIGZvciAodW5zaWduZWQgY291bnQg OiBtX25vZGVMaXN0QW5kQ29sbGVjdGlvbkNvdW50cykKICAgICAgICAgQVNTRVJUX1VOVVNFRChj b3VudCwgIWNvdW50KTsKLQotICAgIGlmIChtX2xvZ2dlcikKLSAgICAgICAgbV9sb2dnZXItPnJl bW92ZU9ic2VydmVyKCp0aGlzKTsKIH0KIAogdm9pZCBEb2N1bWVudDo6cmVtb3ZlZExhc3RSZWYo KQpAQCAtNzc3OCwxMSArNzc3OCwxNiBAQCB2b2lkIERvY3VtZW50OjpkaWRMb2dNZXNzYWdlKGNv bnN0IFdURkxvZ0NoYW5uZWwmIGNoYW5uZWwsIFdURkxvZ0xldmVsIGxldmVsLCBWZQogCiAgICAg QVNTRVJUKHNlc3Npb25JRCgpLmlzQWx3YXlzT25Mb2dnaW5nQWxsb3dlZCgpKTsKIAotICAgIGF1 dG8gbWVzc2FnZVNvdXJjZSA9IG1lc3NhZ2VTb3VyY2VGb3JXVEZMb2dDaGFubmVsKGNoYW5uZWwp OwotICAgIGF1dG8gbWVzc2FnZUxldmVsID0gbWVzc2FnZUxldmVsRnJvbVdURkxvZ0xldmVsKGxl dmVsKTsKLSAgICBhdXRvIG1lc3NhZ2UgPSBzdGQ6Om1ha2VfdW5pcXVlPEluc3BlY3Rvcjo6Q29u c29sZU1lc3NhZ2U+KG1lc3NhZ2VTb3VyY2UsIE1lc3NhZ2VUeXBlOjpMb2csIG1lc3NhZ2VMZXZl bCwgV1RGTW92ZShsb2dNZXNzYWdlcyksIG1haW5Xb3JsZEV4ZWNTdGF0ZShmcmFtZSgpKSk7Cisg ICAgbV9sb2dNZXNzYWdlVGFza1F1ZXVlLmVucXVldWVUYXNrKFt0aGlzLCBjaGFubmVsLCBsZXZl bCwgbG9nTWVzc2FnZXMgPSBXVEZNb3ZlKGxvZ01lc3NhZ2VzKV0oKSBtdXRhYmxlIHsKKyAgICAg ICAgaWYgKCFwYWdlKCkpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgYXV0byBtZXNz YWdlU291cmNlID0gbWVzc2FnZVNvdXJjZUZvcldURkxvZ0NoYW5uZWwoY2hhbm5lbCk7CisgICAg ICAgIGF1dG8gbWVzc2FnZUxldmVsID0gbWVzc2FnZUxldmVsRnJvbVdURkxvZ0xldmVsKGxldmVs KTsKKyAgICAgICAgYXV0byBtZXNzYWdlID0gc3RkOjptYWtlX3VuaXF1ZTxJbnNwZWN0b3I6OkNv bnNvbGVNZXNzYWdlPihtZXNzYWdlU291cmNlLCBNZXNzYWdlVHlwZTo6TG9nLCBtZXNzYWdlTGV2 ZWwsIFdURk1vdmUobG9nTWVzc2FnZXMpLCBtYWluV29ybGRFeGVjU3RhdGUoZnJhbWUoKSkpOwog Ci0gICAgYWRkQ29uc29sZU1lc3NhZ2UoV1RGTW92ZShtZXNzYWdlKSk7CisgICAgICAgIGFkZENv bnNvbGVNZXNzYWdlKFdURk1vdmUobWVzc2FnZSkpOworICAgIH0pOwogfQogCiAjaWYgRU5BQkxF KFNFUlZJQ0VfV09SS0VSKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAppbmRleCBhNWFkNTEwYTBlMWIyNzIx MjhhZDVkZjZkMTAxMTU1OTk0Y2I1ZGIxLi43YjdjZDIxMTEwNmIzY2JjMzAyNTU3YmQzN2U5NjI1 Nzk3YTczOTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaApAQCAtMTczMyw2ICsxNzMzLDggQEAgcHJp dmF0ZToKICAgICBzdGQ6OnVuaXF1ZV9wdHI8RGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyPiBt X2RldmljZU9yaWVudGF0aW9uQ29udHJvbGxlcjsKICNlbmRpZgogCisgICAgR2VuZXJpY1Rhc2tR dWV1ZTxUaW1lcj4gbV9sb2dNZXNzYWdlVGFza1F1ZXVlOworCiAgICAgVGltZXIgbV9wZW5kaW5n VGFza3NUaW1lcjsKICAgICBWZWN0b3I8VGFzaz4gbV9wZW5kaW5nVGFza3M7CiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAx YmVlYWZiYzdiZmM3N2Y1ZjI2YWFhYzBlOTI5OGM4ZDY5ZGZjNGIzLi5lODQ4NWM0ZDczMWM5ZTdm YTg3MTI2MzlhZmVmNjkyMjJiZWZjYmM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDQt MTkgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUnVu dGltZSBsb2dnaW5nIGR1cmluZyBHQyBjYW4gY2F1c2UgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NDc5MgorICAgICAgICA8cmRhcjovL3By b2JsZW0vMzk1Njc5Mjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBtZWRpYS9kZXN0cnVjdG9yLWxvZ2dpbmctY3Jhc2gtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBtZWRpYS9kZXN0cnVjdG9yLWxvZ2dpbmctY3Jhc2guaHRtbDogQWRk ZWQuCisKIDIwMTgtMDQtMTkgIENocmlzIE5hcmRpICA8Y25hcmRpQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBTdXBwb3J0IGNhbGMoKSBpbiB3ZWJraXQtZ3JhZGllbnQgYW5kIGNyb3NzLWZhZGUK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL2Rlc3RydWN0b3ItbG9nZ2luZy1jcmFzaC1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9kZXN0cnVjdG9yLWxvZ2dpbmctY3Jhc2gt ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjE3MmQwMDU2MDE4MWNkMzkzNDYxM2QyNDY3MWUxOTUy MTBhMGJlZDQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9kZXN0cnVjdG9y LWxvZ2dpbmctY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorUEFTUyBzdWNjZXNz ZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitUaGlzIHRlc3RzIHRoYXQgbG9n Z2luZyBmcm9tIHRoZSB2aWRlbyBlbGVtZW50IGRlc3RydWN0b3IgZG9lcyBub3QgY3Jhc2guCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9kZXN0cnVjdG9yLWxvZ2dpbmctY3Jhc2guaHRt bCBiL0xheW91dFRlc3RzL21lZGlhL2Rlc3RydWN0b3ItbG9nZ2luZy1jcmFzaC5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLmJiZjM5N2YzNTFiMmViY2Q4ODg3N2M2NzU5YjJlOTgwZTIxMWQ1Y2QKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9kZXN0cnVjdG9yLWxvZ2dpbmctY3Jhc2guaHRt bApAQCAtMCwwICsxLDMxIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorICAgIDxoZWFkPgor ICAgICAgICA8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Njcmlw dD4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgICAgIHdpbmRvdy5qc1Rlc3RJc0FzeW5jID0g dHJ1ZTsKKworICAgICAgICAgICAgd2luZG93LnJlcXVlc3RBbmltYXRpb25GcmFtZSgoKSA9PiB7 CisgICAgICAgICAgICAgICAgbGV0IHZpZGVvcyA9IFtdOworICAgICAgICAgICAgICAgIGZvciAo dmFyIGkgPSAwOyBpIDwgNTAwOyBpKyspCisgICAgICAgICAgICAgICAgICAgIHZpZGVvcy5wdXNo KGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3ZpZGVvJykpOworICAgICAgICAgICAgICAgIAorICAg ICAgICAgICAgICAgIHdpbmRvdy5yZXF1ZXN0QW5pbWF0aW9uRnJhbWUoKCkgPT4geworICAgICAg ICAgICAgICAgICAgICB2aWRlb3MubGVuZ3RoID0gMDsKKworICAgICAgICAgICAgICAgICAgICB3 aW5kb3cucmVxdWVzdEFuaW1hdGlvbkZyYW1lKCgpID0+IHsKKyAgICAgICAgICAgICAgICAgICAg ICAgIGdjKCk7CisKKyAgICAgICAgICAgICAgICAgICAgICAgIHdpbmRvdy5yZXF1ZXN0QW5pbWF0 aW9uRnJhbWUoKCkgPT4geworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpbmlzaEpTVGVz dCgpOworICAgICAgICAgICAgICAgICAgICAgICAgfSk7CisgICAgICAgICAgICAgICAgICAgIH0p OworICAgICAgICAgICAgICAgIH0pOworICAgICAgICAgICAgfSk7CisgICAgICAgIDwvc2NyaXB0 PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keT4KKyAgICAgICAgPHA+VGhpcyB0ZXN0cyB0aGF0IGxv Z2dpbmcgZnJvbSB0aGUgdmlkZW8gZWxlbWVudCBkZXN0cnVjdG9yIGRvZXMgbm90IGNyYXNoLjwv cD4KKyAgICAgICAgPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwv c2NyaXB0PgorICAgIDwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxl Cg==